Attention is currently required from: jolly, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )
Change subject: bring twjit into libosmo-netif
......................................................................
Patch Set 5:
(2 comments)
File include/osmocom/netif/twjit.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/147d1af4_a1b48df… :
PS2, Line 137: bool osmo_twjit_got_any_input(struct osmo_twjit *twjit);
> I haven't forgotten about this API rename idea, but I haven't changed it in patchset 3 - too many ot […]
I have warmed up to your idea of renaming this API, and I would like to include the same rename in my `twrtp-native` (director's cut) version so this part remains consistent. Please indicate whether you prefer `osmo_twjit_rr_info_is_valid()` or slightly shorter `osmo_twjit_rr_info_valid()`.
File src/twjit.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/9785e1a6_e924e28… :
PS2, Line 504: rtph = osmo_rtp_get_hdr(msg);
> @falcon@freecalypso.org yes several people I know, not only you, (eg. me and @vyanitskiy@sysmocom. […]
@pespin@sysmocom.de: nice to hear about your interest in seeing twrtp merged and become a replacement for ortp. I plan to proceed as follows:
1. I am putting together a "director's cut" version of twrtp that is no longer a prototype (not `twrtp-proto`), that will be used long-term by ThemWi network elements. This ThemWi-native version of twrtp (controlled by me only) will reside in ThemWi area of Osmocom Gitea, planned name `twrtp-native`.
2. The manual in troff-to-PDF format, hosted on freecalypso.org, will describe `twrtp-native` version.
3. In the next revision of the present patchset, the version submitted for inclusion into `libosmo-netif` will officially become a "derivative work based on Themyscira Wireless library", and will be able to contain features requested by Osmocom that can never go into ThemWi-official version.
4. I will add a third patch to this series (revive the one dealing with documentation), adding a local version of the manual to `libosmo-netif/doc`, one that can change in sync with the code.
5. Preparation of merge-candidate patches to OsmoBTS will begin when and if `libosmo-netif` patches are merged.
OsmoBTS patch plans: you can look at my `falconia/twrtp*` branches in `osmo-bts` repo (3 branch versions so far) to see how I plan to address this one, if and when twrtp joins `libosmo-netif`. There I create an OsmoBTS-internal abstraction layer that can use either ortp or twrtp, selectable by vty config, along with a provision to make ortp compile-optional. twrtp then becomes mandatory only if the user chose to compile with ortp excluded. Or are you instead thinking about dropping ortp completely? The latter I could never imagine in my wildest dreams, but if you really do want to go there, let's revisit it after we get twrtp merged into Osmocom libs.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658
Gerrit-Change-Number: 39280
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Aug 2025 17:37:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: falconia, jolly.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )
Change subject: bring twjit into libosmo-netif
......................................................................
Patch Set 5:
(1 comment)
File src/twjit.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/47567b20_09a9b82… :
PS2, Line 504: rtph = osmo_rtp_get_hdr(msg);
> Fair enough: I'll add this option to the next iteration of the present patchset. […]
@falcon@freecalypso.org yes several people I know, not only you, (eg. me and @vyanitskiy@sysmocom.de) are happy to get rid of ortp dependency since it creates a lot of hassle to maintain, and yes, I was expecting you to submit a patch against osmo-bts to drop ortp and use twrtp instead (tbh I don't recall now if you already submitted that since a lot of time has happened?).
Now I hope you understand better my point regarding support M bit.
If we find more not envisioned problematic interop scenarios later on I'm sure we can extend twrtp out of that "closed-minded approach of emulating TDM" in order to get those fixed/improved. AFAIK nobody her anyway looked at full internals of ortp to make sure everything is 100% correct there.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658
Gerrit-Change-Number: 39280
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Wed, 20 Aug 2025 15:38:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )
Change subject: bring twjit into libosmo-netif
......................................................................
Patch Set 5:
(1 comment)
File src/twjit.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/c2538103_aacded0… :
PS2, Line 504: rtph = osmo_rtp_get_hdr(msg);
Fair enough: I'll add this option to the next iteration of the present patchset. However, something to note a little more generally:
> from experience I recall due to how some 3rd party CN generates RTP this will be needed.
Should I interpret this comment as meaning that if these patches were to be merged (the present patchset, then OsmoBTS patches to allow selection between ortp and twrtp), then you anticipate the option of twrtp (instead of ortp) to be used by more than just those who choose to use the full Osmocom+ThemWi stack? IOW, do you expect some users of non-ThemWi Osmo-interfacing CN to switch from ortp to twrtp when the latter becomes available as an option? If so, then two responses from me:
* On the one hand, I would be delighted to see my contribution used in such totally unexpected way;
* On the other hand, I would be highly concerned that twjit won't work well in that environment - it is really not designed for any applications outside my closed-minded (if you wish to call it so) approach of emulating TDM. Sure, I'll add the option to act on M bit like you ask, treating it as handover - but are you sure there won't be other show-stoppers that would break the use of twjit in environments that aren't TDM-minded like ThemWi? That non-ThemWi CN you are thinking of, will it ever emit a sequence of gap, then a lonely packet (e.g., periodic comfort noise update), then another gap? If so, then twjit will not handle it well - see the last bulleted paragraph in document section 2.3.5.
Also, are there really people other than me who would want to use something other ortp in OsmoBTS? I thought everyone other than me were totally happy with ortp and hence would have no desire to use twrtp+twjit instead...
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658
Gerrit-Change-Number: 39280
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Aug 2025 12:01:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: falconia, jolly.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )
Change subject: bring twjit into libosmo-netif
......................................................................
Patch Set 5:
(1 comment)
File src/twjit.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/091b8e55_400f6bb… :
PS2, Line 504: rtph = osmo_rtp_get_hdr(msg);
> The problem with your argument is that it violates the fundamental model of how twrtp+twjit solution […]
As mentioned already, I'm fine with having an API+VTY to be able to tweak the behavior between considering M bit and your behavior "emulate, as faithfully as possible a true circuit-switched TDM connection".
I want to have the possibility to take into account M bits since from experience I recall due to how some 3rd party CN generates RTP this will be needed.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658
Gerrit-Change-Number: 39280
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Wed, 20 Aug 2025 11:01:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40887?usp=email )
Change subject: OBS: sync_obs_projects: support security.d.o
......................................................................
OBS: sync_obs_projects: support security.d.o
The Debian 13 meta config in the OpenSUSE OBS now lists
security.debian.org. Adjust the script that syncs the config to support
this URL too, rewrite it to HTTPS just like the other mirror URL.
Fix for:
changing url to https: http://security.debian.org/debian-security?dist=trixie-security&component=m…
Traceback (most recent call last):
File "/obs/sync_obs_projects.py", line 322, in <module>
main()
File "/obs/sync_obs_projects.py", line 312, in main
rewrite_meta(project)
File "/obs/sync_obs_projects.py", line 190, in rewrite_meta
assert url.startswith("http://ftp.de.debian.org/debian"), \
AssertionError: unexpected mirror URL
Related: https://build.opensuse.org/projects/Debian:13/meta
Change-Id: Iaf6a025376e398e26c5031b07fee6c1f64cbe047
---
M scripts/obs/sync_obs_projects.py
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/scripts/obs/sync_obs_projects.py b/scripts/obs/sync_obs_projects.py
index 732fa02..bf6b0b7 100755
--- a/scripts/obs/sync_obs_projects.py
+++ b/scripts/obs/sync_obs_projects.py
@@ -187,10 +187,14 @@
for download in repository.findall(".download"):
url = download.get("url")
print(f" changing url to https: {url}")
- assert url.startswith("http://ftp.de.debian.org/debian"), \
- "unexpected mirror URL"
- download.set("url", url.replace("http://ftp.de.debian.org/debian",
- "https://debian.inf.tu-dresden.de/debian"))
+ if url.startswith("http://ftp.de.debian.org/debian"):
+ download.set("url", url.replace("http://ftp.de.debian.org/debian",
+ "https://debian.inf.tu-dresden.de/debian"))
+ elif url.startswith("http://security.debian.org/debian-security"):
+ download.set("url", url.replace("http://security.debian.org/debian-security",
+ "https://debian.inf.tu-dresden.de/debian-security"))
+ else:
+ raise RuntimeError(f"Unexpected mirror URL: {url}")
for pubkey in download.findall("pubkey"):
download.remove(pubkey)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40887?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iaf6a025376e398e26c5031b07fee6c1f64cbe047
Gerrit-Change-Number: 40887
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>