lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

August 2025

  • 1 participants
  • 1086 discussions
[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif
by falconia 20 Aug '25

20 Aug '25
Attention is currently required from: jolly, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email ) Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 5: (2 comments) File include/osmocom/netif/twjit.h: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/147d1af4_a1b48df… : PS2, Line 137: bool osmo_twjit_got_any_input(struct osmo_twjit *twjit); > I haven't forgotten about this API rename idea, but I haven't changed it in patchset 3 - too many ot […] I have warmed up to your idea of renaming this API, and I would like to include the same rename in my `twrtp-native` (director's cut) version so this part remains consistent. Please indicate whether you prefer `osmo_twjit_rr_info_is_valid()` or slightly shorter `osmo_twjit_rr_info_valid()`. File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/9785e1a6_e924e28… : PS2, Line 504: rtph = osmo_rtp_get_hdr(msg); > @falcon@freecalypso.org yes several people I know, not only you, (eg. me and @vyanitskiy@sysmocom. […] @pespin@sysmocom.de: nice to hear about your interest in seeing twrtp merged and become a replacement for ortp. I plan to proceed as follows: 1. I am putting together a "director's cut" version of twrtp that is no longer a prototype (not `twrtp-proto`), that will be used long-term by ThemWi network elements. This ThemWi-native version of twrtp (controlled by me only) will reside in ThemWi area of Osmocom Gitea, planned name `twrtp-native`. 2. The manual in troff-to-PDF format, hosted on freecalypso.org, will describe `twrtp-native` version. 3. In the next revision of the present patchset, the version submitted for inclusion into `libosmo-netif` will officially become a "derivative work based on Themyscira Wireless library", and will be able to contain features requested by Osmocom that can never go into ThemWi-official version. 4. I will add a third patch to this series (revive the one dealing with documentation), adding a local version of the manual to `libosmo-netif/doc`, one that can change in sync with the code. 5. Preparation of merge-candidate patches to OsmoBTS will begin when and if `libosmo-netif` patches are merged. OsmoBTS patch plans: you can look at my `falconia/twrtp*` branches in `osmo-bts` repo (3 branch versions so far) to see how I plan to address this one, if and when twrtp joins `libosmo-netif`. There I create an OsmoBTS-internal abstraction layer that can use either ortp or twrtp, selectable by vty config, along with a provision to make ortp compile-optional. twrtp then becomes mandatory only if the user chose to compile with ortp excluded. Or are you instead thinking about dropping ortp completely? The latter I could never imagine in my wildest dreams, but if you really do want to go there, let's revisit it after we get twrtp merged into Osmocom libs. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Aug 2025 17:37:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: 5gc: Add tests for UE release context request procedure
by pespin 20 Aug '25

20 Aug '25
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40893?usp=email ) Change subject: 5gc: Add tests for UE release context request procedure ...................................................................... 5gc: Add tests for UE release context request procedure Change-Id: Icaaeb2923fdcaba47a72ed0aedc5661f68c03774 --- M 5gc/C5G_Tests.ttcn M 5gc/ConnHdlr.ttcn M 5gc/expected-results.xml 3 files changed, 62 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/40893/1 diff --git a/5gc/C5G_Tests.ttcn b/5gc/C5G_Tests.ttcn index f72fef8..fda9e23 100644 --- a/5gc/C5G_Tests.ttcn +++ b/5gc/C5G_Tests.ttcn @@ -330,6 +330,36 @@ vc_conn.done; } +/* 3GPP TS 23.502 4.2.6 AN Release */ +private function f_TC_ue_context_release_no_pdu_session() runs on ConnHdlr { + f_register(); + f_ue_context_release(); +} +testcase TC_ue_context_release_no_pdu_session() runs on MTC_CT { + f_init(); + f_ngap_setup(0); + + var ConnHdlrPars pars := f_init_pars(ue_idx := 0); + var ConnHdlr vc_conn; + vc_conn := f_start_handler_with_pars(refers(f_TC_ue_context_release_no_pdu_session), pars); + vc_conn.done; +} +private function f_TC_ue_context_release_with_pdu_session() runs on ConnHdlr { + f_register(); + f_pdu_sess_establish(); + f_sleep(1.0); + f_ue_context_release(); +} +testcase TC_ue_context_release_with_pdu_session() runs on MTC_CT { + f_init(); + f_ngap_setup(0); + + var ConnHdlrPars pars := f_init_pars(ue_idx := 0); + var ConnHdlr vc_conn; + vc_conn := f_start_handler_with_pars(refers(f_TC_ue_context_release_with_pdu_session), pars); + vc_conn.done; +} + private function f_TC_register_ping4() runs on ConnHdlr { f_register(); f_pdu_sess_establish(); @@ -371,6 +401,8 @@ execute( TC_ng_setup_wrong_tac() ); execute( TC_ng_register() ); execute( TC_periodic_registration_updating() ); + execute( TC_ue_context_release_no_pdu_session() ); + execute( TC_ue_context_release_with_pdu_session() ); execute( TC_ng_register_ping4() ); execute( TC_ng_register_ping4_256() ); } diff --git a/5gc/ConnHdlr.ttcn b/5gc/ConnHdlr.ttcn index dbec212..c72a620 100644 --- a/5gc/ConnHdlr.ttcn +++ b/5gc/ConnHdlr.ttcn @@ -455,13 +455,14 @@ } /* 3GPP TS 38.413 8.3.3 UE Context Release (AMF initiated) */ -private altstep as_ngap_handle_UeContextReleaseCmd() runs on ConnHdlr { +private altstep as_ngap_handle_UeContextReleaseCmd(template (present) Cause exp_cause := ?) runs on ConnHdlr { var NGAP_PDU rx_ngap; var template (present) NGAP_PDU exp_ngap := mw_ngap_initMsg(mw_n2_UEContextReleaseCommand( mw_uE_NGAP_IDs_uE_NGAP_ID_pair( mw_uE_NGAP_ID_pair(g_pars.ue_pars.amf_id, - g_pars.ue_pars.ran_id)))); + g_pars.ue_pars.ran_id)), + p_cause := exp_cause)); [] NGAP.receive(exp_ngap) -> value rx_ngap { NGAP.send(m_ngap_succMsg(f_ts_n2_UEContextReleaseComplete(g_pars.ue_pars.amf_id, @@ -470,6 +471,31 @@ } } +/* 3GPP TS 38.413 8.3.2 UE Context Release Request (NG-RAN node initiated), + * 3GPP TS 23.502 4.2.6 AN Release */ +function f_ue_context_release(template (value) Cause cause := m_cause_radioNetwork(unspecified)) runs on ConnHdlr { + var template (value) NGAP_PDU tx_pdu; + + if (ispresent(g_pars.ue_pars.sess_pars.cn_gtpu_teid)) { + var template (value) PDUSessionResourceListCxtRelReq li_req; + var template (value) PDUSessionResourceItemCxtRelReq it_req; + it_req := m_pDUSessionResourceItemCxtRelReq(g_pars.ue_pars.sess_pars.id); + li_req := { it_req }; + tx_pdu := m_ngap_initMsg(m_n2_UEContextReleaseRequest_withPDUSessionList( + g_pars.ue_pars.amf_id, + g_pars.ue_pars.ran_id, + li_req, + cause)); + } else { + tx_pdu := m_ngap_initMsg(m_n2_UEContextReleaseRequest( + g_pars.ue_pars.amf_id, + g_pars.ue_pars.ran_id, + cause)); + } + NGAP.send(tx_pdu); + as_ngap_handle_UeContextReleaseCmd(exp_cause := cause); +} + /* Handle a PDUSessionResourceSetupRequestTransfer contained inside NGAP InitialContextSetupRequest and return a Result for InitialContextSetupResponse */ private function f_pdu_handle_session_resource_released_item(PDUSessionResourceToReleaseItemRelCmd cmd) runs on ConnHdlr return PDUSessionResourceReleasedItemRelRes { diff --git a/5gc/expected-results.xml b/5gc/expected-results.xml index a94eb6f..99ded9c 100644 --- a/5gc/expected-results.xml +++ b/5gc/expected-results.xml @@ -5,6 +5,8 @@ <testcase classname='C5G_Tests' name='TC_ng_setup' time='MASKED'/> <testcase classname='C5G_Tests' name='TC_ng_register' time='MASKED'/> <testcase classname='C5G_Tests' name='TC_periodic_registration_updating' time='MASKED'/> + <testcase classname='C5G_Tests' name='TC_ue_context_release_no_pdu_session' time='MASKED'/> + <testcase classname='C5G_Tests' name='TC_ue_context_release_with_pdu_session' time='MASKED'/> <testcase classname='C5G_Tests' name='TC_ng_register_ping4' time='MASKED'/> <testcase classname='C5G_Tests' name='TC_ng_register_ping4_256' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40893?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icaaeb2923fdcaba47a72ed0aedc5661f68c03774 Gerrit-Change-Number: 40893 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: 5gc: Place PDU Session params into its own subrecord
by pespin 20 Aug '25

20 Aug '25
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40892?usp=email ) Change subject: 5gc: Place PDU Session params into its own subrecord ...................................................................... 5gc: Place PDU Session params into its own subrecord This way we properly split between layers, plus the fact that we'll probably want to hold several concurrent pdu sessions in each UE in the future. Change-Id: Ibb0c8d3f0901d53e4aa75855e602234410fd00f9 --- M 5gc/C5G_Tests.ttcn M 5gc/ConnHdlr.ttcn 2 files changed, 62 insertions(+), 46 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/40892/1 diff --git a/5gc/C5G_Tests.ttcn b/5gc/C5G_Tests.ttcn index 608bcf8..f72fef8 100644 --- a/5gc/C5G_Tests.ttcn +++ b/5gc/C5G_Tests.ttcn @@ -78,6 +78,20 @@ ping_hostname := mp_ping_hostname } +template (value) PDUSessionParams ts_PDUSessionParams(template (value) PDUSessionID id, + template (value) RunProgParams run_prog_pars, + template (value) OCT4 ran_gtpu_teid) := +{ + id := id, + run_prog_pars := run_prog_pars, + ran_gtpu_ip := mp_local_gtpu_ip, + ran_gtpu_teid := ran_gtpu_teid, + cn_gtpu_ip := omit, + cn_gtpu_teid := omit, + qfi := omit, + ue_ip := omit +}; + template (value) UeParams ts_UeParams(integer idx) := { idx := idx, @@ -88,14 +102,10 @@ apn := mp_apn, ran_id := idx, amf_id := omit, - run_prog_pars := ts_RunProgParams(idx), - ran_gtpu_ip := mp_local_gtpu_ip, - ran_gtpu_teid := int2oct(idx + 1, 4), - cn_gtpu_ip := omit, - cn_gtpu_teid := omit, - qfi := omit, - ue_ip := omit, - guti := omit + guti := omit, + sess_pars := ts_PDUSessionParams(id := 1, + run_prog_pars := ts_RunProgParams(idx), + ran_gtpu_teid := int2oct(idx + 1, 4)) } type component MTC_CT { @@ -324,7 +334,7 @@ f_register(); f_pdu_sess_establish(); f_sleep(1.0); - f_ping4(g_pars.ue_pars.run_prog_pars.ping_hostname); + f_ping4(g_pars.ue_pars.sess_pars.run_prog_pars.ping_hostname); f_pdu_sess_release(); f_deregister(); } diff --git a/5gc/ConnHdlr.ttcn b/5gc/ConnHdlr.ttcn index 2f3344b..dbec212 100644 --- a/5gc/ConnHdlr.ttcn +++ b/5gc/ConnHdlr.ttcn @@ -65,6 +65,17 @@ OCT32 kamf }; +type record PDUSessionParams { + PDUSessionID id, + RunProgParams run_prog_pars, + charstring ran_gtpu_ip, + OCT4 ran_gtpu_teid, + charstring cn_gtpu_ip optional, + OCT4 cn_gtpu_teid optional, + OCT1 qfi optional, + charstring ue_ip optional +}; + /* parameters of emulated UE */ type record UeParams { integer idx, @@ -75,14 +86,8 @@ charstring apn, RAN_UE_NGAP_ID ran_id, AMF_UE_NGAP_ID amf_id optional, - RunProgParams run_prog_pars, - charstring ran_gtpu_ip, - OCT4 ran_gtpu_teid, - charstring cn_gtpu_ip optional, - OCT4 cn_gtpu_teid optional, - OCT1 qfi optional, - charstring ue_ip optional, - octetstring guti optional + octetstring guti optional, + PDUSessionParams sess_pars }; type record RunProgParams { @@ -277,15 +282,15 @@ for (var integer i := 0; i < lengthof(setup_req_transf.protocolIEs); i := i + 1) { if (setup_req_transf.protocolIEs[i].id == id_UL_NGU_UP_TNLInformation) { var UPTransportLayerInformation utli := setup_req_transf.protocolIEs[i].value_.uPTransportLayerInformation; - g_pars.ue_pars.cn_gtpu_ip := f_inet_ntoa(bit2oct(utli.gTPTunnel.transportLayerAddress)); - g_pars.ue_pars.cn_gtpu_teid := utli.gTPTunnel.gTP_TEID; + g_pars.ue_pars.sess_pars.cn_gtpu_ip := f_inet_ntoa(bit2oct(utli.gTPTunnel.transportLayerAddress)); + g_pars.ue_pars.sess_pars.cn_gtpu_teid := utli.gTPTunnel.gTP_TEID; } } /* Prepare Response for it: */ utla := m_uPTransportLayerInformation_gTPTunnel( - m_gTPTunnel(p_tla := oct2bit(f_inet_addr(g_pars.ue_pars.ran_gtpu_ip)), - p_gtp_teid := g_pars.ue_pars.ran_gtpu_teid)); + m_gTPTunnel(p_tla := oct2bit(f_inet_addr(g_pars.ue_pars.sess_pars.ran_gtpu_ip)), + p_gtp_teid := g_pars.ue_pars.sess_pars.ran_gtpu_teid)); qos := m_qosFlowPerTNLInformation(utla, { m_associatedQosFlowItem(1) }); setup_resp_transf := valueof(m_pDUSessionResourceSetupResponseTransfer(qos)); setup_trans_enc := enc_NGAP_PDUSessionResourceSetupResponseTransfer(setup_resp_transf) @@ -335,15 +340,16 @@ var template (value) NG_NAS_UL_Message_Type nas_ul_msg; var NAS_PDU nas_pdu; var NG_NAS_DL_Message_Type rx_nas, inner_nas; + var OCT1 pdu_sess_id := int2oct(g_pars.ue_pars.sess_pars.id, 1); - nas_ul_msg := cs_NG_PDU_SESSION_ESTABLISHMENT_REQUEST(cs_NG_PDU_SessionIdV('01'O), '01'O, + nas_ul_msg := cs_NG_PDU_SESSION_ESTABLISHMENT_REQUEST(cs_NG_PDU_SessionIdV(pdu_sess_id), '01'O, p_IntegrityProtMaxDataRate := cs_IntegrityProtMaxDataRateV('FF'O, 'FF'O), p_PDU_SessionType := cs_PDU_SessionTypeTV('001'B), /* IPv4 */ p_SSC_Mode := cs_SSC_ModeTV('001'B)); nas_pdu := enc_NG_NAS_UL_Message_Type(valueof(nas_ul_msg)); nas_ul_msg := cs_NG_UL_NAS_TRANSPORT(cs_PayloadContainerType(tsc_PayloadContainerESMMsg), cs_PayloadContainerLV(nas_pdu), - p_PDU_SessionId := cs_NG_PDU_SessionIdTV('01'O), + p_PDU_SessionId := cs_NG_PDU_SessionIdTV(pdu_sess_id), p_RequestType := cs_NG_Request_TypeTV('001'B), p_DNN := cs_DNN_TLV(f_enc_dns_hostname(g_pars.ue_pars.apn))); NGAP.send(nas_ul_msg); @@ -353,10 +359,10 @@ NGAP.receive(cr_NG_DL_NAS_TRANSPORT) -> value rx_nas; inner_nas := f_dec_NG_NAS_DL_Message_Payload_Container(rx_nas.dl_Nas_Transport.payloadContainerType.container, rx_nas.dl_Nas_Transport.payload.payload); - g_pars.ue_pars.qfi := inner_nas.pdu_Session_Establishment_Accept.authorizedQoSRules.listofQoSRules[0].identifier; - g_pars.ue_pars.ue_ip := f_inet_ntoa(inner_nas.pdu_Session_Establishment_Accept.pduAddress.adressInfo); - log("5GC assigned CN GTPU Address: ", g_pars.ue_pars.cn_gtpu_ip, " TEID: ", g_pars.ue_pars.cn_gtpu_teid); - log("5GC assigned UE IP address: ", g_pars.ue_pars.ue_ip); + g_pars.ue_pars.sess_pars.qfi := inner_nas.pdu_Session_Establishment_Accept.authorizedQoSRules.listofQoSRules[0].identifier; + g_pars.ue_pars.sess_pars.ue_ip := f_inet_ntoa(inner_nas.pdu_Session_Establishment_Accept.pduAddress.adressInfo); + log("5GC assigned CN GTPU Address: ", g_pars.ue_pars.sess_pars.cn_gtpu_ip, " TEID: ", g_pars.ue_pars.sess_pars.cn_gtpu_teid); + log("5GC assigned UE IP address: ", g_pars.ue_pars.sess_pars.ue_ip); f_pdu_sess_create_tun(); } @@ -472,8 +478,8 @@ nas_cause := oct2bit(cmd.pDUSessionResourceReleaseCommandTransfer); - g_pars.ue_pars.cn_gtpu_ip := omit; - g_pars.ue_pars.cn_gtpu_teid := omit; + g_pars.ue_pars.sess_pars.cn_gtpu_ip := omit; + g_pars.ue_pars.sess_pars.cn_gtpu_teid := omit; /* Prepare Response for it: */ resp := valueof(m_pDUSessionResourceReleasedItemRelRes(cmd.pDUSessionID, bit2oct(nas_cause))); @@ -523,9 +529,9 @@ var template (value) NG_NAS_UL_Message_Type nas_ul_msg; var NAS_PDU nas_pdu; var NG_NAS_DL_Message_Type rx_nas, inner_nas; - var OCT1 pdu_sess_id := '01'O; var ProcedureTransactionIdentifier pti := '02'O; var NAS_CauseValue_Type cause_val := c_5GSM_Cause_RegularDeactivation; + var OCT1 pdu_sess_id := int2oct(g_pars.ue_pars.sess_pars.id, 1); nas_ul_msg := cs_NG_PDU_SESSION_RELEASE_REQUEST(cs_NG_PDU_SessionIdV(pdu_sess_id), pti, p_Cause := cs_GMM_GSM_Cause('59'O, cause_val)); @@ -548,8 +554,8 @@ log2str("Unexpected decoded NAS Payload Container ", inner_nas)); } - g_pars.ue_pars.qfi := omit; - g_pars.ue_pars.ue_ip := omit; + g_pars.ue_pars.sess_pars.qfi := omit; + g_pars.ue_pars.sess_pars.ue_ip := omit; nas_ul_msg := cs_NG_PDU_SESSION_RELEASE_COMPLETE(cs_NG_PDU_SessionIdV(pdu_sess_id), pti, p_Cause := cs_GMM_GSM_Cause('59'O, cause_val)); @@ -568,18 +574,18 @@ var template (value) UECUPS_GtpExtHdr_PduSessContainer pdu_sess_cont; pdu_sess_cont := ts_UECUPS_GtpExtHdr_PduSessContainer(UECUPS_GtpExtHdr_PduSessContainer_Type_ul_pdu_sess_info, - oct2int(g_pars.ue_pars.qfi)); + oct2int(g_pars.ue_pars.sess_pars.qfi)); gtp_ext_hdr := ts_UECUPS_GtpExtHdr(pdu_session_container := pdu_sess_cont); uecups_create := ts_UECUPS_CreateTun( - tx_teid := oct2int(g_pars.ue_pars.cn_gtpu_teid), - rx_teid := oct2int(g_pars.ue_pars.ran_gtpu_teid), + tx_teid := oct2int(g_pars.ue_pars.sess_pars.cn_gtpu_teid), + rx_teid := oct2int(g_pars.ue_pars.sess_pars.ran_gtpu_teid), user_addr_type := IPV4, - user_addr := f_inet_addr(g_pars.ue_pars.ue_ip), - local_gtp_ep := valueof(ts_UECUPS_SockAddr(f_inet_addr(g_pars.ue_pars.ran_gtpu_ip))), - remote_gtp_ep := valueof(ts_UECUPS_SockAddr(f_inet_addr(g_pars.ue_pars.cn_gtpu_ip))), - tun_dev_name := g_pars.ue_pars.run_prog_pars.tun_dev_name, - tun_netns_name := g_pars.ue_pars.run_prog_pars.tun_netns_name, + user_addr := f_inet_addr(g_pars.ue_pars.sess_pars.ue_ip), + local_gtp_ep := valueof(ts_UECUPS_SockAddr(f_inet_addr(g_pars.ue_pars.sess_pars.ran_gtpu_ip))), + remote_gtp_ep := valueof(ts_UECUPS_SockAddr(f_inet_addr(g_pars.ue_pars.sess_pars.cn_gtpu_ip))), + tun_dev_name := g_pars.ue_pars.sess_pars.run_prog_pars.tun_dev_name, + tun_netns_name := g_pars.ue_pars.sess_pars.run_prog_pars.tun_netns_name, gtp_ext_hdr := gtp_ext_hdr ); @@ -590,8 +596,8 @@ function f_pdu_sess_delete_tun() runs on ConnHdlr { var template (value) UECUPS_DestroyTun uecups_destroy; uecups_destroy := ts_UECUPS_DestroyTun( - local_gtp_ep := valueof(ts_UECUPS_SockAddr(f_inet_addr(g_pars.ue_pars.ran_gtpu_ip))), - rx_teid := oct2int(g_pars.ue_pars.ran_gtpu_teid) + local_gtp_ep := valueof(ts_UECUPS_SockAddr(f_inet_addr(g_pars.ue_pars.sess_pars.ran_gtpu_ip))), + rx_teid := oct2int(g_pars.ue_pars.sess_pars.ran_gtpu_teid) ); f_gtp1u_destroy_tunnel(uecups_destroy); } @@ -601,8 +607,8 @@ var template (value) UECUPS_StartProgram sprog := ts_UECUPS_StartProgram( command := command, environment := {}, - run_as_user := g_pars.ue_pars.run_prog_pars.run_as_user, - tun_netns_name := g_pars.ue_pars.run_prog_pars.tun_netns_name + run_as_user := g_pars.ue_pars.sess_pars.run_prog_pars.run_as_user, + tun_netns_name := g_pars.ue_pars.sess_pars.run_prog_pars.tun_netns_name ); return valueof(sprog); } @@ -610,7 +616,7 @@ private function f_run_prog_unique_log_path() runs on ConnHdlr return charstring { var charstring id := testcasename() & "-" & hex2str(g_pars.ue_pars.imsi) & "-" & int2str(g_start_prog_count); - var charstring prefix := g_pars.ue_pars.run_prog_pars.log_path_prefix & "/" & id; + var charstring prefix := g_pars.ue_pars.sess_pars.run_prog_pars.log_path_prefix & "/" & id; g_start_prog_count := g_start_prog_count + 1; return prefix; } @@ -620,7 +626,7 @@ { /* command will be filled in by f_gtp1u_ping4() below: */ var UECUPS_StartProgram sprog := f_run_prog_init(""); - f_gtp1u_ping4(sprog, host, interval, count, g_pars.ue_pars.ue_ip, + f_gtp1u_ping4(sprog, host, interval, count, g_pars.ue_pars.sess_pars.ue_ip, redirect_output := true, redirect_output_path_prefix := f_run_prog_unique_log_path()); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibb0c8d3f0901d53e4aa75855e602234410fd00f9 Gerrit-Change-Number: 40892 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: ngap: Add missing mandatory IE Cause to m_n2_UEContextReleaseRequest
by pespin 20 Aug '25

20 Aug '25
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40889?usp=email ) Change subject: ngap: Add missing mandatory IE Cause to m_n2_UEContextReleaseRequest ...................................................................... ngap: Add missing mandatory IE Cause to m_n2_UEContextReleaseRequest Change-Id: Ib7d87f957e469a23448e35fd82a697d1698c7da7 --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/40889/1 diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index 3dec8ef..d6e0bd8 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -1772,7 +1772,8 @@ template (value) InitiatingMessage m_n2_UEContextReleaseRequest( in template (value) AMF_UE_NGAP_ID p_amfUeNgapID := PX_AMF_UE_NGAP_ID, in template (value) RAN_UE_NGAP_ID p_ranUeNgapID := PX_RAN_UE_NGAP_ID, - in template (value) PDUSessionResourceListCxtRelReq p_pDUSessionResourceListCxtRelReq + in template (value) PDUSessionResourceListCxtRelReq p_pDUSessionResourceListCxtRelReq, + in template (value) Cause p_cause ) := { procedureCode := id_UEContextReleaseRequest, criticality := ignore, @@ -1793,6 +1794,11 @@ id := id_PDUSessionResourceListCxtRelReq, criticality := reject, value_ := { PDUSessionResourceListCxtRelReq := p_pDUSessionResourceListCxtRelReq } + }, + { + id := id_Cause, + criticality := ignore, + value_ := { Cause := p_cause } } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40889?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib7d87f957e469a23448e35fd82a697d1698c7da7 Gerrit-Change-Number: 40889 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: 5gc: Obtain amf_id from NGAP_Emulation
by pespin 20 Aug '25

20 Aug '25
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40891?usp=email ) Change subject: 5gc: Obtain amf_id from NGAP_Emulation ...................................................................... 5gc: Obtain amf_id from NGAP_Emulation This will be needed in a follow-up commit in order to be able to transmit UE Context Release Request. Change-Id: I49cb6d7fe9f18734c49bb49ecceb671e8122ce88 --- M 5gc/C5G_Tests.ttcn M 5gc/ConnHdlr.ttcn M library/NGAP_Emulation.ttcn 3 files changed, 52 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/40891/1 diff --git a/5gc/C5G_Tests.ttcn b/5gc/C5G_Tests.ttcn index 0b71059..608bcf8 100644 --- a/5gc/C5G_Tests.ttcn +++ b/5gc/C5G_Tests.ttcn @@ -86,6 +86,8 @@ usim_key := mp_usim_key, usim_opc := mp_usim_opc, apn := mp_apn, + ran_id := idx, + amf_id := omit, run_prog_pars := ts_RunProgParams(idx), ran_gtpu_ip := mp_local_gtpu_ip, ran_gtpu_teid := int2oct(idx + 1, 4), diff --git a/5gc/ConnHdlr.ttcn b/5gc/ConnHdlr.ttcn index 01dcb1a..2f3344b 100644 --- a/5gc/ConnHdlr.ttcn +++ b/5gc/ConnHdlr.ttcn @@ -73,6 +73,8 @@ octetstring usim_key, octetstring usim_opc, charstring apn, + RAN_UE_NGAP_ID ran_id, + AMF_UE_NGAP_ID amf_id optional, RunProgParams run_prog_pars, charstring ran_gtpu_ip, OCT4 ran_gtpu_teid, @@ -308,10 +310,11 @@ private altstep as_ngap_handle_InitialCtxReq_withPDUSessionList() runs on ConnHdlr { var NGAP_PDU rx_ngap; + var template (present) NGAP_PDU exp_ngap := + mw_ngap_initMsg(mw_n2_InitialContextSetupRequest_withPDUSessionList(g_pars.ue_pars.amf_id, + g_pars.ue_pars.ran_id)); - [] NGAP.receive(mw_ngap_initMsg(mw_n2_InitialContextSetupRequest_withPDUSessionList)) -> value rx_ngap { - var AMF_UE_NGAP_ID amf_id := valueof(f_NGAP_get_AMF_UE_NGAP_ID(rx_ngap)); - var RAN_UE_NGAP_ID ran_id := valueof(f_NGAP_get_RAN_UE_NGAP_ID(rx_ngap)); + [] NGAP.receive(exp_ngap) -> value rx_ngap { var InitialContextSetupRequest ctx_setup_req := rx_ngap.initiatingMessage.value_.initialContextSetupRequest; var PDUSessionResourceSetupListCxtRes resources; @@ -322,7 +325,9 @@ var PDUSessionResourceSetupListCxtReq li := ctx_setup_req.protocolIEs[i].value_.pDUSessionResourceSetupListCxtReq; resources := f_pdu_handle_session_resource_setup_list(li); } - NGAP.send(m_ngap_succMsg(m_n2_InitialContextSetupResponse(amf_id, ran_id, resources))); + NGAP.send(m_ngap_succMsg(m_n2_InitialContextSetupResponse(g_pars.ue_pars.amf_id, + g_pars.ue_pars.ran_id, + resources))); } } @@ -369,7 +374,7 @@ f_SUCI_IMSI()), p_UESecurityCap := f_UE_SecurityCapability()); nas_pdu := enc_NG_NAS_UL_Message_Type(valueof(nas_ul_msg)); - tx_pdu := m_ngap_initMsg(m_n2_initialUeMessage(g_pars.ue_pars.idx, + tx_pdu := m_ngap_initMsg(m_n2_initialUeMessage(g_pars.ue_pars.ran_id, nas_pdu, /* Registration request */ f_ULI(), mo_Signalling)); @@ -388,6 +393,9 @@ as_ngap_handle_auth(); as_ngap_handle_sec_mode(); + /* After receiving DL NAS Transport above, the UE-AMF-Id became known in NGAP_Emulation: */ + g_pars.ue_pars.amf_id := f_ngap_obtain_amf_id(); + NGAP.receive(cr_NG_REGISTRATION_ACCEPT) -> value rx_nas; g_pars.ue_pars.guti := rx_nas.registration_Accept.guti.otherDigits; NGAP.send(cs_NG_REGISTRATION_COMPLETE); @@ -443,11 +451,16 @@ /* 3GPP TS 38.413 8.3.3 UE Context Release (AMF initiated) */ private altstep as_ngap_handle_UeContextReleaseCmd() runs on ConnHdlr { var NGAP_PDU rx_ngap; + var template (present) NGAP_PDU exp_ngap := + mw_ngap_initMsg(mw_n2_UEContextReleaseCommand( + mw_uE_NGAP_IDs_uE_NGAP_ID_pair( + mw_uE_NGAP_ID_pair(g_pars.ue_pars.amf_id, + g_pars.ue_pars.ran_id)))); - [] NGAP.receive(mw_ngap_initMsg(mw_n2_UEContextReleaseCommand)) -> value rx_ngap { - var AMF_UE_NGAP_ID amf_id := valueof(f_NGAP_get_AMF_UE_NGAP_ID(rx_ngap)); - var RAN_UE_NGAP_ID ran_id := valueof(f_NGAP_get_RAN_UE_NGAP_ID(rx_ngap)); - NGAP.send(m_ngap_succMsg(f_ts_n2_UEContextReleaseComplete(amf_id, ran_id, f_ULI()))); + [] NGAP.receive(exp_ngap) -> value rx_ngap { + NGAP.send(m_ngap_succMsg(f_ts_n2_UEContextReleaseComplete(g_pars.ue_pars.amf_id, + g_pars.ue_pars.ran_id, + f_ULI()))); } } @@ -484,10 +497,12 @@ private altstep as_ngap_handle_PDUSessionReleaseCommand() runs on ConnHdlr { var NGAP_PDU rx_ngap; + var template (present) NGAP_PDU exp_ngap := + mw_ngap_initMsg(f_tr_n2_PDUSessionResourceReleaseCommand(g_pars.ue_pars.amf_id, + g_pars.ue_pars.ran_id, + ?, ?)); - [] NGAP.receive(mw_ngap_initMsg(f_tr_n2_PDUSessionResourceReleaseCommand(?, ?, ?, ?))) -> value rx_ngap { - var AMF_UE_NGAP_ID amf_id := valueof(f_NGAP_get_AMF_UE_NGAP_ID(rx_ngap)); - var RAN_UE_NGAP_ID ran_id := valueof(f_NGAP_get_RAN_UE_NGAP_ID(rx_ngap)); + [] NGAP.receive(exp_ngap) -> value rx_ngap { var PDUSessionResourceReleaseCommand rel_cmd := rx_ngap.initiatingMessage.value_.PDUSessionResourceReleaseCommand; var PDUSessionResourceReleasedListRelRes resources; @@ -498,7 +513,9 @@ var PDUSessionResourceToReleaseListRelCmd li := rel_cmd.protocolIEs[i].value_.pDUSessionResourceToReleaseListRelCmd; resources := f_pdu_handle_session_resource_released_list(li); } - NGAP.send(m_ngap_succMsg(m_n2_PDUSessionResourceReleaseResponse(amf_id, ran_id, resources))); + NGAP.send(m_ngap_succMsg(m_n2_PDUSessionResourceReleaseResponse(g_pars.ue_pars.amf_id, + g_pars.ue_pars.ran_id, + resources))); } } diff --git a/library/NGAP_Emulation.ttcn b/library/NGAP_Emulation.ttcn index aa4b485..3034fab 100644 --- a/library/NGAP_Emulation.ttcn +++ b/library/NGAP_Emulation.ttcn @@ -116,11 +116,13 @@ signature NGAPEM_register(in AMF_UE_NGAP_ID amf_id, in RAN_UE_NGAP_ID ran_id, in NGAP_ConnHdlr hdlr); signature NGAPEM_register_proc(in integer procedureCode, in NGAP_ConnHdlr hdlr); +signature NGAPEM_obtain_amf_id() return AMF_UE_NGAP_ID; //signature NGAPEM_derive_nas_token(in octetstring kasme, in NGAP_ConnHdlr hdlr, out OCT32 nas_token); type port NGAPEM_PROC_PT procedure { inout NGAPEM_register; inout NGAPEM_register_proc; + inout NGAPEM_obtain_amf_id; //inout NGAPEM_derive_nas_token; } with { extension "internal" }; @@ -605,6 +607,11 @@ f_create_expect_proc(procedureCode, vc_conn); NGAP_PROC.reply(NGAPEM_register_proc:{procedureCode, vc_conn}) to vc_conn; } + [] NGAP_PROC.getcall(NGAPEM_obtain_amf_id:{}) -> sender vc_conn { + var integer i := f_assoc_id_by_comp(vc_conn); + amf_id := NGapAssociationTable[i].amf_ue_ngap_id; + NGAP_PROC.reply(NGAPEM_obtain_amf_id:{} value amf_id) to vc_conn; + } // [] NGAP_PROC.getcall(NGAPEM_derive_nas_token:{?, ?, -}) -> param(kasme, vc_conn) { // var integer assoc_id := f_assoc_id_by_comp(vc_conn); // var OCT32 nas_token := f_kdf_nas_token(kasme, NGapAssociationTable[assoc_id].nus.tx_count) @@ -701,4 +708,17 @@ } } +/* ConnHdlr function to obtain AMF_ID internally stored in association table. + * This is needed because we don't receive NGAP layer of DownlinkNasTransport in + * ConnHdlr from Emulation, so there's no direct way to obtain it early during + * registration procedure. */ +function f_ngap_obtain_amf_id() runs on NGAP_ConnHdlr return AMF_UE_NGAP_ID { + var AMF_UE_NGAP_ID amf_id; + NGAP_PROC.call(NGAPEM_obtain_amf_id:{}) { + [] NGAP_PROC.getreply(NGAPEM_obtain_amf_id:{}) -> value amf_id { + return amf_id; + } + } +} + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49cb6d7fe9f18734c49bb49ecceb671e8122ce88 Gerrit-Change-Number: 40891 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: ngap: Add template for UEContextReleaseReq without PDU Session List
by pespin 20 Aug '25

20 Aug '25
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40890?usp=email ) Change subject: ngap: Add template for UEContextReleaseReq without PDU Session List ...................................................................... ngap: Add template for UEContextReleaseReq without PDU Session List That's the only optional IE in the message. Add a separate template to be able to transmit with that IE set, similar to what's already done in m_n2_InitialContextSetupRequest_withPDUSessionList(). Change-Id: I0f1a549103b70bcd373dcd4c688761d3eeef10a6 --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 31 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/40890/1 diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index d6e0bd8..9729823 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -1772,6 +1772,36 @@ template (value) InitiatingMessage m_n2_UEContextReleaseRequest( in template (value) AMF_UE_NGAP_ID p_amfUeNgapID := PX_AMF_UE_NGAP_ID, in template (value) RAN_UE_NGAP_ID p_ranUeNgapID := PX_RAN_UE_NGAP_ID, + in template (value) Cause p_cause + ) := { + procedureCode := id_UEContextReleaseRequest, + criticality := ignore, + value_ := { + UEContextReleaseRequest := { + protocolIEs := { + { + id := id_AMF_UE_NGAP_ID, + criticality := reject, + value_ := { AMF_UE_NGAP_ID := p_amfUeNgapID } + }, + { + id := id_RAN_UE_NGAP_ID, + criticality := reject, + value_ := { RAN_UE_NGAP_ID := p_ranUeNgapID } + }, + { + id := id_Cause, + criticality := ignore, + value_ := { Cause := p_cause } + } + } + } + } + } // End of template m_n2_UEContextReleaseRequest + + template (value) InitiatingMessage m_n2_UEContextReleaseRequest_withPDUSessionList( + in template (value) AMF_UE_NGAP_ID p_amfUeNgapID := PX_AMF_UE_NGAP_ID, + in template (value) RAN_UE_NGAP_ID p_ranUeNgapID := PX_RAN_UE_NGAP_ID, in template (value) PDUSessionResourceListCxtRelReq p_pDUSessionResourceListCxtRelReq, in template (value) Cause p_cause ) := { @@ -1803,7 +1833,7 @@ } } } - } // End of template m_n2_UEContextReleaseRequest + } // End of template m_n2_UEContextReleaseRequest_withPDUSessionList } // End of group Send -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0f1a549103b70bcd373dcd4c688761d3eeef10a6 Gerrit-Change-Number: 40890 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif
by pespin 20 Aug '25

20 Aug '25
Attention is currently required from: falconia, jolly. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email ) Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 5: (1 comment) File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/47567b20_09a9b82… : PS2, Line 504: rtph = osmo_rtp_get_hdr(msg); > Fair enough: I'll add this option to the next iteration of the present patchset. […] @falcon@freecalypso.org yes several people I know, not only you, (eg. me and @vyanitskiy@sysmocom.de) are happy to get rid of ortp dependency since it creates a lot of hassle to maintain, and yes, I was expecting you to submit a patch against osmo-bts to drop ortp and use twrtp instead (tbh I don't recall now if you already submitted that since a lot of time has happened?). Now I hope you understand better my point regarding support M bit. If we find more not envisioned problematic interop scenarios later on I'm sure we can extend twrtp out of that "closed-minded approach of emulating TDM" in order to get those fixed/improved. AFAIK nobody her anyway looked at full internals of ortp to make sure everything is 100% correct there. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 20 Aug 2025 15:38:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif
by falconia 20 Aug '25

20 Aug '25
Attention is currently required from: jolly, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email ) Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 5: (1 comment) File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/c2538103_aacded0… : PS2, Line 504: rtph = osmo_rtp_get_hdr(msg); Fair enough: I'll add this option to the next iteration of the present patchset. However, something to note a little more generally: > from experience I recall due to how some 3rd party CN generates RTP this will be needed. Should I interpret this comment as meaning that if these patches were to be merged (the present patchset, then OsmoBTS patches to allow selection between ortp and twrtp), then you anticipate the option of twrtp (instead of ortp) to be used by more than just those who choose to use the full Osmocom+ThemWi stack? IOW, do you expect some users of non-ThemWi Osmo-interfacing CN to switch from ortp to twrtp when the latter becomes available as an option? If so, then two responses from me: * On the one hand, I would be delighted to see my contribution used in such totally unexpected way; * On the other hand, I would be highly concerned that twjit won't work well in that environment - it is really not designed for any applications outside my closed-minded (if you wish to call it so) approach of emulating TDM. Sure, I'll add the option to act on M bit like you ask, treating it as handover - but are you sure there won't be other show-stoppers that would break the use of twjit in environments that aren't TDM-minded like ThemWi? That non-ThemWi CN you are thinking of, will it ever emit a sequence of gap, then a lonely packet (e.g., periodic comfort noise update), then another gap? If so, then twjit will not handle it well - see the last bulleted paragraph in document section 2.3.5. Also, are there really people other than me who would want to use something other ortp in OsmoBTS? I thought everyone other than me were totally happy with ortp and hence would have no desire to use twrtp+twjit instead... -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Aug 2025 12:01:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif
by pespin 20 Aug '25

20 Aug '25
Attention is currently required from: falconia, jolly. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email ) Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 5: (1 comment) File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/091b8e55_400f6bb… : PS2, Line 504: rtph = osmo_rtp_get_hdr(msg); > The problem with your argument is that it violates the fundamental model of how twrtp+twjit solution […] As mentioned already, I'm fine with having an API+VTY to be able to tweak the behavior between considering M bit and your behavior "emulate, as faithfully as possible a true circuit-switched TDM connection". I want to have the possibility to take into account M bits since from experience I recall due to how some 3rd party CN generates RTP this will be needed. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 20 Aug 2025 11:01:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ci[master]: OBS: sync_obs_projects: support security.d.o
by osmith 20 Aug '25

20 Aug '25
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40887?usp=email ) Change subject: OBS: sync_obs_projects: support security.d.o ...................................................................... OBS: sync_obs_projects: support security.d.o The Debian 13 meta config in the OpenSUSE OBS now lists security.debian.org. Adjust the script that syncs the config to support this URL too, rewrite it to HTTPS just like the other mirror URL. Fix for: changing url to https: http://security.debian.org/debian-security?dist=trixie-security&component=m… Traceback (most recent call last): File "/obs/sync_obs_projects.py", line 322, in <module> main() File "/obs/sync_obs_projects.py", line 312, in main rewrite_meta(project) File "/obs/sync_obs_projects.py", line 190, in rewrite_meta assert url.startswith("http://ftp.de.debian.org/debian"), \ AssertionError: unexpected mirror URL Related: https://build.opensuse.org/projects/Debian:13/meta Change-Id: Iaf6a025376e398e26c5031b07fee6c1f64cbe047 --- M scripts/obs/sync_obs_projects.py 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/obs/sync_obs_projects.py b/scripts/obs/sync_obs_projects.py index 732fa02..bf6b0b7 100755 --- a/scripts/obs/sync_obs_projects.py +++ b/scripts/obs/sync_obs_projects.py @@ -187,10 +187,14 @@ for download in repository.findall(".download"): url = download.get("url") print(f" changing url to https: {url}") - assert url.startswith("http://ftp.de.debian.org/debian"), \ - "unexpected mirror URL" - download.set("url", url.replace("http://ftp.de.debian.org/debian", - "https://debian.inf.tu-dresden.de/debian")) + if url.startswith("http://ftp.de.debian.org/debian"): + download.set("url", url.replace("http://ftp.de.debian.org/debian", + "https://debian.inf.tu-dresden.de/debian")) + elif url.startswith("http://security.debian.org/debian-security"): + download.set("url", url.replace("http://security.debian.org/debian-security", + "https://debian.inf.tu-dresden.de/debian-security")) + else: + raise RuntimeError(f"Unexpected mirror URL: {url}") for pubkey in download.findall("pubkey"): download.remove(pubkey) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40887?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaf6a025376e398e26c5031b07fee6c1f64cbe047 Gerrit-Change-Number: 40887 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 58
  • 59
  • 60
  • 61
  • 62
  • 63
  • 64
  • ...
  • 109
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.