Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40854?usp=email )
Change subject: osmo_io: Add unit test to verify segmentation process
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40854?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7d8feba9c8e8386c9fd144669f6ccd01d6bbbabb
Gerrit-Change-Number: 40854
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 18 Aug 2025 10:06:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email )
Change subject: Re-introduce Iu/UTRAN support
......................................................................
Patch Set 2:
(4 comments)
File src/sgsn/gprs_routing_area.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/61e2041c_dfc78cb7?us… :
PS2, Line 439: } else {
You can move this code path above as an early return.
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/474fcc2c_c57d039b?us… :
PS2, Line 483: else if (mmctx->p_tmsi_old != GSM_RESERVED_TMSI)
these "else" here and below are not needed since you are doing early return.
File tests/gprs_routing_area/gprs_routing_area_test.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/ef73e0de_092b9552?us… :
PS2, Line 541: /* check if a GERAN RA/cell with the same LAC as an already register UTRAN gets rejected */
registered?
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/6c557f6c_b5f73713?us… :
PS2, Line 542: void test_routing_area_mv_utran_geran_reject(void)
I think it's worth explaining here that this is an implementation decision we took and that it's not 100% clear whether LACs from different RANs can be supported.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
Gerrit-Change-Number: 40813
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 18 Aug 2025 10:05:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40812?usp=email )
Change subject: Adopt iu_client from osmo-iuh
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
@lynxis@fe80.eu please rename all the followup patches with appended "[1/4]" etc. to denote the are to be merged/reverted together.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40812?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I9c0d9667ddcb57b52eae34da942acfc1688c1418
Gerrit-Change-Number: 40812
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 18 Aug 2025 10:00:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No