August 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-sgsn[master]: routing area: add LOGRA() logging macro

by pespin

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40692?usp=email ) Change subject: routing area: add LOGRA() logging macro ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ib287b70c34b21ce64bc864f69fcf6af5fa0698b9 Gerrit-Change-Number: 40692 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 18 Aug 2025 08:56:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 2 days

1
0
0 0

[S] Change in osmo-sgsn[master]: routing area: introduce sgsn_ra_find_or_create()

by pespin

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40691?usp=email ) Change subject: routing area: introduce sgsn_ra_find_or_create() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6955a09d9d8f3ba4dc3a14d7ed5cd9798d929c61 Gerrit-Change-Number: 40691 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 18 Aug 2025 08:56:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 2 days

1
0
0 0

[XS] Change in osmo-msc[master]: Fix building for debian 13 armv7l

by osmith

Attention is currently required from: fixeria, lynxis lazus. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/40873?usp=email ) Change subject: Fix building for debian 13 armv7l ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: ping, would be great to get this reviewed as it is failing in OBS -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40873?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3de792d62b1989cf35051cbecde98fa9030bfbf2 Gerrit-Change-Number: 40873 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 18 Aug 2025 06:40:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 weeks, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: add TC_silent_call_{start_stop,active_conn}

by osmith

Attention is currently required from: fixeria, laforge, lynxis lazus. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email ) Change subject: msc: add TC_silent_call_{start_stop,active_conn} ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ef22fbb5a05f69cc8aea7f42e05f6e1d6c4a8b6 Gerrit-Change-Number: 40863 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 18 Aug 2025 06:22:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 2 days

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif

by falconia

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email ) Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 5: (3 comments) File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/4f683d70_f4820a8… : PS2, Line 157: config->thinning_int = 17; > AFAICT the only similarity between my algorithm and CoDel is that both algos sometimes "artificially […] Can this point be marked as resolved? File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/792ea0c4_ee9a92a… : PS3, Line 331: static void analytics_cont(struct osmo_twjit *twjit, uint16_t rx_seq, > Not necessarily in perfect order, just same SSRC. […] Can this point be marked as resolved? File src/twjit_vty.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/8911bc55_90e97c7… : PS2, Line 41: vty_out(vty, "%s%s%s", prefix, name ? : "twjit", VTY_NEWLINE); > I think it may be easier having it as total prefix, but not a hard blocker here. Can this point be marked as resolved? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Aug 2025 05:44:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 2 days

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twrtp into libosmo-netif

by falconia

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email ) Change subject: bring twrtp into libosmo-netif ...................................................................... Patch Set 5: (3 comments) File src/twrtp_base.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/5f5204b2_f73fd53… : PS1, Line 120: * file descriptor passing mechanism - hence twrtp layer must have a public > New ThemWi CN sw components, starting with `tw-border-mgw`, already depend on the full `libosmo*` su […] Can this point be marked as resolved? https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/ed8266be_331a960… : PS1, Line 132: * another variant of this API with that alternative behavior. > I really know next to nothing about 3G. […] Still not sure about 3G and IuUP specifically, but more generally speaking, if some application of RTP says "don't use RTCP", they still typically require or at least expect an even UDP port number for RTP, and the corresponding odd port is still reserved for what would have been RTCP. The way to handle such scenarios with twrtp is to let twrtp library bind to both UDP ports, let it swallow all packets that arrive on the odd-numbered port, and let it parse them as if they were RTCP. But don't send out any outgoing RTCP packets (which the library won't do on its own until and unless the application requests RTCP output and configures SDES), and simply ignore the existence of the built-in RTCP receiver and parser. Section 5.6 of the manual says basically the same thing. Can this point be marked as resolved? File src/twrtp_traffic.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/eb625540_bb7a79d… : PS2, Line 32: struct osmo_twrtp *endp = osmo_iofd_get_data(iofd); > Acknowledged Can this point be marked as resolved? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb Gerrit-Change-Number: 39281 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Aug 2025 05:38:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: add TC_silent_call_{start_stop,active_conn}

by fixeria

Attention is currently required from: laforge, lynxis lazus, osmith. Hello Jenkins Builder, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: msc: add TC_silent_call_{start_stop,active_conn} ...................................................................... msc: add TC_silent_call_{start_stop,active_conn} This patch adds testcases for the silent-call feature: * MSC_Tests.TC_silent_call_start_stop Test starting and stopping silent call via the VTY. * MSC_Tests.TC_silent_call_active_conn Test initiating a silent call while there's an active connection. The MSC is expected to be smart and reject such an attempt. Change-Id: I3ef22fbb5a05f69cc8aea7f42e05f6e1d6c4a8b6 Related: osmo-msc.git I93913d189800d71f82c013b6e946bd63db362f65 Related: osmo-msc.git I52b3be26c61cadacc4783b5c324809ecd6906b36 --- M msc/MSC_Tests.ttcn M msc/expected-results.xml 2 files changed, 101 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/40863/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ef22fbb5a05f69cc8aea7f42e05f6e1d6c4a8b6 Gerrit-Change-Number: 40863 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 4 days

1
0
0 0

[XS] Change in pysim[master]: smdp: clean up accidental commited trash

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/40879?usp=email ) Change subject: smdp: clean up accidental commited trash ...................................................................... smdp: clean up accidental commited trash and update gitinore to ensure this does not happen again Change-Id: Ieeb2da3bdb006b08e2f82bfc3b5252f4abf4420b --- M .gitignore D smdpp-data/sm-dp-sessions-BRP D smdpp-data/sm-dp-sessions-NIST 3 files changed, 1 insertion(+), 3 deletions(-) Approvals: Hoernchen: Looks good to me, approved Jenkins Builder: Verified diff --git a/.gitignore b/.gitignore index 6b74841..d40e503 100644 --- a/.gitignore +++ b/.gitignore @@ -7,7 +7,7 @@ /.local /build /pySim.egg-info -/smdpp-data/sm-dp-sessions +/smdpp-data/sm-dp-sessions* dist tags smdpp-data/certs/DPtls/CERT_S_SM_DP_TLS_NIST.pem diff --git a/smdpp-data/sm-dp-sessions-BRP b/smdpp-data/sm-dp-sessions-BRP deleted file mode 120000 index 143169a..0000000 --- a/smdpp-data/sm-dp-sessions-BRP +++ /dev/null @@ -1 +0,0 @@ -/tmp/sm-dp-sessions-BRP \ No newline at end of file diff --git a/smdpp-data/sm-dp-sessions-NIST b/smdpp-data/sm-dp-sessions-NIST deleted file mode 120000 index 3077b26..0000000 --- a/smdpp-data/sm-dp-sessions-NIST +++ /dev/null @@ -1 +0,0 @@ -/tmp/sm-dp-sessions-NIST \ No newline at end of file -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieeb2da3bdb006b08e2f82bfc3b5252f4abf4420b Gerrit-Change-Number: 40879 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

3 weeks, 5 days

1
0
0 0

[XS] Change in pysim[master]: smdp: clean up accidental commited trash

by Hoernchen

Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40879?usp=email ) Change subject: smdp: clean up accidental commited trash ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieeb2da3bdb006b08e2f82bfc3b5252f4abf4420b Gerrit-Change-Number: 40879 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 15 Aug 2025 13:03:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 5 days

1
0
0 0

[XS] Change in pysim[master]: smdp: clean up accidental commited trash

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/40879?usp=email ) Change subject: smdp: clean up accidental commited trash ...................................................................... smdp: clean up accidental commited trash and update gitinore to ensure this does not happen again Change-Id: Ieeb2da3bdb006b08e2f82bfc3b5252f4abf4420b --- M .gitignore D smdpp-data/sm-dp-sessions-BRP D smdpp-data/sm-dp-sessions-NIST 3 files changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/79/40879/1 diff --git a/.gitignore b/.gitignore index 6b74841..d40e503 100644 --- a/.gitignore +++ b/.gitignore @@ -7,7 +7,7 @@ /.local /build /pySim.egg-info -/smdpp-data/sm-dp-sessions +/smdpp-data/sm-dp-sessions* dist tags smdpp-data/certs/DPtls/CERT_S_SM_DP_TLS_NIST.pem diff --git a/smdpp-data/sm-dp-sessions-BRP b/smdpp-data/sm-dp-sessions-BRP deleted file mode 120000 index 143169a..0000000 --- a/smdpp-data/sm-dp-sessions-BRP +++ /dev/null @@ -1 +0,0 @@ -/tmp/sm-dp-sessions-BRP \ No newline at end of file diff --git a/smdpp-data/sm-dp-sessions-NIST b/smdpp-data/sm-dp-sessions-NIST deleted file mode 120000 index 3077b26..0000000 --- a/smdpp-data/sm-dp-sessions-NIST +++ /dev/null @@ -1 +0,0 @@ -/tmp/sm-dp-sessions-NIST \ No newline at end of file -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieeb2da3bdb006b08e2f82bfc3b5252f4abf4420b Gerrit-Change-Number: 40879 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

3 weeks, 5 days

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025