August 2025 - gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: smdpp: less verbose by default

by lynxis lazus

Attention is currently required from: Hoernchen, dexter, laforge. lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40468?usp=email ) Change subject: smdpp: less verbose by default ...................................................................... Patch Set 11: (1 comment) File osmo-smdpp.py: https://gerrit.osmocom.org/c/pysim/+/40468/comment/3f22d345_a90cb5a9?usp=em… : PS6, Line 370: logger.debug("Tx JSON: %s" % json.dumps(output)[:200]) > I fail to understand what exactly we are now discussing here for a simple change from print to logge […] 1) logger.debug("foo %s" % json.dumps(output)[:200]) will always do the string.format() even in cases, when debug output isn't enabled. However logger.debug() supports doing it, when debug is enabled by: `logger.debug("foo %s", json.dumps(output)[:200])` (notice the , replaced the %). Improves performance. 2) json.dumps() is a very expensive operation, because of this, I thought it would be worth checking, if it is a huge object, put it behind logger.isEnabledFor(). After a second look, I see the function is return the json object anyways as string, you could save the json object in a variable and use logger as described in 1) to have the best performance. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I04a72b8f52417862d4dcba1f0743700dd942ef49 Gerrit-Change-Number: 40468 Gerrit-PatchSet: 11 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Aug 2025 18:24:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 6 days

1
0
0 0

[M] Change in pysim[master]: smdpp: less verbose by default

by Hoernchen

Attention is currently required from: dexter, laforge, lynxis lazus. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40468?usp=email ) Change subject: smdpp: less verbose by default ...................................................................... Patch Set 11: (1 comment) File osmo-smdpp.py: https://gerrit.osmocom.org/c/pysim/+/40468/comment/b9eb76ed_9d0b6c51?usp=em… : PS6, Line 370: logger.debug("Tx JSON: %s" % json.dumps(output)[:200]) > I still see % being used and no "if clause". […] I fail to understand what exactly we are now discussing here for a simple change from print to logger.debug. The json output is massive so it is reasonably truncated to the beginning because that is where something interesting might be found and what exactly is dumping full kilobytes of json supposed to accomplish? In particular with chunked, fat pp. The % style is what was originally used, i kept it that way, because I did not want to discuss why I changed it to a new fancy f-string. Yet here we are. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I04a72b8f52417862d4dcba1f0743700dd942ef49 Gerrit-Change-Number: 40468 Gerrit-PatchSet: 11 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Aug 2025 15:44:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 6 days

1
0
0 0

[XS] Change in osmo-pcu[master]: src/pcu_vty_functions: fix error on debian 13 i386

by osmith

Attention is currently required from: fixeria, lynxis lazus. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-pcu/+/40872?usp=email ) Change subject: src/pcu_vty_functions: fix error on debian 13 i386 ...................................................................... Patch Set 2: (1 comment) File src/pcu_vty_functions.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/40872/comment/4f15a201_cef02707?usp… : PS1, Line 65: (unsigned int long) tbf->created_ts(), tbf->state_name(), > maybe we should keep the discussion in one changeset: https://gerrit.osmocom.org/c/osmo-msc/+/40873 […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/40872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I535d997f079dce902bbdd3eff22153201b53353f Gerrit-Change-Number: 40872 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 14 Aug 2025 11:46:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 6 days

1
0
0 0

[XS] Change in osmo-msc[master]: Fix building for debian 13 armv7l

by osmith

Attention is currently required from: fixeria, lynxis lazus. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/40873?usp=email ) Change subject: Fix building for debian 13 armv7l ...................................................................... Patch Set 2: (1 comment) File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/40873/comment/48f0f4e2_ce41cbd0?usp… : PS1, Line 1052: (unsigned int long) ((vsub->expire_lu - now.tv_sec) / 60), > Not 100% sure, but I would go for the "longer" type "long long int" Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40873?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3de792d62b1989cf35051cbecde98fa9030bfbf2 Gerrit-Change-Number: 40873 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 14 Aug 2025 11:46:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 6 days

1
0
0 0

[XS] Change in osmo-pcu[master]: src/pcu_vty_functions: fix error on debian 13 i386

by osmith

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/40872?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: src/pcu_vty_functions: fix error on debian 13 i386 ...................................................................... src/pcu_vty_functions: fix error on debian 13 i386 In Debian 13 armv7l, time_t and suseconds_t are "long long int" instead of "long unsigned int" as seen on x86_64 and aarch64. Fix it by casting to "long long int". Related: OS#6828 Change-Id: I535d997f079dce902bbdd3eff22153201b53353f --- M src/pcu_vty_functions.cpp 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/72/40872/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/40872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I535d997f079dce902bbdd3eff22153201b53353f Gerrit-Change-Number: 40872 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[XS] Change in osmo-msc[master]: Fix building for debian 13 armv7l

by osmith

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/40873?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: Fix building for debian 13 armv7l ...................................................................... Fix building for debian 13 armv7l In Debian 13 armv7l, time_t and suseconds_t are "long long int" instead of "long unsigned int" as seen on x86_64 and aarch64. Fix it by casting to "long long int". Related: OS#6828 Change-Id: I3de792d62b1989cf35051cbecde98fa9030bfbf2 --- M src/libmsc/msc_vty.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/73/40873/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40873?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3de792d62b1989cf35051cbecde98fa9030bfbf2 Gerrit-Change-Number: 40873 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: add TC_silent_call_{start_stop,active_conn}

by osmith

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email ) Change subject: msc: add TC_silent_call_{start_stop,active_conn} ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ef22fbb5a05f69cc8aea7f42e05f6e1d6c4a8b6 Gerrit-Change-Number: 40863 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Aug 2025 11:11:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[XS] Change in osmo-msc[master]: silent_call: check if subscriber has a connection

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/40877?usp=email ) Change subject: silent_call: check if subscriber has a connection ...................................................................... silent_call: check if subscriber has a connection It makes no sense to initiate a silent call if subscriber already has an active connection (e.g. when a normal call is ongoing). Change-Id: I52b3be26c61cadacc4783b5c324809ecd6906b36 --- M src/libmsc/msc_vty.c M src/libmsc/silent_call.c 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index 41cb0d4..e727feb 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -1596,6 +1596,9 @@ case -ENODEV: vty_out(vty, "%% Subscriber not attached%s", VTY_NEWLINE); break; + case -EBUSY: + vty_out(vty, "%% Subscriber already has an active connection%s", VTY_NEWLINE); + break; default: if (rc) vty_out(vty, "%% Cannot start silent call (rc=%d)%s", rc, VTY_NEWLINE); diff --git a/src/libmsc/silent_call.c b/src/libmsc/silent_call.c index 9c0d2b6..327ed7f 100644 --- a/src/libmsc/silent_call.c +++ b/src/libmsc/silent_call.c @@ -142,6 +142,9 @@ struct gsm_network *net = vsub->vlr->user_ctx; struct gsm_trans *trans; + if (msc_a_for_vsub(vsub, true) != NULL) + return -EBUSY; + trans = trans_alloc(net, vsub, TRANS_SILENT_CALL, 0, 0); if (trans == NULL) return -ENODEV; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40877?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I52b3be26c61cadacc4783b5c324809ecd6906b36 Gerrit-Change-Number: 40877 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[XS] Change in osmo-msc[master]: silent_call: use LOG_TRANS when msc_a is NULL

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/40876?usp=email ) Change subject: silent_call: use LOG_TRANS when msc_a is NULL ...................................................................... silent_call: use LOG_TRANS when msc_a is NULL Change-Id: I917f45bc7f75dc0679079554d09891877516eac7 --- M src/libmsc/silent_call.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: lynxis lazus: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/src/libmsc/silent_call.c b/src/libmsc/silent_call.c index c450fdc..9c0d2b6 100644 --- a/src/libmsc/silent_call.c +++ b/src/libmsc/silent_call.c @@ -49,7 +49,7 @@ struct ran_msg assignment; if (!msc_a) { - LOG_MSC_A(msc_a, LOGL_ERROR, "Silent call: MS not responding to Paging\n"); + LOG_TRANS(trans, LOGL_ERROR, "Silent call: MS not responding to Paging\n"); osmo_signal_dispatch(SS_SCALL, S_SCALL_FAILED, &sigdata); trans_free(trans); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40876?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I917f45bc7f75dc0679079554d09891877516eac7 Gerrit-Change-Number: 40876 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[XS] Change in osmo-msc[master]: silent_call: check if subscriber has a connection

by lynxis lazus

Attention is currently required from: fixeria, osmith. lynxis lazus has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/40877?usp=email ) Change subject: silent_call: check if subscriber has a connection ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40877?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I52b3be26c61cadacc4783b5c324809ecd6906b36 Gerrit-Change-Number: 40877 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Aug 2025 10:36:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025