August 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-iuh[master]: iu_client: fix linter issues

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40848?usp=email ) Change subject: iu_client: fix linter issues ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/iu_client.c: https://gerrit.osmocom.org/c/osmo-iuh/+/40848/comment/77ef4525_b10892cc?usp… : PS3, Line 659: } else > I agree! But I don't care enough about this code base. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ia8b3405701ed62eac39b9510d34da4ba1987146c Gerrit-Change-Number: 40848 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 13 Aug 2025 14:32:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

4 weeks

1
0
0 0

[S] Change in osmo-iuh[master]: debian: fix installing osmocom/iuh/common.h

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40878?usp=email ) Change subject: debian: fix installing osmocom/iuh/common.h ...................................................................... Patch Set 3: (1 comment) This change is ready for review. Patchset: PS3: This seems to work as expected now: ``` dpkg -c libosmo-iuh-dev_1.7.0.14.8b08_amd64.deb drwxr-xr-x root/root 0 2025-08-13 16:22 ./ drwxr-xr-x root/root 0 2025-08-13 16:22 ./usr/ drwxr-xr-x root/root 0 2025-08-13 16:22 ./usr/include/ drwxr-xr-x root/root 0 2025-08-13 16:22 ./usr/include/osmocom/ drwxr-xr-x root/root 0 2025-08-13 16:22 ./usr/include/osmocom/iuh/ -rw-r--r-- root/root 112 2025-08-13 16:22 ./usr/include/osmocom/iuh/common.h drwxr-xr-x root/root 0 2025-08-13 16:22 ./usr/share/ drwxr-xr-x root/root 0 2025-08-13 16:22 ./usr/share/doc/ drwxr-xr-x root/root 0 2025-08-13 16:22 ./usr/share/doc/libosmo-iuh-dev/ -rw-r--r-- root/root 4897 2025-08-13 16:22 ./usr/share/doc/libosmo-iuh-dev/changelog.gz -rw-r--r-- root/root 2102 2022-08-23 13:51 ./usr/share/doc/libosmo-iuh-dev/copyright ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I4f7df05bf8b66d1be866895d7fe4158a7b555265 Gerrit-Change-Number: 40878 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 13 Aug 2025 14:26:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 weeks

1
0
0 0

[XS] Change in osmo-iuh[master]: debian: fix installing osmocom/iuh/common.h

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40878?usp=email ) Change subject: debian: fix installing osmocom/iuh/common.h ...................................................................... debian: fix installing osmocom/iuh/common.h Add libosmo-iuh-dev.install to fix that common.h didn't get installed. Fixes: 5267242b ("move general asn debug options into iu_helpers") Change-Id: I4f7df05bf8b66d1be866895d7fe4158a7b555265 --- A debian/libosmo-iuh-dev.install 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/78/40878/1 diff --git a/debian/libosmo-iuh-dev.install b/debian/libosmo-iuh-dev.install new file mode 100644 index 0000000..89b50c5 --- /dev/null +++ b/debian/libosmo-iuh-dev.install @@ -0,0 +1 @@ +usr/include/osmocom/iuh -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I4f7df05bf8b66d1be866895d7fe4158a7b555265 Gerrit-Change-Number: 40878 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS...

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email ) Change subject: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge ...................................................................... Patch Set 3: (1 comment) File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236/comment/762368cf_f744… : PS3, Line 3352: GSUP.receive I believe there should be an `alt` statement with a timeout here, since older osmo-msc versions do not send this. We don't want the testsuite to get stuck here until the `Tguard` kicks in. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 13 Aug 2025 14:10:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: silent_call: use LOG_TRANS when msc_a is NULL

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/40876?usp=email ) Change subject: silent_call: use LOG_TRANS when msc_a is NULL ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40876?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I917f45bc7f75dc0679079554d09891877516eac7 Gerrit-Change-Number: 40876 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Aug 2025 14:05:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: silent_call: check if subscriber has a connection

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/40877?usp=email ) Change subject: silent_call: check if subscriber has a connection ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40877?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I52b3be26c61cadacc4783b5c324809ecd6906b36 Gerrit-Change-Number: 40877 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Aug 2025 14:05:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: add TC_silent_call_start_stop

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email ) Change subject: msc: add TC_silent_call_start_stop ...................................................................... Patch Set 2: (1 comment) File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863/comment/79ee3c0d_156f… : PS2, Line 7735: /* XXX: The MSC pages the MS, even though there is an active connection?!? */ > This comment sounds like this is a bug, maybe open a separate issue and reference it here? It's a lot quicker to get this fixed than creating a ticket ;) https://gerrit.osmocom.org/c/osmo-msc/+/40877 silent_call: check if subscriber has a connection I'll rework this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ef22fbb5a05f69cc8aea7f42e05f6e1d6c4a8b6 Gerrit-Change-Number: 40863 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Aug 2025 14:03:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

4 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: silent_call: use LOG_TRANS when msc_a is NULL

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/40876?usp=email ) Change subject: silent_call: use LOG_TRANS when msc_a is NULL ...................................................................... silent_call: use LOG_TRANS when msc_a is NULL Change-Id: I917f45bc7f75dc0679079554d09891877516eac7 --- M src/libmsc/silent_call.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/76/40876/1 diff --git a/src/libmsc/silent_call.c b/src/libmsc/silent_call.c index c450fdc..9c0d2b6 100644 --- a/src/libmsc/silent_call.c +++ b/src/libmsc/silent_call.c @@ -49,7 +49,7 @@ struct ran_msg assignment; if (!msc_a) { - LOG_MSC_A(msc_a, LOGL_ERROR, "Silent call: MS not responding to Paging\n"); + LOG_TRANS(trans, LOGL_ERROR, "Silent call: MS not responding to Paging\n"); osmo_signal_dispatch(SS_SCALL, S_SCALL_FAILED, &sigdata); trans_free(trans); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40876?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I917f45bc7f75dc0679079554d09891877516eac7 Gerrit-Change-Number: 40876 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

4 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: silent_call: check if subscriber has a connection

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/40877?usp=email ) Change subject: silent_call: check if subscriber has a connection ...................................................................... silent_call: check if subscriber has a connection It makes no sense to initiate a silent call if subscriber already has an active connection (e.g. when a normal call is ongoing). Change-Id: I52b3be26c61cadacc4783b5c324809ecd6906b36 --- M src/libmsc/msc_vty.c M src/libmsc/silent_call.c 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/77/40877/1 diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index 41cb0d4..07791f1 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -1596,6 +1596,9 @@ case -ENODEV: vty_out(vty, "%% Subscriber not attached%s", VTY_NEWLINE); break; + case -EBUSY: + vty_out(vty, "%% Subscriber has an active connection%s", VTY_NEWLINE); + break; default: if (rc) vty_out(vty, "%% Cannot start silent call (rc=%d)%s", rc, VTY_NEWLINE); diff --git a/src/libmsc/silent_call.c b/src/libmsc/silent_call.c index 9c0d2b6..327ed7f 100644 --- a/src/libmsc/silent_call.c +++ b/src/libmsc/silent_call.c @@ -142,6 +142,9 @@ struct gsm_network *net = vsub->vlr->user_ctx; struct gsm_trans *trans; + if (msc_a_for_vsub(vsub, true) != NULL) + return -EBUSY; + trans = trans_alloc(net, vsub, TRANS_SILENT_CALL, 0, 0); if (trans == NULL) return -ENODEV; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40877?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I52b3be26c61cadacc4783b5c324809ecd6906b36 Gerrit-Change-Number: 40877 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

4 weeks

1
0
0 0

[XL] Change in osmo-iuh[master]: Drop iu_client - adopted by osmo-sgsn

by lynxis lazus

Attention is currently required from: daniel, laforge. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by daniel, Code-Review-1 by laforge, Verified+1 by Jenkins Builder Change subject: Drop iu_client - adopted by osmo-sgsn ...................................................................... Drop iu_client - adopted by osmo-sgsn The only remaining use of iu_client is osmo-sgsn. iu_client was originally meant to be used by osmo-msc and osmo-sgsn. But the abstraction didn't hold up and osmo-msc stopped using iu_client for a long time. Move iu_client to osmo-sgsn until it got replaced by a more direct implementation (similar to IUCS in osmo-msc). Related: OS#5487 Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de --- M TODO-RELEASE M include/osmocom/ranap/iu_client.h M src/Makefile.am D src/iu_client.c 4 files changed, 4 insertions(+), 1,372 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/47/40847/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de Gerrit-Change-Number: 40847 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

4 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025