August 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bsc[master]: Fix building for debian 13 armv7l

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40871?usp=email ) Change subject: Fix building for debian 13 armv7l ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I416b31dd11a82ad52f6a662d7e099123a5c77fff Gerrit-Change-Number: 40871 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Aug 2025 09:15:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: Fix building for debian 13 armv7l

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40871?usp=email ) Change subject: Fix building for debian 13 armv7l ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I416b31dd11a82ad52f6a662d7e099123a5c77fff Gerrit-Change-Number: 40871 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Aug 2025 09:15:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: Fix building for debian 13 armv7l

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40871?usp=email ) Change subject: Fix building for debian 13 armv7l ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I416b31dd11a82ad52f6a662d7e099123a5c77fff Gerrit-Change-Number: 40871 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Aug 2025 09:15:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: Fix building for debian 13 armv7l

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40871?usp=email ) Change subject: Fix building for debian 13 armv7l ...................................................................... Fix building for debian 13 armv7l In Debian 13 armv7l, time_t and suseconds_t are "long long int" instead of "long unsigned int" as seen on x86_64 and aarch64. Fix it by casting to "long unsigned int". Related: OS#6828 Change-Id: I416b31dd11a82ad52f6a662d7e099123a5c77fff --- M src/ipaccess/ipaccess-config.c M src/osmo-bsc/bts_ctrl.c M tests/acc/acc_test.c M tests/paging/paging_test.c 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/71/40871/1 diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index a576ebc..27d536a 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -879,7 +879,7 @@ printf("\taddr1: 0x%x\n", ntohl(sub_entry->header_entry.addr1)); printf("\taddr2: 0x%x\n", ntohl(sub_entry->header_entry.addr2)); printf("\tstart: 0x%x\n", ntohl(sub_entry->header_entry.start)); - printf("\tabs. offset: 0x%lx\n", sub_entry->absolute_offset); + printf("\tabs. offset: 0x%lx\n", (unsigned int long) sub_entry->absolute_offset); printf("\n\n"); dump_entry(sub_entry, part++, fd); diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 76806f4..2efa661 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -130,7 +130,7 @@ curloc = llist_first_entry(&bts->loc_list, struct bts_location, list); - cmd->reply = talloc_asprintf(cmd, "%lu,%s,%f,%f,%f", curloc->tstamp, + cmd->reply = talloc_asprintf(cmd, "%lu,%s,%f,%f,%f", (unsigned int long) curloc->tstamp, get_value_string(bts_loc_fix_names, curloc->valid), curloc->lat, curloc->lon, curloc->height); if (!cmd->reply) { cmd->reply = "OOM"; diff --git a/tests/acc/acc_test.c b/tests/acc/acc_test.c index 84a63b0..2f910c4 100644 --- a/tests/acc/acc_test.c +++ b/tests/acc/acc_test.c @@ -36,7 +36,7 @@ struct timeval tv; osmo_gettimeofday(&tv, NULL); fprintf(stderr, "sys={%lu.%06lu}: %s\n", - tv.tv_sec, tv.tv_usec, str); + (unsigned int long) tv.tv_sec, (unsigned int long) tv.tv_usec, str); } #define bts_init(net) _bts_init(net, __func__) diff --git a/tests/paging/paging_test.c b/tests/paging/paging_test.c index dae3499..60180b1 100644 --- a/tests/paging/paging_test.c +++ b/tests/paging/paging_test.c @@ -42,7 +42,7 @@ struct timeval tv; osmo_gettimeofday(&tv, NULL); fprintf(stderr, "sys={%lu.%06lu}: %s\n", - tv.tv_sec, tv.tv_usec, str); + (unsigned int long) tv.tv_sec, (unsigned int long) tv.tv_usec, str); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I416b31dd11a82ad52f6a662d7e099123a5c77fff Gerrit-Change-Number: 40871 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: transaction: Fix potenial use after free of members

by matanp

matanp has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/40853?usp=email ) Change subject: transaction: Fix potenial use after free of members ...................................................................... Abandoned osmo-msc doesn't support multithreading so this change is not welcomed -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40853?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I177959fb298ae04c4e8df877582fc9a1bd4dc2cf Gerrit-Change-Number: 40853 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

4 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: silent_call: Fix use after free of paging request

by matanp

matanp has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/40852?usp=email ) Change subject: silent_call: Fix use after free of paging request ...................................................................... silent_call: Fix use after free of paging request Before this change trans->paging_request was not assigned correctly. In some cases it caused trans_free to not call paging_request_remove. If the paging timeouts, paging_cb_silent would call trans_free again with a stale pointer. Change-Id: I93913d189800d71f82c013b6e946bd63db362f65 --- M src/libmsc/silent_call.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/libmsc/silent_call.c b/src/libmsc/silent_call.c index a59e3af..c450fdc 100644 --- a/src/libmsc/silent_call.c +++ b/src/libmsc/silent_call.c @@ -152,8 +152,9 @@ } trans->silent_call.from_vty = vty; - if (!paging_request_start(vsub, PAGING_CAUSE_CALL_BACKGROUND, paging_cb_silent, trans, - "establish silent call")) { + trans->paging_request = paging_request_start(vsub, PAGING_CAUSE_CALL_BACKGROUND, paging_cb_silent, trans, + "establish silent call"); + if (!trans->paging_request) { trans_free(trans); return -ENODEV; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40852?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I93913d189800d71f82c013b6e946bd63db362f65 Gerrit-Change-Number: 40852 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: matanp <matan1008(a)gmail.com>

4 weeks

1
0
0 0

[L] Change in libosmo-abis[master]: trau: add TFO frame insert/extract functions

by falconia

Attention is currently required from: laforge. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/40646?usp=email ) Change subject: trau: add TFO frame insert/extract functions ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Pinging for review from @laforge@osmocom.org: @pespin@sysmocom.de added you as a reviewer along with his +1. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/40646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Idf149ec682e4064f0e63d67ac757d92402f22dca Gerrit-Change-Number: 40646 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 13 Aug 2025 00:43:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: Makefile: add 'clean-logs' target

by daniel

Attention is currently required from: fixeria. daniel has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40862?usp=email ) Change subject: Makefile: add 'clean-logs' target ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id0597f9eeea9e128ce38a2b19f2126c729e71ffd Gerrit-Change-Number: 40862 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Aug 2025 13:31:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/registry-update-base-images: add debian:trixie

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40868?usp=email ) Change subject: jobs/registry-update-base-images: add debian:trixie ...................................................................... jobs/registry-update-base-images: add debian:trixie Change-Id: I905863157b35bdc4ca60116be477b90abbd215f1 --- M jobs/registry-update-base-images.yml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved daniel: Looks good to me, but someone else must approve diff --git a/jobs/registry-update-base-images.yml b/jobs/registry-update-base-images.yml index c9934cb..889deb9 100644 --- a/jobs/registry-update-base-images.yml +++ b/jobs/registry-update-base-images.yml @@ -29,6 +29,7 @@ debian/eol:buster debian:bullseye debian:bookworm + debian:trixie debian:sid centos:centos7 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I905863157b35bdc4ca60116be477b90abbd215f1 Gerrit-Change-Number: 40868 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/registry-update-base-images: add debian:trixie

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40868?usp=email ) Change subject: jobs/registry-update-base-images: add debian:trixie ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I905863157b35bdc4ca60116be477b90abbd215f1 Gerrit-Change-Number: 40868 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Aug 2025 13:22:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025