August 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: jobs/registry-update-base-images: add debian:trixie

by daniel

Attention is currently required from: osmith. daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40868?usp=email ) Change subject: jobs/registry-update-base-images: add debian:trixie ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I905863157b35bdc4ca60116be477b90abbd215f1 Gerrit-Change-Number: 40868 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Aug 2025 13:22:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-remsim[master]: src/bankd/bankd_main: fix error on debian 13 i386

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/40869?usp=email ) Change subject: src/bankd/bankd_main: fix error on debian 13 i386 ...................................................................... src/bankd/bankd_main: fix error on debian 13 i386 Fix for: bankd_main.c:824:46: error: passing argument 5 of 'worker->ops->transceive' from incompatible pointer type [-Wincompatible-pointer-types] 824 | rx_buf, &rx_buf_len); | ^~~~~~~~~~~ | | | DWORD * {aka long unsigned int *} bankd_main.c:824:46: note: expected 'size_t *' {aka 'unsigned int *'} but argument is of type 'DWORD *' {aka 'long unsigned int *'} Related: OS#6828 Change-Id: I9f943a3448da5f23ea75c116559cf0b6ba6b23c7 --- M src/bankd/bankd_main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index fe11497..6e47376 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -792,7 +792,7 @@ { const struct TpduModemToCard *mdm2sim = &pdu->msg.choice.tpduModemToCard; uint8_t rx_buf[1024]; - DWORD rx_buf_len = sizeof(rx_buf); + size_t rx_buf_len = sizeof(rx_buf); RsproPDU_t *pdu_resp; struct client_slot clslot; struct bank_slot bslot; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/40869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9f943a3448da5f23ea75c116559cf0b6ba6b23c7 Gerrit-Change-Number: 40869 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-remsim[master]: src/bankd/bankd_pcsc: fix error on debian 13 i386

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/40870?usp=email ) Change subject: src/bankd/bankd_pcsc: fix error on debian 13 i386 ...................................................................... src/bankd/bankd_pcsc: fix error on debian 13 i386 Fix for: bankd_pcsc.c:316:98: error: passing argument 7 of 'SCardTransmit' from incompatible pointer type [-Wincompatible-pointer-types] 316 | rc = SCardTransmit(worker->reader.pcsc.hCard, pioSendPci, out, out_len, &pioRecvPci, in, in_len); | ^~~~~~ | | | size_t * {aka unsigned int *} In file included from bankd.h:11, from bankd_pcsc.c:28: /usr/include/PCSC/winscard.h:98:56: note: expected 'LPDWORD' {aka 'long unsigned int *'} but argument is of type 'size_t *' {aka 'unsigned int *'} Related: https://pcsclite.apdu.fr/api/group__API.html#ga9a2d77242a271310269065e64633… Related: OS#6828 Change-Id: I4978cd9b91920fe6049ccb398a8d6b93deaa4980 --- M src/bankd/bankd_pcsc.c 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index e1477dd..f9651f3 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -313,11 +313,15 @@ SCARD_IO_REQUEST pioRecvPci; long rc; - rc = SCardTransmit(worker->reader.pcsc.hCard, pioSendPci, out, out_len, &pioRecvPci, in, in_len); + /* DWORD can be different from size_t */ + DWORD in_len_d = *in_len; + + rc = SCardTransmit(worker->reader.pcsc.hCard, pioSendPci, out, out_len, &pioRecvPci, in, &in_len_d); /* don't use PCSC_ERROR here as we don't want to log every successful SCardTransmit */ if (rc != SCARD_S_SUCCESS) LOGW_PCSC_ERROR(worker, rc, "SCardTransmit"); + *in_len = in_len_d; return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/40870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4978cd9b91920fe6049ccb398a8d6b93deaa4980 Gerrit-Change-Number: 40870 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-remsim[master]: src/bankd/bankd_pcsc: fix error on debian 13 i386

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/40870?usp=email ) Change subject: src/bankd/bankd_pcsc: fix error on debian 13 i386 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/40870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4978cd9b91920fe6049ccb398a8d6b93deaa4980 Gerrit-Change-Number: 40870 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Aug 2025 13:22:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-remsim[master]: src/bankd/bankd_main: fix error on debian 13 i386

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/40869?usp=email ) Change subject: src/bankd/bankd_main: fix error on debian 13 i386 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/40869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9f943a3448da5f23ea75c116559cf0b6ba6b23c7 Gerrit-Change-Number: 40869 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 12 Aug 2025 13:21:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-remsim[master]: src/bankd/bankd_pcsc: fix error on debian 13 i386

by daniel

Attention is currently required from: osmith. daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/40870?usp=email ) Change subject: src/bankd/bankd_pcsc: fix error on debian 13 i386 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/40870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4978cd9b91920fe6049ccb398a8d6b93deaa4980 Gerrit-Change-Number: 40870 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Aug 2025 13:21:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-remsim[master]: src/bankd/bankd_main: fix error on debian 13 i386

by daniel

Attention is currently required from: laforge, osmith. daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/40869?usp=email ) Change subject: src/bankd/bankd_main: fix error on debian 13 i386 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/40869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9f943a3448da5f23ea75c116559cf0b6ba6b23c7 Gerrit-Change-Number: 40869 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 12 Aug 2025 13:20:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-remsim[master]: src/bankd/bankd_pcsc: fix error on debian 13 i386

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/40870?usp=email ) Change subject: src/bankd/bankd_pcsc: fix error on debian 13 i386 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/40870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4978cd9b91920fe6049ccb398a8d6b93deaa4980 Gerrit-Change-Number: 40870 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Aug 2025 12:24:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-remsim[master]: src/bankd/bankd_main: fix error on debian 13 i386

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/40869?usp=email ) Change subject: src/bankd/bankd_main: fix error on debian 13 i386 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/40869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9f943a3448da5f23ea75c116559cf0b6ba6b23c7 Gerrit-Change-Number: 40869 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Aug 2025 12:22:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/registry-update-base-images: add debian:trixie

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40868?usp=email ) Change subject: jobs/registry-update-base-images: add debian:trixie ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I905863157b35bdc4ca60116be477b90abbd215f1 Gerrit-Change-Number: 40868 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Aug 2025 12:22:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025