August 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: Add functions to set LAC/CI on a BTS and update hashtables.

by Jenkins Builder

Jenkins Builder has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email ) Change subject: Add functions to set LAC/CI on a BTS and update hashtables. ...................................................................... Patch Set 3: (8 comments) File src/osmo-bsc/bts.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/47a2e3dd_a3ad6470?usp… : PS3, Line 761: int gsm_bts_set_lac(struct gsm_bts *bts, int lac) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/d7861df3_e851cc4a?usp… : PS3, Line 772: int gsm_bts_set_ci(struct gsm_bts *bts, int ci) { open brace '{' following function definitions go on the next line File src/osmo-bsc/bts_ctrl.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/bf806338_139b019c?usp… : PS3, Line 247: static int get_bts_lac(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/cd392fbd_b63152b9?usp… : PS3, Line 257: static int set_bts_lac(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/25a70f92_dfcc7333?usp… : PS3, Line 266: static int verify_bts_lac(struct ctrl_cmd *cmd, const char *value, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/4cc3e52c_3f7e4f6e?usp… : PS3, Line 280: static int get_bts_ci(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/6f858d44_448561b9?usp… : PS3, Line 290: static int set_bts_ci(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/4bc5d20e_dd7138f7?usp… : PS3, Line 299: static int verify_bts_ci(struct ctrl_cmd *cmd, const char *value, void *data) { open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861 Gerrit-Change-Number: 40917 Gerrit-PatchSet: 3 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 25 Aug 2025 20:43:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: Add functions to set LAC/CI on a BTS and update hashtables.

by keith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add functions to set LAC/CI on a BTS and update hashtables. ...................................................................... Add functions to set LAC/CI on a BTS and update hashtables. Use these function from both the vty and the control interface. This commit fixes the issue where an update to LAC or CI via the control interface was not resulting in updated hashtables and therefore the BTS was not found during paging. Related: OS#6840 Fixes: 15284337ece94e3ff3ebf9575096290f67d69a88 Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ctrl.c M src/osmo-bsc/bts_vty.c 4 files changed, 92 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/17/40917/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861 Gerrit-Change-Number: 40917 Gerrit-PatchSet: 3 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org>

4 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: Add functions to set LAC/CI on a BTS and update hashtables.

by keith

keith has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email ) Change subject: Add functions to set LAC/CI on a BTS and update hashtables. ...................................................................... Patch Set 2: -Verified -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861 Gerrit-Change-Number: 40917 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 25 Aug 2025 20:39:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: Add functions to set LAC/CI on a BTS and update hashtables.

by keith

keith has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email ) Change subject: Add functions to set LAC/CI on a BTS and update hashtables. ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861 Gerrit-Change-Number: 40917 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 25 Aug 2025 20:38:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: Add functions to set LAC/CI on a BTS and update hashtables.

by Jenkins Builder

Jenkins Builder has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email ) Change subject: Add functions to set LAC/CI on a BTS and update hashtables. ...................................................................... Patch Set 2: (8 comments) File src/osmo-bsc/bts.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/3cc40e25_2887aa1c?usp… : PS2, Line 761: int gsm_bts_set_lac(struct gsm_bts *bts, int lac) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/4b4bd1ea_5f765708?usp… : PS2, Line 772: int gsm_bts_set_ci(struct gsm_bts *bts, int ci) { open brace '{' following function definitions go on the next line File src/osmo-bsc/bts_ctrl.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/3389c0f8_40d71919?usp… : PS2, Line 247: static int get_bts_lac(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/c5542973_492f7f35?usp… : PS2, Line 257: static int set_bts_lac(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/54ce82f7_d3198bfb?usp… : PS2, Line 266: static int verify_bts_lac(struct ctrl_cmd *cmd, const char *value, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/dd2fa18e_da922bdd?usp… : PS2, Line 280: static int get_bts_ci(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/35267f88_460e39e5?usp… : PS2, Line 290: static int set_bts_ci(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/3aae866f_79c1f532?usp… : PS2, Line 299: static int verify_bts_ci(struct ctrl_cmd *cmd, const char *value, void *data) { open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861 Gerrit-Change-Number: 40917 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 25 Aug 2025 20:34:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: Add functions to set LAC/CI on a BTS and update hashtables.

by keith

keith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email ) Change subject: Add functions to set LAC/CI on a BTS and update hashtables. ...................................................................... Add functions to set LAC/CI on a BTS and update hashtables. Use these function from both the vty and the control interface. This commit fixes the issue where an update to LAC or CI via the control interface was not resulting in updated hashtables and therefore the BTS was not found during paging. Related: OS#6840 Fixes: 15284337ece94e3ff3ebf9575096290f67d69a88 Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ctrl.c M src/osmo-bsc/bts_vty.c 4 files changed, 94 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/17/40917/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861 Gerrit-Change-Number: 40917 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-CC: Jenkins Builder

4 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: * Add functions to set LAC/CI on a BTS and update hashtables. * Use t...

by Jenkins Builder

Jenkins Builder has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email ) Change subject: * Add functions to set LAC/CI on a BTS and update hashtables. * Use these function from both the vty and the control interface. ...................................................................... Patch Set 1: (8 comments) File src/osmo-bsc/bts.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/2a047d6f_fd94ae51?usp… : PS1, Line 761: int gsm_bts_set_lac(struct gsm_bts *bts, int lac) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/f991221e_191eaf7a?usp… : PS1, Line 772: int gsm_bts_set_ci(struct gsm_bts *bts, int ci) { open brace '{' following function definitions go on the next line File src/osmo-bsc/bts_ctrl.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/b56b4ce5_4b24165d?usp… : PS1, Line 247: static int get_bts_lac(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/f8b8d0e1_b5534a54?usp… : PS1, Line 257: static int set_bts_lac(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/927f1be0_3c5ef528?usp… : PS1, Line 266: static int verify_bts_lac(struct ctrl_cmd *cmd, const char *value, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/5e1af576_9ed217d0?usp… : PS1, Line 280: static int get_bts_ci(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/a5dce18b_eeffb69e?usp… : PS1, Line 290: static int set_bts_ci(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/c093b738_d568d0f8?usp… : PS1, Line 299: static int verify_bts_ci(struct ctrl_cmd *cmd, const char *value, void *data) { open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861 Gerrit-Change-Number: 40917 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 25 Aug 2025 20:31:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: * Add functions to set LAC/CI on a BTS and update hashtables. * Use t...

by keith

keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email ) Change subject: * Add functions to set LAC/CI on a BTS and update hashtables. * Use these function from both the vty and the control interface. ...................................................................... * Add functions to set LAC/CI on a BTS and update hashtables. * Use these function from both the vty and the control interface. This commit fixes the issue where an update to LAC or CI via the control interface was not resulting in updated hashtables and therefore the BTS was not found during paging. Related: OS#6840 Fixes: 15284337ece94e3ff3ebf9575096290f67d69a88 Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ctrl.c M src/osmo-bsc/bts_vty.c 4 files changed, 94 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/17/40917/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 0264dcf..4cf1e1f 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -825,6 +825,9 @@ int gsm_set_bts_model(struct gsm_bts *bts, struct gsm_bts_model *model); int gsm_set_bts_type(struct gsm_bts *bts, enum gsm_bts_type type); +int gsm_bts_set_lac(struct gsm_bts *bts, int lac); +int gsm_bts_set_ci(struct gsm_bts *bts, int lac); + struct gsm_bts_trx *gsm_bts_trx_num(const struct gsm_bts *bts, int num); int bts_gprs_mode_is_compat(struct gsm_bts *bts, enum bts_gprs_mode mode); diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index dd60ef8..6af7ab1 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -758,6 +758,30 @@ return 0; } +int gsm_bts_set_lac(struct gsm_bts *bts, int lac) { + + bts->location_area_code = lac; + hash_del(&bts->node_by_lac); + hash_del(&bts->node_by_lac_ci); + hash_add(bts->network->bts_by_lac, &bts->node_by_lac, bts->location_area_code); + hash_add(bts->network->bts_by_lac_ci, &bts->node_by_lac_ci, + LAC_CI_HASHTABLE_KEY(bts->location_area_code, bts->cell_identity)); + return 0; +} + +int gsm_bts_set_ci(struct gsm_bts *bts, int ci) { + + bts->cell_identity = ci; + hash_del(&bts->node_by_ci); + hash_add(bts->network->bts_by_ci, &bts->node_by_ci, bts->cell_identity); + if (bts->location_area_code != GSM_LAC_RESERVED_DETACHED) { + hash_del(&bts->node_by_lac_ci); + hash_add(bts->network->bts_by_lac_ci, &bts->node_by_lac_ci, + LAC_CI_HASHTABLE_KEY(bts->location_area_code, bts->cell_identity)); + } + return 0; +} + int bts_gprs_mode_is_compat(struct gsm_bts *bts, enum bts_gprs_mode mode) { if (mode != BTS_GPRS_NONE && diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 2efa661..bca146c 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -244,9 +244,70 @@ return 1; } +static int get_bts_lac(struct ctrl_cmd *cmd, void *data) { + struct gsm_bts *bts = cmd->node; + cmd->reply = talloc_asprintf(cmd, "%d", bts->location_area_code); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + return CTRL_CMD_REPLY; +} + +static int set_bts_lac(struct ctrl_cmd *cmd, void *data) { + struct gsm_bts *bts = cmd->node; + int lac; + + osmo_str_to_int(&lac, cmd->value, 0, 0, 0xffff); + gsm_bts_set_lac(bts, lac); + return get_bts_lac(cmd, data); +} + +static int verify_bts_lac(struct ctrl_cmd *cmd, const char *value, void *data) { + int lac; + + if (osmo_str_to_int(&lac, cmd->value, 0, 0, 0xffff) < 0) { + cmd->reply = "LAC is not within the valid range (0-65535)"; + return -1; + } + if (lac == GSM_LAC_RESERVED_DETACHED || lac == GSM_LAC_RESERVED_ALL_BTS) { + cmd->reply = talloc_asprintf(cmd, "LAC %d is reserved by GSM 04.08", lac); + return -1; + } + return 0; +} + +static int get_bts_ci(struct ctrl_cmd *cmd, void *data) { + struct gsm_bts *bts = cmd->node; + cmd->reply = talloc_asprintf(cmd, "%d", bts->cell_identity); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + return CTRL_CMD_REPLY; +} + +static int set_bts_ci(struct ctrl_cmd *cmd, void *data) { + struct gsm_bts *bts = cmd->node; + int ci; + + osmo_str_to_int(&ci, cmd->value, 0, 0, 0xffff); + gsm_bts_set_ci(bts, ci); + return get_bts_ci(cmd, data); +} + +static int verify_bts_ci(struct ctrl_cmd *cmd, const char *value, void *data) { + int ci; + + if (osmo_str_to_int(&ci, cmd->value, 0, 0, 0xffff) < 0) { + cmd->reply = "CI is not within the valid range (0-65535)"; + return -1; + } + return 0; +} /* BTS related commands below */ -CTRL_CMD_DEFINE_RANGE(bts_lac, "location-area-code", struct gsm_bts, location_area_code, 0, 65535); -CTRL_CMD_DEFINE_RANGE(bts_ci, "cell-identity", struct gsm_bts, cell_identity, 0, 65535); +CTRL_CMD_DEFINE(bts_lac, "location-area-code"); +CTRL_CMD_DEFINE(bts_ci, "cell-identity"); CTRL_CMD_DEFINE_RANGE(bts_bsic, "bsic", struct gsm_bts, bsic, 0, 63); CTRL_CMD_DEFINE_RANGE(bts_rach_max_delay, "rach-max-delay", struct gsm_bts, rach_max_delay, 1, 127); CTRL_CMD_DEFINE_RANGE(bts_rach_expiry_timeout, "rach-expiry-timeout", struct gsm_bts, rach_expiry_timeout, 4, 64); diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index b2b1247..b412910 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -274,16 +274,9 @@ ci, VTY_NEWLINE); return CMD_WARNING; } - bts->cell_identity = ci; - hash_del(&bts->node_by_ci); - hash_add(bts->network->bts_by_ci, &bts->node_by_ci, bts->cell_identity); - if (bts->location_area_code != GSM_LAC_RESERVED_DETACHED) { - hash_del(&bts->node_by_lac_ci); - hash_add(bts->network->bts_by_lac_ci, &bts->node_by_lac_ci, - LAC_CI_HASHTABLE_KEY(bts->location_area_code, bts->cell_identity)); - } - return CMD_SUCCESS; + if (gsm_bts_set_ci(bts, ci)) + return CMD_SUCCESS; } DEFUN_USRATTR(cfg_bts_lac, @@ -305,14 +298,8 @@ return CMD_WARNING; } - bts->location_area_code = lac; - hash_del(&bts->node_by_lac); - hash_del(&bts->node_by_lac_ci); - hash_add(bts->network->bts_by_lac, &bts->node_by_lac, bts->location_area_code); - hash_add(bts->network->bts_by_lac_ci, &bts->node_by_lac_ci, - LAC_CI_HASHTABLE_KEY(bts->location_area_code, bts->cell_identity)); - - return CMD_SUCCESS; + if (gsm_bts_set_lac(bts, lac)) + return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861 Gerrit-Change-Number: 40917 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org>

4 weeks

1
0
0 0

[XL] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Improve InitialContextSetupRequest template

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40915?usp=email ) Change subject: NGAP_Templates: Improve InitialContextSetupRequest template ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40915?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib87221455ebc9f59ab0810b28a6509cdcecc81c7 Gerrit-Change-Number: 40915 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 19:08:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Introduce generic NGSetupFailure template f_mw_n2_NGS...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40916?usp=email ) Change subject: NGAP_Templates: Introduce generic NGSetupFailure template f_mw_n2_NGSetupFailure() ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File library/ngap/NGAP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40916/comment/398169d1_073a… : PS2, Line 6210: mw_n2_NGSetupFailure I would remove this template completely, now that you have a more flexible replacement. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I39302624212b907a5267b8104176c2bbb96bd2ae Gerrit-Change-Number: 40916 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 19:06:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025