Attention is currently required from: neels.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email )
Change subject: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to the parent
......................................................................
Patch Set 11:
(1 comment)
File tests/msc_vlr/msc_vlr_test_authen_reuse.err:
https://gerrit.osmocom.org/c/osmo-msc/+/38491/comment/258f5816_8515e255?usp… :
PS11, Line 184: DVLR vlr_lu_fsm(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:GERAN-A:LU){VLR_ULA_S_DONE}: Deferring: will deallocate with msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:GERAN-A:LU)
> I see here that we deallocate the msc_a much much earlier. […]
I don't know.
I ran the test cases and it looked fine (both make check and ttcn3).
Any other idea?
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I27fd1048f85363797b43808d2061ce28be6da81b
Gerrit-Change-Number: 38491
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Aug 2025 17:17:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39257?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: TC_attach_gsup_lu_timeout: increase timeout to 35 seconds
......................................................................
SGSN: TC_attach_gsup_lu_timeout: increase timeout to 35 seconds
Currently the SGSN times out after 30 seconds.
Change-Id: Ie882dd39f3c606e5fe00162fcf17c47b9f713d49
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/57/39257/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39257?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie882dd39f3c606e5fe00162fcf17c47b9f713d49
Gerrit-Change-Number: 39257
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39258?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: TC_attach_auth_sai_timeout: increase t_guard to 35 seconds
......................................................................
SGSN: TC_attach_auth_sai_timeout: increase t_guard to 35 seconds
Currently the SGSN times out after 30 seconds.
Change-Id: Iaef1853f1e5f9b99fedbdfbed597ffa79b9e758a
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/39258/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39258?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iaef1853f1e5f9b99fedbdfbed597ffa79b9e758a
Gerrit-Change-Number: 39258
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed
......................................................................
SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed
Add a TC to to simulate multiple GMM Attach with a different
content.
When receiving a GMM Attach while in an Attach procedure, but with a different
content, the old GMM Attach should be discarded silently and a new
GMM Attach procedure should be initiated.
Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 71 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/39256/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc
Gerrit-Change-Number: 39256
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39259?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: TC_attach_timeout_after_pdp_act: expect SAI when doing auth
......................................................................
SGSN: TC_attach_timeout_after_pdp_act: expect SAI when doing auth
While doing an attach, a authentication should happen.
Change-Id: I46853723ecb43f4809e8c292ec5c4cc5d872ad2f
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/59/39259/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39259?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I46853723ecb43f4809e8c292ec5c4cc5d872ad2f
Gerrit-Change-Number: 39259
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39260?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: remove TC_attach_no_imei_response
......................................................................
SGSN: remove TC_attach_no_imei_response
The SGSN doesn't request the IMEI via Identity Response anymore.
This information is requested via Authentication/Ciphering Req/Resp.
Change-Id: I42dc927513fb54b0fd2d07dda4cf8d4646b9f351
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 0 insertions(+), 48 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/39260/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39260?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I42dc927513fb54b0fd2d07dda4cf8d4646b9f351
Gerrit-Change-Number: 39260
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: dexter, fixeria, laforge, lynxis lazus.
Hello Jenkins Builder, daniel, dexter, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: Remove unsupport test cases
......................................................................
SGSN: Remove unsupport test cases
The functionality for ACL based authentication (only use
the IMSI, but don't request information from the HLR) will
be removed from the SGSN.
Change-Id: I1506324300fe3864069706d5b05860e7b44cd895
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 0 insertions(+), 181 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/39261/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1506324300fe3864069706d5b05860e7b44cd895
Gerrit-Change-Number: 39261
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39263?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: GTPv1C_Templates: add cause code GTP_CAUSE_IMSI_IMEI_NOT_KNOWN
......................................................................
GTPv1C_Templates: add cause code GTP_CAUSE_IMSI_IMEI_NOT_KNOWN
It will be used by SGSN Context Req/Resp/Ack test cases in the SGSN.
Change-Id: I8f919d5982a3c9a317d309c383b36043ad5d3278
---
M library/GTPv1C_Templates.ttcn
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/39263/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39263?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8f919d5982a3c9a317d309c383b36043ad5d3278
Gerrit-Change-Number: 39263
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: add testcases for PDP Context Status
......................................................................
SGSN: add testcases for PDP Context Status
Both the network and the UE can add a TLV which
describes the active PDPs from their perspective.
Change-Id: I5a29e667f53cc2834fbddd2c5dc901d3e6ae72c7
---
M library/L3_Templates.ttcn
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
3 files changed, 222 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/39262/10
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5a29e667f53cc2834fbddd2c5dc901d3e6ae72c7
Gerrit-Change-Number: 39262
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>