Attention is currently required from: lynxis lazus, pespin.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email )
Change subject: SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case
......................................................................
Patch Set 8:
(3 comments)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/79ee115d_9d90… :
PS2, Line 2050: [] as_gmm_auth(umts_aka_challenge := true, expect_sai := true) {};
> I don't see what's the problem. […]
The problem here is that the expected event flow is unclear and the logic is quite permissive. For instance, it's unclear to me if the IDENTITY.req is expected to be optional or mandatory procedure. AFAICS, you permit the SGSN to not send IDENTITY.req and initiate the authentication straight away despite P-TMSI is unknown.
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/e9393421_11c8… :
PS8, Line 2069: If the SGSN follows the rules, this 2nd ATTACH REQ should be ignored, because
: * of the same content
I am not sure why do we even send GMM ATTACH.req again here (perhaps for the sake of fun?) and why only for IMEI (not for IMSI), but I would like to ask you to not remove this comment. Otherwise the second `f_send_l3()` looks confusing, as if it was accidentally copy-pasted.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/9af8efe7_c137… :
PS8, Line 2116: auth-policy accept-all
Unrelated to this patch: is the authentication mandatory now? You mentioned that the ACL will be removed at some point, so does that mean I won't be able to use GPRS with commercial SIM cards for which I have no key material in the HLR?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I026499844940d4c3d82b0fbd61be636c6ca348e6
Gerrit-Change-Number: 39254
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 25 Aug 2025 18:21:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895?usp=email )
Change subject: 5gc: Test UE requested PDU Session Modification procedure
......................................................................
Patch Set 3:
(4 comments)
File 5gc/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895/comment/c240b6f5_eb58… :
PS2, Line 395: min 1 item in list doesn't allow previously allocating an empty list
> You could simply do: […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895/comment/0f8487fd_209e… :
PS2, Line 443: min 1 item in list doesn't allow previously allocating an empty list
> Likewise here, just assign the value using `i` as the index.
Done
File library/NGAP_Functions.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895/comment/e309b14a_9fc6… :
PS2, Line 167: Setup
> Modify?
Done
File library/NG_NAS_Osmo_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895/comment/b2ec55fc_592d… :
PS2, Line 749: omit
> How can the whole template be `omit`? Did you mean `value`?
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id9ac0f0e431c4a82dfab8675c93bf3c3f05442a7
Gerrit-Change-Number: 40895
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Aug 2025 18:19:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
Hello Jenkins Builder, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: 5gc: Test UE requested PDU Session Modification procedure
......................................................................
5gc: Test UE requested PDU Session Modification procedure
Change-Id: Id9ac0f0e431c4a82dfab8675c93bf3c3f05442a7
---
M 5gc/C5G_Tests.ttcn
M 5gc/ConnHdlr.ttcn
M 5gc/expected-results.xml
M deps/Makefile
M library/NGAP_Functions.ttcn
M library/NG_NAS_Osmo_Templates.ttcn
M library/ngap/NGAP_EncDec.cc
M library/ngap/NGAP_Types.ttcn
8 files changed, 340 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/40895/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id9ac0f0e431c4a82dfab8675c93bf3c3f05442a7
Gerrit-Change-Number: 40895
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39018?usp=email )
Change subject: SGSN: f_routing_area_update: add authentication argument
......................................................................
Patch Set 9:
(1 comment)
File sgsn/BSSGP_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39018/comment/3e769ba5_2e79… :
PS9, Line 691: allow_auth
Maybe add an enumerated type with three values?
```
AUTH_MODE_DISABLED
AUTH_MODE_PERMITTED
AUTH_MODE_REQUIRED
```
Let's imagine I want to make sure there's no authentication. With the current API, if I pass `allow_auth := false`, the code will still handle authentication despite it's not expected.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39018?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7125ed8aa81fbda48a19f7f4fc711bc1bf2c875f
Gerrit-Change-Number: 39018
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 25 Aug 2025 17:57:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: laforge, lynxis lazus, pespin.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email )
Change subject: SGSN_Tests: rework TC_sgsn_context_req_out to actual function
......................................................................
Patch Set 10:
(1 comment)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/fd3ebc33_e7db… :
PS10, Line 3350: f_sleep(1.0);
> Why is this needed?
Since I am already the second person asking why do you add an artificial delay here, please add a comment explaining why this `f_sleep()` is needed. What kind of timeouts are you running into?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3
Gerrit-Change-Number: 39017
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 25 Aug 2025 17:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: laforge, lynxis lazus, pespin.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email )
Change subject: SGSN_Tests: rework TC_sgsn_context_req_out to actual function
......................................................................
Patch Set 10:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/24b629da_20ce… :
PS10, Line 7: rework TC_sgsn_context_req_out to actual function
I find the commit name confusing. What's an "actual function"?
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/ddc3e65f_2f43… :
PS10, Line 3237: tr_SGSNContextReqPDU
Weird formatting here.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/3e6f8a48_5cd2… :
PS10, Line 3350: f_sleep(1.0);
Why is this needed?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3
Gerrit-Change-Number: 39017
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 25 Aug 2025 17:45:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895?usp=email )
Change subject: 5gc: Test UE requested PDU Session Modification procedure
......................................................................
Patch Set 2:
(4 comments)
File 5gc/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895/comment/b45afe6a_9d97… :
PS2, Line 395: min 1 item in list doesn't allow previously allocating an empty list
You could simply do:
```
qos_flow_resp_li[i] := qos_flow_resp_it;
```
This works fine and the runtime will resize the list accordingly.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895/comment/3bc5a43d_f2f4… :
PS2, Line 443: min 1 item in list doesn't allow previously allocating an empty list
Likewise here, just assign the value using `i` as the index.
File library/NGAP_Functions.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895/comment/f74baec7_0c14… :
PS2, Line 167: Setup
Modify?
File library/NG_NAS_Osmo_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895/comment/dbcfe584_e734… :
PS2, Line 749: omit
How can the whole template be `omit`? Did you mean `value`?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id9ac0f0e431c4a82dfab8675c93bf3c3f05442a7
Gerrit-Change-Number: 40895
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Aug 2025 17:36:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
