Attention is currently required from: keith, pespin.
fixeria has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email )
Change subject: Add functions to set LAC/CI on a BTS and update hashtables.
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861
Gerrit-Change-Number: 40917
Gerrit-PatchSet: 6
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Gerrit-Comment-Date: Tue, 26 Aug 2025 07:40:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/40918?usp=email )
Change subject: tests/smpp: fix building for debian 13 armv7l
......................................................................
tests/smpp: fix building for debian 13 armv7l
In Debian 13 armv7l, time_t is "long long int" instead of "long unsigned
int" as seen on x86_64 and aarch64. Fix it by casting to "long long
int".
Change-Id: I3801fc7d0a85036f1f9346c54824eff5c126f363
---
M tests/smpp/smpp_test.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/18/40918/1
diff --git a/tests/smpp/smpp_test.c b/tests/smpp/smpp_test.c
index 9b94c63..085d983 100644
--- a/tests/smpp/smpp_test.c
+++ b/tests/smpp/smpp_test.c
@@ -86,7 +86,7 @@
time_t t = smpp_parse_time_format(smpp_time_tests[i], &t_now);
char buf[32];
strftime(buf, sizeof(buf), "%Y-%m-%d %H:%M:%S", gmtime(&t));
- printf("'%s': %ld == %s\n", smpp_time_tests[i], t, buf);
+ printf("'%s': %lld == %s\n", smpp_time_tests[i], (long long int) t, buf);
}
if (orig_tz)
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40918?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3801fc7d0a85036f1f9346c54824eff5c126f363
Gerrit-Change-Number: 40918
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: keith.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add functions to set LAC/CI on a BTS and update hashtables.
......................................................................
Add functions to set LAC/CI on a BTS and update hashtables.
Use these function from both the vty and the control interface.
This commit fixes the issue where an update to LAC or CI
via the control interface was not resulting in updated
hashtables and therefore the BTS was not found during paging.
Related: OS#6840
Fixes: 15284337ece94e3ff3ebf9575096290f67d69a88
Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861
---
M include/osmocom/bsc/bts.h
M src/osmo-bsc/bts.c
M src/osmo-bsc/bts_ctrl.c
M src/osmo-bsc/bts_vty.c
4 files changed, 98 insertions(+), 17 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/17/40917/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861
Gerrit-Change-Number: 40917
Gerrit-PatchSet: 6
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith(a)rhizomatica.org>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40916?usp=email )
Change subject: NGAP_Templates: Introduce generic NGSetupFailure template f_mw_n2_NGSetupFailure()
......................................................................
Patch Set 2:
(1 comment)
File library/ngap/NGAP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40916/comment/2fb2d9d5_217b… :
PS2, Line 6210: mw_n2_NGSetupFailure
> I would remove this template completely, now that you have a more flexible replacement.
I'm using it as a base anyway, so it's fine to keep it if you want to match only the 2 mandatory IEs.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40916?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I39302624212b907a5267b8104176c2bbb96bd2ae
Gerrit-Change-Number: 40916
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Aug 2025 20:53:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: keith.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add functions to set LAC/CI on a BTS and update hashtables.
......................................................................
Add functions to set LAC/CI on a BTS and update hashtables.
Use these function from both the vty and the control interface.
This commit fixes the issue where an update to LAC or CI
via the control interface was not resulting in updated
hashtables and therefore the BTS was not found during paging.
Related: OS#6840
Fixes: 15284337ece94e3ff3ebf9575096290f67d69a88
Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861
---
M include/osmocom/bsc/bts.h
M src/osmo-bsc/bts.c
M src/osmo-bsc/bts_ctrl.c
M src/osmo-bsc/bts_vty.c
4 files changed, 98 insertions(+), 17 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/17/40917/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861
Gerrit-Change-Number: 40917
Gerrit-PatchSet: 5
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith(a)rhizomatica.org>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Attention is currently required from: keith.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add functions to set LAC/CI on a BTS and update hashtables.
......................................................................
Add functions to set LAC/CI on a BTS and update hashtables.
Use these function from both the vty and the control interface.
This commit fixes the issue where an update to LAC or CI
via the control interface was not resulting in updated
hashtables and therefore the BTS was not found during paging.
Related: OS#6840
Fixes: 15284337ece94e3ff3ebf9575096290f67d69a88
Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861
---
M include/osmocom/bsc/bts.h
M src/osmo-bsc/bts.c
M src/osmo-bsc/bts_ctrl.c
M src/osmo-bsc/bts_vty.c
4 files changed, 98 insertions(+), 17 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/17/40917/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861
Gerrit-Change-Number: 40917
Gerrit-PatchSet: 4
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith(a)rhizomatica.org>
Gerrit-Attention: keith <keith(a)rhizomatica.org>