April 2025 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: saip-tool: add commandline option to edit mandatory services list
by laforge 16 Apr '25

16 Apr '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email ) Change subject: saip-tool: add commandline option to edit mandatory services list ...................................................................... saip-tool: add commandline option to edit mandatory services list Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 --- M contrib/saip-tool.py M pySim/esim/saip/__init__.py 2 files changed, 36 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/saip-tool.py b/contrib/saip-tool.py index 927db1f..9fc111c 100755 --- a/contrib/saip-tool.py +++ b/contrib/saip-tool.py @@ -101,6 +101,12 @@ parser_rappi.add_argument('--aid', required=True, help='Load package AID') parser_rappi.add_argument('--inst-aid', required=True, help='Instance AID') +esrv_flag_choices = [t.name for t in asn1.types['ServicesList'].type.root_members] +parser_esrv = subparsers.add_parser('edit-mand-srv-list', help='Add/Remove service flag from/to mandatory services list') +parser_esrv.add_argument('--output-file', required=True, help='Output file name') +parser_esrv.add_argument('--add-flag', default=[], choices=esrv_flag_choices, action='append', help='Add flag to mandatory services list') +parser_esrv.add_argument('--remove-flag', default=[], choices=esrv_flag_choices, action='append', help='Remove flag from mandatory services list') + parser_info = subparsers.add_parser('tree', help='Display the filesystem tree') def write_pes(pes: ProfileElementSequence, output_file:str): @@ -418,6 +424,25 @@ return print("Load Package AID: %s not found in PE Sequence" % opts.aid) +def do_edit_mand_srv_list(pes: ProfileElementSequence, opts): + header = pes.pe_by_type.get('header', [])[0] + + for s in opts.add_flag: + print("Adding service '%s' to mandatory services list..." % s) + header.mandatory_service_add(s) + for s in opts.remove_flag: + if s in header.decoded['eUICC-Mandatory-services'].keys(): + print("Removing service '%s' from mandatory services list..." % s) + header.mandatory_service_remove(s) + else: + print("Service '%s' not present in mandatory services list, cannot remove!" % s) + + print("The following services are now set mandatory:") + for s in header.decoded['eUICC-Mandatory-services'].keys(): + print("\t%s" % s) + + write_pes(pes, opts.output_file) + def do_tree(pes:ProfileElementSequence, opts): pes.mf.print_tree() @@ -458,5 +483,7 @@ do_add_app_inst(pes, opts) elif opts.command == 'remove-app-inst': do_remove_app_inst(pes, opts) + elif opts.command == 'edit-mand-srv-list': + do_edit_mand_srv_list(pes, opts) elif opts.command == 'tree': do_tree(pes, opts) diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 9ccf134..21f44ef 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -1411,6 +1411,15 @@ if profile_type: self.decoded['profileType'] = profile_type + def mandatory_service_add(self, service_name): + self.decoded['eUICC-Mandatory-services'][service_name] = None + + def mandatory_service_remove(self, service_name): + if service_name in self.decoded['eUICC-Mandatory-services'].keys(): + del self.decoded['eUICC-Mandatory-services'][service_name] + else: + raise ValueError("service not in eUICC-Mandatory-services list, cannot remove") + class ProfileElementEnd(ProfileElement): type = 'end' def __init__(self, decoded: Optional[dict] = None, **kwargs): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 Gerrit-Change-Number: 39863 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: saip-tool: add commandline option to edit mandatory services list
by laforge 16 Apr '25

16 Apr '25

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email ) Change subject: saip-tool: add commandline option to edit mandatory services list ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 Gerrit-Change-Number: 39863 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Apr 2025 09:05:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: saip-tool: add commandline option to edit mandatory services list
by dexter 16 Apr '25

16 Apr '25

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email ) Change subject: saip-tool: add commandline option to edit mandatory services list ...................................................................... Patch Set 5: (1 comment) File contrib/saip-tool.py: https://gerrit.osmocom.org/c/pysim/+/39863/comment/e8c205ba_9c9ebc1f?usp=em… : PS3, Line 106: action > for the record, I didn't read any documentation, just interactively played with the ship. […] Thanks for the hint. I wasn't expecting it to be that easy. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 Gerrit-Change-Number: 39863 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Apr 2025 08:37:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: saip-tool: add commandline option to edit mandatory services list
by dexter 16 Apr '25

16 Apr '25

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: saip-tool: add commandline option to edit mandatory services list ...................................................................... saip-tool: add commandline option to edit mandatory services list Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 --- M contrib/saip-tool.py M pySim/esim/saip/__init__.py 2 files changed, 36 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/63/39863/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 Gerrit-Change-Number: 39863 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim-shell: add utility to measure execution time
by dexter 16 Apr '25

16 Apr '25

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/38659?usp=email ) Change subject: pySim-shell: add utility to measure execution time ...................................................................... Abandoned unfortunately there is no convenient way to integrate this with cmd2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38659?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I356ea44e08efe93fe927dbc20564bf850278b546 Gerrit-Change-Number: 38659 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-msc[master]: SMS-over-GSUP: properly update MSC_CTR_SMS_RP_ERR_{MEM,OTHER}
by osmith 16 Apr '25

16 Apr '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/40042?usp=email ) Change subject: SMS-over-GSUP: properly update MSC_CTR_SMS_RP_ERR_{MEM,OTHER} ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40042?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I97b4699e5b2c44989368004a53e26ca5daaa7b14 Gerrit-Change-Number: 40042 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Apr 2025 07:14:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: ttcn3-bts-test: use an older version of fake_trx.py
by osmith 16 Apr '25

16 Apr '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/40041?usp=email ) Change subject: ttcn3-bts-test: use an older version of fake_trx.py ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I251082474bb29d0169f88b5bd545c97d487c8353 Gerrit-Change-Number: 40041 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Apr 2025 07:11:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-msc[master]: SMS-over-GSUP: properly update MSC_CTR_SMS_RP_ERR_{MEM,OTHER}
by laforge 16 Apr '25

16 Apr '25

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/40042?usp=email ) Change subject: SMS-over-GSUP: properly update MSC_CTR_SMS_RP_ERR_{MEM,OTHER} ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40042?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I97b4699e5b2c44989368004a53e26ca5daaa7b14 Gerrit-Change-Number: 40042 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Apr 2025 07:03:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: saip-tool: add commandline option to edit mandatory services list
by laforge 16 Apr '25

16 Apr '25

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email ) Change subject: saip-tool: add commandline option to edit mandatory services list ...................................................................... Patch Set 4: (1 comment) File contrib/saip-tool.py: https://gerrit.osmocom.org/c/pysim/+/39863/comment/3b4e619d_99377229?usp=em… : PS3, Line 106: action > ``` […] for the record, I didn't read any documentation, just interactively played with the ship.asn1 in the python3 shell -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 Gerrit-Change-Number: 39863 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Apr 2025 07:03:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in docker-playground[master]: ttcn3-bts-test: use an older version of fake_trx.py
by laforge 16 Apr '25

16 Apr '25

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/40041?usp=email ) Change subject: ttcn3-bts-test: use an older version of fake_trx.py ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I251082474bb29d0169f88b5bd545c97d487c8353 Gerrit-Change-Number: 40041 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Apr 2025 07:01:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log April 2025