lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

April 2025

  • 1 participants
  • 1186 discussions
[M] Change in docker-playground[master]: move all osmo-*-master containers to Debian 10 (buster)
by laforge 16 Apr '25

16 Apr '25
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/docker-playground/+/17778?usp=email ) Change subject: move all osmo-*-master containers to Debian 10 (buster) ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/17778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibcf323a1fc5c660779a7005127d7cdb4577a9495 Gerrit-Change-Number: 17778 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ci[master]: obs-mirror-include: update Ubuntu versions
by osmith 16 Apr '25

16 Apr '25
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40035?usp=email ) Change subject: obs-mirror-include: update Ubuntu versions ...................................................................... obs-mirror-include: update Ubuntu versions Update the list to only include the Ubuntu versions we currently build for, which are: * 25.04 * 24.10 * 24.04 LTS * 22.04 LTS Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Linux_Distributio… Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Add_a_new_distrib… Related: https://osmocom.org/news/303 Change-Id: Icb07e53ad5640f985241fbdd3678f1a4191baf0c --- M contrib/obs-mirror/obs-mirror-include.txt 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt index e0e2af2..7c64a3e 100644 --- a/contrib/obs-mirror/obs-mirror-include.txt +++ b/contrib/obs-mirror/obs-mirror-include.txt @@ -5,16 +5,16 @@ latest/Debian_12 latest/Raspbian_10 latest/Raspbian_11 -latest/xUbuntu_18.04 -latest/xUbuntu_20.04 -latest/xUbuntu_21.04 latest/xUbuntu_22.04 -latest/xUbuntu_23.04 latest/xUbuntu_24.04 +latest/xUbuntu_24.10 +latest/xUbuntu_25.04 nightly/CentOS_8 nightly/Debian_11 nightly/Debian_12 nightly/Raspbian_11 -nightly/xUbuntu_23.04 +nightly/xUbuntu_22.04 nightly/xUbuntu_24.04 +nightly/xUbuntu_24.10 +nightly/xUbuntu_25.04 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40035?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icb07e53ad5640f985241fbdd3678f1a4191baf0c Gerrit-Change-Number: 40035 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ci[master]: OBS: build_binpkg: use signed-by in sources.list
by osmith 16 Apr '25

16 Apr '25
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40036?usp=email ) Change subject: OBS: build_binpkg: use signed-by in sources.list ...................................................................... OBS: build_binpkg: use signed-by in sources.list Installing repo keys with "apt-key" has been deprecated and fails in debian unstable. Replace it with the new method. Change-Id: I88164d8d106ff2656efbf78e9d3e4031edd9cf45 --- M scripts/obs/data/build_binpkg.Dockerfile 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: jolly: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Verified laforge: Looks good to me, approved diff --git a/scripts/obs/data/build_binpkg.Dockerfile b/scripts/obs/data/build_binpkg.Dockerfile index 66f1feb..0a96272 100644 --- a/scripts/obs/data/build_binpkg.Dockerfile +++ b/scripts/obs/data/build_binpkg.Dockerfile @@ -4,7 +4,7 @@ ARG FEED ARG UID -COPY Release.key /tmp/Release.key +COPY Release.key /usr/share/keyrings/osmocom.asc RUN useradd --uid=${UID} -m user @@ -83,15 +83,11 @@ VERSION="$(echo "$DISTRO" | cut -d : -f 2 | sed 's/./\u&/')"; \ case "$DISTRO" in \ debian:*) \ - apt-key add /tmp/Release.key && \ - rm /tmp/Release.key && \ - echo "deb https://downloads.osmocom.org/packages/osmocom:/$FEED/Debian_$VERSION/ ./" \ + echo "deb [signed-by=/usr/share/keyrings/osmocom.asc] https://downloads.osmocom.org/packages/osmocom:/$FEED/Debian_$VERSION/ ./" \ > /etc/apt/sources.list.d/osmocom-$FEED.list \ ;; \ ubuntu:*) \ - apt-key add /tmp/Release.key && \ - rm /tmp/Release.key && \ - echo "deb https://downloads.osmocom.org/packages/osmocom:/$FEED/xUbuntu_$VERSION/ ./" \ + echo "deb [signed-by=/usr/share/keyrings/osmocom.asc] https://downloads.osmocom.org/packages/osmocom:/$FEED/xUbuntu_$VERSION/ ./" \ > /etc/apt/sources.list.d/osmocom-$FEED.list \ ;; \ almalinux:*|centos:*) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40036?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I88164d8d106ff2656efbf78e9d3e4031edd9cf45 Gerrit-Change-Number: 40036 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: Support configuring RAC on each hnb conn"
by osmith 16 Apr '25

16 Apr '25
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40037?usp=email ) Change subject: Revert "hnbgw: Support configuring RAC on each hnb conn" ...................................................................... Revert "hnbgw: Support configuring RAC on each hnb conn" This reverts commit 4e4398aac6d19fe16c40be88290e0da08588fd2d: caused regression in several other tests. Related: OS#6762 Change-Id: I077c584219bfa54468bd796a1fc2e85fd60b7a02 --- M hnbgw/ConnHdlr.ttcn M hnbgw/HNBGW_Tests.ttcn 2 files changed, 2 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 90d264d..efba060 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -227,7 +227,6 @@ type record HnbConfig { LocationAreaIdentification lai, - uint8_t rac, integer sac } @@ -480,7 +479,7 @@ } var template RANAP_PDU ret; if (pars.ps_domain) { - var RANAP_IEs.RAC rac := int2oct(pars.hnb.rac, 1); + var RANAP_IEs.RAC rac := '00'O; ret := ts_RANAP_initialUE_PS(lai, rac, sai, nas, pars.sigc_id, grnc_id); } else { ret := ts_RANAP_initialUE_CS(lai, sai, nas, pars.sigc_id, grnc_id); diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index a261264..33800f3 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -501,7 +501,6 @@ mcc_mnc := '00F110'H, lac := 2342 + i }, - rac := 11 + i, sac := 55 }; f_init_hnodeb(testcasename(), i, rua_ops); @@ -677,7 +676,7 @@ hex2oct(g_hnb_cfg[hnb_idx].lai.mcc_mnc), int2bit(1 + cell_id, 28), int2oct(g_hnb_cfg[hnb_idx].lai.lac, 2), - int2oct(g_hnb_cfg[hnb_idx].rac, 1), + int2oct(0, 1), int2oct(g_hnb_cfg[hnb_idx].sac, 2))); T.start; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40037?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I077c584219bfa54468bd796a1fc2e85fd60b7a02 Gerrit-Change-Number: 40037 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: Test paging with PAge Area ID IE"
by osmith 16 Apr '25

16 Apr '25
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40038?usp=email ) Change subject: Revert "hnbgw: Test paging with PAge Area ID IE" ...................................................................... Revert "hnbgw: Test paging with PAge Area ID IE" This reverts commit b0e3627eaa2665a03eb2301b099da6bceb4e4d4a: caused regression in several other tests. Related: OS#6762 Change-Id: I416d514e739cc0b16832192bfdb746a4ed09336f --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml M library/ranap/RANAP_Templates.ttcn 3 files changed, 2 insertions(+), 170 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 862bff9..a261264 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -2185,108 +2185,6 @@ f_shutdown_helper(); } -/* Make sure that whichever MSC paged a subscriber will also get the Paging Response. Page by IMSI, which would be - * round-robined to another MSC, to make sure the Paging->Response relation is stronger than the NRI->MSC mapping. */ -friend function f_tc_mscpool_paging_imsi_lai_registered(charstring id) runs on ConnHdlr { - var hexstring imsi := '001010000000123'H; - var RANAP_IEs.CN_DomainIndicator domain_ind; - var template (value) RANAP_IEs.LAI lai := ts_RANAP_LAI(hex2oct(g_pars.hnb.lai.mcc_mnc), - int2oct(g_pars.hnb.lai.lac, 2)); - var template (value) RANAP_IEs.PagingAreaID pag_area_id := ts_RANAP_PagingAreaID_LAI(lai); - if (g_pars.ps_domain) { - domain_ind := ps_domain; - } else { - domain_ind := cs_domain; - } - var template (value) RANAP_PDU paging := ts_RANAP_Paging_pag_area_id(domain_ind, imsi_hex2oct(imsi), pag_area_id); - BSSAP.send(ts_RANAP_UNITDATA_req(g_pars.sccp_addr_hnbgw, g_pars.sccp_addr_msc, paging)); - /* TODO: Expect RUA ConnectionlessTransfer Paging (on subset of HNB). - * We could verify the Paging sent from osmo-hnbgw to RUA with some effort, - * but, this test does not care whether the Paging was forwarded to RUA or not, only that osmo-hnbgw *received* - * the Paging. In the CN pool decisions, osmo-hnbgw should match up Paging Response to an earlier Paging. - */ - - f_sleep(1.0); - - /* Despite the round robin pointing at the second MSC ('roundrobin next msc 1'), the earlier Paging for the same IMSI - * causes this Paging Response to go to the first MSC ('msc 0'). */ - f_perform_compl_l3(f_gen_one_compl_l3(PAGRESP, ts_MI_IMSI_LV(imsi))); - f_sleep(1.0); -} - -/* Test CN sending a RANAP Paging Command with Paging Area ID IE (LAI) present requesting a registered HNB: */ -testcase TC_mscpool_paging_imsi_lai_registered() runs on test_CT { - f_init(nr_msc := 3); - f_sleep(1.0); - - var boolean ps_domain := false; - - /* Testing a Paging on the first MSC to get a Paging Response back to the first MSC. Set round robin to the - * second MSC to make sure we're getting the Paging logic, not a coincidental round robin match. */ - f_vty_set_roundrobin_next(HNBGWVTY, ps_domain, 0); - - f_ctrs_cn_init(ps_domain := ps_domain); - - var ConnHdlr vc_conn1; - var template (value) TestHdlrParams pars1 := f_TestHdlrParams(0, ps_domain := ps_domain, cn_nr := 0); - vc_conn1 := f_start_handler_with_pars(refers(f_tc_mscpool_paging_imsi_lai_registered), pars1); - vc_conn1.done; - f_ctrs_cn_expect(0, "cnpool:subscr:paged"); - f_shutdown_helper(); -} - -/* Make sure that whichever MSC paged a subscriber will also get the Paging Response. Page by IMSI, which would be - * round-robined to another MSC, to make sure the Paging->Response relation is stronger than the NRI->MSC mapping. */ -friend function f_tc_mscpool_paging_imsi_rai_registered(charstring id) runs on ConnHdlr { - var hexstring imsi := '001010000000123'H; - var RANAP_IEs.CN_DomainIndicator domain_ind; - var template (value) RANAP_IEs.LAI lai := ts_RANAP_LAI(hex2oct(g_pars.hnb.lai.mcc_mnc), - int2oct(g_pars.hnb.lai.lac, 2)); - var template (value) RANAP_IEs.RAI rai := ts_RANAP_RAI(lai, - int2oct(g_pars.hnb.rac, 1)); - var template (value) RANAP_IEs.PagingAreaID pag_area_id := ts_RANAP_PagingAreaID_RAI(rai); - if (g_pars.ps_domain) { - domain_ind := ps_domain; - } else { - domain_ind := cs_domain; - } - var template (value) RANAP_PDU paging := ts_RANAP_Paging_pag_area_id(domain_ind, imsi_hex2oct(imsi), pag_area_id); - BSSAP.send(ts_RANAP_UNITDATA_req(g_pars.sccp_addr_hnbgw, g_pars.sccp_addr_msc, paging)); - /* TODO: Expect RUA ConnectionlessTransfer Paging (on subset of HNB). - * We could verify the Paging sent from osmo-hnbgw to RUA with some effort, - * but, this test does not care whether the Paging was forwarded to RUA or not, only that osmo-hnbgw *received* - * the Paging. In the CN pool decisions, osmo-hnbgw should match up Paging Response to an earlier Paging. - */ - - f_sleep(1.0); - - /* Despite the round robin pointing at the second MSC ('roundrobin next msc 1'), the earlier Paging for the same IMSI - * causes this Paging Response to go to the first MSC ('msc 0'). */ - f_perform_compl_l3(f_gen_one_compl_l3(PAGRESP, ts_MI_IMSI_LV(imsi))); - f_sleep(1.0); -} - -/* Test CN sending a RANAP Paging Command with Paging Area ID IE (LAI) present requesting a registered HNB: */ -testcase TC_mscpool_paging_imsi_rai_registered() runs on test_CT { - f_init(nr_msc := 3); - f_sleep(1.0); - - var boolean ps_domain := true; - - /* Testing a Paging on the first MSC to get a Paging Response back to the first MSC. Set round robin to the - * second MSC to make sure we're getting the Paging logic, not a coincidental round robin match. */ - f_vty_set_roundrobin_next(HNBGWVTY, ps_domain, 0); - - f_ctrs_cn_init(ps_domain := ps_domain); - - var ConnHdlr vc_conn1; - var template (value) TestHdlrParams pars1 := f_TestHdlrParams(0, ps_domain := ps_domain, cn_nr := 0); - vc_conn1 := f_start_handler_with_pars(refers(f_tc_mscpool_paging_imsi_rai_registered), pars1); - vc_conn1.done; - f_ctrs_cn_expect(0, "cnpool:subscr:paged"); - f_shutdown_helper(); -} - /* For round-robin, skip a CN link that has 'no allow-attach' set. */ testcase TC_mscpool_no_allow_attach_round_robin() runs on test_CT { @@ -2603,8 +2501,6 @@ execute( TC_mscpool_LU_by_tmsi_from_other_PLMN() ); execute( TC_mscpool_paging_imsi() ); execute( TC_mscpool_paging_tmsi() ); - execute( TC_mscpool_paging_imsi_lai_registered() ); - execute( TC_mscpool_paging_imsi_rai_registered() ); execute( TC_mscpool_no_allow_attach_round_robin() ); execute( TC_mscpool_no_allow_attach_valid_nri() ); execute( TC_mscpool_sccp_n_pcstate_detaches_cnlink() ); diff --git a/hnbgw/expected-results.xml b/hnbgw/expected-results.xml index 3fca542..655db84 100644 --- a/hnbgw/expected-results.xml +++ b/hnbgw/expected-results.xml @@ -43,8 +43,6 @@ <testcase classname='HNBGW_Tests' name='TC_mscpool_LU_by_tmsi_from_other_PLMN' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_paging_imsi' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_paging_tmsi' time='MASKED'/> - <testcase classname='HNBGW_Tests' name='TC_mscpool_paging_imsi_lai_registered' time='MASKED'/> - <testcase classname='HNBGW_Tests' name='TC_mscpool_paging_imsi_rai_registered' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_no_allow_attach_round_robin' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_no_allow_attach_valid_nri' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_sccp_n_pcstate_detaches_cnlink' time='MASKED'/> diff --git a/library/ranap/RANAP_Templates.ttcn b/library/ranap/RANAP_Templates.ttcn index c328171..b09d23e 100644 --- a/library/ranap/RANAP_Templates.ttcn +++ b/library/ranap/RANAP_Templates.ttcn @@ -760,8 +760,7 @@ *****************************************************************************************************/ template (value) RANAP_PDU -ts_RANAP_Paging(template (value) CN_DomainIndicator dom, - template (value) IMSI imsi, +ts_RANAP_Paging(template (value) CN_DomainIndicator dom, template (value) IMSI imsi, template (omit) Paging.protocolExtensions exts := omit) := { initiatingMessage := { procedureCode := id_Paging, @@ -791,8 +790,7 @@ } } template RANAP_PDU -tr_RANAP_Paging(template (present) CN_DomainIndicator dom, - template (present) IMSI imsi, +tr_RANAP_Paging(template CN_DomainIndicator dom, template IMSI imsi, template Paging.protocolExtensions exts := *) := { initiatingMessage := { procedureCode := id_Paging, @@ -822,7 +820,6 @@ } } - template (value) TemporaryUE_ID ts_RANAP_TemporaryUE_ID_TMSI(octetstring tmsi) := { tMSI := tmsi } @@ -865,65 +862,6 @@ } } -template (value) LAI ts_RANAP_LAI(template (value) OCT3 pLMNidentity, - template (value) OCT2 lac) := { - pLMNidentity := pLMNidentity, - lAC := lac, - iE_Extensions := omit -}; - -template (value) RAI ts_RANAP_RAI(template (value) LAI lai, - template (value) OCT1 rac) := { - lAI := lai, - rAC := rac, - iE_Extensions := omit -}; - -template (value) PagingAreaID ts_RANAP_PagingAreaID_LAI(template (value) LAI lai) := { - lAI := lai -}; - -template (value) PagingAreaID ts_RANAP_PagingAreaID_RAI(template (value) RAI rai) := { - rAI := rai -}; - -template (value) RANAP_PDU -ts_RANAP_Paging_pag_area_id(template (value) CN_DomainIndicator dom, template (value) IMSI imsi, - template (value) PagingAreaID pag_area_id, - template (omit) Paging.protocolExtensions exts := omit) := { - initiatingMessage := { - procedureCode := id_Paging, - criticality := ignore, - value_ := { - paging := { - protocolIEs := { - { - id := id_CN_DomainIndicator, - criticality := ignore, - value_ := { - cN_DomainIndicator := dom - } - }, { - id := id_PermanentNAS_UE_ID, - criticality := ignore, - value_ := { - permanentNAS_UE_ID := { - iMSI := imsi - } - } - }, { - id := id_PagingAreaID, - criticality := ignore, - value_ := { - pagingAreaID := pag_area_id - } - } - }, - protocolExtensions := exts - } - } - } -} /***************************************************************************************************** * Common ID -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40038?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I416d514e739cc0b16832192bfdb746a4ed09336f Gerrit-Change-Number: 40038 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-msc[master]: SMS-over-GSUP: properly update MSC_CTR_SMS_RP_ERR_{MEM,OTHER}
by fixeria 15 Apr '25

15 Apr '25
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/40042?usp=email ) Change subject: SMS-over-GSUP: properly update MSC_CTR_SMS_RP_ERR_{MEM,OTHER} ...................................................................... SMS-over-GSUP: properly update MSC_CTR_SMS_RP_ERR_{MEM,OTHER} These counters have not been updated in SMS-over-GSUP mode so far. Move the logic updating counters to the common code path. Take a chance to use rate_ctr_inc2(). Change-Id: I97b4699e5b2c44989368004a53e26ca5daaa7b14 Related: SYS#7323 --- M src/libmsc/gsm_04_11.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/42/40042/1 diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c index d45f1ea..fad2f4b 100644 --- a/src/libmsc/gsm_04_11.c +++ b/src/libmsc/gsm_04_11.c @@ -918,6 +918,11 @@ LOG_TRANS(trans, LOGL_NOTICE, "RX SMS RP-ERROR, cause %d:%d (%s)\n", cause_len, cause, get_value_string(gsm411_rp_cause_strs, cause)); + if (cause == GSM411_RP_CAUSE_MT_MEM_EXCEEDED) + rate_ctr_inc2(net->msc_ctrs, MSC_CTR_SMS_RP_ERR_MEM); + else + rate_ctr_inc2(net->msc_ctrs, MSC_CTR_SMS_RP_ERR_OTHER); + if (trans->net->sms_over_gsup) { /* Forward towards SMSC via GSUP */ uint8_t ui_len = 0; @@ -957,10 +962,8 @@ * to store this in our database and wait for a SMMA message */ /* FIXME */ send_signal(S_SMS_MEM_EXCEEDED, trans, sms, 0); - rate_ctr_inc(rate_ctr_group_get_ctr(net->msc_ctrs, MSC_CTR_SMS_RP_ERR_MEM)); } else { send_signal(S_SMS_UNKNOWN_ERROR, trans, sms, 0); - rate_ctr_inc(rate_ctr_group_get_ctr(net->msc_ctrs, MSC_CTR_SMS_RP_ERR_OTHER)); } sms_free(sms); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40042?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I97b4699e5b2c44989368004a53e26ca5daaa7b14 Gerrit-Change-Number: 40042 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[M] Change in docker-playground[master]: move all osmo-*-master containers to Debian 10 (buster)
by fixeria 15 Apr '25

15 Apr '25
Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/docker-playground/+/17778?usp=email ) Change subject: move all osmo-*-master containers to Debian 10 (buster) ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: @laforge@osmocom.org I think this patch should be abandoned. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/17778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibcf323a1fc5c660779a7005127d7cdb4577a9495 Gerrit-Change-Number: 17778 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 15 Apr 2025 18:44:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in docker-playground[master]: ttcn3-bts-test: use an older version of fake_trx.py
by fixeria 15 Apr '25

15 Apr '25
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/40041?usp=email ) Change subject: ttcn3-bts-test: use an older version of fake_trx.py ...................................................................... ttcn3-bts-test: use an older version of fake_trx.py The latest version of fake_trx.py [re-]introduces burst queueing [1], making its behavior more closely resemble that of a real transceiver. However, this change has also introduced stability issues, leading to increased flakiness in ttcn3-bts-test. As a temporary workaround, use an older version predating this change. Unset the "--sched-rr-prio" [2], which is not supported by that version. Change-Id: I251082474bb29d0169f88b5bd545c97d487c8353 Related: [1] osmocom-bb.git I41291708effdd2c767be680fff22ffbd9a56815e Related: [2] 6374a9e ("ttcn3-bts-test: Run fake_trx with sched-prio-rr") Related: OS#6672 --- M ttcn3-bts-test/Makefile M ttcn3-bts-test/jenkins.sh 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/41/40041/1 diff --git a/ttcn3-bts-test/Makefile b/ttcn3-bts-test/Makefile index fc6f3f8..2af27a9 100644 --- a/ttcn3-bts-test/Makefile +++ b/ttcn3-bts-test/Makefile @@ -1,3 +1,6 @@ +# XXX: use an older version of fake_trx.py, that predates +# commit 0f4714776a9c9b64c4a7268eb8a346f304835565 (OS#6672). +OSMO_BB_BRANCH=ttcn3-bts-test include ../make/Makefile diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index a25456e..1bb92d8 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -74,7 +74,6 @@ --log-file-level DEBUG \ --log-file-time \ --log-level INFO \ - --sched-rr-prio 30 \ -R $SUB4_PREFIX.$SUBNET.20 \ -r $SUB4_PREFIX.$SUBNET.22 \ --trx TRX1@$SUB4_PREFIX.$SUBNET.20:5700/1 \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I251082474bb29d0169f88b5bd545c97d487c8353 Gerrit-Change-Number: 40041 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in pysim[master]: saip-tool: add commandline option to edit mandatory services list
by laforge 15 Apr '25

15 Apr '25
Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email ) Change subject: saip-tool: add commandline option to edit mandatory services list ...................................................................... Patch Set 4: (1 comment) File contrib/saip-tool.py: https://gerrit.osmocom.org/c/pysim/+/39863/comment/87eb568c_2e1f65db?usp=em… : PS3, Line 106: action > I am sure we can configure a fixed set of available options. […] ``` >>> from pySim.esim import saip >>> [t.name for t in saip.asn1.types['ServicesList'].type.root_members] ['contactless', 'usim', 'isim', 'csim', 'milenage', 'tuak128', 'cave', 'gba-usim', 'gba-isim', 'mbms', 'eap', 'javacard', 'multos', 'multiple-usim', 'multiple-isim', 'multiple-csim', 'tuak256', 'usim-test-algorithm', 'ber-tlv', 'dfLink', 'cat-tp', 'get-identity', 'profile-a-x25519', 'profile-b-p256', 'suciCalculatorApi', 'dns-resolution', 'scp11ac', 'scp11c-authorization-mechanism', 's16mode', 'eaka'] ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 Gerrit-Change-Number: 39863 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Apr 2025 16:33:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ci[master]: obs-mirror-include: update Ubuntu versions
by laforge 15 Apr '25

15 Apr '25
Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40035?usp=email ) Change subject: obs-mirror-include: update Ubuntu versions ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40035?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icb07e53ad5640f985241fbdd3678f1a4191baf0c Gerrit-Change-Number: 40035 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Apr 2025 16:29:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 51
  • 52
  • 53
  • 54
  • 55
  • 56
  • 57
  • ...
  • 119
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.