April 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: OBS: build_binpkg: use signed-by in sources.list

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40036?usp=email ) Change subject: OBS: build_binpkg: use signed-by in sources.list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40036?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I88164d8d106ff2656efbf78e9d3e4031edd9cf45 Gerrit-Change-Number: 40036 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Apr 2025 16:28:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: run: add --bisect argument

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40040?usp=email ) Change subject: testenv: run: add --bisect argument ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I941064c1c704560e0f7351c82e810481cd72b6da Gerrit-Change-Number: 40040 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Apr 2025 16:27:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: refactor run --until-nok code

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40039?usp=email ) Change subject: testenv: refactor run --until-nok code ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a8fc83c6833f0d2a8be9c0d7ddaea0546859988 Gerrit-Change-Number: 40039 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Apr 2025 16:27:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: Support configuring RAC on each hnb conn"

by laforge

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40037?usp=email ) Change subject: Revert "hnbgw: Support configuring RAC on each hnb conn" ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40037?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I077c584219bfa54468bd796a1fc2e85fd60b7a02 Gerrit-Change-Number: 40037 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Apr 2025 16:27:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: Test paging with PAge Area ID IE"

by laforge

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40038?usp=email ) Change subject: Revert "hnbgw: Test paging with PAge Area ID IE" ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40038?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I416d514e739cc0b16832192bfdb746a4ed09336f Gerrit-Change-Number: 40038 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Apr 2025 16:27:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[XS] Change in libosmocore[master]: Abort configure run on big endian hosts

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/40014?usp=email ) Change subject: Abort configure run on big endian hosts ...................................................................... Abort configure run on big endian hosts Change-Id: I9bf16113acbbc1e100fd928446a91b927d3c6cbc --- M configure.ac 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 7863624..c8b2f1e 100644 --- a/configure.ac +++ b/configure.ac @@ -66,6 +66,11 @@ AC_SUBST(LTLDFLAGS_OSMOCORE) AC_SUBST(LTLDFLAGS_OSMOCTRL) +AC_C_BIGENDIAN( + [AC_MSG_ERROR([Unfortunately, big endian hosts are currently not supported anymore due to lack of development resources. Contributions welcome.])], + [], + [AC_MSG_WARN([Byte order could not be determined. Strange.])]) + dnl checks for header files AC_HEADER_STDC AC_CHECK_HEADERS(execinfo.h poll.h sys/select.h sys/socket.h sys/signalfd.h sys/eventfd.h sys/timerfd.h syslog.h ctype.h netinet/tcp.h netinet/in.h) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40014?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9bf16113acbbc1e100fd928446a91b927d3c6cbc Gerrit-Change-Number: 40014 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Huemer <alexander.huemer(a)xx.vu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de>

4 months

1
0
0 0

[S] Change in osmo-ci[master]: OBS: build_binpkg: use signed-by in sources.list

by jolly

Attention is currently required from: osmith. jolly has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40036?usp=email ) Change subject: OBS: build_binpkg: use signed-by in sources.list ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40036?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I88164d8d106ff2656efbf78e9d3e4031edd9cf45 Gerrit-Change-Number: 40036 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Apr 2025 14:01:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: run: add --bisect argument

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40040?usp=email ) Change subject: testenv: run: add --bisect argument ...................................................................... testenv: run: add --bisect argument Add an argument that lets testenv.py exit with != 0 when at least one test has failed, so it can be used with "git bisect". Change-Id: I941064c1c704560e0f7351c82e810481cd72b6da --- M _testenv/testenv/__init__.py M _testenv/testenv/testsuite.py 2 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/40040/1 diff --git a/_testenv/testenv/__init__.py b/_testenv/testenv/__init__.py index 015ef24..07880cc 100644 --- a/_testenv/testenv/__init__.py +++ b/_testenv/testenv/__init__.py @@ -95,7 +95,14 @@ help="use binary packages from this Osmocom OBS project instead (e.g. osmocom:nightly)", ) - group = sub_run.add_argument_group("loop options", "Run the testsuite / a single test multiple times.") + group = sub_run.add_argument_group("exit options", "When and how testenv should exit when done.") + group = group.add_mutually_exclusive_group() + group.add_argument( + "-B", + "--bisect", + action="store_true", + help="exit with != 0 if at least one test failed (use with git bisect)", + ) group.add_argument( "-u", "--until-nok", diff --git a/_testenv/testenv/testsuite.py b/_testenv/testenv/testsuite.py index a6929f0..d7e4b6c 100644 --- a/_testenv/testenv/testsuite.py +++ b/_testenv/testenv/testsuite.py @@ -229,6 +229,9 @@ merge_log_files(cfg) format_log_files(cfg) + if testenv.args.bisect and not check_testsuite_successful(): + raise testenv.NoTraceException("Testsuite failed!") + def get_current_test(): path = os.path.join(testenv.testdir.testdir, "testsuite/.current_test") -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I941064c1c704560e0f7351c82e810481cd72b6da Gerrit-Change-Number: 40040 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: refactor run --until-nok code

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40039?usp=email ) Change subject: testenv: refactor run --until-nok code ...................................................................... testenv: refactor run --until-nok code Refactor the code in preparation for using the code that checks if the testsuite was successful with a new --bisect arg in the next patch. Change-Id: I3a8fc83c6833f0d2a8be9c0d7ddaea0546859988 --- M _testenv/testenv.py M _testenv/testenv/testsuite.py 2 files changed, 22 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/39/40039/1 diff --git a/_testenv/testenv.py b/_testenv/testenv.py index b9de4e8..f852c0c 100755 --- a/_testenv/testenv.py +++ b/_testenv/testenv.py @@ -19,17 +19,14 @@ def loop_continue_cond(loop_count): if loop_count == 0: return True - - if testenv.args.until_nok: - logging.info("Checking testsuite logs for failures and errors") - for match_str in ["failures='0'", "errors='0'"]: - if not testenv.testsuite.check_junit_logs_have(loop_count - 1, match_str): - logging.critical("Stopping the loop") - return False - return True - else: + if not testenv.args.until_nok: return False + if not testenv.testsuite.check_testsuite_successful(loop_count - 1): + logging.critical("Stopping the loop") + return False + return True + def run(): testenv.testenv_cfg.init() diff --git a/_testenv/testenv/testsuite.py b/_testenv/testenv/testsuite.py index 9b28668..a6929f0 100644 --- a/_testenv/testenv/testsuite.py +++ b/_testenv/testenv/testsuite.py @@ -156,13 +156,23 @@ testenv.cmd.run(cmd) -def check_junit_logs_have(loop_count, match_str): - topdir = os.path.join(testenv.testdir.testdir_topdir, f"loop-{loop_count}") +def check_testsuite_successful(loop_count=None): + topdir = testenv.testdir.testdir_topdir + if loop_count is not None: + topdir = os.path.join(topdir, f"loop-{loop_count}") + + ret = True + for path in get_junit_logs(topdir): - cmd = ["grep", "-q", match_str, path] - if testenv.cmd.run(cmd, check=False).returncode: - return False - return True + for match_str in ["failures='0'", "errors='0'"]: + cmd = ["grep", "-q", match_str, path] + if testenv.cmd.run(cmd, check=False).returncode: + ret = False + break + if not ret: + break + + return ret def run(cfg): -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a8fc83c6833f0d2a8be9c0d7ddaea0546859988 Gerrit-Change-Number: 40039 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: Support configuring RAC on each hnb conn"

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40037?usp=email ) Change subject: Revert "hnbgw: Support configuring RAC on each hnb conn" ...................................................................... Revert "hnbgw: Support configuring RAC on each hnb conn" This reverts commit 4e4398aac6d19fe16c40be88290e0da08588fd2d: caused regression in several other tests. Related: OS#6762 Change-Id: I077c584219bfa54468bd796a1fc2e85fd60b7a02 --- M hnbgw/ConnHdlr.ttcn M hnbgw/HNBGW_Tests.ttcn 2 files changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/40037/1 diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 90d264d..efba060 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -227,7 +227,6 @@ type record HnbConfig { LocationAreaIdentification lai, - uint8_t rac, integer sac } @@ -480,7 +479,7 @@ } var template RANAP_PDU ret; if (pars.ps_domain) { - var RANAP_IEs.RAC rac := int2oct(pars.hnb.rac, 1); + var RANAP_IEs.RAC rac := '00'O; ret := ts_RANAP_initialUE_PS(lai, rac, sai, nas, pars.sigc_id, grnc_id); } else { ret := ts_RANAP_initialUE_CS(lai, sai, nas, pars.sigc_id, grnc_id); diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 862bff9..e18cff1 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -501,7 +501,6 @@ mcc_mnc := '00F110'H, lac := 2342 + i }, - rac := 11 + i, sac := 55 }; f_init_hnodeb(testcasename(), i, rua_ops); @@ -677,7 +676,7 @@ hex2oct(g_hnb_cfg[hnb_idx].lai.mcc_mnc), int2bit(1 + cell_id, 28), int2oct(g_hnb_cfg[hnb_idx].lai.lac, 2), - int2oct(g_hnb_cfg[hnb_idx].rac, 1), + int2oct(0, 1), int2oct(g_hnb_cfg[hnb_idx].sac, 2))); T.start; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40037?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I077c584219bfa54468bd796a1fc2e85fd60b7a02 Gerrit-Change-Number: 40037 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025