fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40016?usp=email )
Change subject: sctp_{client,server}: accept arguments in form of a map
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40016?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I07c7365181037ee36c1bce73e91f7bafa7f7f0cf
Gerrit-Change-Number: 40016
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Apr 2025 11:27:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/40022?usp=email )
Change subject: Remove ttcn3 testsuites ported to testenv, part 3
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
> should we maybe have a README. […]
The README already points at how to run them now:
```
Historically this repository had all containers for running the TTCN3
testsuites. We are porting them over to the new testenv configurations
inside `osmo-ttcn3-hacks.git` and removing them afterwards from
`docker-playground.git`. See
[_testenv/README.md](https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/br…
for more information, and [OS#6494](https://osmocom.org/issues/6494)
for reasoning.
```
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40022?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic07793fb7d8889684fd89b00860ebd0b17561a9e
Gerrit-Change-Number: 40022
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 14 Apr 2025 11:14:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/39780?usp=email )
Change subject: ara_m: add command to lock write access to the ARA-M rules.
......................................................................
ara_m: add command to lock write access to the ARA-M rules.
Recent versions of the ARA-M applet from Bertrand Martel can lock
the write access to ARA-M rules. Let's add a command for that and
some documentation.
Related: SYS#7245
Change-Id: I71581a0c9f146f9a0921093d9b53b053b4a8946c
---
M docs/shell.rst
M pySim/ara_m.py
2 files changed, 24 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/docs/shell.rst b/docs/shell.rst
index 564f162..0eb64ba 100644
--- a/docs/shell.rst
+++ b/docs/shell.rst
@@ -1,4 +1,4 @@
-pySim-shell
+pySim-shell
===========
pySim-shell is an interactive command line shell for all kind of interactions with SIM cards,
@@ -1006,6 +1006,24 @@
intended must be manually inserted again using :ref:`aram_store_ref_ar_do`
+aram_lock
+~~~~~~~~~
+This command allows to lock the access to the STORE DATA command. This renders
+all access rules stored within the ARA-M applet effectively read-only. The lock
+can only be removed via a secure channel to the security domain and is therefore
+suitable to prevent unauthorized changes to ARA-M rules.
+
+Removal of the lock:
+::
+
+ pySIM-shell (SCP02[01]:00:MF/ADF.ISD)> install_for_personalization A00000015141434C00
+ pySIM-shell (SCP02[01]:00:MF/ADF.ISD)> apdu --expect-sw 9000 80E2900001A2
+
+NOTE: ARA-M Locking is a proprietary feature that is specific to sysmocom's
+fork of Bertrand Martel's ARA-M implementation. ARA-M Locking is supported in
+newer (2025) applet versions from v0.1.0 onward.
+
+
GlobalPlatform commands
-----------------------
diff --git a/pySim/ara_m.py b/pySim/ara_m.py
index 7a0f93f..e10ae10 100644
--- a/pySim/ara_m.py
+++ b/pySim/ara_m.py
@@ -389,6 +389,11 @@
if res_do:
self._cmd.poutput_json(res_do.to_dict())
+ def do_aram_lock(self, opts):
+ """Lock STORE DATA command to prevent unauthorized changes
+ (Proprietary feature that is specific to sysmocom's fork of Bertrand Martel’s ARA-M implementation.)"""
+ self._cmd.lchan.scc.send_apdu_checksw('80e2900001A1', '9000')
+
# SEAC v1.1 Section 4.1.2.2 + 5.1.2.2
sw_aram = {
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/39780?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I71581a0c9f146f9a0921093d9b53b053b4a8946c
Gerrit-Change-Number: 39780
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40002?usp=email )
Change subject: stp: Fix typo in comment
......................................................................
stp: Fix typo in comment
Change-Id: I9f4a1e5ec0b0d2614b3cec0768e8847fce3e3cdf
---
M stp/STP_Tests_IPA.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
osmith: Looks good to me, approved
diff --git a/stp/STP_Tests_IPA.ttcn b/stp/STP_Tests_IPA.ttcn
index 66e7262..ae7e1da 100644
--- a/stp/STP_Tests_IPA.ttcn
+++ b/stp/STP_Tests_IPA.ttcn
@@ -309,8 +309,8 @@
}
}
- /* All traffic should not still be sent to the same receiver, since
- * OPC+SLS cannot change in IPA ASPs.
+ /* All traffic should still be sent to the same receiver, since
+ * OPC+DPC+SLS cannot change in IPA ASPs.
* However, depending on how the SLS seed tables were allocated, it can
* be that STP was routing through Alternative Route and now that the
* 2nd receiver is up it is now routing to it (Normal Route). Account
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40002?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9f4a1e5ec0b0d2614b3cec0768e8847fce3e3cdf
Gerrit-Change-Number: 40002
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>