Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email )
Change subject: saip-tool: add commandline option to edit mandatory services list
......................................................................
Patch Set 4:
(2 comments)
File contrib/saip-tool.py:
https://gerrit.osmocom.org/c/pysim/+/39863/comment/a7705847_4ac04ce2?usp=em… :
PS3, Line 104: set
> "set" sounds like it is setting (overwriting) the list. […]
Done
https://gerrit.osmocom.org/c/pysim/+/39863/comment/a1a3ba19_6318b1fe?usp=em… :
PS3, Line 106: action
> there is a way (I forgot how exactly, maybet he "choices" argument?) to tell the parser which string […]
I am sure we can configure a fixed set of available options. However, at the moment I have now idea how to pull that information out of the ASN.1 parser. I would have to look that up and read some more documentation about that, unless someone has a good hint.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235
Gerrit-Change-Number: 39863
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Apr 2025 12:41:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40025?usp=email )
Change subject: testenv: clean: fix cleaning git dir
......................................................................
testenv: clean: fix cleaning git dir
Don't try to build a PATH that contains the testsuite dir if running the
"clean" action, because then no testsuite is defined.
Fix for:
$ ./testenv.py clean
[testenv] + ['rm', '-rf', '/home/user/.cache/osmo-ttcn3-testenv/git']
Traceback (most recent call last):
File "/home/user/code/osmo-dev/src/osmo-ttcn3-hacks/./testenv.py", line 137, in <module>
main()
File "/home/user/code/osmo-dev/src/osmo-ttcn3-hacks/./testenv.py", line 133, in main
clean()
File "/home/user/code/osmo-dev/src/osmo-ttcn3-hacks/./testenv.py", line 117, in clean
testenv.cmd.run(["rm", "-rf", path])
File "/home/user/code/osmo-dev/src/osmo-ttcn3-hacks/_testenv/testenv/cmd.py", line 106, in run
env=generate_env(env),
^^^^^^^^^^^^^^^^^
File "/home/user/code/osmo-dev/src/osmo-ttcn3-hacks/_testenv/testenv/cmd.py", line 72, in generate_env
path += f":{os.path.join(testenv.testsuite.ttcn3_hacks_dir, testenv.args.testsuite)}"
^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Namespace' object has no attribute 'testsuite'
Change-Id: I65da89581260fc60b3d8da0a93ee04c0c22c7f2c
---
M _testenv/testenv/cmd.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/_testenv/testenv/cmd.py b/_testenv/testenv/cmd.py
index df57b79..f84769d 100644
--- a/_testenv/testenv/cmd.py
+++ b/_testenv/testenv/cmd.py
@@ -68,7 +68,7 @@
ret = dict(env_extra)
path = os.path.join(testenv.data_dir, "scripts")
path += f":{os.path.join(testenv.data_dir, 'scripts/qemu')}"
- if testenv.testsuite.ttcn3_hacks_dir:
+ if testenv.args.action == "run" and testenv.testsuite.ttcn3_hacks_dir:
path += f":{os.path.join(testenv.testsuite.ttcn3_hacks_dir, testenv.args.testsuite)}"
if usr_dir:
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40025?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I65da89581260fc60b3d8da0a93ee04c0c22c7f2c
Gerrit-Change-Number: 40025
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40019?usp=email )
Change subject: sctp_{client,server}: set sndbuf/recbuf explicitly
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> I'm wondering why we use 64k if the kernel default (at least on my system) would be > 200k. […]
As stated in the commit message, 65536 is what Erlang/OTP is setting by default for the `SNDBUF`. I am fine with using a higher value, I can also implement reading the default from procfs.
Is my understanding correct that there exist no SCTP specific but global defaults in Linux? If so, I could just use `212992`, which is the default for 64-bit Linux as explained in https://unix.stackexchange.com/questions/424380/what-values-may-linux-use-f….
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40019?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I66f4a0f6a2441a3c8a4dbd266da8e44a3860b993
Gerrit-Change-Number: 40019
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Apr 2025 11:43:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>