lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

April 2025

  • 1 participants
  • 1186 discussions
[S] Change in osmo-ttcn3-hacks[master]: msc: add TC_mo_ussd_evil_ms for OS#6756
by fixeria 17 Apr '25

17 Apr '25
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39975?usp=email ) Change subject: msc: add TC_mo_ussd_evil_ms for OS#6756 ...................................................................... msc: add TC_mo_ussd_evil_ms for OS#6756 This is an "evil MS" scenario that crashes current osmo-msc. Change-Id: If1d85a1b4b63b01b4565e53677acfd21e664e799 Related: osmo-msc.git I724f0f0c9ef8611d3c3653e9370361b252127f72 Related: OS#6756 --- M msc/MSC_Tests.ttcn M msc/expected-results.xml 2 files changed, 49 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 527b71a..2f8df4d 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -4393,6 +4393,50 @@ vc_conn.done; } +/* MO (mobile-originated) SS/USSD FACILITY for an unknown transaction, + * and CM SERVICE REQUEST with wrong establishment cause prior to that. + * This is an "evil MS" scenario that can be used to reproduce OS#6756. */ +friend function f_TC_mo_ussd_evil_ms(charstring id, BSC_ConnHdlrPars pars) +runs on BSC_ConnHdlr { + f_init_handler(pars); + + f_ran_register_imsi(g_pars.imsi, g_pars.tmsi); + f_create_gsup_expect(hex2str(g_pars.imsi)); + + /* Perform location update */ + f_perform_lu(); + + /* Send CM Service Request indicating *wrong* reason */ + f_establish_fully(EST_TYPE_MO_CALL); + + /* GSM 04.80 FACILITY message for a non-existing transaction */ + var template (value) PDU_ML3_MS_NW mo_ss_fac := ts_ML3_MO_SS_FACILITY( + tid := 1, /* An arbitrary transaction identifier */ + ti_flag := c_TIF_ORIG, /* Sent from the side that originates the TI */ + facility := f_rnd_octstring(23) /* We don't care about the Facility IE */ + ); + + /* Expected response from the network */ + var template PDU_ML3_NW_MS mt_ss_rel := tr_ML3_MT_SS_RELEASE_COMPLETE( + tid := 1, /* Same as in the FACILITY message */ + ti_flag := c_TIF_REPL, /* Sent to the side that originates the TI */ + facility := omit + ); + + /* Send GSM 04.80 FACILITY for non-existing transaction */ + BSSAP.send(ts_PDU_DTAP_MO(mo_ss_fac)); + + /* Expect GSM 04.80 RELEASE COMPLETE message */ + f_expect_mt_dtap_msg(mt_ss_rel); + f_expect_clear(); +} +testcase TC_mo_ussd_evil_ms() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_mo_ussd_evil_ms), 111); + vc_conn.done; +} + /* Verify multiple concurrent MO SS/USSD transactions * (one subscriber - one transaction) */ @@ -7568,6 +7612,10 @@ execute( TC_proc_ss_paging_fail() ); execute( TC_proc_ss_abort() ); + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + execute( TC_mo_ussd_evil_ms() ); /* XXX: crashes osmo-msc */ + } + execute( TC_multi_lu_and_mo_ussd() ); execute( TC_multi_lu_and_mt_ussd() ); diff --git a/msc/expected-results.xml b/msc/expected-results.xml index 2dc7e97..dacb840 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -94,6 +94,7 @@ <testcase classname='MSC_Tests' name='TC_proc_ss_for_unknown_session' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_proc_ss_paging_fail' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_proc_ss_abort' time='MASKED'/> + <testcase classname='MSC_Tests' name='TC_mo_ussd_evil_ms' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_multi_lu_and_mo_ussd' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_multi_lu_and_mt_ussd' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_cipher_complete_with_invalid_cipher' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If1d85a1b4b63b01b4565e53677acfd21e664e799 Gerrit-Change-Number: 39975 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in docker-playground[master]: fixup: ttcn3-bts-test: use an older version of fake_trx.py
by fixeria 17 Apr '25

17 Apr '25
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/40043?usp=email ) Change subject: fixup: ttcn3-bts-test: use an older version of fake_trx.py ...................................................................... fixup: ttcn3-bts-test: use an older version of fake_trx.py Setting OSMO_BB_BRANCH=ttcn3-bts-test did not achieve the goal, because it was not consumed by the osmocom-bb-host-master's Makefile. Setting it in jenkins.sh does the trick. Change-Id: Ib6857fafd4085aae91eec9c67f08766bdabeb2b7 Fixes: 8540ae7 ("ttcn3-bts-test: use an older version of fake_trx.py") --- M ttcn3-bts-test/Makefile M ttcn3-bts-test/jenkins.sh 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/ttcn3-bts-test/Makefile b/ttcn3-bts-test/Makefile index 2af27a9..26ac873 100644 --- a/ttcn3-bts-test/Makefile +++ b/ttcn3-bts-test/Makefile @@ -1,7 +1,3 @@ -# XXX: use an older version of fake_trx.py, that predates -# commit 0f4714776a9c9b64c4a7268eb8a346f304835565 (OS#6672). -OSMO_BB_BRANCH=ttcn3-bts-test - include ../make/Makefile CFG_SRC_FILES = \ diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 1bb92d8..edb7030 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -2,6 +2,10 @@ TEST_CONFIGS_ALL="generic virtphy oml hopping" TEST_CONFIGS="${TEST_CONFIGS:-"generic oml hopping"}" +# XXX: use an older version of fake_trx.py, that predates +# commit 0f4714776a9c9b64c4a7268eb8a346f304835565 (OS#6672). +export OSMO_BB_BRANCH=ttcn3-bts-test + . ../jenkins-common.sh IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}" # NOTE: there is no osmocom-bb-host-latest, hence always use master! -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib6857fafd4085aae91eec9c67f08766bdabeb2b7 Gerrit-Change-Number: 40043 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
1 0
0 0
[M] Change in ...osmo-s1gw[master]: s1gw_metrics: add histograms for gen_sctp:send/3 delay
by laforge 17 Apr '25

17 Apr '25
Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39666?usp=email ) Change subject: s1gw_metrics: add histograms for gen_sctp:send/3 delay ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7633a6e6182bda3fca4e7562e2b780b2b9f9708f Gerrit-Change-Number: 39666 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Apr 2025 09:31:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: msc: add TC_mo_ussd_evil_ms for OS#6756
by laforge 17 Apr '25

17 Apr '25
Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39975?usp=email ) Change subject: msc: add TC_mo_ussd_evil_ms for OS#6756 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If1d85a1b4b63b01b4565e53677acfd21e664e799 Gerrit-Change-Number: 39975 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Apr 2025 09:30:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in docker-playground[master]: fixup: ttcn3-bts-test: use an older version of fake_trx.py
by osmith 17 Apr '25

17 Apr '25
Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/40043?usp=email ) Change subject: fixup: ttcn3-bts-test: use an older version of fake_trx.py ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib6857fafd4085aae91eec9c67f08766bdabeb2b7 Gerrit-Change-Number: 40043 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Apr 2025 09:17:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in docker-playground[master]: fixup: ttcn3-bts-test: use an older version of fake_trx.py
by fixeria 17 Apr '25

17 Apr '25
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/40043?usp=email ) Change subject: fixup: ttcn3-bts-test: use an older version of fake_trx.py ...................................................................... fixup: ttcn3-bts-test: use an older version of fake_trx.py Setting OSMO_BB_BRANCH=ttcn3-bts-test did not achieve the goal, because it was not consumed by the osmocom-bb-host-master's Makefile. Setting it in jenkins.sh does the trick. Change-Id: Ib6857fafd4085aae91eec9c67f08766bdabeb2b7 Fixes: 8540ae7 ("ttcn3-bts-test: use an older version of fake_trx.py") --- M ttcn3-bts-test/Makefile M ttcn3-bts-test/jenkins.sh 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/43/40043/1 diff --git a/ttcn3-bts-test/Makefile b/ttcn3-bts-test/Makefile index 2af27a9..26ac873 100644 --- a/ttcn3-bts-test/Makefile +++ b/ttcn3-bts-test/Makefile @@ -1,7 +1,3 @@ -# XXX: use an older version of fake_trx.py, that predates -# commit 0f4714776a9c9b64c4a7268eb8a346f304835565 (OS#6672). -OSMO_BB_BRANCH=ttcn3-bts-test - include ../make/Makefile CFG_SRC_FILES = \ diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 1bb92d8..edb7030 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -2,6 +2,10 @@ TEST_CONFIGS_ALL="generic virtphy oml hopping" TEST_CONFIGS="${TEST_CONFIGS:-"generic oml hopping"}" +# XXX: use an older version of fake_trx.py, that predates +# commit 0f4714776a9c9b64c4a7268eb8a346f304835565 (OS#6672). +export OSMO_BB_BRANCH=ttcn3-bts-test + . ../jenkins-common.sh IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}" # NOTE: there is no osmocom-bb-host-latest, hence always use master! -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib6857fafd4085aae91eec9c67f08766bdabeb2b7 Gerrit-Change-Number: 40043 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: msc: add TC_mo_ussd_evil_ms for OS#6756
by osmith 17 Apr '25

17 Apr '25
Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39975?usp=email ) Change subject: msc: add TC_mo_ussd_evil_ms for OS#6756 ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If1d85a1b4b63b01b4565e53677acfd21e664e799 Gerrit-Change-Number: 39975 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Apr 2025 07:41:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in ...osmo-s1gw[master]: s1gw_metrics: add histograms for gen_sctp:send/3 delay
by fixeria 17 Apr '25

17 Apr '25
Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39666?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: s1gw_metrics: add histograms for gen_sctp:send/3 delay ...................................................................... s1gw_metrics: add histograms for gen_sctp:send/3 delay https://www.erlang.org/doc/apps/kernel/gen_sctp.html#send/3 clearly states that gen_sctp:send/3 is blocking, unless non_block_send is set. With the current architecture of the S1GW, gen_sctp:send/3 may block the S1GW-MME link (sctp_client) or the eNB-S1GW link (sctp_server) completely, preventing sending and receiving of other S1AP PDUs. Ideally, we should rework the S1GW to spawn a separate process for each received S1AP PDU, so that blocking gen_sctp:send/3 would at least not block receiving and processing of incoming PDUs. But this would require quite some effort. For now, let's add a histogram reflecting min/max/avg/mean/median delay caused by gen_sctp:send/3, so that we can detect this when the problem starts biting us. Change-Id: I7633a6e6182bda3fca4e7562e2b780b2b9f9708f Related: SYS#7288 --- M config/sys.config M include/s1gw_metrics.hrl M src/s1gw_metrics.erl M src/sctp_common.erl M src/sctp_proxy.erl M src/sctp_server.erl 6 files changed, 54 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/66/39666/5 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7633a6e6182bda3fca4e7562e2b780b2b9f9708f Gerrit-Change-Number: 39666 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: msc: add TC_mo_ussd_evil_ms for OS#6756
by fixeria 17 Apr '25

17 Apr '25
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39975?usp=email ) Change subject: msc: add TC_mo_ussd_evil_ms for OS#6756 ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If1d85a1b4b63b01b4565e53677acfd21e664e799 Gerrit-Change-Number: 39975 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 17 Apr 2025 06:20:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No
1 0
0 0
[S] Change in osmo-msc[master]: gsm0911_rcv_nc_ss(): avoid assertion failure in msc_a_put()
by fixeria 17 Apr '25

17 Apr '25
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/39976?usp=email ) Change subject: gsm0911_rcv_nc_ss(): avoid assertion failure in msc_a_put() ...................................................................... gsm0911_rcv_nc_ss(): avoid assertion failure in msc_a_put() It was reported by a user that osmo-msc hits an assertion failure: Assert failed osmo_use_count_get_put(&msc_a->use_count, "cm_service_ss", -1) == 0 gsm_09_11.c:147 It's yet unclear how can this happen, because the MS/UE shall not be sending SS/USSD messages without a prior CM Service Request. However, I was able to write an "evil MS" testcase that reproduces the problem (see the related patch). This is pretty much a DoS vector, so let's add safety checks preventing this to gsm0911_rcv_nc_ss(). Change-Id: I724f0f0c9ef8611d3c3653e9370361b252127f72 Related: osmo-ttcn3-hacks.git If1d85a1b4b63b01b4565e53677acfd21e664e799 Related: 5fb4a9efcf ("Release BSS connection when SS message is rejected") Related: OS#6756 --- M src/libmsc/gsm_09_11.c 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c index 442995e..f0d31bb 100644 --- a/src/libmsc/gsm_09_11.c +++ b/src/libmsc/gsm_09_11.c @@ -143,8 +143,10 @@ GSM48_PDISC_NC_SS | (tid << 4), GSM0480_MTYPE_RELEASE_COMPLETE); /* Decrement use counter that has been incremented by CM Service Request (SS). - * If there is no other service request, the BSS connection will be released. */ - msc_a_put(msc_a, MSC_A_USE_CM_SERVICE_SS); + * If there is no other service request, the BSS connection will be released. + * Guard against an "evil" MS/UE not sending CM Service Request (see OS#6756). */ + if (osmo_use_count_by(&msc_a->use_count, MSC_A_USE_CM_SERVICE_SS)) + msc_a_put(msc_a, MSC_A_USE_CM_SERVICE_SS); return -EINVAL; } @@ -155,8 +157,10 @@ GSM48_PDISC_NC_SS | (tid << 4), GSM0480_MTYPE_RELEASE_COMPLETE); /* Decrement use counter that has been incremented by CM Service Request (SS). - * If there is no other service request, the BSS connection will be released. */ - msc_a_put(msc_a, MSC_A_USE_CM_SERVICE_SS); + * If there is no other service request, the BSS connection will be released. + * Guard against an "evil" MS/UE not sending CM Service Request (see OS#6756). */ + if (osmo_use_count_by(&msc_a->use_count, MSC_A_USE_CM_SERVICE_SS)) + msc_a_put(msc_a, MSC_A_USE_CM_SERVICE_SS); return -ENOMEM; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39976?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I724f0f0c9ef8611d3c3653e9370361b252127f72 Gerrit-Change-Number: 39976 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 48
  • 49
  • 50
  • 51
  • 52
  • 53
  • 54
  • ...
  • 119
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.