April 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: OBS: fix f-string without any placeholders

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39910?usp=email ) Change subject: OBS: fix f-string without any placeholders ...................................................................... OBS: fix f-string without any placeholders Change-Id: I9b7b11a41930a99819a3569f817a0da5586e30a3 --- M scripts/obs/sync_obs_projects.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/obs/sync_obs_projects.py b/scripts/obs/sync_obs_projects.py index da45306..732fa02 100755 --- a/scripts/obs/sync_obs_projects.py +++ b/scripts/obs/sync_obs_projects.py @@ -92,7 +92,7 @@ ret += "### \n" ret += "### Do not modify manually. See OS#6165.\n" ret += "### \n" - ret += f"### Sync information:\n" + ret += "### Sync information:\n" ret += f"### - source meta: {hashlib.md5(source_meta).hexdigest()}\n" ret += f"### - source prjconf: {hashlib.md5(source_prjconf).hexdigest()}\n" ret += "\n" @@ -188,7 +188,7 @@ url = download.get("url") print(f" changing url to https: {url}") assert url.startswith("http://ftp.de.debian.org/debian"), \ - f"unexpected mirror URL" + "unexpected mirror URL" download.set("url", url.replace("http://ftp.de.debian.org/debian", "https://debian.inf.tu-dresden.de/debian")) for pubkey in download.findall("pubkey"): @@ -229,7 +229,7 @@ # Extend the AlmaLinux prjconf to also set CentOS variables, as some of # our prjconfigs and spec files rely on them if project == "AlmaLinux:8": - print(f" appending CentOS 8 variables") + print(" appending CentOS 8 variables") prjconf += "\n" prjconf += "# CentOS 8 compat added by sync script\n" prjconf += "%define centos_version 800\n" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9b7b11a41930a99819a3569f817a0da5586e30a3 Gerrit-Change-Number: 39910 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: *.py: ignore: E722 Do not use bare `except`

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39909?usp=email ) Change subject: *.py: ignore: E722 Do not use bare `except` ...................................................................... *.py: ignore: E722 Do not use bare `except` Let the ruff linter not complain about the existing cases of "Do not use bare `except`" so we get the linter to pass without changing the existing logic here. With this we don't disable the check globally, so we can consider making stricter excepts in new code. Change-Id: Iaef20d47cd171aab23e516e7f7516caf98264249 --- M scripts/obs/lib/srcpkg.py M scripts/verify_log_statements.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index b5286d8..fc39563 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -57,7 +57,7 @@ print(f"{project}: getting version from debian/changelog") version = lib.debian.get_last_version_from_changelog(project) return f"{version}.{count}-{commit}" - except: + except: # noqa: E722 print(f"{project}: using 0.0.0 as version") return f"0.0.0.{count}-{commit}" diff --git a/scripts/verify_log_statements.py b/scripts/verify_log_statements.py index e0bcce6..a7b27d6 100755 --- a/scripts/verify_log_statements.py +++ b/scripts/verify_log_statements.py @@ -86,7 +86,7 @@ # that are not in quotes, between separate string constants. try: quoted = eval('(' + quoted + '\n)' ) - except: + except: # noqa: E722 # hopefully eval broke because of some '## args' macro def if debug: ignored.append(error_found(f, log.start(), 'Ignoring', log.group(0))) @@ -115,7 +115,7 @@ r.line = line return errors_found - except: + except: # noqa: E722 print("ERROR WHILE PROCESSING %r" % f, file=sys.stderr) raise -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaef20d47cd171aab23e516e7f7516caf98264249 Gerrit-Change-Number: 39909 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: scripts/verify_log_statements: fix undefined name

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39911?usp=email ) Change subject: scripts/verify_log_statements: fix undefined name ...................................................................... scripts/verify_log_statements: fix undefined name Append it to "errors_found" instead of undefined variable "ignored". This makes it work similarly to further above: # Skip 'LOG("bla" fmt )' strings that typically appear as #defines. if fmt_re.match(quoted): if debug: errors_found.append(error_found(f, log.start(), 'Skipping define', log.group(0))) continue Fix the following bug: scripts/verify_log_statements.py:92:11: F821 Undefined name `ignored` | 90 | # hopefully eval broke because of some '## args' macro def 91 | if debug: 92 | ignored.append(error_found(f, log.start(), 'Ignoring', log.group(0))) | ^^^^^^^ F821 93 | continue | Change-Id: I4661d4677a1f0fc8d595985e73e2632b9a83b7d6 --- M scripts/verify_log_statements.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/verify_log_statements.py b/scripts/verify_log_statements.py index a7b27d6..1590799 100755 --- a/scripts/verify_log_statements.py +++ b/scripts/verify_log_statements.py @@ -89,7 +89,7 @@ except: # noqa: E722 # hopefully eval broke because of some '## args' macro def if debug: - ignored.append(error_found(f, log.start(), 'Ignoring', log.group(0))) + errors_found.append(error_found(f, log.start(), 'Ignoring', log.group(0))) continue # check for errors... -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4661d4677a1f0fc8d595985e73e2632b9a83b7d6 Gerrit-Change-Number: 39911 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[S] Change in osmo-ci[master]: lint: run 'ruff' on various repositories

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39912?usp=email ) Change subject: lint: run 'ruff' on various repositories ...................................................................... lint: run 'ruff' on various repositories Lint the python code with "ruff check" and "ruff format" where they are known to pass. Related: https://docs.astral.sh/ruff/ Change-Id: I5c2ede1a7b2a204ca3deb24c55008c7585c289a0 --- M lint/lint_diff.sh 1 file changed, 45 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/lint/lint_diff.sh b/lint/lint_diff.sh index 4b95b9f..408d79f 100755 --- a/lint/lint_diff.sh +++ b/lint/lint_diff.sh @@ -4,12 +4,21 @@ GIT_DIR="$(git rev-parse --show-toplevel 2>/dev/null || true)" SCRIPT_DIR="$(dirname "$(realpath "$0")")" ERROR=0 +PROJECT="${GERRIT_PROJECT}" if [ "$OSMO_LINT" = 0 ]; then echo "Skipping lint_diff.sh (OSMO_LINT=0)" exit 0 fi +get_project() { + if [ -n "$PROJECT" ] || ! [ -e .gitreview ]; then + return + fi + + PROJECT="$(grep project= .gitreview | cut -d = -f2)" +} + check_git_dir() { if [ -z "$GIT_DIR" ]; then echo "ERROR: path is not a git repository: $PWD" @@ -70,6 +79,40 @@ fi } +test_ruff() { + local i + local check_projects=" + osmo-ci + osmo-dev + osmo-ttcn3-hacks + " + local format_projects=" + osmo-ttcn3-hacks + " + + if ! command -v ruff >/dev/null; then + return + fi + + for i in $check_projects; do + if [ "$i" = "$PROJECT" ]; then + echo "Running 'ruff check'..." + echo + ruff check + break + fi + done + + for i in $format_projects; do + if [ "$i" = "$PROJECT" ]; then + echo "Running 'ruff format --diff'..." + echo + ruff format --diff + break + fi + done +} + show_error() { echo echo "Please fix the linting errors above. More information:" @@ -106,8 +149,10 @@ < gerrit_report.json } +get_project check_git_dir set_commit +test_ruff test_docker_run_rm test_checkpatch test_clang_format -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5c2ede1a7b2a204ca3deb24c55008c7585c289a0 Gerrit-Change-Number: 39912 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: *.py: ignore: E722 Do not use bare `except`

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39909?usp=email ) Change subject: *.py: ignore: E722 Do not use bare `except` ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaef20d47cd171aab23e516e7f7516caf98264249 Gerrit-Change-Number: 39909 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 11:34:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: *.py: fix imported but unused

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39907?usp=email ) Change subject: *.py: fix imported but unused ...................................................................... *.py: fix imported but unused Prepare to run "ruff check" on this repository by first fixing what it complains about in this and following patches. Change-Id: I89fa4a50a28f6ceab48cce939ca0c076967d43fd --- M lint/checkpatch/checkpatch_json.py M scripts/obs/lib/osc.py M scripts/obs/lib/srcpkg.py M scripts/obs/sync_obs_projects.py M scripts/osmo-depcheck/buildstack.py 5 files changed, 0 insertions(+), 7 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/lint/checkpatch/checkpatch_json.py b/lint/checkpatch/checkpatch_json.py index 81946ca..bf7f0af 100755 --- a/lint/checkpatch/checkpatch_json.py +++ b/lint/checkpatch/checkpatch_json.py @@ -7,7 +7,6 @@ INPUT: output of checkpatch.pl. OUTPUT: json format output that can be used to post comment in gerrit """ -import os import sys import json diff --git a/scripts/obs/lib/osc.py b/scripts/obs/lib/osc.py index 57be783..8838b1a 100644 --- a/scripts/obs/lib/osc.py +++ b/scripts/obs/lib/osc.py @@ -5,7 +5,6 @@ import glob import os import shlex -import shutil import sys import lib import lib.config diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index 9dcb33f..b5286d8 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -4,7 +4,6 @@ import glob import os import pathlib -import sys import lib.config import lib.debian import lib.rpm_spec diff --git a/scripts/obs/sync_obs_projects.py b/scripts/obs/sync_obs_projects.py index beb3e09..da45306 100755 --- a/scripts/obs/sync_obs_projects.py +++ b/scripts/obs/sync_obs_projects.py @@ -2,7 +2,6 @@ # SPDX-License-Identifier: GPL-2.0-or-later # Copyright 2023 sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> import argparse -import glob import hashlib import html import os diff --git a/scripts/osmo-depcheck/buildstack.py b/scripts/osmo-depcheck/buildstack.py index 0a9a011..440b4f9 100644 --- a/scripts/osmo-depcheck/buildstack.py +++ b/scripts/osmo-depcheck/buildstack.py @@ -1,13 +1,10 @@ # SPDX-License-Identifier: GPL-2.0-or-later # Copyright 2018 sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> -import atexit import collections import sys import os -import shutil import subprocess -import tempfile def next_buildable(depends, done): -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39907?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I89fa4a50a28f6ceab48cce939ca0c076967d43fd Gerrit-Change-Number: 39907 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: *.py: fix variable assigned to but never used

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39908?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: *.py: fix variable assigned to but never used ...................................................................... *.py: fix variable assigned to but never used Change-Id: I6aca8f9aab10e7ee395980b53316a720ab2e2469 --- M scripts/obs/lib/debian.py M scripts/obs/lib/metapkg.py M scripts/verify_log_statements.py 3 files changed, 0 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/scripts/obs/lib/debian.py b/scripts/obs/lib/debian.py index 85fcc5f..8e0fd5e 100644 --- a/scripts/obs/lib/debian.py +++ b/scripts/obs/lib/debian.py @@ -141,7 +141,6 @@ print(f"{project}: adding configure parameters: {parameters}") rules = f"{lib.git.get_repo_path(project)}/debian/rules" override_found = False - replaced = False with open(rules, "r") as f: lines = f.readlines() for i in range(len(lines)): @@ -157,7 +156,6 @@ else: lines[i] = line.replace("dh_auto_configure", f"dh_auto_configure -- {parameters}", 1) - replaced = True break if not override_found: lines += ["\n", diff --git a/scripts/obs/lib/metapkg.py b/scripts/obs/lib/metapkg.py index 8a9922d..1b78777 100644 --- a/scripts/obs/lib/metapkg.py +++ b/scripts/obs/lib/metapkg.py @@ -27,7 +27,6 @@ def generate_debian_pkg(pkgname, version): - feed = lib.args.feed path = f"{lib.config.path_cache}/{pkgname}" conflicts = get_conflicts(pkgname) @@ -65,7 +64,6 @@ def generate_rpm_spec(pkgname, version): - feed = lib.args.feed print(f"{pkgname}: generating rpm spec file") path = f"{lib.config.path_cache}/{pkgname}/contrib/{pkgname}.spec.in" conflicts = get_conflicts(pkgname) diff --git a/scripts/verify_log_statements.py b/scripts/verify_log_statements.py index 064df73..e0bcce6 100755 --- a/scripts/verify_log_statements.py +++ b/scripts/verify_log_statements.py @@ -52,7 +52,6 @@ def char_pos_2_line(line_idx, sorted_char_positions): r = [] line_i = 0 - next_line_i = 1 for char_pos in sorted_char_positions: while (line_i+1) < len(line_idx) and char_pos > line_idx[line_i+1][0]: line_i += 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39908?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6aca8f9aab10e7ee395980b53316a720ab2e2469 Gerrit-Change-Number: 39908 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-remsim[master]: src/rspro_client_fsm: fix osmo_stream_cli_destroy

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email ) Change subject: src/rspro_client_fsm: fix osmo_stream_cli_destroy ...................................................................... src/rspro_client_fsm: fix osmo_stream_cli_destroy Fix for: Assert failed stream_cli_close(cli) == false ../../src_copy/libosmo-netif/src/stream_cli.c:1023 Reproducer in osmo-ttcn3-hacks: ./testenv.py run remsim -c client -t RemsimClient_Tests.TC_bank_disconnect Suggested-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f --- M src/rspro_client_fsm.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index d847f3b..63bd534 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -534,8 +534,9 @@ case SRVC_E_DISCONNECT: if (srvc->conn) { LOGPFSML(fi, LOGL_INFO, "Destroying existing connection to server\n"); - osmo_stream_cli_destroy(srvc->conn); + struct osmo_stream_cli *conn = srvc->conn; srvc->conn = NULL; + osmo_stream_cli_destroy(conn); } osmo_fsm_inst_state_chg(fi, SRVC_ST_INIT, 0, 0); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f Gerrit-Change-Number: 39920 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[S] Change in libosmo-sigtran[master]: vty: Introduce AS node cmd 'binding-table reset'

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39917?usp=email ) Change subject: vty: Introduce AS node cmd 'binding-table reset' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I56c34072a9ded42c13dbfc105a0ab3353ca353ec Gerrit-Change-Number: 39917 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 11:31:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-remsim[master]: src/rspro_client_fsm: fix osmo_stream_cli_destroy

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email ) Change subject: src/rspro_client_fsm: fix osmo_stream_cli_destroy ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f Gerrit-Change-Number: 39920 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 11:30:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025