pespin has submitted this change. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39900?usp=email )
Change subject: testsuites: tunend: upf: Fix wrong format of some ip neigh commands
......................................................................
testsuites: tunend: upf: Fix wrong format of some ip neigh commands
The ip-neigh+printf commands were taken from an older gtplab-sysmo2017
which was printing stuff as ".1%02u", but in the gtplab-sysmo2025
testsuite where they were put they were used to print ".%02u".
As a result, the following IP addresses where printed:
172.16.32.01
..
172.16.32.07
172.16.32.08
172.16.32.09
172.16.32.10
It turns out that commands such as ip neigh actually read integers
between dots as octal if they start with a leading 0.
As a result, addresses .01-.07 were working fine, since those octal
values match the decimal ones. However, .08 and .08 failed to be set due
to not being octal numbers.
As a result, when running eupf tunend ul+dl tests, DL traffic
encapsulated back aimed at RAN iface was, for some unknown reason, sent
over CN iface instead because it couldn't find an ARP resolution for it,
creating misbehaviors when running that testcase.
Change-Id: I1cdc9559aa8243c062d022f97a20ad8f8d3ad55b
---
M testsuites/gtplab-sysmo2025/tunend/upf/eupf/configure.sh
M testsuites/gtplab-sysmo2025/tunend/upf/osmo-upf/configure.sh
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/testsuites/gtplab-sysmo2025/tunend/upf/eupf/configure.sh b/testsuites/gtplab-sysmo2025/tunend/upf/eupf/configure.sh
index eede062..a949e2d 100755
--- a/testsuites/gtplab-sysmo2025/tunend/upf/eupf/configure.sh
+++ b/testsuites/gtplab-sysmo2025/tunend/upf/eupf/configure.sh
@@ -66,8 +66,8 @@
# TRex doesn't answer ARPs, so we need to set up the peers:
for i in $(seq "2" "$((NUM_ENB + 1))"); do
# Delete needed to potentially drop incomplet entries created when trying to Tx traffic:
- sudo ip neigh del "$(printf "172.16.32.%02u" "$i")" lladdr $MAC_RAN_PEER nud permanent dev $IFACE_RAN || true
- sudo ip neigh add "$(printf "172.16.32.%02u" "$i")" lladdr $MAC_RAN_PEER nud permanent dev $IFACE_RAN || true
+ sudo ip neigh del "$(printf "172.16.32.%u" "$i")" lladdr $MAC_RAN_PEER nud permanent dev $IFACE_RAN || true
+ sudo ip neigh add "$(printf "172.16.32.%u" "$i")" lladdr $MAC_RAN_PEER nud permanent dev $IFACE_RAN || true
done
sudo ip neigh del 172.16.31.200 lladdr $MAC_CN_PEER nud permanent dev $IFACE_CN || true
sudo ip neigh add 172.16.31.200 lladdr $MAC_CN_PEER nud permanent dev $IFACE_CN || true
diff --git a/testsuites/gtplab-sysmo2025/tunend/upf/osmo-upf/configure.sh b/testsuites/gtplab-sysmo2025/tunend/upf/osmo-upf/configure.sh
index b574738..f41e98a 100755
--- a/testsuites/gtplab-sysmo2025/tunend/upf/osmo-upf/configure.sh
+++ b/testsuites/gtplab-sysmo2025/tunend/upf/osmo-upf/configure.sh
@@ -67,8 +67,8 @@
# TRex doesn't answer ARPs, so we need to set up the peers:
for i in $(seq "2" "$((NUM_ENB + 1))"); do
# Delete needed to potentially drop incomplet entries created when trying to Tx traffic:
- sudo ip neigh del "$(printf "172.16.32.%02u" "$i")" lladdr $MAC_RAN_PEER nud permanent dev $IFACE_RAN || true
- sudo ip neigh add "$(printf "172.16.32.%02u" "$i")" lladdr $MAC_RAN_PEER nud permanent dev $IFACE_RAN || true
+ sudo ip neigh del "$(printf "172.16.32.%u" "$i")" lladdr $MAC_RAN_PEER nud permanent dev $IFACE_RAN || true
+ sudo ip neigh add "$(printf "172.16.32.%u" "$i")" lladdr $MAC_RAN_PEER nud permanent dev $IFACE_RAN || true
done
sudo ip neigh del 172.16.31.200 lladdr $MAC_CN_PEER nud permanent dev $IFACE_CN || true
sudo ip neigh add 172.16.31.200 lladdr $MAC_CN_PEER nud permanent dev $IFACE_CN || true
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39900?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: I1cdc9559aa8243c062d022f97a20ad8f8d3ad55b
Gerrit-Change-Number: 39900
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39905?usp=email )
Change subject: tunend: trex: Support differnet amount of pkt per UL/DL dir
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39905?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: Id273fabc9cd09df352a12b6d8f3ba60b6a9ce39f
Gerrit-Change-Number: 39905
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Apr 2025 09:21:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes