April 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: testenv: fix building osmo-remsim with osmo-dev

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39919?usp=email ) Change subject: testenv: fix building osmo-remsim with osmo-dev ...................................................................... testenv: fix building osmo-remsim with osmo-dev Use --disable-remsim-client-ifdhandler as configure argument for osmo-remsim. We don't need this for running tests and this prevents the buildsystem from trying to write to /usr/lib/pcsc/drivers/ which fails the build. Change-Id: I3b00e5301433476bd19de3814943878f918c1fa0 --- D _testenv/data/osmo-dev/osmo-bts-trx.opts A _testenv/data/osmo-dev/testenv.opts M _testenv/testenv/osmo_dev.py 3 files changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/_testenv/data/osmo-dev/osmo-bts-trx.opts b/_testenv/data/osmo-dev/osmo-bts-trx.opts deleted file mode 100644 index 8acec2d..0000000 --- a/_testenv/data/osmo-dev/osmo-bts-trx.opts +++ /dev/null @@ -1 +0,0 @@ -osmo-bts --enable-trx diff --git a/_testenv/data/osmo-dev/testenv.opts b/_testenv/data/osmo-dev/testenv.opts new file mode 100644 index 0000000..15ab331 --- /dev/null +++ b/_testenv/data/osmo-dev/testenv.opts @@ -0,0 +1,2 @@ +osmo-bts --enable-trx +osmo-remsim --disable-remsim-client-ifdhandler diff --git a/_testenv/testenv/osmo_dev.py b/_testenv/testenv/osmo_dev.py index 695ca0d..1e94cf1 100644 --- a/_testenv/testenv/osmo_dev.py +++ b/_testenv/testenv/osmo_dev.py @@ -98,7 +98,7 @@ "no_man_pages.opts", "no_systemd.opts", "werror.opts", - os.path.join(testenv.data_dir, "osmo-dev/osmo-bts-trx.opts"), + os.path.join(testenv.data_dir, "osmo-dev/testenv.opts"), "--autoreconf-in-src-copy", ] + extra_opts -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39919?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3b00e5301433476bd19de3814943878f918c1fa0 Gerrit-Change-Number: 39919 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-remsim[master]: src/rspro_client_fsm: fix osmo_stream_cli_destroy

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email ) Change subject: src/rspro_client_fsm: fix osmo_stream_cli_destroy ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f Gerrit-Change-Number: 39920 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 11:29:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-remsim[master]: src/rspro_client_fsm: fix osmo_stream_cli_destroy

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email ) Change subject: src/rspro_client_fsm: fix osmo_stream_cli_destroy ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > @pespin@sysmocom.de: is this the proper way to fix this? for reference, the trace: […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f Gerrit-Change-Number: 39920 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 11:29:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-remsim[master]: src/rspro_client_fsm: fix osmo_stream_cli_destroy

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email ) Change subject: src/rspro_client_fsm: fix osmo_stream_cli_destroy ...................................................................... Patch Set 2: (1 comment) File src/rspro_client_fsm.c: https://gerrit.osmocom.org/c/osmo-remsim/+/39920/comment/33457c74_568206e6?… : PS1, Line 538: osmo_stream_cli_destroy(srvc->conn); > Can you actually try the following? […] that fixes it too, thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f Gerrit-Change-Number: 39920 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 11:28:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-remsim[master]: src/rspro_client_fsm: fix osmo_stream_cli_destroy

by osmith

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: src/rspro_client_fsm: fix osmo_stream_cli_destroy ...................................................................... src/rspro_client_fsm: fix osmo_stream_cli_destroy Fix for: Assert failed stream_cli_close(cli) == false ../../src_copy/libosmo-netif/src/stream_cli.c:1023 Reproducer in osmo-ttcn3-hacks: ./testenv.py run remsim -c client -t RemsimClient_Tests.TC_bank_disconnect Suggested-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f --- M src/rspro_client_fsm.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/20/39920/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f Gerrit-Change-Number: 39920 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-remsim[master]: src/client/user_shell: add missing \n

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39921?usp=email ) Change subject: src/client/user_shell: add missing \n ...................................................................... src/client/user_shell: add missing \n Change-Id: Id9590a03885e47245d8fb28e4f0277a23a223da5 --- M src/client/user_shell.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/client/user_shell.c b/src/client/user_shell.c index f0dcd55..6a80553 100644 --- a/src/client/user_shell.c +++ b/src/client/user_shell.c @@ -145,7 +145,7 @@ if (rc < 0) return rc; if (rc == 0) { - fprintf(stderr, "STDIN was closed, terminating"); + fprintf(stderr, "STDIN was closed, terminating\n"); exit(0); } msgb_put(ss->rx_msg, rc); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id9590a03885e47245d8fb28e4f0277a23a223da5 Gerrit-Change-Number: 39921 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: fix building osmo-remsim with osmo-dev

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39919?usp=email ) Change subject: testenv: fix building osmo-remsim with osmo-dev ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39919?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3b00e5301433476bd19de3814943878f918c1fa0 Gerrit-Change-Number: 39919 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 11:23:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-remsim[master]: src/rspro_client_fsm: fix osmo_stream_cli_destroy

by pespin

Attention is currently required from: osmith, pespin. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email ) Change subject: src/rspro_client_fsm: fix osmo_stream_cli_destroy ...................................................................... Patch Set 1: Code-Review-1 Copied votes on follow-up patch sets have been updated: * Code-Review-1 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN"). (1 comment) File src/rspro_client_fsm.c: https://gerrit.osmocom.org/c/osmo-remsim/+/39920/comment/cffe36ad_cf3fae09?… : PS1, Line 538: osmo_stream_cli_destroy(srvc->conn); Can you actually try the following? if (srvc->conn) { struct ... conn = srvc->conn; srvc->conn = NULL; osmo_stream_cli_destroy(conn); } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f Gerrit-Change-Number: 39920 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 11:23:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-remsim[master]: src/rspro_client_fsm: fix osmo_stream_cli_destroy

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email ) Change subject: src/rspro_client_fsm: fix osmo_stream_cli_destroy ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f Gerrit-Change-Number: 39920 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 11:23:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-remsim[master]: src/client/user_shell: add missing \n

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39921?usp=email ) Change subject: src/client/user_shell: add missing \n ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id9590a03885e47245d8fb28e4f0277a23a223da5 Gerrit-Change-Number: 39921 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 11:22:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025