April 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-remsim[master]: src/client/user_shell: add missing \n

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39921?usp=email ) Change subject: src/client/user_shell: add missing \n ...................................................................... src/client/user_shell: add missing \n Change-Id: Id9590a03885e47245d8fb28e4f0277a23a223da5 --- M src/client/user_shell.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/21/39921/1 diff --git a/src/client/user_shell.c b/src/client/user_shell.c index f0dcd55..6a80553 100644 --- a/src/client/user_shell.c +++ b/src/client/user_shell.c @@ -145,7 +145,7 @@ if (rc < 0) return rc; if (rc == 0) { - fprintf(stderr, "STDIN was closed, terminating"); + fprintf(stderr, "STDIN was closed, terminating\n"); exit(0); } msgb_put(ss->rx_msg, rc); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id9590a03885e47245d8fb28e4f0277a23a223da5 Gerrit-Change-Number: 39921 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: fix building osmo-remsim with osmo-dev

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39919?usp=email ) Change subject: testenv: fix building osmo-remsim with osmo-dev ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39919?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3b00e5301433476bd19de3814943878f918c1fa0 Gerrit-Change-Number: 39919 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 11:21:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-remsim[master]: src/rspro_client_fsm: fix osmo_stream_cli_destroy

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email ) Change subject: src/rspro_client_fsm: fix osmo_stream_cli_destroy ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @pespin@sysmocom.de: is this the proper way to fix this? for reference, the trace: ``` Program terminated with signal SIGABRT, Aborted. #0 __pthread_kill_implementation (no_tid=0, signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:44 #0 __pthread_kill_implementation (no_tid=0, signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:44 #1 __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78 #2 __GI___pthread_kill (threadid=<optimized out>, signo=signo@entry=6) at ./nptl/pthread_kill.c:89 #3 0x00007ccc71e4527e in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26 #4 0x00007ccc71e288ff in __GI_abort () at ./stdlib/abort.c:79 #5 0x00007ccc72227be2 in osmo_panic_default (fmt=0x7ccc7233e60c "Assert failed %s %s:%d\n", args=0x7ffd6c845160) at ../../../src_copy/libosmocore/src/core/panic.c:45 #6 0x00007ccc72227cc2 in osmo_panic (fmt=0x7ccc7233e60c "Assert failed %s %s:%d\n") at ../../../src_copy/libosmocore/src/core/panic.c:80 #7 0x00007ccc72334ea2 in osmo_stream_cli_destroy (cli=0x5fed47a41ca0) at ../../src_copy/libosmo-netif/src/stream_cli.c:1023 #8 0x00005fed1ca12b56 in srvc_allstate_action (fi=0x5fed47a3dc80, event=1, data=0x0) at ../../../src_copy/osmo-remsim/src/client/../rspro_client_fsm.c:537 #9 0x00007ccc722143e3 in _osmo_fsm_inst_dispatch (fi=0x5fed47a3dc80, event=1, data=0x0, file=0x5fed1ca13bf8 "../../../src_copy/osmo-remsim/src/client/main_fsm.c", line=154) at ../../../src_copy/libosmocore/src/core/fsm.c:863 #10 0x00005fed1ca0e366 in main_st_unconfigured_onenter (fi=0x5fed47a3d720, prev_state=3) at ../../../src_copy/osmo-remsim/src/client/main_fsm.c:154 #11 0x00007ccc72213a1f in state_chg (fi=0x5fed47a3d720, new_state=1, keep_timer=false, timeout_ms=0, T=0, file=0x5fed1ca13bf8 "../../../src_copy/osmo-remsim/src/client/main_fsm.c", line=253) at ../../../src_copy/libosmocore/src/core/fsm.c:697 #12 0x00007ccc72213a9a in _osmo_fsm_inst_state_chg (fi=0x5fed47a3d720, new_state=1, timeout_secs=0, T=0, file=0x5fed1ca13bf8 "../../../src_copy/osmo-remsim/src/client/main_fsm.c", line=253) at ../../../src_copy/libosmocore/src/core/fsm.c:746 #13 0x00005fed1ca0eae0 in main_st_operational (fi=0x5fed47a3d720, event=2, data=0x5fed47a40a80) at ../../../src_copy/osmo-remsim/src/client/main_fsm.c:253 #14 0x00007ccc722146de in _osmo_fsm_inst_dispatch (fi=0x5fed47a3d720, event=2, data=0x5fed47a40a80, file=0x5fed1ca13720 "../../../src_copy/osmo-remsim/src/client/remsim_client.c", line=129) at ../../../src_copy/libosmocore/src/core/fsm.c:875 #15 0x00005fed1ca0d5b9 in srvc_handle_rx (srvc=0x5fed47a3d020, pdu=0x5fed47a40a80) at ../../../src_copy/osmo-remsim/src/client/remsim_client.c:129 #16 0x00005fed1ca11426 in srvc_read_cb (cli=0x5fed47a3ff80, res=35, msg=0x5fed47a42830) at ../../../src_copy/osmo-remsim/src/client/../rspro_client_fsm.c:261 #17 0x00007ccc72333e69 in stream_cli_iofd_read_cb (iofd=0x5fed47a40e60, res=35, msg=0x5fed47a42830) at ../../src_copy/libosmo-netif/src/stream_cli.c:569 #18 0x00007ccc7222591e in iofd_handle_segmented_read (iofd=0x5fed47a40e60, msg=0x5fed47a42830, rc=35) at ../../../src_copy/libosmocore/src/core/osmo_io.c:350 #19 0x00007ccc72225a25 in iofd_handle_recv (iofd=0x5fed47a40e60, msg=0x5fed47a42830, rc=35, hdr=0x0) at ../../../src_copy/libosmocore/src/core/osmo_io.c:377 #20 0x00007ccc72227561 in iofd_poll_ofd_cb_recvmsg_sendmsg (ofd=0x5fed47a40f10, what=1) at ../../../src_copy/libosmocore/src/core/osmo_io_poll.c:64 #21 0x00007ccc722279bb in iofd_poll_ofd_cb_dispatch (ofd=0x5fed47a40f10, what=1) at ../../../src_copy/libosmocore/src/core/osmo_io_poll.c:136 #22 0x00007ccc7222b040 in poll_disp_fds (n_fd=3) at ../../../src_copy/libosmocore/src/core/select.c:419 #23 0x00007ccc7222b15a in _osmo_select_main (polling=0) at ../../../src_copy/libosmocore/src/core/select.c:457 #24 0x00007ccc7222b179 in osmo_select_main (polling=0) at ../../../src_copy/libosmocore/src/core/select.c:496 #25 0x00005fed1ca0c647 in client_user_main (bc=0x5fed47a3d020) at ../../../src_copy/osmo-remsim/src/client/user_shell.c:185 #26 0x00005fed1ca0cc47 in main (argc=1, argv=0x7ffd6c845c48) at ../../../src_copy/osmo-remsim/src/client/remsim_client_main.c:221 ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f Gerrit-Change-Number: 39920 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 04 Apr 2025 11:14:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 1 week

1
0
0 0

[XS] Change in osmo-remsim[master]: src/rspro_client_fsm: fix osmo_stream_cli_destroy

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email ) Change subject: src/rspro_client_fsm: fix osmo_stream_cli_destroy ...................................................................... src/rspro_client_fsm: fix osmo_stream_cli_destroy Run osmo_stream_cli_close() before osmo_stream_cli_destroy(), as otherwise _destroy() fails with: Assert failed stream_cli_close(cli) == false ../../src_copy/libosmo-netif/src/stream_cli.c:1023 Reproducer in osmo-ttcn3-hacks: ./testenv.py run remsim -c client -t RemsimClient_Tests.TC_bank_disconnect Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f --- M src/rspro_client_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/20/39920/1 diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index d847f3b..01cf3fe 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -534,6 +534,7 @@ case SRVC_E_DISCONNECT: if (srvc->conn) { LOGPFSML(fi, LOGL_INFO, "Destroying existing connection to server\n"); + osmo_stream_cli_close(srvc->conn); osmo_stream_cli_destroy(srvc->conn); srvc->conn = NULL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f Gerrit-Change-Number: 39920 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: fix building osmo-remsim with osmo-dev

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39919?usp=email ) Change subject: testenv: fix building osmo-remsim with osmo-dev ...................................................................... testenv: fix building osmo-remsim with osmo-dev Use --disable-remsim-client-ifdhandler as configure argument for osmo-remsim. We don't need this for running tests and this prevents the buildsystem from trying to write to /usr/lib/pcsc/drivers/ which fails the build. Change-Id: I3b00e5301433476bd19de3814943878f918c1fa0 --- D _testenv/data/osmo-dev/osmo-bts-trx.opts A _testenv/data/osmo-dev/testenv.opts M _testenv/testenv/osmo_dev.py 3 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/39919/1 diff --git a/_testenv/data/osmo-dev/osmo-bts-trx.opts b/_testenv/data/osmo-dev/osmo-bts-trx.opts deleted file mode 100644 index 8acec2d..0000000 --- a/_testenv/data/osmo-dev/osmo-bts-trx.opts +++ /dev/null @@ -1 +0,0 @@ -osmo-bts --enable-trx diff --git a/_testenv/data/osmo-dev/testenv.opts b/_testenv/data/osmo-dev/testenv.opts new file mode 100644 index 0000000..15ab331 --- /dev/null +++ b/_testenv/data/osmo-dev/testenv.opts @@ -0,0 +1,2 @@ +osmo-bts --enable-trx +osmo-remsim --disable-remsim-client-ifdhandler diff --git a/_testenv/testenv/osmo_dev.py b/_testenv/testenv/osmo_dev.py index 695ca0d..1e94cf1 100644 --- a/_testenv/testenv/osmo_dev.py +++ b/_testenv/testenv/osmo_dev.py @@ -98,7 +98,7 @@ "no_man_pages.opts", "no_systemd.opts", "werror.opts", - os.path.join(testenv.data_dir, "osmo-dev/osmo-bts-trx.opts"), + os.path.join(testenv.data_dir, "osmo-dev/testenv.opts"), "--autoreconf-in-src-copy", ] + extra_opts -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39919?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3b00e5301433476bd19de3814943878f918c1fa0 Gerrit-Change-Number: 39919 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[S] Change in osmo-ci[master]: lint: run 'ruff' on various repositories

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39912?usp=email ) Change subject: lint: run 'ruff' on various repositories ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5c2ede1a7b2a204ca3deb24c55008c7585c289a0 Gerrit-Change-Number: 39912 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 10:26:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: scripts/verify_log_statements: fix undefined name

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39911?usp=email ) Change subject: scripts/verify_log_statements: fix undefined name ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4661d4677a1f0fc8d595985e73e2632b9a83b7d6 Gerrit-Change-Number: 39911 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 10:26:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: OBS: fix f-string without any placeholders

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39910?usp=email ) Change subject: OBS: fix f-string without any placeholders ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9b7b11a41930a99819a3569f817a0da5586e30a3 Gerrit-Change-Number: 39910 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 10:25:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: *.py: ignore: E722 Do not use bare `except`

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39909?usp=email ) Change subject: *.py: ignore: E722 Do not use bare `except` ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS1: > I would rather not change the existing logic in this patch. I am wondering if `except Exception:` would do the trick? Not critical. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaef20d47cd171aab23e516e7f7516caf98264249 Gerrit-Change-Number: 39909 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 10:25:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: *.py: fix variable assigned to but never used

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39908?usp=email ) Change subject: *.py: fix variable assigned to but never used ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39908?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6aca8f9aab10e7ee395980b53316a720ab2e2469 Gerrit-Change-Number: 39908 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Apr 2025 10:23:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025