April 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: stp: TC_tmt_loadshare*: Use new vty command 'binding-table reset'

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39918?usp=email ) Change subject: stp: TC_tmt_loadshare*: Use new vty command 'binding-table reset' ...................................................................... stp: TC_tmt_loadshare*: Use new vty command 'binding-table reset' Reset the eSLS binding table state before starting the test, to run it with a clean state. This test also fixes TC_unknown_client_dynamic_tmt_loadshare since it now resets the table after connecting the 2nd dynamic ASP, which allows re-distributing all seeds in the table into the new available set of ASPs. Depends: libosmo-sigtran.git Change-Id I56c34072a9ded42c13dbfc105a0ab3353ca353ec Change-Id: I40b7724edcc06a3df641e316be4770d0e56bb72d --- M stp/STP_Tests_IPA.ttcn M stp/STP_Tests_M3UA.ttcn 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/18/39918/1 diff --git a/stp/STP_Tests_IPA.ttcn b/stp/STP_Tests_IPA.ttcn index 88c9312..66e7262 100644 --- a/stp/STP_Tests_IPA.ttcn +++ b/stp/STP_Tests_IPA.ttcn @@ -269,7 +269,8 @@ f_init_ipa(); - f_vty_config2(VTY, {"cs7 instance 0", "as " & mp_ipa_as_names[2] & " ipa"}, "traffic-mode loadshare"); + f_vty_config3(VTY, {"cs7 instance 0", "as " & mp_ipa_as_names[2] & " ipa"}, + { "traffic-mode loadshare", "binding-table reset" }); /* bring up the 'sender' side (single ASP in AS) */ f_connect_ipa(0, unknwon_dynamic_asp); @@ -284,6 +285,10 @@ /* activate the second 'receiver' side ASP */ f_connect_ipa(3, unknwon_dynamic_asp); + /* Since we are using dynamic ASPs, they were unknown by STP until they got connected. + * Hence, reset the binding-table so that load is now properly spread among them: */ + f_vty_config2(VTY, {"cs7 instance 0", "as " & mp_ipa_as_names[2] & " ipa"}, "binding-table reset" ); + /* verify traffic is routed from sender to new receiver */ const integer iter_per_asp := 20; const integer NUM_SLS := 16; /* SLS in ITU is 4 bits. */ diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index ba44b3f..89be9e0 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -663,7 +663,8 @@ f_init_m3ua(); - f_vty_config2(VTY, {"cs7 instance 0", "as as-receiver m3ua"}, "traffic-mode loadshare"); + f_vty_config3(VTY, {"cs7 instance 0", "as as-receiver m3ua"}, + { "traffic-mode loadshare", "binding-table reset" }); var OCT4 rctx_sender := int2oct(f_m3ua_cli_config(0).routing_ctx, 4); var OCT4 pc_sender := int2oct(f_m3ua_cli_config(0).point_code, 4); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I40b7724edcc06a3df641e316be4770d0e56bb72d Gerrit-Change-Number: 39918 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[S] Change in libosmo-sigtran[master]: vty: Introduce AS node cmd 'binding-table reset'

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39917?usp=email ) Change subject: vty: Introduce AS node cmd 'binding-table reset' ...................................................................... vty: Introduce AS node cmd 'binding-table reset' This is useful when reconfiguring a deployed osmo-stp where new ASPs are added/removed to the config, or when changing the binding seed calculation to improve distribution based on current traffic. This will also be used by tests validating loadshare feature, to start with a clean state every time. Change-Id: I56c34072a9ded42c13dbfc105a0ab3353ca353ec --- M src/osmo_ss7_as.c M src/osmo_ss7_vty.c M src/ss7_as.h 3 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/17/39917/1 diff --git a/src/osmo_ss7_as.c b/src/osmo_ss7_as.c index 525f394..e84a36d 100644 --- a/src/osmo_ss7_as.c +++ b/src/osmo_ss7_as.c @@ -350,6 +350,15 @@ return asp; } +/* Reset loadshare bindings table. It will be filled in as needed. + * This is useful for instance when user changes the ASP set inside an AS, or + * changes the way the binding seed (eSLS) is calculated. */ +void ss7_as_loadshare_binding_table_reset(struct osmo_ss7_as *as) +{ + memset(&as->aesls_table[0], 0, sizeof(as->aesls_table)); + as->cfg.last_asp_idx_assigned = 0; +} + static as_ext_sls_t osmo_ss7_instance_calc_itu_as_ext_sls(const struct osmo_ss7_as *as, uint32_t opc, uint8_t sls) { uint16_t opc12; diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index bcf3ffe..bf3bec2 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -2185,6 +2185,17 @@ return CMD_SUCCESS; } +DEFUN_ATTR(as_bindingtable_reset, as_bindingtable_reset_cmd, + "binding-table reset", + "AS Loadshare binding table operations\n" + "Reset loadshare binding table\n", + CMD_ATTR_IMMEDIATE) +{ + struct osmo_ss7_as *as = vty->index; + ss7_as_loadshare_binding_table_reset(as); + return CMD_SUCCESS; +} + DEFUN_ATTR(as_recov_tout, as_recov_tout_cmd, "recovery-timeout <1-2000>", "Specifies the recovery timeout value in milliseconds\n" @@ -3440,6 +3451,7 @@ install_lib_element(L_CS7_AS_NODE, &as_traf_mode_loadshare_cmd); install_lib_element(L_CS7_AS_NODE, &as_no_traf_mode_cmd); install_lib_element(L_CS7_AS_NODE, &as_sls_shift_cmd); + install_lib_element(L_CS7_AS_NODE, &as_bindingtable_reset_cmd); install_lib_element(L_CS7_AS_NODE, &as_recov_tout_cmd); install_lib_element(L_CS7_AS_NODE, &as_qos_class_cmd); install_lib_element(L_CS7_AS_NODE, &as_rout_key_cmd); diff --git a/src/ss7_as.h b/src/ss7_as.h index 13592e9..bc17726 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -131,6 +131,7 @@ unsigned int osmo_ss7_as_count_asp(const struct osmo_ss7_as *as); int ss7_as_add_asp(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp); +void ss7_as_loadshare_binding_table_reset(struct osmo_ss7_as *as); #define LOGPAS(as, subsys, level, fmt, args ...) \ _LOGSS7((as)->inst, subsys, level, "AS(%s) " fmt, (as)->cfg.name, ## args) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I56c34072a9ded42c13dbfc105a0ab3353ca353ec Gerrit-Change-Number: 39917 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites: run remsim with testenv

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39915?usp=email ) Change subject: jobs/ttcn3-testsuites: run remsim with testenv ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39915?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ibaa638408c130335e5d14590111e641493cdc194 Gerrit-Change-Number: 39915 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Apr 2025 14:17:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: remsim: make client tests work in testenv

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39916?usp=email ) Change subject: remsim: make client tests work in testenv ...................................................................... remsim: make client tests work in testenv * Prevent osmo-remsim-client-shell from closing immediately with "STDIN was closed, terminating". * Fix REMSIM_Tests.cfg: * move mp_ to proper section * proper IP Change-Id: I91b08b9bfde11f4600993b18ece1e810b61ed904 --- M remsim/client/REMSIM_Tests.cfg M remsim/testenv_client.cfg 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/39916/1 diff --git a/remsim/client/REMSIM_Tests.cfg b/remsim/client/REMSIM_Tests.cfg index b249087..affa599 100644 --- a/remsim/client/REMSIM_Tests.cfg +++ b/remsim/client/REMSIM_Tests.cfg @@ -6,12 +6,12 @@ *.JUnitLogger.filename_stem := "junit-xml-client" [TESTPORT_PARAMETERS] -# IP address to which ATS binds emulated remsim-server -REMSIM_Tests.mp_server_ip := "127.0.0.10" -# IP address to which ATS binds emulated remsim-bankd -REMSIM_Tests.mp_bankd_ip := "127.0.0.10" [MODULE_PARAMETERS] +# IP address to which ATS binds emulated remsim-server +REMSIM_Tests.mp_server_ip := "127.0.0.1" +# IP address to which ATS binds emulated remsim-bankd +REMSIM_Tests.mp_bankd_ip := "127.0.0.1" [MAIN_CONTROLLER] diff --git a/remsim/testenv_client.cfg b/remsim/testenv_client.cfg index c7d525b..73b8680 100644 --- a/remsim/testenv_client.cfg +++ b/remsim/testenv_client.cfg @@ -3,6 +3,7 @@ config=client/REMSIM_Tests.cfg [client] -program=osmo-remsim-client-shell +# sleep: avoid "STDIN was closed, terminating" +program=sleep 9999 | osmo-remsim-client-shell make=osmo-remsim package=osmo-remsim-client-shell -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I91b08b9bfde11f4600993b18ece1e810b61ed904 Gerrit-Change-Number: 39916 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites: run remsim with testenv

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39915?usp=email ) Change subject: jobs/ttcn3-testsuites: run remsim with testenv ...................................................................... jobs/ttcn3-testsuites: run remsim with testenv Related: OS#6494 Change-Id: Ibaa638408c130335e5d14590111e641493cdc194 --- M jobs/ttcn3-testsuites-testenv.yml M jobs/ttcn3-testsuites.yml 2 files changed, 15 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/15/39915/1 diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index fa58381..e5e78c9 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -166,6 +166,11 @@ args: -b osmocom:nightly timer: H 10 * * * + - ttcn3-remsim-test: # ~6 min + testsuite: remsim + args: -b osmocom:nightly -c all + timer: H 10 * * * + # --------------------------------------------- # Debian latest # --------------------------------------------- @@ -282,6 +287,11 @@ args: -b osmocom:latest timer: H 13 * * * + - ttcn3-remsim-test-latest: # ~6 min + testsuite: remsim + args: -b osmocom:latest -c all + timer: H 13 * * * + # --------------------------------------------- # Debian nightly + io_uring (OS#6357) # --------------------------------------------- @@ -383,6 +393,11 @@ args: -b osmocom:nightly:asan -c all timer: H 17 * * * + - ttcn3-remsim-test-asan: # ~6 min + testsuite: remsim + args: -b osmocom:nightly:asan -c all + timer: H 17 * * * + - job-template: name: '{job-name}' project-type: freestyle diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 5d44718..51b5a91 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -26,8 +26,6 @@ timer: H 03 * * * - nplab-sua-test: # ~1 min timer: H 03 * * * - - ttcn3-remsim-test: # ~6 min - timer: H 03 * * * - ttcn3-sccp-test: # ~2 min timer: H 03 * * * - ttcn3-gbproxy-test: # ~15 min @@ -66,8 +64,6 @@ timer: H 04 * * * - ttcn3-msc-test-latest: # ~35 min timer: H 04 * * * - - ttcn3-remsim-test-latest: # ~6 min - timer: H 05 * * * - ttcn3-sccp-test-latest: # ~2 min timer: H 05 * * * - ttcn3-gbproxy-test-latest: # ~15 min @@ -115,8 +111,6 @@ timer: H 07 * * * - ttcn3-msc-test-asan: # ~35 min timer: H 07 * * * - - ttcn3-remsim-test-asan: # ~6 min - timer: H 07 * * * - ttcn3-sccp-test-asan: # ~2 min timer: H 07 * * * -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39915?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ibaa638408c130335e5d14590111e641493cdc194 Gerrit-Change-Number: 39915 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmocom-build-tags…: set seccomp profile

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39914?usp=email ) Change subject: jobs/osmocom-build-tags…: set seccomp profile ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39914?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9636ce30a0515b773be0581a8018bf1f62c1341c Gerrit-Change-Number: 39914 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Apr 2025 12:18:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[M] Change in osmo-ci[master]: OBS: cleanup: new script

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39913?usp=email ) Change subject: OBS: cleanup: new script ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4649dedf0bb52f0bbdc7577ac0bc9e93cb3be192 Gerrit-Change-Number: 39913 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Apr 2025 12:17:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[S] Change in osmo-ci[master]: lint: run 'ruff' on various repositories

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39912?usp=email ) Change subject: lint: run 'ruff' on various repositories ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5c2ede1a7b2a204ca3deb24c55008c7585c289a0 Gerrit-Change-Number: 39912 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Apr 2025 12:16:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: scripts/verify_log_statements: fix undefined name

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39911?usp=email ) Change subject: scripts/verify_log_statements: fix undefined name ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4661d4677a1f0fc8d595985e73e2632b9a83b7d6 Gerrit-Change-Number: 39911 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Apr 2025 12:15:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: OBS: fix f-string without any placeholders

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39910?usp=email ) Change subject: OBS: fix f-string without any placeholders ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9b7b11a41930a99819a3569f817a0da5586e30a3 Gerrit-Change-Number: 39910 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Apr 2025 12:14:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025