lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

April 2025

  • 1 participants
  • 1186 discussions
[XS] Change in osmo-ci[master]: *.py: fix imported but unused
by osmith 03 Apr '25

03 Apr '25
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39907?usp=email ) Change subject: *.py: fix imported but unused ...................................................................... *.py: fix imported but unused Prepare to run "ruff check" on this repository by first fixing what it complains about in this and following patches. Change-Id: I89fa4a50a28f6ceab48cce939ca0c076967d43fd --- M lint/checkpatch/checkpatch_json.py M scripts/obs/lib/osc.py M scripts/obs/lib/srcpkg.py M scripts/obs/sync_obs_projects.py M scripts/osmo-depcheck/buildstack.py 5 files changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/07/39907/1 diff --git a/lint/checkpatch/checkpatch_json.py b/lint/checkpatch/checkpatch_json.py index 81946ca..bf7f0af 100755 --- a/lint/checkpatch/checkpatch_json.py +++ b/lint/checkpatch/checkpatch_json.py @@ -7,7 +7,6 @@ INPUT: output of checkpatch.pl. OUTPUT: json format output that can be used to post comment in gerrit """ -import os import sys import json diff --git a/scripts/obs/lib/osc.py b/scripts/obs/lib/osc.py index 57be783..8838b1a 100644 --- a/scripts/obs/lib/osc.py +++ b/scripts/obs/lib/osc.py @@ -5,7 +5,6 @@ import glob import os import shlex -import shutil import sys import lib import lib.config diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index 9dcb33f..b5286d8 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -4,7 +4,6 @@ import glob import os import pathlib -import sys import lib.config import lib.debian import lib.rpm_spec diff --git a/scripts/obs/sync_obs_projects.py b/scripts/obs/sync_obs_projects.py index beb3e09..da45306 100755 --- a/scripts/obs/sync_obs_projects.py +++ b/scripts/obs/sync_obs_projects.py @@ -2,7 +2,6 @@ # SPDX-License-Identifier: GPL-2.0-or-later # Copyright 2023 sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> import argparse -import glob import hashlib import html import os diff --git a/scripts/osmo-depcheck/buildstack.py b/scripts/osmo-depcheck/buildstack.py index 0a9a011..440b4f9 100644 --- a/scripts/osmo-depcheck/buildstack.py +++ b/scripts/osmo-depcheck/buildstack.py @@ -1,13 +1,10 @@ # SPDX-License-Identifier: GPL-2.0-or-later # Copyright 2018 sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> -import atexit import collections import sys import os -import shutil import subprocess -import tempfile def next_buildable(depends, done): -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39907?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I89fa4a50a28f6ceab48cce939ca0c076967d43fd Gerrit-Change-Number: 39907 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-ci[master]: OBS: fix f-string without any placeholders
by osmith 03 Apr '25

03 Apr '25
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39910?usp=email ) Change subject: OBS: fix f-string without any placeholders ...................................................................... OBS: fix f-string without any placeholders Change-Id: I9b7b11a41930a99819a3569f817a0da5586e30a3 --- M scripts/obs/sync_obs_projects.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/10/39910/1 diff --git a/scripts/obs/sync_obs_projects.py b/scripts/obs/sync_obs_projects.py index da45306..732fa02 100755 --- a/scripts/obs/sync_obs_projects.py +++ b/scripts/obs/sync_obs_projects.py @@ -92,7 +92,7 @@ ret += "### \n" ret += "### Do not modify manually. See OS#6165.\n" ret += "### \n" - ret += f"### Sync information:\n" + ret += "### Sync information:\n" ret += f"### - source meta: {hashlib.md5(source_meta).hexdigest()}\n" ret += f"### - source prjconf: {hashlib.md5(source_prjconf).hexdigest()}\n" ret += "\n" @@ -188,7 +188,7 @@ url = download.get("url") print(f" changing url to https: {url}") assert url.startswith("http://ftp.de.debian.org/debian"), \ - f"unexpected mirror URL" + "unexpected mirror URL" download.set("url", url.replace("http://ftp.de.debian.org/debian", "https://debian.inf.tu-dresden.de/debian")) for pubkey in download.findall("pubkey"): @@ -229,7 +229,7 @@ # Extend the AlmaLinux prjconf to also set CentOS variables, as some of # our prjconfigs and spec files rely on them if project == "AlmaLinux:8": - print(f" appending CentOS 8 variables") + print(" appending CentOS 8 variables") prjconf += "\n" prjconf += "# CentOS 8 compat added by sync script\n" prjconf += "%define centos_version 800\n" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9b7b11a41930a99819a3569f817a0da5586e30a3 Gerrit-Change-Number: 39910 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-ci[master]: *.py: ignore: E722 Do not use bare `except`
by osmith 03 Apr '25

03 Apr '25
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39909?usp=email ) Change subject: *.py: ignore: E722 Do not use bare `except` ...................................................................... *.py: ignore: E722 Do not use bare `except` Let the ruff linter not complain about the existing cases of "Do not use bare `except`" so we get the linter to pass without changing the existing logic here. With this we don't disable the check globally, so we can consider making stricter excepts in new code. Change-Id: Iaef20d47cd171aab23e516e7f7516caf98264249 --- M scripts/obs/lib/srcpkg.py M scripts/verify_log_statements.py 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/09/39909/1 diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index b5286d8..fc39563 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -57,7 +57,7 @@ print(f"{project}: getting version from debian/changelog") version = lib.debian.get_last_version_from_changelog(project) return f"{version}.{count}-{commit}" - except: + except: # noqa: E722 print(f"{project}: using 0.0.0 as version") return f"0.0.0.{count}-{commit}" diff --git a/scripts/verify_log_statements.py b/scripts/verify_log_statements.py index e0bcce6..a7b27d6 100755 --- a/scripts/verify_log_statements.py +++ b/scripts/verify_log_statements.py @@ -86,7 +86,7 @@ # that are not in quotes, between separate string constants. try: quoted = eval('(' + quoted + '\n)' ) - except: + except: # noqa: E722 # hopefully eval broke because of some '## args' macro def if debug: ignored.append(error_found(f, log.start(), 'Ignoring', log.group(0))) @@ -115,7 +115,7 @@ r.line = line return errors_found - except: + except: # noqa: E722 print("ERROR WHILE PROCESSING %r" % f, file=sys.stderr) raise -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaef20d47cd171aab23e516e7f7516caf98264249 Gerrit-Change-Number: 39909 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-ci[master]: scripts/verify_log_statements: fix undefined name
by osmith 03 Apr '25

03 Apr '25
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39911?usp=email ) Change subject: scripts/verify_log_statements: fix undefined name ...................................................................... scripts/verify_log_statements: fix undefined name Append it to "errors_found" instead of undefined variable "ignored". This makes it work similarly to further above: # Skip 'LOG("bla" fmt )' strings that typically appear as #defines. if fmt_re.match(quoted): if debug: errors_found.append(error_found(f, log.start(), 'Skipping define', log.group(0))) continue Fix the following bug: scripts/verify_log_statements.py:92:11: F821 Undefined name `ignored` | 90 | # hopefully eval broke because of some '## args' macro def 91 | if debug: 92 | ignored.append(error_found(f, log.start(), 'Ignoring', log.group(0))) | ^^^^^^^ F821 93 | continue | Change-Id: I4661d4677a1f0fc8d595985e73e2632b9a83b7d6 --- M scripts/verify_log_statements.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/11/39911/1 diff --git a/scripts/verify_log_statements.py b/scripts/verify_log_statements.py index a7b27d6..1590799 100755 --- a/scripts/verify_log_statements.py +++ b/scripts/verify_log_statements.py @@ -89,7 +89,7 @@ except: # noqa: E722 # hopefully eval broke because of some '## args' macro def if debug: - ignored.append(error_found(f, log.start(), 'Ignoring', log.group(0))) + errors_found.append(error_found(f, log.start(), 'Ignoring', log.group(0))) continue # check for errors... -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4661d4677a1f0fc8d595985e73e2632b9a83b7d6 Gerrit-Change-Number: 39911 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ci[master]: lint: run 'ruff' on various repositories
by osmith 03 Apr '25

03 Apr '25
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39912?usp=email ) Change subject: lint: run 'ruff' on various repositories ...................................................................... lint: run 'ruff' on various repositories Lint the python code with "ruff check" and "ruff format" where they are known to pass. Related: https://docs.astral.sh/ruff/ Change-Id: I5c2ede1a7b2a204ca3deb24c55008c7585c289a0 --- M lint/lint_diff.sh 1 file changed, 45 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/12/39912/1 diff --git a/lint/lint_diff.sh b/lint/lint_diff.sh index 4b95b9f..408d79f 100755 --- a/lint/lint_diff.sh +++ b/lint/lint_diff.sh @@ -4,12 +4,21 @@ GIT_DIR="$(git rev-parse --show-toplevel 2>/dev/null || true)" SCRIPT_DIR="$(dirname "$(realpath "$0")")" ERROR=0 +PROJECT="${GERRIT_PROJECT}" if [ "$OSMO_LINT" = 0 ]; then echo "Skipping lint_diff.sh (OSMO_LINT=0)" exit 0 fi +get_project() { + if [ -n "$PROJECT" ] || ! [ -e .gitreview ]; then + return + fi + + PROJECT="$(grep project= .gitreview | cut -d = -f2)" +} + check_git_dir() { if [ -z "$GIT_DIR" ]; then echo "ERROR: path is not a git repository: $PWD" @@ -70,6 +79,40 @@ fi } +test_ruff() { + local i + local check_projects=" + osmo-ci + osmo-dev + osmo-ttcn3-hacks + " + local format_projects=" + osmo-ttcn3-hacks + " + + if ! command -v ruff >/dev/null; then + return + fi + + for i in $check_projects; do + if [ "$i" = "$PROJECT" ]; then + echo "Running 'ruff check'..." + echo + ruff check + break + fi + done + + for i in $format_projects; do + if [ "$i" = "$PROJECT" ]; then + echo "Running 'ruff format --diff'..." + echo + ruff format --diff + break + fi + done +} + show_error() { echo echo "Please fix the linting errors above. More information:" @@ -106,8 +149,10 @@ < gerrit_report.json } +get_project check_git_dir set_commit +test_ruff test_docker_run_rm test_checkpatch test_clang_format -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5c2ede1a7b2a204ca3deb24c55008c7585c289a0 Gerrit-Change-Number: 39912 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in docker-playground[master]: debian-bookworm-build: fix lcov-to-cobertura-xml
by fixeria 03 Apr '25

03 Apr '25
Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/39897?usp=email ) Change subject: debian-bookworm-build: fix lcov-to-cobertura-xml ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2e248bf988be055a3a88cc414946e0377e266e1e Gerrit-Change-Number: 39897 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Apr 2025 07:34:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in libosmocore[master]: osmo-release: improve check for REL argument
by fixeria 03 Apr '25

03 Apr '25
Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/39896?usp=email ) Change subject: osmo-release: improve check for REL argument ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39896?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibac10dbc983b6d65cce6de10371fb731505a7ce8 Gerrit-Change-Number: 39896 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Apr 2025 07:33:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-hlr[master]: Bump version: 1.9.0.2-1a71e → 1.9.1
by fixeria 03 Apr '25

03 Apr '25
Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39899?usp=email ) Change subject: Bump version: 1.9.0.2-1a71e → 1.9.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib8bdcee7a6fa4ae9821d9748a8a7ea4aecbea62e Gerrit-Change-Number: 39899 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Apr 2025 07:32:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in libosmocore[master]: osmo-release: improve check for REL argument
by osmith 03 Apr '25

03 Apr '25
Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/39896?usp=email ) Change subject: osmo-release: improve check for REL argument ...................................................................... Patch Set 2: (1 comment) File osmo-release.sh: https://gerrit.osmocom.org/c/libosmocore/+/39896/comment/17270dbd_aaa3681e?… : PS1, Line 9: echo "usage: make REL=patch|minor|major release" > you may want to put this into a print_help() function, but fine anyway. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39896?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibac10dbc983b6d65cce6de10371fb731505a7ce8 Gerrit-Change-Number: 39896 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Apr 2025 06:48:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in libosmocore[master]: osmo-release: improve check for REL argument
by osmith 03 Apr '25

03 Apr '25
Attention is currently required from: osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/39896?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: osmo-release: improve check for REL argument ...................................................................... osmo-release: improve check for REL argument Verify that REL is actually "patch", "minor" or "major". If it is something else (e.g. because of a typo), the script would contiune otherwise and create an invalid release commit without bumping the version. Change-Id: Ibac10dbc983b6d65cce6de10371fb731505a7ce8 --- M osmo-release.sh 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/96/39896/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39896?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibac10dbc983b6d65cce6de10371fb731505a7ce8 Gerrit-Change-Number: 39896 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 108
  • 109
  • 110
  • 111
  • 112
  • 113
  • 114
  • ...
  • 119
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.