Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39880?usp=email )
Change subject: library: add f_rnd_sleep()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File library/Osmocom_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39880/comment/9df0628c_b17f… :
PS1, Line 117: f_sleep(rnd() * max_seconds);
> So you call f_rnd_sleep(max_seconds:=30) and it may end up sleeping 32435562354324234232 seconds?
Ah, rnd() returns something 0..1.
Please document that like done in line 62.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39880?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I97474d0c39052d8a9dd294238530e0b6c31a19e0
Gerrit-Change-Number: 39880
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Mar 2025 11:36:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39880?usp=email )
Change subject: library: add f_rnd_sleep()
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File library/Osmocom_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39880/comment/4ec2eb1b_f101… :
PS1, Line 117: f_sleep(rnd() * max_seconds);
So you call f_rnd_sleep(max_seconds:=30) and it may end up sleeping 32435562354324234232 seconds?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39880?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I97474d0c39052d8a9dd294238530e0b6c31a19e0
Gerrit-Change-Number: 39880
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Mar 2025 11:35:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes