Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39876?usp=email )
Change subject: remove unused ROHC_CNL113426_LATEST dir
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39876?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I30a5595ad1d0dfd2d6e4193add9e9e3503210aca
Gerrit-Change-Number: 39876
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 30 Mar 2025 17:36:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39874?usp=email )
Change subject: rmlinks.sh: use -delete instead of -exec rm
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39874?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic2cf9c36159a2bbf1acb59e6b316d1ef30aabe28
Gerrit-Change-Number: 39874
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 30 Mar 2025 10:29:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39878?usp=email )
Change subject: deps: fix overriding recipe for target 'titan.ProtocolEmulations.SCCP'
......................................................................
deps: fix overriding recipe for target 'titan.ProtocolEmulations.SCCP'
This patch fixes the following warnings:
Makefile:188: warning: overriding recipe for target 'titan.ProtocolEmulations.SCCP'
Makefile:185: warning: ignoring old recipe for target 'titan.ProtocolEmulations.SCCP'
Makefile:188: warning: overriding recipe for target 'titan.ProtocolEmulations.SCCP/clean'
Makefile:185: warning: ignoring old recipe for target 'titan.ProtocolEmulations.SCCP/clean'
Makefile:188: warning: overriding recipe for target 'titan.ProtocolEmulations.SCCP/distclean'
Makefile:185: warning: ignoring old recipe for target 'titan.ProtocolEmulations.SCCP/distclean'
The problem is that 'titan.ProtocolEmulations.SCCP' is listed in
both ECLIPSEGITLAB_REPOS and OSMOGITHUB_REPOS.
Change-Id: Ia215f02fc08d66fb56e7e0e452b75d6e2f6c59c5
Fixes: 207ce0370 ("deps: Update titan.ProtocolEmulations.SCCP to upstream master")
---
M deps/Makefile
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/39878/1
diff --git a/deps/Makefile b/deps/Makefile
index 9e0229f..0c5a033 100644
--- a/deps/Makefile
+++ b/deps/Makefile
@@ -65,7 +65,6 @@
OSMOGITHUB_REPOS= titan.TestPorts.SCTPasp \
titan.TestPorts.MTP3asp \
- titan.ProtocolEmulations.SCCP \
titan.ProtocolModules.BSSGP_v13.0.0
OSMOGERRIT_REPOS= osmo-uecups
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39878?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia215f02fc08d66fb56e7e0e452b75d6e2f6c59c5
Gerrit-Change-Number: 39878
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39877?usp=email )
Change subject: bts: simplify f_tc_rsl_ms_pwr_ctrl()
......................................................................
bts: simplify f_tc_rsl_ms_pwr_ctrl()
Change-Id: I67968a0398f9957dc4cc9c7fdffaf2b0ac40b88a
---
M bts/BTS_Tests.ttcn
1 file changed, 2 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/39877/1
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 8c05bb3..b49cb28 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -3831,8 +3831,6 @@
* the BTS is forwarding those values to the MS via the SACCH L1 header. */
private function f_tc_rsl_ms_pwr_ctrl(charstring id) runs on ConnHdlr {
var SacchL1Header l1h;
- var RSL_IE_MS_Power ms_power;
- var RSL_Message rsl;
var uint5_t power_level := 0;
f_l1_tune(L1CTL);
@@ -3840,16 +3838,11 @@
f_est_dchan();
- ms_power.reserved := 0;
- ms_power.fpc_epc := false;
-
/* Send the first power control command. This will disable any BTS/TRX
* internal power control and switch the MS (which is not in scope of
* this test) to a constant power level. We start with a power level
* of 0 */
- ms_power.power_level := power_level;
- rsl := valueof(ts_RSL_MS_PWR_CTRL(g_chan_nr, ms_power));
- RSL.send(rsl);
+ RSL.send(ts_RSL_MS_PWR_CTRL(g_chan_nr, ts_RSL_IE_MS_Power(power_level)));
alt {
[] as_l1_sacch_l1h(l1h, do_apply := false) {
@@ -3862,9 +3855,7 @@
/* Signal a new power level via RSL for the next turn. */
if (power_level < 31) {
power_level := power_level + 1;
- ms_power.power_level := power_level;
- rsl := valueof(ts_RSL_MS_PWR_CTRL(g_chan_nr, ms_power));
- RSL.send(rsl);
+ RSL.send(ts_RSL_MS_PWR_CTRL(g_chan_nr, ts_RSL_IE_MS_Power(power_level)));
repeat;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39877?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I67968a0398f9957dc4cc9c7fdffaf2b0ac40b88a
Gerrit-Change-Number: 39877
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>