March 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: msc: f_establish_fully(): merge EST_TYPE_MO_{CALL,CSD}

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39870?usp=email ) Change subject: msc: f_establish_fully(): merge EST_TYPE_MO_{CALL,CSD} ...................................................................... msc: f_establish_fully(): merge EST_TYPE_MO_{CALL,CSD} There's nothing special about CSD at the stage of MM connection establishment, it looks like a normal call at this point. Change-Id: I732b58ed43bc0d76fb78a6a41e19261658d8f755 --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/70/39870/1 diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 4444f37..fc3522e 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -380,7 +380,6 @@ EST_TYPE_PAG_RESP, EST_TYPE_MO_SMS, EST_TYPE_SS_ACT, - EST_TYPE_MO_CSD, EST_TYPE_VGCS, EST_TYPE_VBS }; @@ -402,9 +401,6 @@ case (EST_TYPE_MO_CALL) { l3_info := valueof(ts_CM_SERV_REQ(CM_TYPE_MO_CALL, mi)); } - case (EST_TYPE_MO_CSD) { - l3_info := valueof(ts_CM_SERV_REQ(CM_TYPE_MO_CALL, mi)); - } case (EST_TYPE_EMERG_CALL) { l3_info := valueof(ts_CM_SERV_REQ(CM_TYPE_EMERG_CALL, mi)); } @@ -1681,8 +1677,6 @@ if (cpars.emergency) { f_establish_fully(EST_TYPE_EMERG_CALL); - } else if (cpars.csd) { - f_establish_fully(EST_TYPE_MO_CSD); } else { f_establish_fully(EST_TYPE_MO_CALL); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I732b58ed43bc0d76fb78a6a41e19261658d8f755 Gerrit-Change-Number: 39870 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: split up as_unexp_gsup_or_bssap_msg()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39872?usp=email ) Change subject: msc: split up as_unexp_gsup_or_bssap_msg() ...................................................................... msc: split up as_unexp_gsup_or_bssap_msg() Make use of derived as_unexp_{gsup,bssap}_msg() altsteps. Take a chance to improve them by printing unexpected PDUs. Change-Id: Ie6c349bdae289d19614809545e23c2b7bf88f8ed --- M msc/MSC_Tests.ttcn 1 file changed, 47 insertions(+), 88 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/39872/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 380052b..03f2412 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -673,14 +673,11 @@ alt { [] BSSAP.receive(tr_PDU_DTAP_MT(tr_CM_SERV_REJ)) { } //[] BSSAP.receive(tr_PDU_DTAP_MT(tr_CM_SERV_ACC)) { } - [] BSSAP.receive { - setverdict(fail, "Received unexpected BSSAP"); - mtc.stop; - } [] GSUP.receive(tr_GSUP_UL_REQ(g_pars.imsi)) { setverdict(fail, "Unexpected GSUP UL REQ"); mtc.stop; } + [] as_unexp_bssap_msg(); [] T.timeout { setverdict(fail, "Timeout waiting for CM SERV REJ"); mtc.stop; @@ -714,10 +711,7 @@ T.start; alt { [] BSSAP.receive(tr_PDU_DTAP_MT(tr_CM_SERV_REJ)) { } - [] BSSAP.receive { - setverdict(fail, "Received unexpected BSSAP"); - mtc.stop; - } + [] as_unexp_bssap_msg(); [] T.timeout { setverdict(fail, "Timeout waiting for CM SERV REJ"); mtc.stop; @@ -1890,10 +1884,7 @@ f_cl3_or_initial_ue(l3_info); alt { [] BSSAP.receive(tr_PDU_DTAP_MT(tr_CM_SERV_REJ)) { } - [] BSSAP.receive { - setverdict(fail, "Received unexpected BSSAP instead of CM SERV REJ"); - mtc.stop; - } + [] as_unexp_bssap_msg(); } f_expect_clear(); @@ -1974,10 +1965,7 @@ setverdict(fail, "CipherModeCommand despite no A5 intersection"); mtc.stop; } - [] BSSAP.receive { - setverdict(fail, "Unknown/unexpected BSSAP received"); - mtc.stop; - } + [] as_unexp_bssap_msg(); } setverdict(pass); } @@ -2041,10 +2029,7 @@ setverdict(fail, "CipherModeCommand despite no A5 intersection"); mtc.stop; } - [] BSSAP.receive { - setverdict(fail, "Unknown/unexpected BSSAP received"); - mtc.stop; - } + [] as_unexp_bssap_msg(); } setverdict(pass); } @@ -2545,10 +2530,7 @@ setverdict(fail, "paging seems not to stop!"); mtc.stop; } - [] BSSAP.receive { - setverdict(fail, "unexpected BSSAP message received"); - self.stop; - } + [] as_unexp_bssap_msg(); [] T.timeout { setverdict(pass); } @@ -2793,10 +2775,7 @@ log("RX MO-forwardSM-Req: ", gsup_msg_rx); setverdict(pass); } - [] GSUP.receive { - setverdict(fail, "Rx unexpected GSUP message"); - mtc.stop; - } + [] as_unexp_gsup_msg(); } /* Trigger RP-ACK by sending MO-forwardSM-Res */ @@ -2848,10 +2827,7 @@ log("RX MO-ReadyForSM-Req: ", gsup_msg_rx); setverdict(pass); } - [] GSUP.receive { - setverdict(fail, "Rx unexpected GSUP message"); - mtc.stop; - } + [] as_unexp_gsup_msg(); } /* Trigger RP-ACK by sending MO-forwardSM-Res */ @@ -2935,10 +2911,7 @@ log("RX MT-forwardSM-Res (RP-ACK)"); setverdict(pass); } - [] GSUP.receive { - setverdict(fail, "Rx unexpected GSUP message"); - mtc.stop; - } + [] as_unexp_gsup_msg(); } f_expect_clear(); @@ -2997,10 +2970,7 @@ setverdict(pass); mtc.stop; } - [] GSUP.receive { - setverdict(fail, "Rx unexpected GSUP message"); - mtc.stop; - } + [] as_unexp_gsup_msg(); } f_expect_clear(); @@ -3084,10 +3054,7 @@ log("RX MT-forwardSM-Res (RP-ACK)"); setverdict(pass); } - [] GSUP.receive { - setverdict(fail, "Rx unexpected GSUP message"); - mtc.stop; - } + [] as_unexp_gsup_msg(); } /* Send the 2nd RP-ACK and expect MT-forwardSM-Res on GSUP */ @@ -3100,10 +3067,7 @@ log("RX MT-forwardSM-Res (RP-ACK)"); setverdict(pass); } - [] GSUP.receive { - setverdict(fail, "Rx unexpected GSUP message"); - mtc.stop; - } + [] as_unexp_gsup_msg(); } f_expect_clear(); @@ -3155,10 +3119,7 @@ log("RX MO-ReadyForSM-Req, SM-RP-MR is '00'O"); setverdict(pass); } - [] GSUP.receive { - setverdict(fail, "Rx unexpected GSUP message"); - mtc.stop; - } + [] as_unexp_gsup_msg(); } /* Submit MT SMS on GSUP */ @@ -3197,10 +3158,7 @@ log("RX MT-forwardSM-Res (RP-ACK)"); setverdict(pass); } - [] GSUP.receive { - setverdict(fail, "Rx unexpected GSUP message"); - mtc.stop; - } + [] as_unexp_gsup_msg(); } f_expect_clear(); @@ -3260,10 +3218,7 @@ log("RX MT-forwardSM-Res (RP-ACK)"); setverdict(pass); } - [] GSUP.receive { - setverdict(fail, "Rx unexpected GSUP message"); - mtc.stop; - } + [] as_unexp_gsup_msg(); } /* Keep some 'distance' between transmissions */ @@ -3321,10 +3276,7 @@ log("RX MT-forwardSM-Res (RP-ACK)"); setverdict(pass); } - [] GSUP.receive { - setverdict(fail, "Rx unexpected GSUP message"); - mtc.stop; - } + [] as_unexp_gsup_msg(); } f_expect_clear(); @@ -3461,16 +3413,33 @@ * USSD Testing ***********************************************************************/ -private altstep as_unexp_gsup_or_bssap_msg() +private altstep as_unexp_gsup_msg() runs on BSC_ConnHdlr { - [] GSUP.receive { - setverdict(fail, "Unknown/unexpected GSUP received"); + var GSUP_PDU pdu; + + [] GSUP.receive(GSUP_PDU:?) -> value pdu { + setverdict(fail, "Unknown/unexpected GSUP received: ", pdu); self.stop; - } + } +} + +private altstep as_unexp_bssap_msg() +runs on BSC_ConnHdlr { + var PDU_DTAP_MT dtap; + var PDU_BSSAP bssap; + + [] BSSAP.receive(PDU_DTAP_MT:?) -> value dtap { + setverdict(fail, "Unknown/unexpected BSSAP/DTAP received: ", dtap); + self.stop; + } + [] BSSAP.receive(PDU_BSSAP:?) -> value bssap { + setverdict(fail, "Unknown/unexpected BSSAP received: ", bssap); + self.stop; + } [] BSSAP.receive { - setverdict(fail, "Unknown/unexpected BSSAP message received"); + setverdict(fail, "Unknown/unexpected BSSAP received"); self.stop; - } + } } private function f_expect_gsup_msg(template GSUP_PDU msg, @@ -3485,7 +3454,8 @@ setverdict(pass); } /* We don't expect anything else */ - [] as_unexp_gsup_or_bssap_msg(); + [] as_unexp_gsup_msg(); + [] as_unexp_bssap_msg(); [] T.timeout { setverdict(fail, "Timeout waiting for GSUP message: ", msg); } @@ -3506,7 +3476,8 @@ setverdict(pass); } /* We don't expect anything else */ - [] as_unexp_gsup_or_bssap_msg(); + [] as_unexp_gsup_msg(); + [] as_unexp_bssap_msg(); [] T.timeout { setverdict(fail, "Timeout waiting for BSSAP message: ", msg); } @@ -4385,10 +4356,7 @@ setverdict(fail, "Wrong ciphering algorithm mask in CiphModCmd"); mtc.stop; } - [] BSSAP.receive { - setverdict(fail, "Unknown/unexpected BSSAP received"); - mtc.stop; - } + [] as_unexp_bssap_msg(); } f_expect_common_id(); @@ -4397,10 +4365,7 @@ [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { setverdict(pass); } - [] BSSAP.receive { - setverdict(fail, "Unknown/unexpected BSSAP received"); - mtc.stop; - } + [] as_unexp_bssap_msg(); } f_expect_clear(); } @@ -4434,10 +4399,7 @@ [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { setverdict(pass); } - [] BSSAP.receive { - setverdict(fail, "Unknown/unexpected BSSAP received"); - mtc.stop; - } + [] as_unexp_bssap_msg(); } f_expect_clear(verify_vlr_cell_id:=false); } @@ -4481,10 +4443,7 @@ setverdict(fail, "Wrong ciphering algorithm mask in CiphModCmd"); mtc.stop; } - [] BSSAP.receive { - setverdict(fail, "Unknown/unexpected BSSAP received"); - mtc.stop; - } + [] as_unexp_bssap_msg(); } f_expect_common_id(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie6c349bdae289d19614809545e23c2b7bf88f8ed Gerrit-Change-Number: 39872 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: use f_expect_paging() in SS/USSD TCs

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39871?usp=email ) Change subject: msc: use f_expect_paging() in SS/USSD TCs ...................................................................... msc: use f_expect_paging() in SS/USSD TCs Change-Id: Ia75420c738ef412af6ae602566fab7c997b48335 --- M msc/MSC_Tests.ttcn 1 file changed, 4 insertions(+), 45 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/39871/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index b4b3614..380052b 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -3596,8 +3596,6 @@ /* LU followed by MT USSD notification */ friend function f_tc_lu_and_mt_ussd_notification(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { - timer T := 5.0; - f_init_handler(pars); /* Perform location update */ @@ -3637,18 +3635,7 @@ /* Send it to MSC and expect Paging Request */ GSUP.send(gsup_req); - T.start; - alt { - [] as_paging() { setverdict(pass); } - [] as_paging_any() { - setverdict(fail, "Rx unexpected BSSMAP/RANAP Paging"); - mtc.stop; - } - [] as_unexp_gsup_or_bssap_msg(); - [] T.timeout { - setverdict(fail, "Timeout waiting for Paging Request"); - } - } + f_expect_paging(); /* Send Paging Response and expect USSD notification */ f_establish_fully(EST_TYPE_PAG_RESP); @@ -4221,8 +4208,6 @@ /* MT (network-originated) USSD and no response to Paging Request */ friend function f_tc_proc_ss_paging_fail(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { - timer TP := 2.0; /* Paging timer */ - f_init_handler(pars); /* Perform location update */ @@ -4246,22 +4231,9 @@ cause := ? /* FIXME: introduce an enumerated type! */ ); - /* Initiate a MT USSD notification */ + /* Initiate a MT USSD notification, expect paging */ GSUP.send(gsup_req); - - /* Send it to MSC and expect Paging Request */ - TP.start; - alt { - [] as_paging() { setverdict(pass); } - [] as_paging_any() { - setverdict(fail, "Rx unexpected BSSMAP/RANAP Paging"); - mtc.stop; - } - [] as_unexp_gsup_or_bssap_msg(); - [] TP.timeout { - setverdict(fail, "Timeout waiting for Paging Request"); - } - } + f_expect_paging(); /* Wait up to 20 seconds for GSUP PROC_SS_ERROR message. * OsmoMSC waits for Paging Response 10 seconds by default. */ @@ -4279,7 +4251,6 @@ runs on BSC_ConnHdlr { var octetstring facility := f_rnd_octstring(23); var OCT4 sid := '20000555'O; - timer TP := 2.0; f_init_handler(pars); @@ -4320,20 +4291,8 @@ /* Initiate a MT USSD with random payload */ GSUP.send(gsup_req); - /* Expect Paging Request */ - TP.start; - alt { - [] as_paging() { setverdict(pass); } - [] as_paging_any() { - setverdict(fail, "Rx unexpected BSSMAP/RANAP Paging"); - mtc.stop; - } - [] as_unexp_gsup_or_bssap_msg(); - [] TP.timeout { - setverdict(fail, "Timeout waiting for Paging Request"); - } - } + f_expect_paging(); /* Send Paging Response and establish connection */ f_establish_fully(EST_TYPE_PAG_RESP); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia75420c738ef412af6ae602566fab7c997b48335 Gerrit-Change-Number: 39871 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: add TC_gsup_mt_sms_{paging,conn}_timeout

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39873?usp=email ) Change subject: msc: add TC_gsup_mt_sms_{paging,conn}_timeout ...................................................................... msc: add TC_gsup_mt_sms_{paging,conn}_timeout Change-Id: Ief16753783e044911f1e3cef8d7012810d709e61 Related: SYS#7323 --- M msc/MSC_Tests.ttcn M msc/expected-results.xml 2 files changed, 110 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/39873/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 03f2412..a36dbb8 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -3294,6 +3294,112 @@ f_vty_config(MSCVTY, "msc", "no sms-over-gsup"); } +/* Test sending of GSUP MT-forwardSM-Err if MS does not respond to paging */ +friend function f_TC_gsup_mt_sms_paging_timeout(charstring id, BSC_ConnHdlrPars pars) +runs on BSC_ConnHdlr { + var SmsParameters spars := valueof(t_SmsPars); + var boolean released := false; + timer T; + + f_init_handler(pars); + + /* We need to inspect GSUP activity */ + f_create_gsup_expect(hex2str(g_pars.imsi)); + + /* Perform location update */ + f_perform_lu(); + + /* Register an 'expect' for given IMSI (+TMSI) */ + f_ran_register_imsi(g_pars.imsi, g_pars.tmsi); + + /* Submit a MT SMS on GSUP, expect paging */ + f_gsup_forwardSM_req(spars); + f_expect_paging(); + + /* ... MS does not respond to paging ... */ + + T.start(10.0 + 2.0); /* X4 + 2 seconds */ + alt { + /* Expect the MSC to indicate an error after paging timeout + * TODO: expect a specific SM-RP-Cause value + * XXX: should we expect SM-RP-REF to be 'FF'O? */ + [] GSUP.receive(tr_GSUP_MT_FORWARD_SM_ERR(g_pars.imsi, ?, ?)); + [] as_unexp_gsup_msg(); + [] as_unexp_bssap_msg(); + [] T.timeout { + setverdict(fail, "Timeout waiting for GSUP MT-forwardSM-Err"); + } + } +} +testcase TC_gsup_mt_sms_paging_timeout() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "msc", "sms-over-gsup"); + vc_conn := f_start_handler(refers(f_TC_gsup_mt_sms_paging_timeout), 93); + vc_conn.done; + f_vty_config(MSCVTY, "msc", "no sms-over-gsup"); +} + +/* Test sending of GSUP MT-forwardSM-Err if MS does not send RP-ACK */ +friend function f_TC_gsup_mt_sms_conn_timeout(charstring id, BSC_ConnHdlrPars pars) +runs on BSC_ConnHdlr { + var SmsParameters spars := valueof(t_SmsPars); + var boolean released := false; + timer T; + + f_init_handler(pars); + + /* We need to inspect GSUP activity */ + f_create_gsup_expect(hex2str(g_pars.imsi)); + + /* Perform location update */ + f_perform_lu(); + + /* Register an 'expect' for given IMSI (+TMSI) */ + f_ran_register_imsi(g_pars.imsi, g_pars.tmsi); + + /* Submit a MT SMS on GSUP, expect paging */ + f_gsup_forwardSM_req(spars); + f_expect_paging(); + + f_establish_fully(EST_TYPE_PAG_RESP); + + /* expect a MT SMS on DTAP */ + BSSAP.receive(f_mt_sms_deliver_pdu(spars)); + + /* ... MS does not send RP-ACK ... */ + + T.start(5.0 + 2.0); /* X1 + 2 seconds */ + alt { + /* Expect the MSC to indicate an error after connection timeout + * TODO: expect a specific SM-RP-Cause value + * XXX: should we expect SM-RP-REF to be 'FF'O? */ + [] GSUP.receive(tr_GSUP_MT_FORWARD_SM_ERR(g_pars.imsi, ?, ?)); + /* Timeout of X1 (5s) will trigger connection release */ + [not released] as_expect_clear() { + released := true; + repeat; + } + [] as_unexp_gsup_msg(); + [] as_unexp_bssap_msg(); + [] T.timeout { + setverdict(fail, "Timeout waiting for GSUP MT-forwardSM-Err"); + } + } + + if (not released) { + f_expect_clear(); + } +} +testcase TC_gsup_mt_sms_conn_timeout() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "msc", "sms-over-gsup"); + vc_conn := f_start_handler(refers(f_TC_gsup_mt_sms_conn_timeout), 94); + vc_conn.done; + f_vty_config(MSCVTY, "msc", "no sms-over-gsup"); +} + /* convert GSM L3 TON to SMPP_TON enum */ function f_sm_ton_from_gsm(BIT3 ton) return SMPP_TON { select (ton) { @@ -7446,6 +7552,8 @@ execute( TC_gsup_mo_mt_sms_rp_mr() ); execute( TC_gsup_mt_multi_part_sms() ); execute( TC_gsup_mt_sms_lu_delay() ); + execute( TC_gsup_mt_sms_paging_timeout() ); + execute( TC_gsup_mt_sms_conn_timeout() ); execute( TC_lu_and_mo_ussd_single_request() ); execute( TC_lu_and_mt_ussd_notification() ); diff --git a/msc/expected-results.xml b/msc/expected-results.xml index d846cad..ffe85a6 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -81,6 +81,8 @@ <testcase classname='MSC_Tests' name='TC_gsup_mo_mt_sms_rp_mr' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_gsup_mt_multi_part_sms' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_gsup_mt_sms_lu_delay' time='MASKED'/> + <testcase classname='MSC_Tests' name='TC_gsup_mt_sms_paging_timeout' time='MASKED'/> + <testcase classname='MSC_Tests' name='TC_gsup_mt_sms_conn_timeout' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_and_mo_ussd_single_request' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_and_mt_ussd_notification' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_and_mo_ussd_during_mt_call' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39873?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ief16753783e044911f1e3cef8d7012810d709e61 Gerrit-Change-Number: 39873 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: disable Nagle for eNB and MME connections

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39852?usp=email ) Change subject: s1gw: disable Nagle for eNB and MME connections ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39852?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id89941659fd2763aad9262b05aa007370424f2c1 Gerrit-Change-Number: 39852 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 29 Mar 2025 12:46:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add TC_uemux_uldl_nas_release

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39851?usp=email ) Change subject: s1gw: add TC_uemux_uldl_nas_release ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8e5db55739241f89592a7d2a81a13e8028e90d1d Gerrit-Change-Number: 39851 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 29 Mar 2025 12:46:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: s1gw: add UE multiplex component

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39850?usp=email ) Change subject: s1gw: add UE multiplex component ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39850?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I60e6f5d2b9882c27cecd06a2450bda4909c0532a Gerrit-Change-Number: 39850 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 29 Mar 2025 12:46:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: derive altsteps from f_ConnHdlr_rx_s1ap_from_{enb,mme}()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39849?usp=email ) Change subject: s1gw: derive altsteps from f_ConnHdlr_rx_s1ap_from_{enb,mme}() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39849?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8637a8abed0f0152abf2dce63ac28aa90f85bdc7 Gerrit-Change-Number: 39849 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 29 Mar 2025 12:46:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: library/s1ap: split PDU specific API to S1AP_Functions.ttcn

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848?usp=email ) Change subject: library/s1ap: split PDU specific API to S1AP_Functions.ttcn ...................................................................... Patch Set 2: (1 comment) File library/S1AP_Utils.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848/comment/5df8ed99_34e9… : PS1, Line 1: module S1AP_Utils { > Done. […] Uh, great, now I poisoned the cache in Jenkins with a broken symlink: ``` ttcn3_makefilegen: error: Cannot find any source file for argument `S1AP_Utils.ttcn'. ``` No idea how to get this fixed, maybe @osmith@sysmocom.de could help? Thanks in advance! TL;DR, I've renamed `S1AP_Utils.ttcn` to `S1AP_Functions.ttcn`, but a symlink to the old name remains in the workspace and needs to be removed (manually?). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id3ba089140093490abd0307addeb5d7287dc5894 Gerrit-Change-Number: 39848 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 29 Mar 2025 12:45:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: rtp-patch rfc5993hr: convert to each end's respective format

by falconia

Attention is currently required from: falconia. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: mgw: rtp-patch rfc5993hr: convert to each end's respective format ...................................................................... mgw: rtp-patch rfc5993hr: convert to each end's respective format The purpose of 'rtp-patch rfc5993hr' feature is to convert GSM-HR RTP packets between RFC 5993 format that is expected on AoIP interface (as prescribed by 3GPP) and TS 101 318 format that is emitted and perhaps required by some legacy IP-based BTS. However, the original implementation of this feature was excessively brute: when enabled, it would unconditionally "flip" the format of each RTP packet handled by the MGW. The operator therefore had to be careful to enable this feature only when those old BTS models are in use, and there was no possibility of mixing both old and new BTS on the same OsmoBSC+OsmoMGW setup. Modify this feature to work by autodetecting the format emitted by each RTP peer, and send packets toward each peer in the same format as that peer emits. Related: OS#6059 Change-Id: I6b446ad83c540fb8b7e1aae24b78c27010212d64 --- M include/osmocom/mgcp/mgcp_rtp_end.h M src/libosmo-mgcp/mgcp_network.c 2 files changed, 148 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/69/39869/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6b446ad83c540fb8b7e1aae24b78c27010212d64 Gerrit-Change-Number: 39869 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: falconia <falcon(a)freecalypso.org>

3 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025