March 2025 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: pySim/commands: Fix envelope command APDU case after T=1 support

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/39866?usp=email ) Change subject: pySim/commands: Fix envelope command APDU case after T=1 support ...................................................................... pySim/commands: Fix envelope command APDU case after T=1 support When we merged I8b56d7804a2b4c392f43f8540e0b6e70001a8970 for T=1 support, the ENVELOPE C-APDU was not adjusted to reflect the correct case. ENVELOPE expects a response and hence needs a Le byte present. This avoids below related message when performing e.g. OTA via SMS Warning: received unexpected response data, incorrect APDU-case (3, should be 4, missing Le field?)! Change-Id: Ice12675e02aa5438cf9f069f8fcc296c64aabc5a Related: OS#6367 --- M pySim/commands.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/66/39866/1 diff --git a/pySim/commands.py b/pySim/commands.py index af9f247..dd58109 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -735,7 +735,7 @@ Args: payload : payload as hex string """ - return self.send_apdu_checksw('80c20000%02x%s' % (len(payload)//2, payload), apply_lchan = False) + return self.send_apdu_checksw('80c20000%02x%s' % (len(payload)//2, payload) + "00", apply_lchan = False) def terminal_profile(self, payload: Hexstr) -> ResTuple: """Send TERMINAL PROFILE to card -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ice12675e02aa5438cf9f069f8fcc296c64aabc5a Gerrit-Change-Number: 39866 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

3 months, 1 week

1
0
0 0

[S] Change in pysim[master]: saip-tool: add commandline option to edit mandatory services list

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email ) Change subject: saip-tool: add commandline option to edit mandatory services list ...................................................................... Patch Set 1: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/39863/comment/dfefc56b_167d88a4?usp=em… : PS1, Line 1356: if service_name in self.decoded['eUICC-Mandatory-services'].keys(): Maybe it's worth letting the user know that they're trying to remove something that is not present in the service list, rather than doing nothing and not even printing a warning? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 Gerrit-Change-Number: 39863 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 20:52:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 months, 1 week

1
0
0 0

[S] Change in pysim[master]: saip-tool: add commandline option to edit mandatory services list

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39863?usp=email ) Change subject: saip-tool: add commandline option to edit mandatory services list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I120b98d4b0942c26674bc1365c5711101ec95235 Gerrit-Change-Number: 39863 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 20:51:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[XS] Change in pysim[master]: saip-tool: allow removing of profile elements by type

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39862?usp=email ) Change subject: saip-tool: allow removing of profile elements by type ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I92f9f9d5b4382242963f1b3ded814a0d013c4808 Gerrit-Change-Number: 39862 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 20:46:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[S] Change in pysim[master]: saip-tool: add option to extact profile elements to file

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39861?usp=email ) Change subject: saip-tool: add option to extact profile elements to file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I77a80bfaf8970660a84fa61f7e08f404ffc4c2da Gerrit-Change-Number: 39861 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 20:45:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[L] Change in pysim[master]: saip-tool: add features to add and remove applications profile elements

by fixeria

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39860?usp=email ) Change subject: saip-tool: add features to add and remove applications profile elements ...................................................................... Patch Set 1: (5 comments) File contrib/saip-tool.py: https://gerrit.osmocom.org/c/pysim/+/39860/comment/f238e89a_fab73d6e?usp=em… : PS1, Line 22: import zipfile > removing those unused imports is a logically separate change, isn't it? Acknowledged https://gerrit.osmocom.org/c/pysim/+/39860/comment/bf59f361_b00e6312?usp=em… : PS1, Line 250: if dictionary is None: The type hint `:dict` suggests that it cannot be `None`, change to `Optional[dict]` then? https://gerrit.osmocom.org/c/pysim/+/39860/comment/ba8d4bce_3c0ba022?usp=em… : PS1, Line 255: elif value is None: : Looks like a no-op branch that can be removed without any consequences? https://gerrit.osmocom.org/c/pysim/+/39860/comment/5109e147_a6e47968?usp=em… : PS1, Line 268: for app_pe in apps: You can drop `app_index` above and use `enumerate()` instead: ``` for app_index, app_pe in enumerate(apps): ``` This way there's no need to maintain the counter manually. https://gerrit.osmocom.org/c/pysim/+/39860/comment/4ec99c16_30eea229?usp=em… : PS1, Line 283: for inst in app_pe.decoded.get('instanceList', []): Likewise, use `enumerate()` here. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I41db96f2f0ccc29c1725a92215ce6b17d87b76ce Gerrit-Change-Number: 39860 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 20:44:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 1 week

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: s1gw: add UE multiplex component

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39850?usp=email ) Change subject: s1gw: add UE multiplex component ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39850?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I60e6f5d2b9882c27cecd06a2450bda4909c0532a Gerrit-Change-Number: 39850 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 20:41:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[S] Change in pysim[master]: saip-tool: add function to write PE sequence

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39859?usp=email ) Change subject: saip-tool: add function to write PE sequence ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39859?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I38733422270f5b9c18187b7f247b84bf21f9121b Gerrit-Change-Number: 39859 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 20:24:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: library/s1ap: split PDU specific API to S1AP_Functions.ttcn

by fixeria

Attention is currently required from: fixeria, laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848?usp=email ) Change subject: library/s1ap: split PDU specific API to S1AP_Functions.ttcn ...................................................................... Patch Set 2: (1 comment) File library/S1AP_Utils.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848/comment/a7e6c6fb_9565… : PS1, Line 1: module S1AP_Utils { > I am all for using consistent naming, and I am happy to amend this patch. […] Done. Honestly, I would still prefer `Utils` because `Functions` is way too specific (I may want to add constants and altsteps, so shall I create separate files for that?) and `Helpers` is kinda obvious because everything in the library is helpers. In any case, I didn't want to be blocked here either, so whatever. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id3ba089140093490abd0307addeb5d7287dc5894 Gerrit-Change-Number: 39848 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 20:18:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: s1gw: add UE multiplex component

by fixeria

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39850?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: s1gw: add UE multiplex component ...................................................................... s1gw: add UE multiplex component The UEMux is built upon the ConnHdlr component, allowing to simulate concurrent activity of multiple virtual UEs. This new component will be used in follow-up patches. Change-Id: I60e6f5d2b9882c27cecd06a2450bda4909c0532a Related: SYS#7288 --- A s1gw/S1GW_UEMux.ttcn M s1gw/gen_links.sh 2 files changed, 328 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/39850/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39850?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I60e6f5d2b9882c27cecd06a2450bda4909c0532a Gerrit-Change-Number: 39850 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025