March 2025 - gerrit-log - lists.osmocom.org

[L] Change in osmo-ttcn3-hacks[master]: library/s1ap: split PDU specific API to S1AP_Functions.ttcn

by fixeria

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: library/s1ap: split PDU specific API to S1AP_Functions.ttcn ...................................................................... library/s1ap: split PDU specific API to S1AP_Functions.ttcn Change-Id: Id3ba089140093490abd0307addeb5d7287dc5894 Related: SYS#7288 --- M library/S1AP_Emulation.ttcn A library/S1AP_Functions.ttcn M mme/MME_Tests.ttcn M mme/gen_links.sh 4 files changed, 170 insertions(+), 152 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/48/39848/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id3ba089140093490abd0307addeb5d7287dc5894 Gerrit-Change-Number: 39848 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: library/s1ap: split PDU specific API to S1AP_Utils.ttcn

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848?usp=email ) Change subject: library/s1ap: split PDU specific API to S1AP_Utils.ttcn ...................................................................... Patch Set 1: (1 comment) File library/S1AP_Utils.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848/comment/bb2fbb47_c5fb… : PS1, Line 1: module S1AP_Utils { > Acknowledged I am all for using consistent naming, and I am happy to amend this patch. But before doing so, let's see what kinds of naming we already have in the `library`: ``` $ ls library/ | grep -i -e helper -e function -e utils BSSGP_Helper.cc BSSGP_Helper_Functions.ttcn DNS_Helpers.ttcn Misc_Helpers.ttcn Native_FunctionDefs.cc Native_Functions.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_VTY_Functions.ttcn USSD_Helpers.ttcn ``` so we have: * `Helper` / `Helpers`, * `Functions` (as you suggest), * `Helper_Functions`. There's no `Utils`, so I need to pick something else to avoid adding even more variants. I find `S1AP_Helper_Functions` quite long and verbose, so I would go for `Functions` or `Helpers`. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id3ba089140093490abd0307addeb5d7287dc5894 Gerrit-Change-Number: 39848 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 20:09:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[M] Change in pysim[master]: [5/6] personalization: refactor AlgorithmID, K, Opc

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39745?usp=email ) Change subject: [5/6] personalization: refactor AlgorithmID, K, Opc ...................................................................... Patch Set 3: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39745/comment/23d923bc_40a42058?usp=em… : PS3, Line 551: allow_len = int(128/8) # length in bytes (from BinaryParam) > You mean the length of 128 bit? I have no idea!! Will have to check, thanks! […] just look at the pysim-shell code for setting the values on a sysmoISIM card: # TUAK has a rather different layout for the data, so we define a different # construct below and use explicit _{decode,encode}_bin() methods for separating # the TUAK and non-TUAK situation CfgByteTuak = BitStruct(Padding(1), 'key_length'/Mapping(Bit, {128:0, 256:1}), 'sres_deriv_func_in_2g'/Mapping(Bit, {1:0, 2:1}), 'use_opc_instead_of_op'/Mapping(Bit, {False:0, True:1}), 'algorithm'/Algorithm) TuakCfgByte = BitStruct(Padding(1), 'ck_and_ik_size'/Mapping(Bit, {128:0, 256:1}), 'mac_size'/Mapping(BitsInteger(3), {64:0, 128:1, 256:2}), 'res_size'/Mapping(BitsInteger(3), {32:0, 64:1, 128:2, 256:3})) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6296fdcfd5d2ed313c4aade57ff43cc362375848 Gerrit-Change-Number: 39745 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 20:00:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 1 week

1
0
0 0

[M] Change in pysim[master]: [4/6] personalization: refactor Pin, Adm

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39744?usp=email ) Change subject: [4/6] personalization: refactor Pin, Adm ...................................................................... Patch Set 3: -Code-Review (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39744/comment/7ef4d6b0_4e20244d?usp=em… : PS3, Line 408: return (pe for pe in l if pe.type == wanted_type) > No! […] * I think from an ISO7816 and UICC point of view it's sadly not correct to limit to MF. The MF has PINs, and each application on a card (e.g. USIM or ISIM application on a typical telecom card) may have its own set of application PINs. I haven't really seen any use of that, though. And I'm not sure what eSIM profiles support in that regard, please check the SAIP spec. * Regarding the ProfileElementList: I think we have to distinguish an acutal plain list in the python sense, from the decoded asn.1 structures of the SAIP PEList definition. If you come up with a better way to name and/or logically represent those two in the code: be my guest. For sure it would be elegant not having to reimplement things. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39744?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I54aef10b6d4309398d4b779a3740a7d706d68603 Gerrit-Change-Number: 39744 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 19:56:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 1 week

1
0
0 0

[M] Change in pysim[master]: [1/6] personalization: refactor: drop ClassVarMeta use

by laforge

Attention is currently required from: fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39741?usp=email ) Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > So many letters here... is it a comment by Mychaela? Oh, no, it's Neels! […] CSV matching: I have other use cases than you do. My CSV/name matching doesn't have to be related at all at what you do. All I want to make sure is that the classes still have a 'name' member with a human-readable name for the parameter, irrespective of the automatic class-name python uses for referencing the class. About the other topics: I sadly do not remotely have sufficient time to investigate or comment for several weeks already, sorry. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051 Gerrit-Change-Number: 39741 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 19:43:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[XS] Change in osmo-bts[master]: rsl: rsl_rx_chan_activ(): fix code formatting

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/39828?usp=email ) Change subject: rsl: rsl_rx_chan_activ(): fix code formatting ...................................................................... rsl: rsl_rx_chan_activ(): fix code formatting Change-Id: Ib22f9b90a5194370d2b5bb768d050cc0b167320e --- M src/common/rsl.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/src/common/rsl.c b/src/common/rsl.c index 20581d4..7931a17 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -2078,8 +2078,8 @@ } /* Spec explicitly states BTS should only perform - * autonomous MS power control loop in BTS if 'MS Power - * Parameters' IE is present! */ + * autonomous MS power control loop in BTS if 'MS Power + * Parameters' IE is present! */ lchan->ms_power_ctrl.dpc_params = params; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib22f9b90a5194370d2b5bb768d050cc0b167320e Gerrit-Change-Number: 39828 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 1 week

1
0
0 0

[XS] Change in libosmo-sigtran[master]: vty: Describe lower route priority value means higher priority

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39854?usp=email ) Change subject: vty: Describe lower route priority value means higher priority ...................................................................... vty: Describe lower route priority value means higher priority Change-Id: Id09df27ec4d47f1476b10bfd81f0201e553b29ef --- M src/osmo_ss7_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index e286509..bcf3ffe 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -404,7 +404,7 @@ "Point Code Mask\n" "Specify Destination Linkset\n" "Linkset Name\n" - "Specify Priority\n" + "Specify Priority (lower value means higher priority)\n" ROUTE_PRIO_VAR_HELP_STR "Specify QoS Class\n" QOS_CLASS_VAR_HELP_STR, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39854?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id09df27ec4d47f1476b10bfd81f0201e553b29ef Gerrit-Change-Number: 39854 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

3 months, 1 week

1
0
0 0

[S] Change in libosmo-sigtran[master]: tests/vty: Test adding routes with smaller bitmask len to routing table

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39855?usp=email ) Change subject: tests/vty: Test adding routes with smaller bitmask len to routing table ...................................................................... tests/vty: Test adding routes with smaller bitmask len to routing table Change-Id: I376ba40ab990acb1d309db0a0ef7b09c5b80e67f --- M tests/vty/osmo_stp_route_prio.vty 1 file changed, 30 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/vty/osmo_stp_route_prio.vty b/tests/vty/osmo_stp_route_prio.vty index 9e34d6e..b993cbb 100644 --- a/tests/vty/osmo_stp_route_prio.vty +++ b/tests/vty/osmo_stp_route_prio.vty @@ -63,8 +63,8 @@ accept-asp-connections dynamic-permitted end -OsmoSTP(config-cs7)# ! ADD 2 ROUTES WITH DECREASING PRIORITIES. THEY SHOULD END UP REORDERED BY PRIORITY: OsmoSTP(config-cs7)# route-table system +OsmoSTP(config-cs7-rt)# ! ADD 2 ROUTES WITH DECREASING PRIORITIES. THEY SHOULD END UP REORDERED BY PRIORITY: OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset as1 priority 6 qos-class 7 OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset as2 OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset as3 priority 2 @@ -87,6 +87,35 @@ 3.2.1/14 INACC 0 5 as2 UNAVAIL ? UNAVAIL 3.2.1/14 INACC 7 6 as1 UNAVAIL ? UNAVAIL +OsmoSTP(config-cs7-rt)# ! NOW ADD MORE GENERIC ROUTES (SMALLER BITMASK LENGTH) +OsmoSTP(config-cs7-rt)# update route 3.2.0 7.255.0 linkset as1 priority 1 +OsmoSTP(config-cs7-rt)# update route 3.2.0 7.255.0 linkset as2 priority 1 +OsmoSTP(config-cs7-rt)# update route 3.2.0 7.255.0 linkset as3 priority 1 +OsmoSTP(config-cs7-rt)# show running-config +... +cs7 instance 0 +... + route-table system + update route 3.2.1 7.255.7 linkset as3 priority 2 + update route 3.2.1 7.255.7 linkset as2 + update route 3.2.1 7.255.7 linkset as1 priority 6 qos-class 7 + update route 3.2.0 7.255.0 linkset as1 priority 1 + update route 3.2.0 7.255.0 linkset as2 priority 1 + update route 3.2.0 7.255.0 linkset as3 priority 1 +... +OsmoSTP(config-cs7-rt)# do show cs7 instance 0 route +Routing table = system +C=Cong Q=QoS P=Prio + +Destination C Q P Linkset Name Linkset Non-adj Route +---------------------- - - - ------------------- ------- ------- ------- +3.2.1/14 INACC 0 2 as3 UNAVAIL ? UNAVAIL +3.2.1/14 INACC 0 5 as2 UNAVAIL ? UNAVAIL +3.2.1/14 INACC 7 6 as1 UNAVAIL ? UNAVAIL +3.2.0/11 INACC 0 1 as1 UNAVAIL ? UNAVAIL +3.2.0/11 INACC 0 1 as2 UNAVAIL ? UNAVAIL +3.2.0/11 INACC 0 1 as3 UNAVAIL ? UNAVAIL + OsmoSTP(config-cs7-rt)# do show cs7 instance 0 route binding-table 3.2.1 Combined Linkset: dpc=6161=3.2.1, mask=0x3fff=7.255.7, prio=2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39855?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I376ba40ab990acb1d309db0a0ef7b09c5b80e67f Gerrit-Change-Number: 39855 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

3 months, 1 week

1
0
0 0

[S] Change in libosmo-sigtran[master]: tests/vty: Test adding routes with smaller bitmask len to routing table

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39855?usp=email ) Change subject: tests/vty: Test adding routes with smaller bitmask len to routing table ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39855?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I376ba40ab990acb1d309db0a0ef7b09c5b80e67f Gerrit-Change-Number: 39855 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 19:37:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

[S] Change in libosmo-sigtran[master]: tests/vty: Test adding routes with smaller bitmask len to routing table

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39855?usp=email ) Change subject: tests/vty: Test adding routes with smaller bitmask len to routing table ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39855?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I376ba40ab990acb1d309db0a0ef7b09c5b80e67f Gerrit-Change-Number: 39855 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Mar 2025 19:37:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025