March 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: lint/lint_diff.sh: allow skipping with LINT=0

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39797?usp=email ) Change subject: lint/lint_diff.sh: allow skipping with LINT=0 ...................................................................... Patch Set 1: (1 comment) File lint/lint_diff.sh: https://gerrit.osmocom.org/c/osmo-ci/+/39797/comment/1b9e2d88_be957c8b?usp=… : PS1, Line 8: if [ "$LINT" = 0 ]; then maybe adding some OSMO_ prefix would make this a lot less prone to conflict with something else. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39797?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia4563c13d9916a879a1e8afeacad8c541662adaa Gerrit-Change-Number: 39797 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Mar 2025 15:57:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 months, 3 weeks

1
0
0 0

[S] Change in osmo-ci[master]: lint/lint_diff: run clang-format if config was found

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39796?usp=email ) Change subject: lint/lint_diff: run clang-format if config was found ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie210966ebfbada43dd8507b9b48218df4925820d Gerrit-Change-Number: 39796 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Mar 2025 15:55:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ci[master]: lint/lint_diff: make use of shell functions

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39795?usp=email ) Change subject: lint/lint_diff: make use of shell functions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If884f51f20e794397ee0fecff0cf1f958957da05 Gerrit-Change-Number: 39795 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Mar 2025 15:55:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[S] Change in osmo-ci[master]: jobs/gerrit-lint: run in docker

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39794?usp=email ) Change subject: jobs/gerrit-lint: run in docker ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I17d2e538f1f9fb69f298ac223bc293570db90a83 Gerrit-Change-Number: 39794 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Mar 2025 15:54:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[S] Change in osmo-ccid-firmware[master]: [cosmetic]: Fix coding style issues in ccid_common

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39790?usp=email ) Change subject: [cosmetic]: Fix coding style issues in ccid_common ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: If1035d558d326f2d1fe58974773a2c91ab6df73f Gerrit-Change-Number: 39790 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 14 Mar 2025 15:52:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[S] Change in osmo-ccid-firmware[master]: sysmoOCTSIM/README: Describe how to build matching libosmocore

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39789?usp=email ) Change subject: sysmoOCTSIM/README: Describe how to build matching libosmocore ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39789?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I3392d134ed75dbdd558643aac6d58407e00d23ba Gerrit-Change-Number: 39789 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 14 Mar 2025 15:51:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: configure.ac: check for Python interpreter unconditionally

by pespin

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/39776?usp=email ) Change subject: configure.ac: check for Python interpreter unconditionally ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Looked at the Makefiles, it really seems not possible to build it without python. […] we should probably depend there on something like python-native or alike if it exists. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib19c4c4bb2b8dd12805ce470896ec5d82c72b064 Gerrit-Change-Number: 39776 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Mar 2025 15:50:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: configure.ac: check for Python interpreter unconditionally

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/39776?usp=email ) Change subject: configure.ac: check for Python interpreter unconditionally ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib19c4c4bb2b8dd12805ce470896ec5d82c72b064 Gerrit-Change-Number: 39776 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Mar 2025 15:49:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[S] Change in libosmo-gprs[master]: csn1: Use enum to select enc/dec direction

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39783?usp=email ) Change subject: csn1: Use enum to select enc/dec direction ...................................................................... csn1: Use enum to select enc/dec direction Ported from osmo-pcu.git Change-Id I845bcab61e354436bff1c3a0f2b6f49de9705716 Change-Id: I216d4d94f585dd4dcf9947324fdbdc786ab2b5c5 --- M include/osmocom/csn1/csn1.h M src/csn1/csn1.c M src/csn1/csn1_dec.c M src/csn1/csn1_enc.c M src/rlcmac/csn1_ts_24_008.c M src/rlcmac/csn1_ts_44_060.c 6 files changed, 12 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/include/osmocom/csn1/csn1.h b/include/osmocom/csn1/csn1.h index a87f5a0..cb3ad13 100644 --- a/include/osmocom/csn1/csn1.h +++ b/include/osmocom/csn1/csn1.h @@ -52,7 +52,10 @@ #define CSNCBS_REVISION_LIMIT_STOP -20 /* Stop packing/unpacking - revision limit */ #define CSNCBS_NOT_SUPPORTED_IE -21 /* Handling of the unpacked IE is not supported by MS-software */ - +enum CSN_Direction { + CSN_DIRECTION_ENC = 0, + CSN_DIRECTION_DEC = 1, +}; #ifndef ElementsOf #define ElementsOf(array) (sizeof(array) / sizeof(array[0])) @@ -64,7 +67,7 @@ { gint remaining_bits_len; /* IN to an csn stream operation */ gint bit_offset; /* IN/OUT to an csn stream operation */ - gint direction; /* 0 - decode; 1 - encode */ + enum CSN_Direction direction; /* encode vs decode */ } csnStream_t; typedef gint16 (*StreamSerializeFcn_t)(csnStream_t* ar, struct bitvec *vector, unsigned *readIndex, void* data); diff --git a/src/csn1/csn1.c b/src/csn1/csn1.c index f07c414..5eb35ea 100644 --- a/src/csn1/csn1.c +++ b/src/csn1/csn1.c @@ -72,7 +72,7 @@ { ar->remaining_bits_len = remaining_bits_len; ar->bit_offset = bit_offset; - ar->direction = 0; + ar->direction = CSN_DIRECTION_ENC; } static const struct value_string csn1_error_names[] = { diff --git a/src/csn1/csn1_dec.c b/src/csn1/csn1_dec.c index 0fa09ad..c179f9b 100644 --- a/src/csn1/csn1_dec.c +++ b/src/csn1/csn1_dec.c @@ -483,7 +483,7 @@ remaining_bits_len -= length_len; osmo_csn1_stream_init(&arT, bit_offset, length > 0 ? length : remaining_bits_len); - arT.direction = 1; + arT.direction = CSN_DIRECTION_DEC; LOGPC(DLCSN1, LOGL_DEBUG, "offset = %u | ", pDescr->offset); Status = serialize(&arT, vector, readIndex, pvDATA(data, pDescr->offset)); diff --git a/src/csn1/csn1_enc.c b/src/csn1/csn1_enc.c index 6405525..a07caf0 100644 --- a/src/csn1/csn1_enc.c +++ b/src/csn1/csn1_enc.c @@ -433,7 +433,7 @@ *writeIndex += length_len; bit_offset += length_len; remaining_bits_len -= length_len; - arT.direction = 0; + arT.direction = CSN_DIRECTION_ENC; osmo_csn1_stream_init(&arT, bit_offset, remaining_bits_len); Status = serialize(&arT, vector, writeIndex, pvDATA(data, pDescr->offset)); diff --git a/src/rlcmac/csn1_ts_24_008.c b/src/rlcmac/csn1_ts_24_008.c index d38185d..79deff3 100644 --- a/src/rlcmac/csn1_ts_24_008.c +++ b/src/rlcmac/csn1_ts_24_008.c @@ -281,7 +281,7 @@ static gint16 Content_Dissector(csnStream_t* ar, struct bitvec *vector, unsigned *readIndex, void* data) { - if (ar->direction == 0) + if (ar->direction == CSN_DIRECTION_ENC) { return osmo_csn1_stream_encode(ar, CSNDESCR(Content_t), vector, readIndex, data); } @@ -305,7 +305,7 @@ static gint16 Additional_access_technologies_Dissector(csnStream_t* ar, struct bitvec *vector, unsigned *readIndex, void* data) { - if (ar->direction == 0) + if (ar->direction == CSN_DIRECTION_ENC) { return osmo_csn1_stream_encode(ar, CSNDESCR(Additional_access_technologies_t), vector, readIndex, data); } diff --git a/src/rlcmac/csn1_ts_44_060.c b/src/rlcmac/csn1_ts_44_060.c index e8c03df..e3270b7 100644 --- a/src/rlcmac/csn1_ts_44_060.c +++ b/src/rlcmac/csn1_ts_44_060.c @@ -183,7 +183,7 @@ /*< EGPRS Ack/Nack Description IE >*/ static gint16 Egprs_Ack_Nack_Desc_w_len_Dissector(csnStream_t* ar, struct bitvec *vector, unsigned *readIndex, void* data) { - if (ar->direction == 0) + if (ar->direction == CSN_DIRECTION_ENC) { return osmo_csn1_stream_encode(ar, CSNDESCR(EGPRS_AckNack_Desc_t), vector, readIndex, data); } @@ -394,7 +394,7 @@ #if 0 gint16 Receive_N_PDU_Number_list_Dissector(csnStream_t* ar, struct bitvec *vector, unsigned *readIndex, void* data) { - if (ar->direction == 0) + if (ar->direction == CSN_DIRECTION_ENC) { return osmo_csn1_stream_encode(ar, CSNDESCR(Receive_N_PDU_Number_t), vector, readIndex, data); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I216d4d94f585dd4dcf9947324fdbdc786ab2b5c5 Gerrit-Change-Number: 39783 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: lint/lint_diff.sh: allow skipping with LINT=0

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39797?usp=email ) Change subject: lint/lint_diff.sh: allow skipping with LINT=0 ...................................................................... lint/lint_diff.sh: allow skipping with LINT=0 When this script is set as pre-commit hook, it can be useful to skip the linter with this env var to make a commit that intentionally does not pass the linter (e.g. to test if it will be caught in gerrit + jenkins). There is also "git commit --no-verify", but with that the hook that applies the Change-Id does not run. Change-Id: Ia4563c13d9916a879a1e8afeacad8c541662adaa --- M lint/lint_diff.sh 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/97/39797/1 diff --git a/lint/lint_diff.sh b/lint/lint_diff.sh index 60fd8b1..6a40ba4 100755 --- a/lint/lint_diff.sh +++ b/lint/lint_diff.sh @@ -5,6 +5,11 @@ SCRIPT_DIR="$(dirname "$(realpath "$0")")" ERROR=0 +if [ "$LINT" = 0 ]; then + echo "Skipping lint_diff.sh (LINT=0)" + exit 0 +fi + check_git_dir() { if [ -z "$GIT_DIR" ]; then echo "ERROR: path is not a git repository: $PWD" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39797?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia4563c13d9916a879a1e8afeacad8c541662adaa Gerrit-Change-Number: 39797 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025