osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39802?usp=email )
Change subject: configure: set min python version check to 3.4
......................................................................
configure: set min python version check to 3.4
While the osmo-gsm-tester builder jobs that use the poky SDK with python
version 3.5 are passing with the last patch, the jobs that build our
images and packages with the poky SDK (201705 jobs) are still failing.
This is because they run on a machine with Python 3.4 installed, and that
version gets used in the build process. Lower the version to 3.4 to not
have a regression there.
Fixes: 489a6f ("configure.ac: check for Python interpreter unconditionally")
Fixes: 40e8f5 ("configure: set min python version check to 3.5")
Change-Id: Ia83f360274061463232c1fcd7f6dc6e70f774738
---
M configure.ac
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/02/39802/1
diff --git a/configure.ac b/configure.ac
index 80d1b76..7863624 100644
--- a/configure.ac
+++ b/configure.ac
@@ -176,7 +176,8 @@
dnl Search for a Python interpreter on the system
dnl python is needed at built-time for auto-generating code
dnl Don't require a newer version than 3.5 for now, as poky 201705 ships that
-AM_PATH_PYTHON([3.5])
+dnl Don't require a newer version than 3.4, we build poky 201705 on debian 8
+AM_PATH_PYTHON([3.4])
PKG_CHECK_MODULES(TALLOC, [talloc >= 2.1.0])
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39802?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia83f360274061463232c1fcd7f6dc6e70f774738
Gerrit-Change-Number: 39802
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: falconia.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39799?usp=email )
Change subject: trau2rtp HR: update to TW-TS-002 version 1.2.0
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39799?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I497ad7b1f0f7229dc9a50cd3cc318e3dc1394171
Gerrit-Change-Number: 39799
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Mon, 17 Mar 2025 09:48:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39797?usp=email )
Change subject: lint/lint_diff: allow skipping with OSMO_LINT=0
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39797?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia4563c13d9916a879a1e8afeacad8c541662adaa
Gerrit-Change-Number: 39797
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Mar 2025 09:41:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/39801?usp=email )
Change subject: configure: set min python version check to 3.5
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
unfortunately it is still failing, I'll look further into it
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39801?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia39e7e04dd8a31efaf87fd1f0fbbfdc5b5fa37c2
Gerrit-Change-Number: 39801
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Mar 2025 09:40:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39801?usp=email )
Change subject: configure: set min python version check to 3.5
......................................................................
configure: set min python version check to 3.5
The osmo-gsm-tester and 201705 jobs, which use the OE poky SDK from 2017
have started failing since the check for python 3.6 was added. This SDK
has version 3.5, so lower the required version check to that for now.
Fixes: 489a6f ("configure.ac: check for Python interpreter unconditionally")
Change-Id: Ia39e7e04dd8a31efaf87fd1f0fbbfdc5b5fa37c2
---
M configure.ac
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/configure.ac b/configure.ac
index 25db55c..80d1b76 100644
--- a/configure.ac
+++ b/configure.ac
@@ -175,7 +175,8 @@
dnl Search for a Python interpreter on the system
dnl python is needed at built-time for auto-generating code
-AM_PATH_PYTHON([3.6])
+dnl Don't require a newer version than 3.5 for now, as poky 201705 ships that
+AM_PATH_PYTHON([3.5])
PKG_CHECK_MODULES(TALLOC, [talloc >= 2.1.0])
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39801?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia39e7e04dd8a31efaf87fd1f0fbbfdc5b5fa37c2
Gerrit-Change-Number: 39801
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39801?usp=email )
Change subject: configure: set min python version check to 3.5
......................................................................
configure: set min python version check to 3.5
The osmo-gsm-tester and 201705 jobs, which use the OE poky SDK from 2017
have started failing since the check for python 3.6 was added. This SDK
has version 3.5, so lower the required version check to that for now.
Fixes: 489a6f ("configure.ac: check for Python interpreter unconditionally")
Change-Id: Ia39e7e04dd8a31efaf87fd1f0fbbfdc5b5fa37c2
---
M configure.ac
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/01/39801/1
diff --git a/configure.ac b/configure.ac
index 25db55c..80d1b76 100644
--- a/configure.ac
+++ b/configure.ac
@@ -175,7 +175,8 @@
dnl Search for a Python interpreter on the system
dnl python is needed at built-time for auto-generating code
-AM_PATH_PYTHON([3.6])
+dnl Don't require a newer version than 3.5 for now, as poky 201705 ships that
+AM_PATH_PYTHON([3.5])
PKG_CHECK_MODULES(TALLOC, [talloc >= 2.1.0])
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39801?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia39e7e04dd8a31efaf87fd1f0fbbfdc5b5fa37c2
Gerrit-Change-Number: 39801
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39797?usp=email )
Change subject: lint/lint_diff: allow skipping with OSMO_LINT=0
......................................................................
Patch Set 2:
(1 comment)
File lint/lint_diff.sh:
https://gerrit.osmocom.org/c/osmo-ci/+/39797/comment/e565997e_c2bf84c6?usp=… :
PS1, Line 8: if [ "$LINT" = 0 ]; then
> maybe adding some OSMO_ prefix would make this a lot less prone to conflict with something else.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39797?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia4563c13d9916a879a1e8afeacad8c541662adaa
Gerrit-Change-Number: 39797
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Mar 2025 07:45:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>