March 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: TW-TS-* support: pass RTP extensions to MGW

by laforge

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39798?usp=email ) Change subject: TW-TS-* support: pass RTP extensions to MGW ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iaa6e4c56313f06b79852c06dcec686f21950e638 Gerrit-Change-Number: 39798 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 17 Mar 2025 11:57:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: lapd: Take talloc msgb ownsership when enqueueing it

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39807?usp=email ) Change subject: lapd: Take talloc msgb ownsership when enqueueing it ...................................................................... lapd: Take talloc msgb ownsership when enqueueing it Otherwise the msg talloc rererence is kept parented at some unknown pointer in some unknown upper layer. Related: OS#6728 Change-Id: I32729060b5a18576310b3789da522f4392d9611e --- M src/isdn/lapd_core.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/07/39807/1 diff --git a/src/isdn/lapd_core.c b/src/isdn/lapd_core.c index b32ed26..b26edfc 100644 --- a/src/isdn/lapd_core.c +++ b/src/isdn/lapd_core.c @@ -1922,6 +1922,8 @@ LOGDL(dl, LOGL_INFO, "writing message to send-queue: l3len: %d\n", msgb_l3len(msg)); + /* Take ownsership of msg, since we are keeping it around in this layer: */ + talloc_steal(tall_lapd_ctx, msg); /* Write data into the send queue */ msgb_enqueue(&dl->send_queue, msg); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I32729060b5a18576310b3789da522f4392d9611e Gerrit-Change-Number: 39807 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: lapdm: Take talloc msgb ownsership when enqueueing it

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39808?usp=email ) Change subject: lapdm: Take talloc msgb ownsership when enqueueing it ...................................................................... lapdm: Take talloc msgb ownsership when enqueueing it Otherwise the msg talloc rererence is kept parented at some unknown pointer in some unknown upper layer. Change-Id: Iba7b11bd9541c883588f34df67fdd865d72710d7 Related: OS#6728 --- M src/gsm/lapdm.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/08/39808/1 diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c index 61ea535..8f7db90 100644 --- a/src/gsm/lapdm.c +++ b/src/gsm/lapdm.c @@ -376,6 +376,8 @@ *msgb_push(msg, 1) = pad; *msgb_push(msg, 1) = link_id; *msgb_push(msg, 1) = chan_nr; + /* Take ownsership of msg, since we are keeping it around in this layer: */ + talloc_steal(tall_lapd_ctx, msg); msgb_enqueue(&dl->dl.tx_queue, msg); return 0; } @@ -403,6 +405,8 @@ *msgb_push(msg, 1) = pad; *msgb_push(msg, 1) = link_id; *msgb_push(msg, 1) = chan_nr; + /* Take ownsership of msg, since we are keeping it around in this layer: */ + talloc_steal(tall_lapd_ctx, msg); msgb_enqueue(&dl->tx_ui_queue, msg); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iba7b11bd9541c883588f34df67fdd865d72710d7 Gerrit-Change-Number: 39808 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[S] Change in libosmo-abis[master]: trau2rtp HR: update to TW-TS-002 version 1.2.0

by laforge

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39799?usp=email ) Change subject: trau2rtp HR: update to TW-TS-002 version 1.2.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39799?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I497ad7b1f0f7229dc9a50cd3cc318e3dc1394171 Gerrit-Change-Number: 39799 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 17 Mar 2025 11:56:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-abis[master]: examples/lapd-over-datagram: Use newer non-deprecated API lapd_instan...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39805?usp=email ) Change subject: examples/lapd-over-datagram: Use newer non-deprecated API lapd_instance_alloc2() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I548343db3bf5d2375ed1c77f3d0474a2d0c80476 Gerrit-Change-Number: 39805 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Mar 2025 11:55:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: cosmetic: lapd: Fix typo in comment

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39806?usp=email ) Change subject: cosmetic: lapd: Fix typo in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ica6df273b95b25d217ff19bb3686ae1990790d94 Gerrit-Change-Number: 39806 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Mar 2025 11:55:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: cosmetic: lapd: Fix typo in comment

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39806?usp=email ) Change subject: cosmetic: lapd: Fix typo in comment ...................................................................... cosmetic: lapd: Fix typo in comment Change-Id: Ica6df273b95b25d217ff19bb3686ae1990790d94 --- M src/gsm/lapdm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/39806/1 diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c index 1fc986d..61ea535 100644 --- a/src/gsm/lapdm.c +++ b/src/gsm/lapdm.c @@ -301,7 +301,7 @@ } } -/* lfush and release all resources in LAPDm channel +/* flush and release all resources in LAPDm channel * * A convenience wrapper calling \ref lapdm_entity_exit on both * entities inside the \ref lapdm_channel -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ica6df273b95b25d217ff19bb3686ae1990790d94 Gerrit-Change-Number: 39806 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-abis[master]: examples/lapd-over-datagram: Use newer non-deprecated API lapd_instan...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39805?usp=email ) Change subject: examples/lapd-over-datagram: Use newer non-deprecated API lapd_instance_alloc2() ...................................................................... examples/lapd-over-datagram: Use newer non-deprecated API lapd_instance_alloc2() libosmocore API lapd_instance_alloc() has been deprecated for a while now. Change-Id: I548343db3bf5d2375ed1c77f3d0474a2d0c80476 --- M doc/examples/lapd-over-datagram/lapd-over-datagram-network.c M doc/examples/lapd-over-datagram/lapd-over-datagram-user.c 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/05/39805/1 diff --git a/doc/examples/lapd-over-datagram/lapd-over-datagram-network.c b/doc/examples/lapd-over-datagram/lapd-over-datagram-network.c index 8915e81..eecba8e 100644 --- a/doc/examples/lapd-over-datagram/lapd-over-datagram-network.c +++ b/doc/examples/lapd-over-datagram/lapd-over-datagram-network.c @@ -151,8 +151,8 @@ osmo_dgram_set_remote_port(conn, 10000); osmo_dgram_set_read_cb(conn, read_cb); - lapd = lapd_instance_alloc(1, lapd_tx_cb, conn, lapd_rx_cb, conn, - &lapd_profile_sat); + lapd = lapd_instance_alloc2(1, lapd_tx_cb, conn, lapd_rx_cb, conn, + &lapd_profile_sat, "lapd_test"); if (lapd == NULL) { LOGP(DLAPDTEST, LOGL_ERROR, "cannot allocate instance\n"); exit(EXIT_FAILURE); diff --git a/doc/examples/lapd-over-datagram/lapd-over-datagram-user.c b/doc/examples/lapd-over-datagram/lapd-over-datagram-user.c index c988b22..5eb58e8 100644 --- a/doc/examples/lapd-over-datagram/lapd-over-datagram-user.c +++ b/doc/examples/lapd-over-datagram/lapd-over-datagram-user.c @@ -201,8 +201,8 @@ * initialize LAPD stuff. */ - lapd = lapd_instance_alloc(0, lapd_tx_cb, NULL, lapd_rx_cb, &num_msgs, - &lapd_profile_sat); + lapd = lapd_instance_alloc2(0, lapd_tx_cb, NULL, lapd_rx_cb, &num_msgs, + &lapd_profile_sat, "lapd_test"); if (lapd == NULL) { LOGP(DLINP, LOGL_ERROR, "cannot allocate instance\n"); exit(EXIT_FAILURE); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I548343db3bf5d2375ed1c77f3d0474a2d0c80476 Gerrit-Change-Number: 39805 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[S] Change in osmo-hlr[master]: src/hlr: reopen DB after changing schema version

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39804?usp=email ) Change subject: src/hlr: reopen DB after changing schema version ...................................................................... src/hlr: reopen DB after changing schema version Close and reopen the DB after changing the version to so it gets written to disk. Otherwise it may be that the DB does not get closed, and when sqlite restores the DB the version can be 0 again, leading to errors when trying to re-apply the schema upgrades Related: SYS#7394 Change-Id: I5943a1cb3447c038c6e7972f68f9656b73a9248b --- M src/db.c M tests/db_upgrade/db_upgrade_test.ok 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/04/39804/1 diff --git a/src/db.c b/src/db.c index 7b8a415..c9f526c 100644 --- a/src/db.c +++ b/src/db.c @@ -595,6 +595,7 @@ int rc; bool has_sqlite_config_sqllog = false; int version; + bool version_changed = false; LOGP(DDB, LOGL_NOTICE, "using database: %s\n", fname); LOGP(DDB, LOGL_INFO, "Compiled against SQLite3 lib version %s\n", SQLITE_VERSION); @@ -672,6 +673,7 @@ goto out_free; } version = CURRENT_SCHEMA_VERSION; + version_changed = true; } LOGP(DDB, LOGL_NOTICE, "Database '%s' has HLR DB schema version %d\n", dbc->fname, version); @@ -686,6 +688,7 @@ } LOGP(DDB, LOGL_NOTICE, "Database '%s' has been upgraded to HLR DB schema version %d\n", dbc->fname, version+1); + version_changed = true; } if (version != CURRENT_SCHEMA_VERSION) { @@ -702,6 +705,17 @@ goto out_free; } + /* Close and reopen the DB after changing the version to so it gets + * written to disk. Otherwise it may be that the DB does not get + * closed, and when sqlite restores the DB the version can be 0 again, + * leading to errors when trying to re-apply the schema upgrades + * (SYS#7394). */ + if (version_changed) { + LOGP(DDB, LOGL_NOTICE, "HLR DB schema version was changed, reopening...\n"); + db_close(dbc); + return db_open(ctx, fname, enable_sqlite_logging, false); + } + /* prepare all SQL statements */ for (i = 0; i < ARRAY_SIZE(dbc->stmt); i++) { rc = sqlite3_prepare_v2(dbc->db, stmt_sql[i], -1, diff --git a/tests/db_upgrade/db_upgrade_test.ok b/tests/db_upgrade/db_upgrade_test.ok index c719498..7248606 100644 --- a/tests/db_upgrade/db_upgrade_test.ok +++ b/tests/db_upgrade/db_upgrade_test.ok @@ -87,6 +87,9 @@ DDB Database <PATH>test.db' has been upgraded to HLR DB schema version 5 DDB Database <PATH>test.db' has been upgraded to HLR DB schema version 6 DDB Database <PATH>test.db' has been upgraded to HLR DB schema version 7 +DDB HLR DB schema version was changed, reopening... +DDB using database: <PATH>test.db +DDB Database <PATH>test.db' has HLR DB schema version 7 DMAIN Cmdline option --db-check: Database was opened successfully, quitting. Resulting db: -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I5943a1cb3447c038c6e7972f68f9656b73a9248b Gerrit-Change-Number: 39804 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: -h output: add more binary repo examples

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39803?usp=email ) Change subject: testenv: -h output: add more binary repo examples ...................................................................... testenv: -h output: add more binary repo examples It wasn't clear how to use the nightly asan repository with testenv. Extend the help output for that. Change-Id: I5e18059f129423eac3374bd6beff32930a0f7c95 --- M _testenv/testenv/__init__.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/_testenv/testenv/__init__.py b/_testenv/testenv/__init__.py index c1991ca..015ef24 100644 --- a/_testenv/testenv/__init__.py +++ b/_testenv/testenv/__init__.py @@ -43,6 +43,8 @@ " ./testenv.py run mgw\n" " ./testenv.py run mgw --test TC_crcx\n" " ./testenv.py run mgw --podman --binary-repo osmocom:latest\n" + " ./testenv.py run mgw --podman --binary-repo osmocom:nightly\n" + " ./testenv.py run mgw --podman --binary-repo osmocom:nightly:asan\n" " ./testenv.py run mgw --io-uring\n" " ./testenv.py run ggsn --config open5gs\n" " ./testenv.py run ggsn --config 'osmo_ggsn_v4_only'\n" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39803?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5e18059f129423eac3374bd6beff32930a0f7c95 Gerrit-Change-Number: 39803 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025