March 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: E1 BTS: direct MGW to 8k subslots for TCH/H

by falconia

Attention is currently required from: dexter, neels. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39752?usp=email ) Change subject: E1 BTS: direct MGW to 8k subslots for TCH/H ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This patch has CR+2 now, but there are two additional reviewers listed who haven't said anything yet. I requested review from @nhofmeyr@sysmocom.de a week ago, and when @pespin@sysmocom.de gave his CR+2, he also added @pmaier@sysmocom.de as a reviewer. I shall wait a few days for @nhofmeyr@sysmocom.de and/or @pmaier@sysmocom.de to weigh in; if I don't hear anything toward the end of this week, I shall assume no objections and merge the current patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39752?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If6141a55434ce08f8fdd1c69b6fc9a97d6c726a7 Gerrit-Change-Number: 39752 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Mar 2025 17:08:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: lapd: Take talloc msgb ownsership when enqueueing it

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39807?usp=email ) Change subject: lapd: Take talloc msgb ownsership when enqueueing it ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I32729060b5a18576310b3789da522f4392d9611e Gerrit-Change-Number: 39807 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 17 Mar 2025 17:07:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-hlr[master]: db: flush after changing schema version

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39804?usp=email ) Change subject: db: flush after changing schema version ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I5943a1cb3447c038c6e7972f68f9656b73a9248b Gerrit-Change-Number: 39804 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Mar 2025 14:53:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[S] Change in libosmo-abis[master]: trau2rtp HR: update to TW-TS-002 version 1.2.0

by falconia

falconia has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39799?usp=email ) Change subject: trau2rtp HR: update to TW-TS-002 version 1.2.0 ...................................................................... trau2rtp HR: update to TW-TS-002 version 1.2.0 osmo_trau2rtp() in HRv1 mode emits either RFC 5993 or TW-TS-002 format, depending on whether or not the latter extended format is enabled. TW-TS-002 can represent BFIs and invalid SID frames, in addition to good speech and valid SID in common with RFC 5993. TW-TS-002 spec has recently been updated to version 1.2.0: https://www.freecalypso.org/specs/tw-ts-002-v010200.txt The principal difference is the way invalid SID frames are represented: in version 1.1.0 all payload bits were stripped in the case of invalid SID; version 1.2.0 allows these payload bits to be preserved if they exist. Section 5.4 in the new spec version provides the detailed rationale for this change. Change osmo_trau2rtp() operating on HR frames in TW-TS-002 mode to emit invalid SID frames in the "verbose" form of TW-TS-002 version 1.2.0. Compatibility considerations: there is no currently released or deployed software that accepts TW-TS-002 version 1.1.0 but not version 1.2.0. More specifically: * osmo_rtp2trau() in TRAU-UL/TFO output mode accepts invalid SID in both short and long forms since first implementation; * Themyscira libgsmhr1, the library that accepts TW-TS-002 RTP input for either full speech decoding or TFO transform, has not yet reached its first release. The current code in Hg implements TW-TS-002 version 1.2.0, thus the library will support both short and long forms of invalid SID upon its upcoming first release. Change-Id: I497ad7b1f0f7229dc9a50cd3cc318e3dc1394171 --- M src/trau/trau_rtp_conv.c M tests/trau_conv/trau2rtp_hr_twts002.ok 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index a36d317..f2e0022 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -294,9 +294,10 @@ if (tf->c_bits[11] && sidc == OSMO_GSM631_SID_CLASS_SPEECH) out[0] = FT_BFI_WITH_DATA << 4; twts002_hr16_set_extra_flags(out, tf); - /* invalid SID frames are truncated in TW-TS-002 */ + /* Invalid SID handling updated in TW-TS-002 version 1.2.0: + * see sections 5.4 and 6.2.3. */ if (sidc == OSMO_GSM631_SID_CLASS_INVALID) - return 1; + out[0] |= 0x04; /* Invalid_SID_Verbose bit */ } /* TS 101 318 Section 5.2: The order of occurrence of the codec parameters in the buffer is @@ -398,12 +399,13 @@ /* can be represented only in TW-TS-002, not in RFC 5993 */ if (!emit_twts002) return 0; - out[0] = FT_INVALID_SID << 4; + out[0] = (FT_INVALID_SID << 4) | 0x04; /* Invalid_SID_Verbose */ twts002_hr8_set_extra_flags(out, tf); /* XC4 is TAF with this frame type */ if (tf->xc_bits[3]) out[0] |= 0x01; - return 1; /* short format per TW-TS-002 */ + osmo_ubit2pbit(out + 1, tf->d_bits, 112); + return GSM_HR_BYTES_RTP_RFC5993; case 6: case 7: /* bad speech frame (BFI=1, SID=0) */ diff --git a/tests/trau_conv/trau2rtp_hr_twts002.ok b/tests/trau_conv/trau2rtp_hr_twts002.ok index db65082..3593eb9 100644 --- a/tests/trau_conv/trau2rtp_hr_twts002.ok +++ b/tests/trau_conv/trau2rtp_hr_twts002.ok @@ -7,7 +7,7 @@ 00C4FF2305E137DF28F928DD5231EB 00CCFF0580FEB85D20AF485C70CFD0 20025FBB32FFFFFFFFFFFFFFFFFFFF -10 +140399BCE3FFFFFFFFFFFFDD7FFAFF 70 70 70 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39799?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I497ad7b1f0f7229dc9a50cd3cc318e3dc1394171 Gerrit-Change-Number: 39799 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-hlr[master]: db: flush after changing schema version

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39804?usp=email ) Change subject: db: flush after changing schema version ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I5943a1cb3447c038c6e7972f68f9656b73a9248b Gerrit-Change-Number: 39804 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 17 Mar 2025 13:46:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: BTS_Tests.cfg: set BTS_Tests.mp_transceiver_num

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39810?usp=email ) Change subject: bts: BTS_Tests.cfg: set BTS_Tests.mp_transceiver_num ...................................................................... bts: BTS_Tests.cfg: set BTS_Tests.mp_transceiver_num At least for osmo-bts-trx, we are running the testsuite with 4 transceivers. This is also required for running the hopping config. Change-Id: I449001f67abe1748f221c1ef9d0212f024f710dd --- M bts/BTS_Tests.cfg 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/bts/BTS_Tests.cfg b/bts/BTS_Tests.cfg index b37bc2f..f9d51eb 100644 --- a/bts/BTS_Tests.cfg +++ b/bts/BTS_Tests.cfg @@ -11,6 +11,7 @@ [TESTPORT_PARAMETERS] [MODULE_PARAMETERS] +BTS_Tests.mp_transceiver_num := 4 L1CTL_PortType.m_l1ctl_sock_path := "/tmp/osmocom_l2" BTS_Tests.mp_pcu_socket := "/tmp/pcu_sock" BTS_Tests.mp_l1_supports_gprs := true -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39810?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I449001f67abe1748f221c1ef9d0212f024f710dd Gerrit-Change-Number: 39810 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bts: BTS_Tests.cfg: remove commented out params

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39809?usp=email ) Change subject: bts: BTS_Tests.cfg: remove commented out params ...................................................................... bts: BTS_Tests.cfg: remove commented out params ... most of them are personal stuff. Change-Id: I892ae9003082da78ba41df55b6fb56ff4aae5526 --- M bts/BTS_Tests.cfg 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/bts/BTS_Tests.cfg b/bts/BTS_Tests.cfg index fb78eba..b37bc2f 100644 --- a/bts/BTS_Tests.cfg +++ b/bts/BTS_Tests.cfg @@ -9,22 +9,10 @@ [LOGGING] [TESTPORT_PARAMETERS] -#*.BTSVTY.CTRL_HOSTNAME := "10.9.1.191" # sysmoBTS Max -#*.BTSVTY.CTRL_HOSTNAME := "10.9.1.162" # sysmoBTS Pau -#*.BTSVTY.CTRL_HOSTNAME := "192.168.100.130" # sysmoBTS home -#*.BTSVTY.CTRL_HOSTNAME := "127.0.0.20" # osmo-bts-trx -#*.BSCVTY.CTRL_HOSTNAME := "127.0.0.11" # osmo-bsc [MODULE_PARAMETERS] L1CTL_PortType.m_l1ctl_sock_path := "/tmp/osmocom_l2" -#BTS_Tests.mp_rsl_ip := "10.9.1.2" # office -#BTS_Tests.mp_rsl_ip := "192.168.100.2" # home -#BTS_Tests.mp_rsl_ip := "127.0.0.10" BTS_Tests.mp_pcu_socket := "/tmp/pcu_sock" -#BTS_Tests.mp_bts_trxc_ip := "127.0.0.21" -#BTS_Tests.mp_ctrl_ip := "127.0.0.20" -#BTS_Tests_OML.mp_oml_ip := "192.168.102.239" # home -#BTS_Tests_OML.mp_oml_port := 3002 BTS_Tests.mp_l1_supports_gprs := true # real BTS / RF @@ -32,8 +20,6 @@ #BTS_Tests.mp_tolerance_rxlev := 10; #BTS_Tests.mp_tolerance_rxqual := 1; -BTS_Tests_OML.mp_pcu_socket := "/tmp/pcu_sock" - [MAIN_CONTROLLER] [EXECUTE] -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I892ae9003082da78ba41df55b6fb56ff4aae5526 Gerrit-Change-Number: 39809 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: BTS_Tests.cfg: set BTS_Tests.mp_transceiver_num

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39810?usp=email ) Change subject: bts: BTS_Tests.cfg: set BTS_Tests.mp_transceiver_num ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39810?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I449001f67abe1748f221c1ef9d0212f024f710dd Gerrit-Change-Number: 39810 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Mar 2025 12:46:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bts: BTS_Tests.cfg: remove commented out params

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39809?usp=email ) Change subject: bts: BTS_Tests.cfg: remove commented out params ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I892ae9003082da78ba41df55b6fb56ff4aae5526 Gerrit-Change-Number: 39809 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Mar 2025 12:45:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: BTS_Tests.cfg: set BTS_Tests.mp_transceiver_num

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39810?usp=email ) Change subject: bts: BTS_Tests.cfg: set BTS_Tests.mp_transceiver_num ...................................................................... bts: BTS_Tests.cfg: set BTS_Tests.mp_transceiver_num At least for osmo-bts-trx, we are running the testsuite with 4 transceivers. This is also required for running the hopping config. Change-Id: I449001f67abe1748f221c1ef9d0212f024f710dd --- M bts/BTS_Tests.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/10/39810/1 diff --git a/bts/BTS_Tests.cfg b/bts/BTS_Tests.cfg index b37bc2f..f9d51eb 100644 --- a/bts/BTS_Tests.cfg +++ b/bts/BTS_Tests.cfg @@ -11,6 +11,7 @@ [TESTPORT_PARAMETERS] [MODULE_PARAMETERS] +BTS_Tests.mp_transceiver_num := 4 L1CTL_PortType.m_l1ctl_sock_path := "/tmp/osmocom_l2" BTS_Tests.mp_pcu_socket := "/tmp/pcu_sock" BTS_Tests.mp_l1_supports_gprs := true -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39810?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I449001f67abe1748f221c1ef9d0212f024f710dd Gerrit-Change-Number: 39810 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025