Attention is currently required from: osmith.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39786?usp=email )
Change subject: gcc/Makefile: fail early if xxd is not installed
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39786?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I6a3e7021929ba58c14f1ffced5702d2dfa839ebe
Gerrit-Change-Number: 39786
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Mar 2025 09:40:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39787?usp=email )
Change subject: contrib/jenkins: fix upload
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
CI is expected to fail until https://gerrit.osmocom.org/c/docker-playground/+/39784 is merged.
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39787?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I767d3b99840eba5e1b395079c878dcbae78b08a0
Gerrit-Change-Number: 39787
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 14 Mar 2025 09:38:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39786?usp=email )
Change subject: gcc/Makefile: fail early if xxd is not installed
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
CI is expected to fail until https://gerrit.osmocom.org/c/docker-playground/+/39784 is merged
```
Makefile:17: *** missing required program "xxd". Stop.
```
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39786?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I6a3e7021929ba58c14f1ffced5702d2dfa839ebe
Gerrit-Change-Number: 39786
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 14 Mar 2025 09:38:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39785?usp=email )
Change subject: gcc/Makefile: set shell: bash -o pipefail -e
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
CI is expected to fail until https://gerrit.osmocom.org/c/docker-playground/+/39784 is merged
```
/bin/bash: line 13: xxd: command not found
/bin/bash: line 13: xxd: command not found
/bin/bash: line 13: xxd: command not found
make: *** [Makefile:119: dfu-merge] Error 127
```
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39785?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I9459f63828eab461607fa9f226716d32ae898549
Gerrit-Change-Number: 39785
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 14 Mar 2025 09:37:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria, laforge.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/39776?usp=email )
Change subject: configure.ac: check for Python interpreter unconditionally
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
Looked at the Makefiles, it really seems not possible to build it without python. It is not listed as dependency in the OE build, but I guess there python from the host just gets used implicitly (which is needed for OE itself IIRC).
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39776?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib19c4c4bb2b8dd12805ce470896ec5d82c72b064
Gerrit-Change-Number: 39776
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Mar 2025 09:36:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes