March 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-asf4-dfu[master]: ver in usb prod desc

by laforge

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39438?usp=email ) Change subject: ver in usb prod desc ...................................................................... Abandoned became part of I39eae7aaafd5531db6ce48837c9499432caadbed -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39438?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I1f183695a3e458db2668e9950f859c936a821dc8 Gerrit-Change-Number: 39438 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-asf4-dfu[master]: gcc/Makefile: fail early if xxd is not installed

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39786?usp=email ) Change subject: gcc/Makefile: fail early if xxd is not installed ...................................................................... gcc/Makefile: fail early if xxd is not installed Since aaec8734 ("add fw update crcstub") the xxd program is required for running the Makefile. Change-Id: I6a3e7021929ba58c14f1ffced5702d2dfa839ebe --- M gcc/Makefile 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/86/39786/1 diff --git a/gcc/Makefile b/gcc/Makefile index b5d3cf0..27a9143 100644 --- a/gcc/Makefile +++ b/gcc/Makefile @@ -13,6 +13,10 @@ MK_DIR = mkdir -p +ifeq (, $(shell which xxd)) +$(error missing required program "xxd") +endif + OBJS += \ hal/src/hal_io.o \ hpl/core/hpl_core_m4.o \ -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I6a3e7021929ba58c14f1ffced5702d2dfa839ebe Gerrit-Change-Number: 39786 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-asf4-dfu[master]: gcc/Makefile: set shell: bash -o pipefail -e

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39785?usp=email ) Change subject: gcc/Makefile: set shell: bash -o pipefail -e ...................................................................... gcc/Makefile: set shell: bash -o pipefail -e Don't ignore errors from commands piped into others, like in this line in the Makefile that has been added in aaec8734 ("add fw update crcstub"): printf $$CRC_HEX | xxd -r -p | xxd -e | xxd -r | dd of=$(OUTPUT_FILE_NAME)-dfu.bin bs=1 seek=$$CRC_CHECKSUM_OFFSET conv=notrunc 2>/dev/null; \ Change-Id: I9459f63828eab461607fa9f226716d32ae898549 --- M gcc/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/85/39785/1 diff --git a/gcc/Makefile b/gcc/Makefile index 7813750..b5d3cf0 100644 --- a/gcc/Makefile +++ b/gcc/Makefile @@ -1,5 +1,5 @@ # possible values: SAME54_XPLAINED_PRO, SYSMOOCTSIM -SHELL := /bin/bash +SHELL := /bin/bash -o pipefail -e BOARD ?= SYSMOOCTSIM CROSSCC ?= arm-none-eabi- SILENT ?= @ -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I9459f63828eab461607fa9f226716d32ae898549 Gerrit-Change-Number: 39785 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-asf4-dfu[master]: contrib/jenkins: fix upload

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39787?usp=email ) Change subject: contrib/jenkins: fix upload ...................................................................... contrib/jenkins: fix upload Bring back the bootloader-sysmooctsim.{bin,elf} symlinks, so the upload to "latest" does not fail with: rsync: [sender] link_stat "/build/gcc/bootloader-sysmooctsim.bin" failed: No such file or directory (2) rsync: [sender] link_stat "/build/gcc/bootloader-sysmooctsim.elf" failed: No such file or directory (2) Adjust the pattern for uploading to "all" to only match the -dfu files, not the new -flash files as discussed with Eric. Fixes: 412731 ("bl updater app") Change-Id: I767d3b99840eba5e1b395079c878dcbae78b08a0 --- M contrib/jenkins.sh M gcc/Makefile 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/87/39787/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index e9296c6..86794ed 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -43,7 +43,7 @@ $TOPDIR/gcc/bootloader-sysmooctsim.{bin,elf} \ binaries@ftp.osmocom.org:web-files/osmo-asf4-dfu/latest/ rsync --archive --verbose --compress --rsh "$SSH_COMMAND" \ - $TOPDIR/gcc/bootloader-*-*.{bin,elf} \ + $TOPDIR/gcc/bootloader-*-*-dfu.{bin,elf} \ binaries@ftp.osmocom.org:web-files/osmo-asf4-dfu/all/ fi #--exclude $TOPDIR/sysmoOCTSIM/gcc/bootloader-sysmooctsim.bin \ diff --git a/gcc/Makefile b/gcc/Makefile index 27a9143..31cdbad 100644 --- a/gcc/Makefile +++ b/gcc/Makefile @@ -140,6 +140,8 @@ xxd -s $$(($$CRC_START_ADDR - $$FLASH_START_ADDR -4)) -l 4 -g 1 section_text.bin; \ "$(CROSSCC)objcopy" --update-section .text=section_text.bin $(OUTPUT_FILE_NAME)-dfu.elf; + ln -sf $(OUTPUT_FILE_NAME)-dfu.bin bootloader-$(BOARD_LC).bin + ln -sf $(OUTPUT_FILE_NAME)-dfu.elf bootloader-$(BOARD_LC).elf # Compiler targets %.o: %.c -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I767d3b99840eba5e1b395079c878dcbae78b08a0 Gerrit-Change-Number: 39787 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in docker-playground[master]: debian-bookworm-build: add xxd

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/39784?usp=email ) Change subject: debian-bookworm-build: add xxd ...................................................................... debian-bookworm-build: add xxd The xxd program is now required for building osmo-asf4-dfu. Related: osmo-asf4-dfu I1403d35497cdea41ea5bed2c94b9e729ca352772 Change-Id: I8064c6a24ad7dfc0a6c83c1ff5bcb7b47fdd66f4 --- M debian-bookworm-build/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/84/39784/1 diff --git a/debian-bookworm-build/Dockerfile b/debian-bookworm-build/Dockerfile index 8fbc9d3..6755dcf 100644 --- a/debian-bookworm-build/Dockerfile +++ b/debian-bookworm-build/Dockerfile @@ -167,6 +167,7 @@ unzip \ virtualenv \ xsltproc \ + xxd \ && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8064c6a24ad7dfc0a6c83c1ff5bcb7b47fdd66f4 Gerrit-Change-Number: 39784 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: configure.ac: check for Python interpreter unconditionally

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/39776?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: configure.ac: check for Python interpreter unconditionally ...................................................................... configure.ac: check for Python interpreter unconditionally Python is required at built-time for auto-generating code. Change-Id: Ib19c4c4bb2b8dd12805ce470896ec5d82c72b064 Fixes: OS#4885 --- M configure.ac 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/39776/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib19c4c4bb2b8dd12805ce470896ec5d82c72b064 Gerrit-Change-Number: 39776 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[S] Change in libosmo-gprs[master]: csn1: Use enum to select enc/dec direction

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39783?usp=email ) Change subject: csn1: Use enum to select enc/dec direction ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I216d4d94f585dd4dcf9947324fdbdc786ab2b5c5 Gerrit-Change-Number: 39783 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Mar 2025 09:07:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in pysim[master]: [1/6] personalization: refactor: drop ClassVarMeta use

by fixeria

Attention is currently required from: laforge, neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39741?usp=email ) Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > Name: […] So many letters here... is it a comment by Mychaela? Oh, no, it's Neels! Just a few cents from me: if properly implemented, a metaclass allows you to pass variables in both ways: ``` # like this class Foo(metaclass=MetaFoo, a=1, b=2): ''' ... ''' # and like this # like this class Foo(metaclass=MetaFoo): a = 1 b = 2 # or both at the same time class Foo(metaclass=MetaFoo, a=1): b = 2 ``` This can be achieved as follows: ``` class MetaFoo(abc.ABCMeta): def __new__(mcs, name, bases, namespace, **kwargs): x = super().__new__(mcs, name, bases, namespace) x.a = namespace.get('a', kwargs.get('a', None)) x.b = namespace.get('b', kwargs.get('b', None)) return x ``` A good example is `ApduCommandMeta`. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051 Gerrit-Change-Number: 39741 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 14 Mar 2025 08:53:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: [6/6] personalization: refactor SdKey

by neels

Attention is currently required from: dexter. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39747?usp=email ) Change subject: [6/6] personalization: refactor SdKey ...................................................................... Patch Set 3: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39747/comment/ccd47056_e6bd6df5?usp=em… : PS3, Line 296: def _apply_sd(cls, pe: ProfileElement, value): > If you want to make this method more private you can apply __ underscores instead of one _. […] erm gerrit is formatting this comment so that i can only guess. Can you encaps your underscores in backticks like ~~~ `__` ~~~ Did you mean double underscores? If yes, then no. Double underscores are reserved for python interpreter internals! We may override doublescored functions and mess with python internals, but we should not make up new names with double underscores. The standard way of marking a private function is a single underscore at the start. It's not enforced, of course, because how could you enforce ANYTHING in python, we can even override `__getattr__()` and get a dir() of absolutely everything. Hope i did understand correctly! -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39747?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I427ea851bfa28b2b045e70a19a9e35d361f0d393 Gerrit-Change-Number: 39747 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Mar 2025 22:23:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[M] Change in pysim[master]: [5/6] personalization: refactor AlgorithmID, K, Opc

by neels

Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39745?usp=email ) Change subject: [5/6] personalization: refactor AlgorithmID, K, Opc ...................................................................... Patch Set 3: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39745/comment/07a3a3bc_9b3ff747?usp=em… : PS3, Line 551: allow_len = int(128/8) # length in bytes (from BinaryParam) > ist that universally true? I think for MILENAGE yes, but for TUAK it can have different length? You mean the length of 128 bit? I have no idea!! Will have to check, thanks! Let me know if you already have a spec reference... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6296fdcfd5d2ed313c4aade57ff43cc362375848 Gerrit-Change-Number: 39745 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 13 Mar 2025 22:14:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025