laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41528?usp=email )
Change subject: contrib/saip-tool: Use repr() on security domain keys
......................................................................
contrib/saip-tool: Use repr() on security domain keys
Let's not reinvent the wheel of printing such data structures and use
the repr method provided by the respective class instead. This also
adds the missing key_usage_qualifier information to the print-out,
as well as the mac_len of the key components.
Change-Id: Iaead4a02f07130fd00bcecc43e1c843f1c221e63
---
M contrib/saip-tool.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
dexter: Looks good to me, approved; Verified
diff --git a/contrib/saip-tool.py b/contrib/saip-tool.py
index fd6d373..71113d3 100755
--- a/contrib/saip-tool.py
+++ b/contrib/saip-tool.py
@@ -329,7 +329,7 @@
print("Security domain Instance AID: %s" % b2h(sd.decoded['instance']['instanceAID']))
# FIXME: 'applicationSpecificParametersC9' parsing to figure out enabled SCP
for key in sd.keys:
- print("\tKVN=0x%02x, KID=0x%02x, %s" % (key.key_version_number, key.key_identifier, key.key_components))
+ print("\t%s" % repr(key))
# RFM
print()
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41528?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iaead4a02f07130fd00bcecc43e1c843f1c221e63
Gerrit-Change-Number: 41528
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Attention is currently required from: laforge, lynxis lazus.
dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41579?usp=email )
Change subject: pySim.runtime: Fix file selection by upper case hex FID
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
As far as I can see this patch looks good. I have left one comment with an idea to make this approach more general.
File pySim/runtime.py:
https://gerrit.osmocom.org/c/pysim/+/41579/comment/255ce142_ced8e17d?usp=em… :
PS1, Line 488: name = name.lower()
I think this is ok. I see lines like this in select also. However, it might be worth checking if is possible to generalize this with a method or function that just gets us the file object either by name or by FID. This function would then accept case insensitive FIDs and case sensitive file names.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41579?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idd0db1f4bbd3ee9eec20f5fd0f4371c2882950cd
Gerrit-Change-Number: 41579
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:59:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/meta-telephony/+/41638?usp=email )
Change subject: Update osmo-sgsn and libosmo-sigtran to last patch releases
......................................................................
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/41638?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: I6a55fa1d29c6cbb67d4da55863db3d6bfc161d55
Gerrit-Change-Number: 41638
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:54:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/meta-telephony/+/41638?usp=email )
Change subject: Update osmo-sgsn and libosmo-sigtran to last patch releases
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/41638?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: I6a55fa1d29c6cbb67d4da55863db3d6bfc161d55
Gerrit-Change-Number: 41638
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:53:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: falconia, neels.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41630?usp=email )
Change subject: MGW control: migrate to new API for codecs and payload types
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I think this might benefit from a TODO-RELEASE entry specifying explicitly that a new/future tagged […]
ACK
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41630?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iafc38a3da64ce7c2f060a32864174dcde9f57b56
Gerrit-Change-Number: 41630
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:37:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: laforge.
dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41528?usp=email )
Change subject: contrib/saip-tool: Use repr() on security domain keys
......................................................................
Patch Set 1: Code-Review+2 Verified+1
(1 comment)
Patchset:
PS1:
I have given this a quick test. The output looks fine. I think we can merge this.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41528?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iaead4a02f07130fd00bcecc43e1c843f1c221e63
Gerrit-Change-Number: 41528
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:35:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge.
dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41527?usp=email )
Change subject: pySim.esim.saip: Hex representation of SecurityDomainKey
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
As far as I can see the patch is correct. However, I didn't test it though but the code looks correct.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41527?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic9a92d53d73378eafca1760dd8351215bce1157a
Gerrit-Change-Number: 41527
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:26:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes