Attention is currently required from: laforge, lynxis lazus. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41579?usp=email ) Change subject: pySim.runtime: Fix file selection by upper case hex FID ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: As far as I can see this patch looks good. I have left one comment with an idea to make this approach more general. File pySim/runtime.py: https://gerrit.osmocom.org/c/pysim/+/41579/comment/255ce142_ced8e17d?usp=ema... : PS1, Line 488: name = name.lower() I think this is ok. I see lines like this in select also. However, it might be worth checking if is possible to generalize this with a method or function that just gets us the file object either by name or by FID. This function would then accept case insensitive FIDs and case sensitive file names. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idd0db1f4bbd3ee9eec20f5fd0f4371c2882950cd Gerrit-Change-Number: 41579 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Tue, 09 Dec 2025 14:59:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes