Attention is currently required from: laforge, lynxis lazus.

Patch set 1:Code-Review +1

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    As far as I can see this patch looks good. I have left one comment with an idea to make this approach more general.

• File pySim/runtime.py:

  • Patch Set #1, Line 488: name = name.lower()

    I think this is ok. I see lines like this in select also. However, it might be worth checking if is possible to generalize this with a method or function that just gets us the file object either by name or by FID. This function would then accept case insensitive FIDs and case sensitive file names.

To view, visit change 41579. To unsubscribe, or for help writing mail filters, visit settings.