laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41528?usp=email ) Change subject: contrib/saip-tool: Use repr() on security domain keys ...................................................................... contrib/saip-tool: Use repr() on security domain keys Let's not reinvent the wheel of printing such data structures and use the repr method provided by the respective class instead. This also adds the missing key_usage_qualifier information to the print-out, as well as the mac_len of the key components. Change-Id: Iaead4a02f07130fd00bcecc43e1c843f1c221e63 --- M contrib/saip-tool.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved; Verified diff --git a/contrib/saip-tool.py b/contrib/saip-tool.py index fd6d373..71113d3 100755 --- a/contrib/saip-tool.py +++ b/contrib/saip-tool.py @@ -329,7 +329,7 @@ print("Security domain Instance AID: %s" % b2h(sd.decoded['instance']['instanceAID'])) # FIXME: 'applicationSpecificParametersC9' parsing to figure out enabled SCP for key in sd.keys: - print("\tKVN=0x%02x, KID=0x%02x, %s" % (key.key_version_number, key.key_identifier, key.key_components)) + print("\t%s" % repr(key)) # RFM print() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41528?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iaead4a02f07130fd00bcecc43e1c843f1c221e63 Gerrit-Change-Number: 41528 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org>