December 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: gsm/protocol/gsm_48_103.h: add definition for TW-TS-007
by laforge 09 Dec '25

09 Dec '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41633?usp=email ) Change subject: gsm/protocol/gsm_48_103.h: add definition for TW-TS-007 ...................................................................... gsm/protocol/gsm_48_103.h: add definition for TW-TS-007 TW-TS-007 is a Themyscira/Osmocom extension to AoIP interface that provides a much more compact payload format for CSD, matching the size of compressed speech payloads. Clause 9 in this spec fixes the payload type on AoIP interface for this pseudo-codec as 127, distinguishing it from CLEARMODE and from all speech codecs. Osmocom applications that may need payload type numbers for the standard set of codecs defined in TS 48.103 may also need the payload type for TW-TS-007 if they implement this extension, as this payload format is intended to "stand on equal footing" with standard AoIP payload types. Therefore, add it to the same header file. Change-Id: I74c9e76ebcce32ad20501134ec5089794acb4f62 --- M include/osmocom/gsm/protocol/gsm_48_103.h 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/gsm/protocol/gsm_48_103.h b/include/osmocom/gsm/protocol/gsm_48_103.h index d40acac..6fe461b 100644 --- a/include/osmocom/gsm/protocol/gsm_48_103.h +++ b/include/osmocom/gsm/protocol/gsm_48_103.h @@ -19,3 +19,6 @@ /* circuit-switched data */ #define OSMO_AOIP_RTP_PT_CSD 120 /* without redundancy */ #define OSMO_AOIP_RTP_PT_CSD_RED 121 /* with redundancy */ + +/* Osmocom and Themyscira extensions */ +#define OSMO_AOIP_RTP_PT_TWTS007 127 /* compressed form of CSD */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41633?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I74c9e76ebcce32ad20501134ec5089794acb4f62 Gerrit-Change-Number: 41633 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsm/protocol/gsm_48_103.h: add definition for TW-TS-007
by laforge 09 Dec '25

09 Dec '25

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/41633?usp=email ) Change subject: gsm/protocol/gsm_48_103.h: add definition for TW-TS-007 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41633?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I74c9e76ebcce32ad20501134ec5089794acb4f62 Gerrit-Change-Number: 41633 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 09 Dec 2025 14:18:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: E1: add support for AMR in TW-TS-006 enhanced RTP format
by laforge 09 Dec '25

09 Dec '25

Attention is currently required from: falconia, neels. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41632?usp=email ) Change subject: E1: add support for AMR in TW-TS-006 enhanced RTP format ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41632?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icf859ca4975079c91a2f41190da0ce94aa686365 Gerrit-Change-Number: 41632 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Dec 2025 14:18:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: MGW control: migrate to new API for fmtp
by laforge 09 Dec '25

09 Dec '25

Attention is currently required from: falconia, neels. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41631?usp=email ) Change subject: MGW control: migrate to new API for fmtp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41631?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id869c9fa33a3ca6fecd30d5630741fbbf21cf6ed Gerrit-Change-Number: 41631 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Dec 2025 14:17:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: MGW control: migrate to new API for codecs and payload types
by laforge 09 Dec '25

09 Dec '25

Attention is currently required from: falconia, neels. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41630?usp=email ) Change subject: MGW control: migrate to new API for codecs and payload types ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I think this might benefit from a TODO-RELEASE entry specifying explicitly that a new/future tagged libosmo-mgcp-client is needed? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41630?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iafc38a3da64ce7c2f060a32864174dcde9f57b56 Gerrit-Change-Number: 41630 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Dec 2025 14:17:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-mgw[master]: mgcp_client: add fmtp string to struct ptmap
by laforge 09 Dec '25

09 Dec '25

Attention is currently required from: falconia, neels. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/41629?usp=email ) Change subject: mgcp_client: add fmtp string to struct ptmap ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41629?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I84ba2ed5ab9d379ac0b675520796446ad6ee0710 Gerrit-Change-Number: 41629 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Dec 2025 14:16:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-epdg[master]: s2b: allow to set the restart counter/recovery field
by laforge 09 Dec '25

09 Dec '25

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email ) Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > I'm not following here. […] I agree with pespin. If the counter is only 8-bit wide, the probability of accidentially using the same "random" counter value than before is rather low. If it was 32bit or more, I think ok, one can get away with the "random" value... but not at 8 bit. Whats' wrong with the osmo-ggsn approach of having a file in the filesystem storing a single integer, which gets incremented on every program start? Doesn't sound overly complex to me? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Dec 2025 14:14:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: ts_102_221: EF.ARR: fix read_arr_record
by laforge 09 Dec '25

09 Dec '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41580?usp=email ) Change subject: ts_102_221: EF.ARR: fix read_arr_record ...................................................................... ts_102_221: EF.ARR: fix read_arr_record `read_arr_record 1` failed with an AttributeError exception because RECORD_NR must be all caps. Change-Id: If44f9f2271293d3063f6c527e5a68dcfaeb5942e --- M pySim/ts_102_221.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index d97b3cf..e38483d 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -750,7 +750,7 @@ @cmd2.with_argparser(LinFixedEF.ShellCommands.read_rec_dec_parser) def do_read_arr_record(self, opts): """Read one EF.ARR record in flattened, human-friendly form.""" - (data, _sw) = self._cmd.lchan.read_record_dec(opts.record_nr) + (data, _sw) = self._cmd.lchan.read_record_dec(opts.RECORD_NR) data = self._cmd.lchan.selected_file.flatten(data) self._cmd.poutput_json(data, opts.oneline) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41580?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If44f9f2271293d3063f6c527e5a68dcfaeb5942e Gerrit-Change-Number: 41580 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: ts_102_221: EF.ARR: fix read_arr_record
by laforge 09 Dec '25

09 Dec '25

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/41580?usp=email ) Change subject: ts_102_221: EF.ARR: fix read_arr_record ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41580?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If44f9f2271293d3063f6c527e5a68dcfaeb5942e Gerrit-Change-Number: 41580 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Dec 2025 14:11:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: ts_31_102: EF SUCI_Calc_Info: fix decoding empty files
by laforge 09 Dec '25

09 Dec '25

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/41581?usp=email ) Change subject: ts_31_102: EF SUCI_Calc_Info: fix decoding empty files ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File pySim/ts_31_102.py: https://gerrit.osmocom.org/c/pysim/+/41581/comment/665b251f_da76d648?usp=em… : PS1, Line 392: hnet_pubkey_list = self._compact_pubkey_list(hpkl.to_dict()['hnet_pubkey_list']) wouldn't something more compact work without interrupting the cotrol flow of the source / indent / ...? ``` hnet_pubkey_list = self._compact_pubkey_list(hpkl.to_dict()['hnet_pubkey_list'] or []) ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41581?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib8e322e65dd768bfd49e7a5620a2163f12a74ec7 Gerrit-Change-Number: 41581 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Dec 2025 14:11:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0