Attention is currently required from: falconia, pespin.
fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email )
Change subject: add vty setting for ThemWi RTP formats
......................................................................
Patch Set 6:
(1 comment)
File src/libmsc/msc_vty.c:
https://gerrit.osmocom.org/c/osmo-msc/+/41698/comment/5df4a316_98bf05ba?usp… :
PS5, Line 694: "tw-rtp-formats (fr|hr|amr|csd) [(fr|hr|amr|csd)] [(fr|hr|amr|csd)] [(fr|hr|amr|csd)]",
> You can put "(fr|hr|amr|csd)" in a define above and use it here 4 times.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14
Gerrit-Change-Number: 41698
Gerrit-PatchSet: 6
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Dec 2025 18:55:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: falconia, fixeria.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: add vty setting for ThemWi RTP formats
......................................................................
add vty setting for ThemWi RTP formats
For every GSM speech codec and for CSD, Osmocom BSS supports both
the standard RTP format prescribed by 3GPP and an alternative enhanced
RTP format invented by Themyscira Wireless: TW-TS-001, TW-TS-002,
TW-TS-006 and TW-TS-007. In order to enable these enhanced RTP
formats, the MSC needs to include an extension IE in the Assignment
Request it sends to the BSS. Until now there was no way to do so
in mainline OsmoMSC, only via local code patches - fix this omission.
The following considerations apply to this new tw-rtp-formats
vty setting:
* When internal MNCC is used, it is beneficial to enable enhanced TW
RTP formats, especially when using E1 BTS with tw-e1abis-mgw:
the DL call leg receives more complete information content from
the UL call leg in each direction.
* When external MNCC is used with non-ThemWi CN software (e.g., with
a PBX via osmo-sip-connector), tw-rtp-formats should NOT be
enabled - off-the-shelf PBX etc software won't understand them.
* Future patches will allow osmo-msc to operate with a ThemWi
transcoding MGW (TC to G.711) in the place of non-TC osmo-mgw;
in that configuration TW RTP formats will become mandatory,
as they are strictly required by ThemWi TC implementation.
Depends: I4c184db53bec28ab42bcd45e033733d850eea5d2 (libosmocore.git)
Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14
---
M TODO-RELEASE
M include/osmocom/msc/gsm_data.h
M include/osmocom/msc/ran_msg.h
M src/libmsc/msc_a.c
M src/libmsc/msc_vty.c
M src/libmsc/ran_msg_a.c
M tests/test_nodes.vty
7 files changed, 78 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/98/41698/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14
Gerrit-Change-Number: 41698
Gerrit-PatchSet: 6
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: daniel, dexter, laforge.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email )
Change subject: card_key_provider: add PostgreSQL support
......................................................................
Patch Set 5:
(3 comments)
File contrib/csv-to-pgsql.py:
https://gerrit.osmocom.org/c/pysim/+/41508/comment/2a3b526c_05475850?usp=em… :
PS5, Line 38: table_name
Maybe do the `self.table = lower(table_name)` here to avoid doing this in each query?
https://gerrit.osmocom.org/c/pysim/+/41508/comment/f78ee9bd_3c7e041e?usp=em… :
PS5, Line 132: %s;", (self.table.lower(),))
Why not using `SQL("...").format(...)` here like you do above?
File setup.py:
https://gerrit.osmocom.org/c/pysim/+/41508/comment/3e9c6337_a820596a?usp=em… :
PS4, Line 37: psycopg2-binary
> What if we leave it out and mention it in the manual that it is needed
when someone wants to use the CardKeyProviderPgsql? Would that be an option?
This is indeed an option. Also, we do have `extras_require` below - this is where you can specify optional dependencies. You would also need to take care of importing the `psycopg2` not globally, but in a specific place (e.g. during the class instance instantiation).
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3
Gerrit-Change-Number: 41508
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Dec 2025 18:51:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: falconia, fixeria.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email )
Change subject: add vty setting for ThemWi RTP formats
......................................................................
Patch Set 5:
(2 comments)
File TODO-RELEASE:
https://gerrit.osmocom.org/c/osmo-msc/+/41698/comment/8d1ddf0d_1107615a?usp… :
PS5, Line 10: vty >1.12.0 working optional-multi-choice
libosmovty
You can use ">=1.12.1" here, since it's more precise and I already did a patch release today with it.
File src/libmsc/msc_vty.c:
https://gerrit.osmocom.org/c/osmo-msc/+/41698/comment/471d19fc_3f03baff?usp… :
PS5, Line 694: "tw-rtp-formats (fr|hr|amr|csd) [(fr|hr|amr|csd)] [(fr|hr|amr|csd)] [(fr|hr|amr|csd)]",
You can put "(fr|hr|amr|csd)" in a define above and use it here 4 times.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14
Gerrit-Change-Number: 41698
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Dec 2025 17:50:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41725?usp=email )
Change subject: BSSAP(_LE)/RANAP: Proper counting of RESET retries
......................................................................
BSSAP(_LE)/RANAP: Proper counting of RESET retries
N retries means N+1 attempts.
Since M3UA_Emulation (in deps/, not in library) doesn't support pushing
DUNA/DAVA as primitive up the stack, we cannot implement the related
SCCP primitives which should end up sending in turn other primitives to
our BSSAP(_LE)/RANAP emulations.
This means we currently have no way to figure out the status of the
underlying SCCP/MTP link, and our only way is implement a poor man's
solution: retransmit RESET until we get an answer.
Since before bssap_reset_retries was set to 1 everywhere and we were
only attempting once, it could happen that the other end (the IUT) was
not yet connected to the STP when we send the RESET, and hence it is
discarded the STP. In that scenario, we'd time out and fail the test.
Instead, now that we do N+1 attempts, we retry after 5 seconds, which
should be enough time for the peer to reconnect to the STP.
Change-Id: If02e424672ff6270aed323c3bb236e822d8a39a4
---
M library/BSSAP_LE_Emulation.ttcn
M library/RAN_Emulation.ttcnpp
2 files changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/41725/1
diff --git a/library/BSSAP_LE_Emulation.ttcn b/library/BSSAP_LE_Emulation.ttcn
index 44afc89..bd9c50c 100644
--- a/library/BSSAP_LE_Emulation.ttcn
+++ b/library/BSSAP_LE_Emulation.ttcn
@@ -310,7 +310,7 @@
private function f_bssap_le_reset(SCCP_PAR_Address peer, SCCP_PAR_Address own) runs on BSSAP_LE_Emulation_CT {
timer T := 5.0;
- var integer attempts := g_ran_ops.bssap_le_reset_retries;
+ var integer attempts := g_ran_ops.bssap_le_reset_retries + 1;
while (attempts > 0) {
attempts := attempts - 1;
@@ -514,7 +514,6 @@
f_expect_table_init();
if (isvalue(ops.sccp_addr_peer) and isvalue(ops.sccp_addr_local)) {
- f_sleep(1.0); /* HACK to wait for M3UA/ASP to be ACTIVE */
f_bssap_le_reset(ops.sccp_addr_peer, ops.sccp_addr_local);
}
diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp
index 563fa0c..8125569 100644
--- a/library/RAN_Emulation.ttcnpp
+++ b/library/RAN_Emulation.ttcnpp
@@ -592,7 +592,7 @@
function f_bssap_reset(SCCP_PAR_Address peer, SCCP_PAR_Address own) runs on RAN_Emulation_CT {
timer T := 5.0;
var boolean append_osmux_support := append_osmux_ie();
- var integer attempts := g_ran_ops.bssap_reset_retries;
+ var integer attempts := g_ran_ops.bssap_reset_retries + 1;
while (attempts > 0) {
attempts := attempts - 1;
@@ -799,7 +799,7 @@
SCCP_PAR_Address own,
template (omit) GlobalRNC_ID grnc_id := omit) runs on RAN_Emulation_CT {
timer T := 5.0;
- var integer attempts := g_ran_ops.bssap_reset_retries;
+ var integer attempts := g_ran_ops.bssap_reset_retries + 1;
var CN_DomainIndicator dom;
if (g_ran_ops.ps_domain) {
@@ -1346,7 +1346,6 @@
f_expect_table_init();
if (isvalue(ops.sccp_addr_peer) and isvalue(ops.sccp_addr_local)) {
- f_sleep(1.0); /* HACK to wait for M3UA/ASP to be ACTIVE */
select (g_ran_ops.protocol) {
#ifdef RAN_EMULATION_BSSAP
case (RAN_PROTOCOL_BSSAP) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41725?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If02e424672ff6270aed323c3bb236e822d8a39a4
Gerrit-Change-Number: 41725
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>