December 2025 - gerrit-log - lists.osmocom.org

[M] Change in docker-playground[master]: ttcn3-bts-test: run bpftrace scripts
by osmith 18 Dec '25

18 Dec '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/41720?usp=email ) Change subject: ttcn3-bts-test: run bpftrace scripts ...................................................................... ttcn3-bts-test: run bpftrace scripts Add logic to run bpftrace scripts attached to osmo-bts-* while the testsuite runs. The initial script is from Vadim: https://gitea.osmocom.org/osmocom/bpftrace-scripts/src/branch/master/udp_se… Change-Id: I5c22cdbb08fe797be936ca174f65ade626fa4895 --- M README.md M osmo-bts-latest/Dockerfile M osmo-bts-master/Dockerfile A ttcn3-bts-test/bpftrace/udp_sendmsg_delay.bt M ttcn3-bts-test/jenkins.sh 5 files changed, 82 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/20/41720/1 diff --git a/README.md b/README.md index eeb9272..3f55e3e 100644 --- a/README.md +++ b/README.md @@ -39,6 +39,7 @@ * `TEST_CONFIGS`: for tests that can run with multiple config sets (e.g. `ttcn3-bts-test`), run only some of them. See `TEST_CONFIGS_ALL` in the `jenkins.sh` for possible values. +* `RUN_BPFTRACE`: when set to `1`, run bpftrace scripts in `ttcn3-bts-test`. ### Run only one test diff --git a/osmo-bts-latest/Dockerfile b/osmo-bts-latest/Dockerfile index ad79cb3..6449829 100644 --- a/osmo-bts-latest/Dockerfile +++ b/osmo-bts-latest/Dockerfile @@ -9,6 +9,7 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ + bpftrace \ osmo-bts-trx \ osmo-bts-virtual && \ apt-get clean \ diff --git a/osmo-bts-master/Dockerfile b/osmo-bts-master/Dockerfile index 2e1b628..e081471 100644 --- a/osmo-bts-master/Dockerfile +++ b/osmo-bts-master/Dockerfile @@ -8,6 +8,7 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ + bpftrace \ libosmocore-dev \ libosmo-abis-dev \ libosmo-netif-dev && \ diff --git a/ttcn3-bts-test/bpftrace/udp_sendmsg_delay.bt b/ttcn3-bts-test/bpftrace/udp_sendmsg_delay.bt new file mode 100644 index 0000000..8525413 --- /dev/null +++ b/ttcn3-bts-test/bpftrace/udp_sendmsg_delay.bt @@ -0,0 +1,42 @@ +#!/usr/bin/env bpftrace + +/* Script to obtain udp_sendmsg() latency histograms. + * It will measure time between entry and exit and plot one histogram + * for each destination port number, indicating the amount of time spent. + * + * Implemented 2025 by Vadim Yanitskiy <fixeria(a)osmocom.org> + * SPDX-License-Identifier: CC0 + * + * As no filtering on PID etc. is done, you will likely use this with 'bpftrace -p' like + * + * bpftrace ./udp_sendmsg_delay.bt -p PID + * + * (where PID is the PID of the process, like osmo-bts-trx) + */ + +BEGIN +{ + printf("Tracing udp_sendmsg() latency... Hit Ctrl-C to end.\n"); +} + +kprobe:udp_sendmsg +{ + $sk = (struct sock *)arg0; + /* poor man's ntohs() */ + $dport = ($sk->__sk_common.skc_dport & 0xff) << 8; + $dport |= ($sk->__sk_common.skc_dport >> 8) & 0xff; + + @start[tid] = nsecs; + @dport[tid] = $dport; +} + +kretprobe:udp_sendmsg / @start[tid] / +{ + $delta_us = (nsecs - @start[tid]) / 1000; + @latency[@dport[tid]] = hist($delta_us); + + delete(@start[tid]); + delete(@dport[tid]); +} + +/* vim:set ts=2 sw=2 et: */ diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 49d5cf3..24a91a5 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -44,8 +44,17 @@ start_bts() { local variant="$1" local sleep_time_respawn="$2" + local extra_args="" echo Starting container with BTS + if [ "$RUN_BPFTRACE" = "1" ]; then + if ! mount | grep -q /sys/kernel/tracing; then + echo "ERROR: mount /sys/kernel/tracing first!" + echo "https://www.kernel.org/doc/html/latest/trace/ftrace.html#the-file-system" + exit 1 + fi + extra_args="--ulimit memlock=-1 --privileged" + fi if [ -z "$variant" ]; then echo ERROR: You have to specify a BTS variant exit 23 @@ -55,13 +64,41 @@ --cap-add=SYS_ADMIN \ --ulimit rtprio=99 \ --ulimit core=-1 \ + -v /sys/kernel/tracing:/sys/kernel/tracing \ -v $VOL_BASE_DIR/bts:/data \ -v $VOL_BASE_DIR/unix:/data/unix \ -e "SLEEP_BEFORE_RESPAWN=$sleep_time_respawn" \ --name ${BUILD_TAG}-bts -d \ $DOCKER_ARGS \ + $extra_args \ $REPO_USER/osmo-bts-$IMAGE_SUFFIX \ /bin/sh -c "/usr/local/bin/respawn.sh osmo-bts-$variant -c /data/osmo-bts.gen.cfg >>/data/osmo-bts.log 2>&1" + + # Run bpftrace scripts (OS#6794#note-16) + if [ "$RUN_BPFTRACE" = "1" ]; then + local script + mkdir -p "$VOL_BASE_DIR"/bts/bpftrace + for script in bpftrace/*.bt; do + if ! [ -e "$script" ]; then + # Avoid unexpected behavior when there are no scripts + continue + fi + + local logfile="$VOL_BASE_DIR"/bts/bpftrace/$(basename "$script" | sed s/\.bt/.log/) + local startscript="$VOL_BASE_DIR"/bts/bpftrace/$(basename "$script" | sed s/\.bt/.sh/) + + cp "$script" "$VOL_BASE_DIR"/bts/bpftrace + + ( echo "#!/bin/sh -ex" + echo "bpftrace /data/bpftrace/$(basename "$script") -p \$(pidof osmo-bts-$variant)" ) >"$startscript" + chmod +x "$startscript" + + docker exec \ + "${BUILD_TAG}-bts" \ + /usr/local/bin/respawn.sh /data/bpftrace/"$(basename "$startscript")" \ + >>"$logfile" 2>&1 & + done + fi } start_fake_trx() { -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41720?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5c22cdbb08fe797be936ca174f65ade626fa4895 Gerrit-Change-Number: 41720 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: tweak local vars
by osmith 18 Dec '25

18 Dec '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/41719?usp=email ) Change subject: ttcn3-bts-test/jenkins.sh: tweak local vars ...................................................................... ttcn3-bts-test/jenkins.sh: tweak local vars Make it consistent. Change-Id: I8c5597f20428f8f274ea15f62e561562e5768460 --- M ttcn3-bts-test/jenkins.sh 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/19/41719/1 diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index bfb92aa..49d5cf3 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -42,9 +42,9 @@ } start_bts() { - local variant - variant="$1" - sleep_time_respawn="$2" + local variant="$1" + local sleep_time_respawn="$2" + echo Starting container with BTS if [ -z "$variant" ]; then echo ERROR: You have to specify a BTS variant -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8c5597f20428f8f274ea15f62e561562e5768460 Gerrit-Change-Number: 41719 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in docker-playground[master]: common/respawn: improve logging
by osmith 18 Dec '25

18 Dec '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/41721?usp=email ) Change subject: common/respawn: improve logging ...................................................................... common/respawn: improve logging Add "[$(date)] respawn:" infront of all log messages, so it is clear that they come from this script and so we have timestamps that we can compare. This will be useful when running the bpftrace scripts along with osmo-bts-*, which will get restarted at the same time as the osmo-bts-* processes. Change-Id: I641f17f6988eced12c9b301042fb5c5cfd757511 --- M common/respawn.sh 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/21/41721/1 diff --git a/common/respawn.sh b/common/respawn.sh index d9bf641..1040408 100755 --- a/common/respawn.sh +++ b/common/respawn.sh @@ -7,15 +7,15 @@ i=0 max_i=500 while [ $i -lt $max_i ]; do - echo "respawn: $i: starting: $*" + echo "[$(date)] respawn: $i: starting: $*" $* & LAST_PID=$! wait $LAST_PID - echo "$i: stopped pid $LAST_PID with status $?" + echo "[$(date)] respawn: $i: stopped pid $LAST_PID with status $?" if [ $SLEEP_BEFORE_RESPAWN -gt 0 ]; then - echo "sleeping $SLEEP_BEFORE_RESPAWN seconds..." + echo "[$(date)] respawn: sleeping $SLEEP_BEFORE_RESPAWN seconds..." sleep $SLEEP_BEFORE_RESPAWN fi i=$(expr $i + 1) done -echo "exiting after $max_i runs" +echo "[$(date)] respawn: exiting after $max_i runs" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41721?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I641f17f6988eced12c9b301042fb5c5cfd757511 Gerrit-Change-Number: 41721 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: ansible: jenkins: mount tracefs via fstab
by osmith 18 Dec '25

18 Dec '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41717?usp=email ) Change subject: ansible: jenkins: mount tracefs via fstab ...................................................................... ansible: jenkins: mount tracefs via fstab Allow using bpftrace inside the jenkins lxc containers by making /sys/kernel/tracing available through /etc/fstab. Related: OS#6794 Change-Id: I568e3635fcc33040036fd19e9226b413db0d3ef3 --- M ansible/roles/osmocom-jenkins-slave/tasks/main.yml 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/17/41717/1 diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/main.yml b/ansible/roles/osmocom-jenkins-slave/tasks/main.yml index 46da076..1ddbff9 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/main.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/main.yml @@ -78,3 +78,11 @@ fstype: tmpfs state: mounted opts: "uid=1000,gid=1000" + +- name: add tracefs to /etc/fstab + ansible.posix.mount: + boot: true + path: /sys/kernel/tracing + src: tracefs + fstype: tracefs + state: present -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I568e3635fcc33040036fd19e9226b413db0d3ef3 Gerrit-Change-Number: 41717 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites: set RUN_BPFTRACE=1
by osmith 18 Dec '25

18 Dec '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41718?usp=email ) Change subject: jobs/ttcn3-testsuites: set RUN_BPFTRACE=1 ...................................................................... jobs/ttcn3-testsuites: set RUN_BPFTRACE=1 Related: OS#6794 Related: docker-playground I5c22cdbb08fe797be936ca174f65ade626fa4895 Change-Id: Iaa960772fb0b09722594747006890e5e43752d43 --- M jobs/ttcn3-testsuites.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/18/41718/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 3202212..40a2183 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -95,6 +95,7 @@ builders: - shell: |- export REGISTRY_HOST="registry.osmocom.org" + export RUN_BPFTRACE=1 # Translate job name to docker-playground dir and relevant # environment variables -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41718?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaa960772fb0b09722594747006890e5e43752d43 Gerrit-Change-Number: 41718 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in pysim[master]: unittests/test_files: Pass to-be-encoded length to encoder functions
by dexter 18 Dec '25

18 Dec '25

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41676?usp=email ) Change subject: unittests/test_files: Pass to-be-encoded length to encoder functions ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88f957e49b0c88a121a266d3582e79822fa0e214 Gerrit-Change-Number: 41676 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 18 Dec 2025 15:51:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: logging_vty: Set 'gsmtap log nonblocking-io' as default
by laforge 18 Dec '25

18 Dec '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41703?usp=email ) Change subject: logging_vty: Set 'gsmtap log nonblocking-io' as default ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifca8a821e13ec1327ab2476b0db91078fcff948b Gerrit-Change-Number: 41703 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 15:50:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: logging_vty: Allow setting gsmtap log tgt as (blocking-io|nonblocking...
by laforge 18 Dec '25

18 Dec '25

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41702?usp=email ) Change subject: logging_vty: Allow setting gsmtap log tgt as (blocking-io|nonblocking-io|wq) ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS2: > > and it seems one can set whatever large integer value, the kernel will […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41702?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id5d31bedd7d265d18f6e475ccbc94ced80598d04 Gerrit-Change-Number: 41702 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 15:50:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: gsmtap_util: Increase source_fd's SO_SNDBUF to 4MB
by laforge 18 Dec '25

18 Dec '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41716?usp=email ) Change subject: gsmtap_util: Increase source_fd's SO_SNDBUF to 4MB ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41716?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5033a018dfc748b309600102b8a9ade0df014615 Gerrit-Change-Number: 41716 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 15:49:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: gsmtap_util: Set source_fd RCVBUF to minimum
by laforge 18 Dec '25

18 Dec '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41715?usp=email ) Change subject: gsmtap_util: Set source_fd RCVBUF to minimum ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41715?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If82b3edf11dea1a124035d4eb0e6aa44f4223555 Gerrit-Change-Number: 41715 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 15:48:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0