Attention is currently required from: falconia, fixeria.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: add vty setting for ThemWi RTP formats
......................................................................
add vty setting for ThemWi RTP formats
For every GSM speech codec and for CSD, Osmocom BSS supports both
the standard RTP format prescribed by 3GPP and an alternative enhanced
RTP format invented by Themyscira Wireless: TW-TS-001, TW-TS-002,
TW-TS-006 and TW-TS-007. In order to enable these enhanced RTP
formats, the MSC needs to include an extension IE in the Assignment
Request it sends to the BSS. Until now there was no way to do so
in mainline OsmoMSC, only via local code patches - fix this omission.
The following considerations apply to this new tw-rtp-formats
vty setting:
* When internal MNCC is used, it is beneficial to enable enhanced TW
RTP formats, especially when using E1 BTS with tw-e1abis-mgw:
the DL call leg receives more complete information content from
the UL call leg in each direction.
* When external MNCC is used with non-ThemWi CN software (e.g., with
a PBX via osmo-sip-connector), tw-rtp-formats should NOT be
enabled - off-the-shelf PBX etc software won't understand them.
* Future patches will allow osmo-msc to operate with a ThemWi
transcoding MGW (TC to G.711) in the place of non-TC osmo-mgw;
in that configuration TW RTP formats will become mandatory,
as they are strictly required by ThemWi TC implementation.
Depends: I4c184db53bec28ab42bcd45e033733d850eea5d2 (libosmocore.git)
Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14
---
M TODO-RELEASE
M include/osmocom/msc/gsm_data.h
M include/osmocom/msc/ran_msg.h
M src/libmsc/msc_a.c
M src/libmsc/msc_vty.c
M src/libmsc/ran_msg_a.c
M tests/test_nodes.vty
7 files changed, 77 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/98/41698/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14
Gerrit-Change-Number: 41698
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: daniel, laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/meta-telephony/+/41722?usp=email )
Change subject: libosmocore: upgrade to 1.12.1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
TODO for myself: once merged, rebase laforge/nightly on top of it.
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/41722?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: I0f07f52312739fc8c1dd985f1ccf6d379daed760
Gerrit-Change-Number: 41722
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:23:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41718?usp=email )
Change subject: jobs/ttcn3-testsuites: set RUN_BPFTRACE=1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> This probably need some explanation in the commit description or the file where the line is changed. […]
only the ttcn3-bts-test testsuite makes use of this, I'll update the commit message tomorrow
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41718?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iaa960772fb0b09722594747006890e5e43752d43
Gerrit-Change-Number: 41718
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:10:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/41720?usp=email )
Change subject: ttcn3-bts-test: run bpftrace scripts
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41720?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I5c22cdbb08fe797be936ca174f65ade626fa4895
Gerrit-Change-Number: 41720
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:06:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge, neels.
dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41674?usp=email )
Change subject: ts_51_011/EF.SMSP: Fix parsing of parameter_indicators
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/41674/comment/49d82687_91abe667?usp=em… :
PS2, Line 11: during encode.
I was a bit confused by the Const(7,...) in the code... I have looked it up in the spec. Maybe "...considers '111' to be the default." is more precise?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41674?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ibe24a07f5f73d875d2077fa55471dbfc4e90da23
Gerrit-Change-Number: 41674
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:04:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/41719?usp=email )
Change subject: ttcn3-bts-test/jenkins.sh: tweak local vars
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41719?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I8c5597f20428f8f274ea15f62e561562e5768460
Gerrit-Change-Number: 41719
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:03:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41718?usp=email )
Change subject: jobs/ttcn3-testsuites: set RUN_BPFTRACE=1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This probably need some explanation in the commit description or the file where the line is changed...
AFAIU we are running bpftrace for all testsuites now? IMHO that doesn't make sense. This is something we want to enable during specific times in specific jobs.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41718?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iaa960772fb0b09722594747006890e5e43752d43
Gerrit-Change-Number: 41718
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:03:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41717?usp=email )
Change subject: ansible: jenkins: mount tracefs via fstab
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41717?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I568e3635fcc33040036fd19e9226b413db0d3ef3
Gerrit-Change-Number: 41717
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:01:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes