December 2025 - gerrit-log - lists.osmocom.org

[L] Change in pysim[master]: card_key_provider: add PostgreSQL support
by dexter 18 Dec '25

18 Dec '25

Attention is currently required from: daniel, fixeria, laforge. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review-1 by daniel, Code-Review-1 by laforge, Verified+1 by Jenkins Builder Change subject: card_key_provider: add PostgreSQL support ...................................................................... card_key_provider: add PostgreSQL support The Card Key Provider currently only has support for CSV files as input. Unfortunately using CSV files does not scale very well when the card inventory is very large and continously updated. In this case a centralized storage in the form of a database is the more suitable approach. This patch adds PostgreSQL support next to the existing CSV file support. It also adds an importer tool to import existing CSV files into the database. Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Related: SYS#7725 --- M README.md A contrib/csv-to-pgsql.py M docs/card-key-provider.rst M pySim-shell.py M pySim/card_key_provider.py M requirements.txt M setup.py 7 files changed, 576 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/08/41508/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: logging_vty: Allow setting gsmtap log tgt as (blocking-io|nonblocking...
by pespin 18 Dec '25

18 Dec '25

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41702?usp=email ) Change subject: logging_vty: Allow setting gsmtap log tgt as (blocking-io|nonblocking-io|wq) ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > and it seems one can set whatever large integer value, the kernel will always accept it and just truncate it to (twice) the amount set in the sysctl. ACK, this seems to be done on purpose in liux sk_setsockopt(): /* Don't error on this BSD doesn't and if you think * about it this is right. Otherwise apps have to * play 'guess the biggest size' games. RCVBUF/SNDBUF * are treated in BSD as hints */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41702?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id5d31bedd7d265d18f6e475ccbc94ced80598d04 Gerrit-Change-Number: 41702 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 15:00:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: ts_51_011: Improve testing of EF_SMSP
by fixeria 18 Dec '25

18 Dec '25

Attention is currently required from: dexter, laforge, neels. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41677?usp=email ) Change subject: ts_51_011: Improve testing of EF_SMSP ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8d16e195641bb59b2c26072008f88434692c0cab Gerrit-Change-Number: 41677 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 14:20:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: unittests/test_files: Pass to-be-encoded length to encoder functions
by fixeria 18 Dec '25

18 Dec '25

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41676?usp=email ) Change subject: unittests/test_files: Pass to-be-encoded length to encoder functions ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88f957e49b0c88a121a266d3582e79822fa0e214 Gerrit-Change-Number: 41676 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 14:15:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: unittest/test_files.TransparentEF_Test: Actually test encoder
by fixeria 18 Dec '25

18 Dec '25

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41675?usp=email ) Change subject: unittest/test_files.TransparentEF_Test: Actually test encoder ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41675?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id23305a78ab9acd2e006f2b26b72408795844d23 Gerrit-Change-Number: 41675 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 14:15:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: ts_51_011/EF.SMSP: Fix parsing of parameter_indicators
by fixeria 18 Dec '25

18 Dec '25

Attention is currently required from: dexter, laforge, neels. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41674?usp=email ) Change subject: ts_51_011/EF.SMSP: Fix parsing of parameter_indicators ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibe24a07f5f73d875d2077fa55471dbfc4e90da23 Gerrit-Change-Number: 41674 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 14:14:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pyshark_gsmtap: Adjust display filter for some wireshark versions
by fixeria 18 Dec '25

18 Dec '25

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41712?usp=email ) Change subject: pyshark_gsmtap: Adjust display filter for some wireshark versions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I53c1c8ed58a82c37cd4be4af3890af21da839e86 Gerrit-Change-Number: 41712 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 18 Dec 2025 14:12:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim.esim.saip.personalization: Support Milenage customization
by fixeria 18 Dec '25

18 Dec '25

Attention is currently required from: dexter, laforge, neels. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41690?usp=email ) Change subject: pySim.esim.saip.personalization: Support Milenage customization ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I397df6c0c708a8061e4adc0fde03a3f746bcb5b6 Gerrit-Change-Number: 41690 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 14:12:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim.esim.saip.personalization: Support Milenage customization
by laforge 18 Dec '25

18 Dec '25

Attention is currently required from: dexter, fixeria, neels. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41690?usp=email ) Change subject: pySim.esim.saip.personalization: Support Milenage customization ...................................................................... Patch Set 2: (5 comments) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/41690/comment/1948a1f7_972b23ff?usp=em… : PS1, Line 327: Provided as octet-string concatenation of all 5 constants.""" > Which type exactly goes into the PES? […] yes, it's 5 bytes, each of which contains an uint8_t whose value shall not exceed 127. btw, the default value is ``` rotationConstants OCTET STRING (SIZE (5)) DEFAULT '4000204060'H, ``` i.e. this will be used if the user doesn't provide any override for this ConfigurableParameter https://gerrit.osmocom.org/c/pysim/+/41690/comment/2222a348_b4c93b29?usp=em… : PS1, Line 331: raise('Length of value must be 5 octets') > Raise an exception, not a string (linter). Done https://gerrit.osmocom.org/c/pysim/+/41690/comment/d2b4dc86_02fd838c?usp=em… : PS1, Line 340: raise('Length of value must be 80 octets') > Raise an exception, not a string (linter). Done https://gerrit.osmocom.org/c/pysim/+/41690/comment/7635a2a8_7c68e04a?usp=em… : PS1, Line 341: super().validate() > (On my branch I will inherit from BinaryParam,AlgoConfig and set allowed_len, so this won't need its […] Done https://gerrit.osmocom.org/c/pysim/+/41690/comment/db4dd2ad_672a2160?usp=em… : PS1, Line 343: """Number of iterations of Keccak-f[1600] permuitation as recomended by Section 7.2 of 3GPP TS 35.231""" > question from the future: what is a good default value for this? is 1 ok? thx! Yes, 1 is the default as specified in 3GPP TS 35.231. It is also what the SAIP ASN.1 definition lists as default if the field is absent: ``` numberOfKeccak UInt8 DEFAULT 1 ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I397df6c0c708a8061e4adc0fde03a3f746bcb5b6 Gerrit-Change-Number: 41690 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Dec 2025 14:09:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim.esim.saip.personalization: Support Milenage customization
by laforge 18 Dec '25

18 Dec '25

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, dexter, fixeria, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41690?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim.esim.saip.personalization: Support Milenage customization ...................................................................... pySim.esim.saip.personalization: Support Milenage customization Milenage offers the capability for operators to modify the r1-r5 rotation constants as well as the c1-c5 xor-ing constants; let's add ConfigurableParameters for that. Change-Id: I397df6c0c708a8061e4adc0fde03a3f746bcb5b6 Related: SYS#7787 --- M pySim/esim/saip/personalization.py 1 file changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/90/41690/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I397df6c0c708a8061e4adc0fde03a3f746bcb5b6 Gerrit-Change-Number: 41690 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log December 2025