pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41725?usp=email )
Change subject: BSSAP(_LE)/RANAP: Proper counting of RESET retries
......................................................................
BSSAP(_LE)/RANAP: Proper counting of RESET retries
N retries means N+1 attempts.
Since M3UA_Emulation (in deps/, not in library) doesn't support pushing
DUNA/DAVA as primitive up the stack, we cannot implement the related
SCCP primitives which should end up sending in turn other primitives to
our BSSAP(_LE)/RANAP emulations.
This means we currently have no way to figure out the status of the
underlying SCCP/MTP link, and our only way is implement a poor man's
solution: retransmit RESET until we get an answer.
Since before bssap_reset_retries was set to 1 everywhere and we were
only attempting once, it could happen that the other end (the IUT) was
not yet connected to the STP when we send the RESET, and hence it is
discarded the STP. In that scenario, we'd time out and fail the test.
Instead, now that we do N+1 attempts, we retry after 5 seconds, which
should be enough time for the peer to reconnect to the STP.
Change-Id: If02e424672ff6270aed323c3bb236e822d8a39a4
---
M library/BSSAP_LE_Emulation.ttcn
M library/RAN_Emulation.ttcnpp
2 files changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/41725/1
diff --git a/library/BSSAP_LE_Emulation.ttcn b/library/BSSAP_LE_Emulation.ttcn
index 44afc89..bd9c50c 100644
--- a/library/BSSAP_LE_Emulation.ttcn
+++ b/library/BSSAP_LE_Emulation.ttcn
@@ -310,7 +310,7 @@
private function f_bssap_le_reset(SCCP_PAR_Address peer, SCCP_PAR_Address own) runs on BSSAP_LE_Emulation_CT {
timer T := 5.0;
- var integer attempts := g_ran_ops.bssap_le_reset_retries;
+ var integer attempts := g_ran_ops.bssap_le_reset_retries + 1;
while (attempts > 0) {
attempts := attempts - 1;
@@ -514,7 +514,6 @@
f_expect_table_init();
if (isvalue(ops.sccp_addr_peer) and isvalue(ops.sccp_addr_local)) {
- f_sleep(1.0); /* HACK to wait for M3UA/ASP to be ACTIVE */
f_bssap_le_reset(ops.sccp_addr_peer, ops.sccp_addr_local);
}
diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp
index 563fa0c..8125569 100644
--- a/library/RAN_Emulation.ttcnpp
+++ b/library/RAN_Emulation.ttcnpp
@@ -592,7 +592,7 @@
function f_bssap_reset(SCCP_PAR_Address peer, SCCP_PAR_Address own) runs on RAN_Emulation_CT {
timer T := 5.0;
var boolean append_osmux_support := append_osmux_ie();
- var integer attempts := g_ran_ops.bssap_reset_retries;
+ var integer attempts := g_ran_ops.bssap_reset_retries + 1;
while (attempts > 0) {
attempts := attempts - 1;
@@ -799,7 +799,7 @@
SCCP_PAR_Address own,
template (omit) GlobalRNC_ID grnc_id := omit) runs on RAN_Emulation_CT {
timer T := 5.0;
- var integer attempts := g_ran_ops.bssap_reset_retries;
+ var integer attempts := g_ran_ops.bssap_reset_retries + 1;
var CN_DomainIndicator dom;
if (g_ran_ops.ps_domain) {
@@ -1346,7 +1346,6 @@
f_expect_table_init();
if (isvalue(ops.sccp_addr_peer) and isvalue(ops.sccp_addr_local)) {
- f_sleep(1.0); /* HACK to wait for M3UA/ASP to be ACTIVE */
select (g_ran_ops.protocol) {
#ifdef RAN_EMULATION_BSSAP
case (RAN_PROTOCOL_BSSAP) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41725?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If02e424672ff6270aed323c3bb236e822d8a39a4
Gerrit-Change-Number: 41725
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Attention is currently required from: falconia, fixeria.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: add vty setting for ThemWi RTP formats
......................................................................
add vty setting for ThemWi RTP formats
For every GSM speech codec and for CSD, Osmocom BSS supports both
the standard RTP format prescribed by 3GPP and an alternative enhanced
RTP format invented by Themyscira Wireless: TW-TS-001, TW-TS-002,
TW-TS-006 and TW-TS-007. In order to enable these enhanced RTP
formats, the MSC needs to include an extension IE in the Assignment
Request it sends to the BSS. Until now there was no way to do so
in mainline OsmoMSC, only via local code patches - fix this omission.
The following considerations apply to this new tw-rtp-formats
vty setting:
* When internal MNCC is used, it is beneficial to enable enhanced TW
RTP formats, especially when using E1 BTS with tw-e1abis-mgw:
the DL call leg receives more complete information content from
the UL call leg in each direction.
* When external MNCC is used with non-ThemWi CN software (e.g., with
a PBX via osmo-sip-connector), tw-rtp-formats should NOT be
enabled - off-the-shelf PBX etc software won't understand them.
* Future patches will allow osmo-msc to operate with a ThemWi
transcoding MGW (TC to G.711) in the place of non-TC osmo-mgw;
in that configuration TW RTP formats will become mandatory,
as they are strictly required by ThemWi TC implementation.
Depends: I4c184db53bec28ab42bcd45e033733d850eea5d2 (libosmocore.git)
Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14
---
M TODO-RELEASE
M include/osmocom/msc/gsm_data.h
M include/osmocom/msc/ran_msg.h
M src/libmsc/msc_a.c
M src/libmsc/msc_vty.c
M src/libmsc/ran_msg_a.c
M tests/test_nodes.vty
7 files changed, 77 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/98/41698/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Icea152f5f2cdbcb0df09ef5b7211d1461b499f14
Gerrit-Change-Number: 41698
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: daniel, laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/meta-telephony/+/41722?usp=email )
Change subject: libosmocore: upgrade to 1.12.1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
TODO for myself: once merged, rebase laforge/nightly on top of it.
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/41722?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: I0f07f52312739fc8c1dd985f1ccf6d379daed760
Gerrit-Change-Number: 41722
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:23:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41718?usp=email )
Change subject: jobs/ttcn3-testsuites: set RUN_BPFTRACE=1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> This probably need some explanation in the commit description or the file where the line is changed. […]
only the ttcn3-bts-test testsuite makes use of this, I'll update the commit message tomorrow
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41718?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iaa960772fb0b09722594747006890e5e43752d43
Gerrit-Change-Number: 41718
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:10:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/41720?usp=email )
Change subject: ttcn3-bts-test: run bpftrace scripts
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41720?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I5c22cdbb08fe797be936ca174f65ade626fa4895
Gerrit-Change-Number: 41720
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:06:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge, neels.
dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41674?usp=email )
Change subject: ts_51_011/EF.SMSP: Fix parsing of parameter_indicators
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/41674/comment/49d82687_91abe667?usp=em… :
PS2, Line 11: during encode.
I was a bit confused by the Const(7,...) in the code... I have looked it up in the spec. Maybe "...considers '111' to be the default." is more precise?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41674?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ibe24a07f5f73d875d2077fa55471dbfc4e90da23
Gerrit-Change-Number: 41674
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:04:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes