December 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: cosmetic: 5gc: Update done & todo spec reference procedures
by osmith 01 Dec '25

01 Dec '25

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41533?usp=email ) Change subject: cosmetic: 5gc: Update done & todo spec reference procedures ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41533?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8e2d9c690f1e602190c5949783679f3e7e18d00e Gerrit-Change-Number: 41533 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 13:28:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: cosmetic: 5gc: Update done & todo spec reference procedures
by pespin 01 Dec '25

01 Dec '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41533?usp=email ) Change subject: cosmetic: 5gc: Update done & todo spec reference procedures ...................................................................... cosmetic: 5gc: Update done & todo spec reference procedures Change-Id: I8e2d9c690f1e602190c5949783679f3e7e18d00e --- M 5gc/C5G_Tests.ttcn M 5gc/ConnHdlr.ttcn 2 files changed, 38 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/41533/1 diff --git a/5gc/C5G_Tests.ttcn b/5gc/C5G_Tests.ttcn index 84d0c3f..699d998 100644 --- a/5gc/C5G_Tests.ttcn +++ b/5gc/C5G_Tests.ttcn @@ -432,6 +432,42 @@ } /* TODO: + * - 3GPP TS 23.502 4.2.2.2.3 Registration with AMF re-allocation + * - 3GPP TS 23.502 4.2.2.2.4 Registration with Onboarding SNPN + * - 3GPP TS 23.502 4.2.2.3.3 Network-initiated Deregistration + * - 3GPP TS 23.502 4.2.3.2 UE Triggered Service Request + * - 3GPP TS 23.502 4.2.3.3 Network Triggered Service Request + * - 3GPP TS 23.502 4.2.4.3 UE Configuration Update procedure for transparent UE Policy delivery + * - 3GPP TS 23.502 4.2.5.2 UE Reachability Notification Request procedure + * - 3GPP TS 23.502 4.2.5.3 UE Activity Notification procedure + * - 3GPP TS 23.502 4.2.9.2 Network Slice-Specific Authentication and Authorization + * - 3GPP TS 23.502 4.2.9.3 AAA Server triggered Network Slice-Specific Re-authentication and Re-authorization procedure + * - 3GPP TS 23.502 4.2.9.4 AAA Server triggered Slice-Specific Authorization Revocation + * - 3GPP TS 23.502 4.5.2 Session Management Subscriber Data Update Notification to SMF + * - 3GPP TS 23.502 4.5.3 Purge of subscriber data in AMF + * - 3GPP TS 23.502 4.7 ME Identity check procedure + * - 3GPP TS 23.502 4.8.1.1(a) Connection Inactive procedure + * - 3GPP TS 23.502 4.8.1.2 Connection Suspend procedure + * - 3GPP TS 23.502 4.8.2 Connection Resume procedure + * - 3GPP TS 23.502 4.9 Handover procedures + * - 3GPP TS 23.502 4.12 Procedures for Untrusted non-3GPP access + * - 3GPP TS 23.502 4.12a Procedures for Trusted non-3GPP access + * - 3GPP TS 23.502 4.13.3 SMS over NAS procedures + * - 3GPP TS 23.502 4.13.3.3 MO SMS over NAS in CM-IDLE (baseline) + * - 3GPP TS 23.502 4.13.3.5 MO SMS over NAS in CM-CONNECTED + * - 3GPP TS 23.502 4.13.3.6 MT SMS over NAS in CM-IDLE state and RRC_INACTIVE with CN based MT communication state via 3GPP access + * - 3GPP TS 23.502 4.13.3.7 MT SMS over NAS in CM-CONNECTED state via 3GPP access + * - 3GPP TS 23.502 4.13.3.8 MT SMS over NAS via non-3GPP access + * - 3GPP TS 23.502 4.13.4 Emergency Services + * - 3GPP TS 23.502 4.13.4.2 Emergency Services Fallback + * - 3GPP TS 23.502 4.13.5 Location Services procedures + * - 3GPP TS 23.502 4.13.6.1 EPS fallback for IMS voice + * - 3GPP TS 23.502 4.13.6.2 Inter RAT Fallback in 5GC for IMS voice + * - 3GPP TS 23.502 4.13.6.3 Transfer of PDU session used for IMS voice from non-3GPP access to 5GS + * - 3GPP TS 23.502 4.14.1 RAN Initiated QoS Flow Mobility + * - 3GPP TS 23.502 4.21 Secondary RAT Usage Data Reporting Procedure + * - 3GPP TS 23.502 Annex G (normative): Support of GERAN/UTRAN access by SMF+PGW-C + * * - Emergency call (PDU Sess Establish "Request Type"="Emergency Request") * - Handover from/to EPS vs 5GC * - Handover from/to 3GPP vs non-3GPP (PDU Sess Establish "Request Type"="Existing PDU Session" and RAT Type change) diff --git a/5gc/ConnHdlr.ttcn b/5gc/ConnHdlr.ttcn index 8cc483e..3e51545 100644 --- a/5gc/ConnHdlr.ttcn +++ b/5gc/ConnHdlr.ttcn @@ -523,6 +523,7 @@ NGAP.send(nas_ul_msg); } +/* 3GPP TS 23.502 4.2.2.2.2 General Registration */ function f_register() runs on ConnHdlr { var template (value) NGAP_PDU tx_pdu; var template (value) NG_NAS_UL_Message_Type nas_ul_msg; @@ -707,6 +708,7 @@ } } +/* 3GPP TS 23.502 4.3.4 PDU Session Release */ function f_pdu_sess_release(boolean configure_userplane := true) runs on ConnHdlr { var template (value) NG_NAS_UL_Message_Type nas_ul_msg; var NAS_PDU nas_pdu; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41533?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8e2d9c690f1e602190c5949783679f3e7e18d00e Gerrit-Change-Number: 41533 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Introduce tests to validate inaccessible SP scenario
by fixeria 01 Dec '25

01 Dec '25

Attention is currently required from: daniel, laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email ) Change subject: stp: Introduce tests to validate inaccessible SP scenario ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File stp/STP_Tests_IPA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/215827dd_e8bf… : PS3, Line 655: f_sleep(1.0); > ... this tests simply validates the osmo-stp doesn't crash unexpectedly ... This is exactly what I wanted to clarify, thanks. It's not obvious from reading the testcase scenario at all. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d Gerrit-Change-Number: 41525 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 12:18:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: sctp_common: gen_sockopts/1: add heartbeat and RTO params
by pespin 01 Dec '25

01 Dec '25

Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email ) Change subject: sctp_common: gen_sockopts/1: add heartbeat and RTO params ...................................................................... Patch Set 2: (1 comment) File config/sys.config: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531/comment/1464c4a1_488c… : PS2, Line 17: %% * rto_initial - RTO (retransmission time-out) initial, ms (default: 1000) > Agreeing with @andreas@eversberg.eu here. […] do you mind sharing to which sysctls/sockopts those values relate? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I081852d2df187ca7c3cb8969686530b8ac3644f3 Gerrit-Change-Number: 41531 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 12:17:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Introduce tests to validate inaccessible SP scenario
by pespin 01 Dec '25

01 Dec '25

Attention is currently required from: daniel, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email ) Change subject: stp: Introduce tests to validate inaccessible SP scenario ...................................................................... Patch Set 4: (2 comments) File stp/STP_Tests_IPA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/a9d2bcd3_06c5… : PS3, Line 655: f_sleep(1.0); > > STP discards the message to be forwarded, since its destination is not accessible. […] It's impossible the message gets anywhere because there's no conn1 up/connected where it can forward the message to. So for now this tests simply validates the osmo-stp doesn't crash unexpectedly, which is already good since I run into this issue. File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/03f8bdef_9621… : PS3, Line 204: [] M3UA[idx].receive(t_M3UA_RecvFrom(?)) -> value rx > I am fine with the Hearbeats, it's actually the two `M3UA[idx]. […] As mentioned, the 2 receives accomplish different purposes, so I want to keep them. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d Gerrit-Change-Number: 41525 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 12:15:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Introduce tests to validate inaccessible SP scenario
by pespin 01 Dec '25

01 Dec '25

Attention is currently required from: daniel, laforge, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: stp: Introduce tests to validate inaccessible SP scenario ...................................................................... stp: Introduce tests to validate inaccessible SP scenario Related: OS#6892 Related: libosmo-sigtran.git Change-Id I7e89db3d82374ca03a2e71fb558c7cec9bd651c4 Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d --- M stp/STP_Tests_IPA.ttcn M stp/STP_Tests_M3UA.ttcn M stp/expected-results.xml 3 files changed, 124 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/41525/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d Gerrit-Change-Number: 41525 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: sctp_common: gen_sockopts/1: add heartbeat and RTO params
by fixeria 01 Dec '25

01 Dec '25

Attention is currently required from: jolly, laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email ) Change subject: sctp_common: gen_sockopts/1: add heartbeat and RTO params ...................................................................... Patch Set 2: (1 comment) File config/sys.config: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531/comment/0cf19afe_f6d5… : PS2, Line 17: %% * rto_initial - RTO (retransmission time-out) initial, ms (default: 1000) > I suggest to use our values as defaults, rather than the kernel defaults. […] Agreeing with @andreas@eversberg.eu here. However, we need to be careful not to make our default configuration way too picky about the link latency, which is higher when satellite backhaul is used. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I081852d2df187ca7c3cb8969686530b8ac3644f3 Gerrit-Change-Number: 41531 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 12:12:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: sctp_common: gen_sockopts/1: add heartbeat and RTO params
by jolly 01 Dec '25

01 Dec '25

Attention is currently required from: fixeria, laforge. jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email ) Change subject: sctp_common: gen_sockopts/1: add heartbeat and RTO params ...................................................................... Patch Set 2: (1 comment) File config/sys.config: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531/comment/1c0b1dfe_798c… : PS2, Line 17: %% * rto_initial - RTO (retransmission time-out) initial, ms (default: 1000) > I'm not sure we want to provide defaults for RTO ourselves, I'd say let the kernel pick them up. […] I suggest to use our values as defaults, rather than the kernel defaults. A timeout of about 10 minutes makes no sense for S1 link. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I081852d2df187ca7c3cb8969686530b8ac3644f3 Gerrit-Change-Number: 41531 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 12:03:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-upf[master]: Validate session remote CP F-SEID and use it to transmit session requ...
by fixeria 01 Dec '25

01 Dec '25

Attention is currently required from: neels, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email ) Change subject: Validate session remote CP F-SEID and use it to transmit session requests ...................................................................... Patch Set 1: (3 comments) File src/osmo-upf/up_endpoint.c: https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/89c29d8b_ac966511?usp… : PS1, Line 176: OSMO_ASSERT(f_seid) missing semicolon? https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/44410d52_347faa68?usp… : PS1, Line 217: nack_response I would go for a separate function (e.g. `up_ep_tx_nack()`) to avoid code duplication. File src/osmo-upf/up_session.c: https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/c5055d00_e4a50b9f?usp… : PS1, Line 115: return NULL; This code is unreachable. Maybe do `OSMO_ASSERT(0)` here and remove these two above? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ifccd4d2b8d500c9928778400bb096baaa12c9a31 Gerrit-Change-Number: 41482 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 11:54:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Introduce tests to validate inaccessible SP scenario
by fixeria 01 Dec '25

01 Dec '25

Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email ) Change subject: stp: Introduce tests to validate inaccessible SP scenario ...................................................................... Patch Set 3: (2 comments) File stp/STP_Tests_IPA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/6910d803_d49a… : PS3, Line 655: f_sleep(1.0); > STP discards the message to be forwarded, since its destination is not accessible. But the testcase does not know whether the message has been discarded or not, right? File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/003590a9_b07f… : PS3, Line 204: [] M3UA[idx].receive(t_M3UA_RecvFrom(?)) -> value rx > Plus keeping answering for Hearbeats meanwhile to avoid failing due to other reasons, etc. I am fine with the Hearbeats, it's actually the two `M3UA[idx].receive` statements making this function look a bit weird. Not blocking though. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d Gerrit-Change-Number: 41525 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 11:45:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0