Attention is currently required from: daniel, fixeria, laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email )
Change subject: stp: Introduce tests to validate inaccessible SP scenario
......................................................................
Patch Set 4:
(2 comments)
File stp/STP_Tests_IPA.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/a9d2bcd3_06c5… :
PS3, Line 655: f_sleep(1.0);
> > STP discards the message to be forwarded, since its destination is not accessible. […]
It's impossible the message gets anywhere because there's no conn1 up/connected where it can forward the message to.
So for now this tests simply validates the osmo-stp doesn't crash unexpectedly, which is already good since I run into this issue.
File stp/STP_Tests_M3UA.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/03f8bdef_9621… :
PS3, Line 204: [] M3UA[idx].receive(t_M3UA_RecvFrom(?)) -> value rx
> I am fine with the Hearbeats, it's actually the two `M3UA[idx]. […]
As mentioned, the 2 receives accomplish different purposes, so I want to keep them.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d
Gerrit-Change-Number: 41525
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Dec 2025 12:15:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly, laforge, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email )
Change subject: sctp_common: gen_sockopts/1: add heartbeat and RTO params
......................................................................
Patch Set 2:
(1 comment)
File config/sys.config:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531/comment/0cf19afe_f6d5… :
PS2, Line 17: %% * rto_initial - RTO (retransmission time-out) initial, ms (default: 1000)
> I suggest to use our values as defaults, rather than the kernel defaults. […]
Agreeing with @andreas@eversberg.eu here. However, we need to be careful not to make our default configuration way too picky about the link latency, which is higher when satellite backhaul is used.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I081852d2df187ca7c3cb8969686530b8ac3644f3
Gerrit-Change-Number: 41531
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Dec 2025 12:12:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, laforge.
jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email )
Change subject: sctp_common: gen_sockopts/1: add heartbeat and RTO params
......................................................................
Patch Set 2:
(1 comment)
File config/sys.config:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531/comment/1c0b1dfe_798c… :
PS2, Line 17: %% * rto_initial - RTO (retransmission time-out) initial, ms (default: 1000)
> I'm not sure we want to provide defaults for RTO ourselves, I'd say let the kernel pick them up. […]
I suggest to use our values as defaults, rather than the kernel defaults. A timeout of about 10 minutes makes no sense for S1 link.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I081852d2df187ca7c3cb8969686530b8ac3644f3
Gerrit-Change-Number: 41531
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Dec 2025 12:03:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: neels, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email )
Change subject: Validate session remote CP F-SEID and use it to transmit session requests
......................................................................
Patch Set 1:
(3 comments)
File src/osmo-upf/up_endpoint.c:
https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/89c29d8b_ac966511?usp… :
PS1, Line 176: OSMO_ASSERT(f_seid)
missing semicolon?
https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/44410d52_347faa68?usp… :
PS1, Line 217: nack_response
I would go for a separate function (e.g. `up_ep_tx_nack()`) to avoid code duplication.
File src/osmo-upf/up_session.c:
https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/c5055d00_e4a50b9f?usp… :
PS1, Line 115: return NULL;
This code is unreachable. Maybe do `OSMO_ASSERT(0)` here and remove these two above?
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ifccd4d2b8d500c9928778400bb096baaa12c9a31
Gerrit-Change-Number: 41482
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Dec 2025 11:54:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, laforge, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email )
Change subject: stp: Introduce tests to validate inaccessible SP scenario
......................................................................
Patch Set 3:
(2 comments)
File stp/STP_Tests_IPA.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/6910d803_d49a… :
PS3, Line 655: f_sleep(1.0);
> STP discards the message to be forwarded, since its destination is not accessible.
But the testcase does not know whether the message has been discarded or not, right?
File stp/STP_Tests_M3UA.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/003590a9_b07f… :
PS3, Line 204: [] M3UA[idx].receive(t_M3UA_RecvFrom(?)) -> value rx
> Plus keeping answering for Hearbeats meanwhile to avoid failing due to other reasons, etc.
I am fine with the Hearbeats, it's actually the two `M3UA[idx].receive` statements making this function look a bit weird. Not blocking though.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d
Gerrit-Change-Number: 41525
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Dec 2025 11:45:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>