Attention is currently required from: fixeria, laforge, neels, osmith.
Hello Jenkins Builder, fixeria, laforge, neels, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: Validate session remote CP F-SEID and use it to transmit session requests
......................................................................
Validate session remote CP F-SEID and use it to transmit session requests
Change-Id: Ifccd4d2b8d500c9928778400bb096baaa12c9a31
---
M include/osmocom/upf/pfcp_entity_peer.h
M src/osmo-upf/pfcp_entity_peer.c
M src/osmo-upf/up_endpoint.c
M src/osmo-upf/up_session.c
4 files changed, 156 insertions(+), 34 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/82/41482/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ifccd4d2b8d500c9928778400bb096baaa12c9a31
Gerrit-Change-Number: 41482
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, neels.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email )
Change subject: Validate session remote CP F-SEID and use it to transmit session requests
......................................................................
Patch Set 1:
(3 comments)
File src/osmo-upf/up_endpoint.c:
https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/2afd55c2_4ce685ab?usp… :
PS1, Line 176: OSMO_ASSERT(f_seid)
> missing semicolon?
Done
https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/074f1a03_24ab73ee?usp… :
PS1, Line 217: nack_response
> I would go for a separate function (e.g. `up_ep_tx_nack()`) to avoid code duplication.
I think it's fine having it this, way it's only 3 lines of code and it's common practice to handle nack this way imho.
It would make sense if a lot of code was needed, but it's not really the case.
File src/osmo-upf/up_session.c:
https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/c24cdc2b_eeb44a8f?usp… :
PS1, Line 115: return NULL;
> This code is unreachable. […]
I also thought about it, and tbh I only added this return to avoid warnings on older compilers/static analysis tools. I prefer keeping the assert in each branch, specially the first one, since it becomes clearer that the break is not something which may not been done on purpose.
I'll add a comment here /* unreachable */, since adding more code like ASSERT could also trigger a warning by static analysis tools
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ifccd4d2b8d500c9928778400bb096baaa12c9a31
Gerrit-Change-Number: 41482
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Dec 2025 15:14:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: laforge, lynxis lazus, osmith, pespin.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )
Change subject: Add TCAP based loadsharing/routing
......................................................................
Patch Set 17:
(1 comment)
File tests/vty/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/e54ef190_2b17b… :
PS15, Line 35: ss7_asp_test.vty \
> this fixes it: […]
amazing, thanks!
I'll add it to VTY_TEST_ASP as well so it works consistently if we ever need to remove the glob there
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
Gerrit-Change-Number: 41309
Gerrit-PatchSet: 17
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 01 Dec 2025 14:57:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: laforge, lynxis lazus, osmith, pespin.
daniel has uploaded a new patch set (#17) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add TCAP based loadsharing/routing
......................................................................
Add TCAP based loadsharing/routing
TCAP based loadsharing will share the load based on the TCAP oTID and
dTID.
Because TCAP are session based, a TCAP session based tracking is implemented,
to allow following traffic to forwarded to the same ASP.
This TCAP session tracking is similar to IP connection tracking.
ASPs within an AS can use the new IPA TCAP ROUTING protocol to register
for specific TCAP ranges.
TCAP sessions initiated by a peer (traffic towards such loadsharing AS/ASP),
will use the oTID of the `TCAP Begin` to loadshare and select a ASP.
Further if the TCAP session was initiated by a `loadshared` ASP, the oTID
will be added to the session tracking.
Co-authored-by: Harald Welte <laforge(a)osmocom.org>
Co-authored-by: Alexander Couzens <lynxis(a)fe80.eu>
Co-authored-by: Pau Espin Pedrol <pespin(a)sysmocom.de>
Related: SYS#5423
Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
---
M configure.ac
M src/Makefile.am
M src/ipa.c
M src/ss7_as.c
M src/ss7_as.h
M src/ss7_as_vty.c
M src/ss7_asp.h
A src/tcap_as_loadshare.c
A src/tcap_as_loadshare.h
A src/tcap_trans_tracking.c
A src/tcap_trans_tracking.h
M src/xua_asp_fsm.c
M tests/Makefile.am
A tests/tcap/Makefile.am
A tests/tcap/tcap_transaction_tracking_test.c
A tests/tcap/tcap_transaction_tracking_test.ok
M tests/testsuite.at
M tests/vty/Makefile.am
M tests/vty/osmo_stp_test.vty
A tests/vty/osmo_stp_test_tcap.vty
20 files changed, 1,981 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/41309/17
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
Gerrit-Change-Number: 41309
Gerrit-PatchSet: 17
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>