December 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: cosmetic: 5gc: Update done & todo spec reference procedures
by fixeria 01 Dec '25

01 Dec '25

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41533?usp=email ) Change subject: cosmetic: 5gc: Update done & todo spec reference procedures ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41533?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8e2d9c690f1e602190c5949783679f3e7e18d00e Gerrit-Change-Number: 41533 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 15:34:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-upf[master]: Validate session remote CP F-SEID and use it to transmit session requ...
by pespin 01 Dec '25

01 Dec '25

Attention is currently required from: fixeria, laforge, neels, osmith. Hello Jenkins Builder, fixeria, laforge, neels, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Validate session remote CP F-SEID and use it to transmit session requests ...................................................................... Validate session remote CP F-SEID and use it to transmit session requests Change-Id: Ifccd4d2b8d500c9928778400bb096baaa12c9a31 --- M include/osmocom/upf/pfcp_entity_peer.h M src/osmo-upf/pfcp_entity_peer.c M src/osmo-upf/up_endpoint.c M src/osmo-upf/up_session.c 4 files changed, 156 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/82/41482/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ifccd4d2b8d500c9928778400bb096baaa12c9a31 Gerrit-Change-Number: 41482 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-upf[master]: Validate session remote CP F-SEID and use it to transmit session requ...
by pespin 01 Dec '25

01 Dec '25

Attention is currently required from: fixeria, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email ) Change subject: Validate session remote CP F-SEID and use it to transmit session requests ...................................................................... Patch Set 1: (3 comments) File src/osmo-upf/up_endpoint.c: https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/2afd55c2_4ce685ab?usp… : PS1, Line 176: OSMO_ASSERT(f_seid) > missing semicolon? Done https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/074f1a03_24ab73ee?usp… : PS1, Line 217: nack_response > I would go for a separate function (e.g. `up_ep_tx_nack()`) to avoid code duplication. I think it's fine having it this, way it's only 3 lines of code and it's common practice to handle nack this way imho. It would make sense if a lot of code was needed, but it's not really the case. File src/osmo-upf/up_session.c: https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/c24cdc2b_eeb44a8f?usp… : PS1, Line 115: return NULL; > This code is unreachable. […] I also thought about it, and tbh I only added this return to avoid warnings on older compilers/static analysis tools. I prefer keeping the assert in each branch, specially the first one, since it becomes clearer that the break is not something which may not been done on purpose. I'll add a comment here /* unreachable */, since adding more code like ASSERT could also trigger a warning by static analysis tools -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ifccd4d2b8d500c9928778400bb096baaa12c9a31 Gerrit-Change-Number: 41482 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 15:14:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by pespin 01 Dec '25

01 Dec '25

Attention is currently required from: daniel, laforge, lynxis lazus, osmith. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 17: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 17 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 01 Dec 2025 15:03:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Introduce tests to validate inaccessible SP scenario
by pespin 01 Dec '25

01 Dec '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email ) Change subject: stp: Introduce tests to validate inaccessible SP scenario ...................................................................... stp: Introduce tests to validate inaccessible SP scenario Related: OS#6892 Related: libosmo-sigtran.git Change-Id I7e89db3d82374ca03a2e71fb558c7cec9bd651c4 Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d --- M stp/STP_Tests_IPA.ttcn M stp/STP_Tests_M3UA.ttcn M stp/expected-results.xml 3 files changed, 124 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/stp/STP_Tests_IPA.ttcn b/stp/STP_Tests_IPA.ttcn index b110228..0a5b56c 100644 --- a/stp/STP_Tests_IPA.ttcn +++ b/stp/STP_Tests_IPA.ttcn @@ -638,6 +638,26 @@ f_tc_combinedlset_loadshare(true); } +/* test "traffic-mode override" behavior */ +testcase TC_inaccessible_sp() runs on IPA_CT { + var Misc_Helpers.ro_charstring asps := { "ipa-asp-override-sender" }; + var IpaConfigs ipa_configs := ipa_build_configs(asps); + f_init_ipa(ipa_configs := ipa_configs); + + /* bring up the 'sender' side (single ASP in AS) */ + f_connect_ipa(0); + /* Here none of ipa-asp-override-receiver* is brought up on purpose, so test route failure inside IUT. */ + + var octetstring data := f_SCCP_UDT(); + f_IPA_send(0, data); + + /* STP discards the message to be forwarded, since its destination is not accessible. */ + /* FIXME: DUNA doesn't exist in IPA. Sould we probably receive SCCP UDTS here? */ + f_sleep(1.0); + + setverdict(pass); +} + private function f_IPA_ping(integer idx) runs on IPA_CT { var IpaCcmMsgtype ipa_ping_msg := IPAC_MSGT_PING; @@ -753,6 +773,7 @@ execute( TC_unknown_client_dynamic_tmt_loadshare() ); execute( TC_combinedlset_loadshare() ); execute( TC_unknown_client_dynamic_combinedlset_loadshare() ); + execute( TC_inaccessible_sp() ); execute( TC_beat() ); execute( TC_beat_timeout() ); diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index ebdb6e1..4716bb4 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -49,6 +49,12 @@ M3uaConfigs mp_m3ua_configs := {}; integer mp_recovery_timeout_msec := 2000; charstring mp_sccp_service_type := "mtp3_itu"; + + /* Some PC which is known to be inaccessible for the IUT (no route) */ + integer mp_inaccessible_pc := 666; + + /* Network Indicator of the STP (IUT) network: */ + OCT1 mp_ni := '00'O; } type record M3uaConfig { @@ -183,6 +189,30 @@ return rx; } +friend function f_M3UA_exp_no(integer idx, template (present) PDU_M3UA msg, + float timeout_val := 5.0, boolean answer_beat := true) +runs on RAW_M3UA_CT return M3UA_RecvFrom { + var M3UA_RecvFrom rx; + timer T := timeout_val; + T.start; + alt { + [] M3UA[idx].receive(t_M3UA_RecvFrom(msg)) -> value rx { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Received unexpected M3UA[", idx, "] ", rx)); + } + [answer_beat] as_m3ua_beat_answer(idx); + [] M3UA[idx].receive(t_M3UA_RecvFrom(?)) -> value rx { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Received unexpected M3UA[", idx, "] ", rx, + " before timeout expecting no ", msg)); + } + [] T.timeout { + setverdict(pass); + } + } + return rx; +} + /* flush any number of queued messages matching 'msg' */ friend function f_M3UA_flush(integer idx, template (present) PDU_M3UA msg) runs on RAW_M3UA_CT { var M3UA_RecvFrom rx; @@ -669,7 +699,7 @@ /* Test if traffic is routed from idx_tx/pc_tx to idx_rx/pc_rx */ friend function f_test_traffic(integer idx_tx, template (omit) OCT4 rctx_sender, OCT4 pc_tx, integer idx_rx, template (omit) OCT4 rctx_receiver, OCT4 pc_rx, - OCT1 si := '23'O, OCT1 ni := '00'O, OCT1 mp := '00'O, OCT1 sls := '00'O) + OCT1 si := '23'O, OCT1 ni := mp_ni, OCT1 mp := '00'O, OCT1 sls := '00'O) runs on RAW_M3UA_CT { var octetstring data := f_rnd_octstring_rnd_len(100); f_M3UA_send(idx_tx, ts_M3UA_DATA(rctx_sender, @@ -1765,6 +1795,73 @@ f_clear_m3ua(); } +private function f_tc_inaccessible_sp_duna(integer idx_tx, OCT4 pc_sender, OCT4 rctx_sender, + OCT4 pc_receiver, OCT4 rctx_receiver) runs on RAW_M3UA_CT { + var octetstring data := f_rnd_octstring_rnd_len(100); + var template (value) M3UA_Protocol_Data m3ua_data; + /* Max for T8 is 1200 msec, so we leave some more time. to avodi race conditions: */ + const float c_t8_max_sec := 1.2 + 0.5; + + /* bring up the sender specifying a routing context */ + f_M3UA_asp_up_act(idx_tx, rctx := rctx_sender); + + /* check if DATA is accepted without Routing Context IE */ + m3ua_data := ts_M3UA_protocol_data(pc_sender, pc_receiver, si:= '23'O, ni := mp_ni, + mp := '00'O, sls := '00'O, data := data); + f_M3UA_send(idx_tx, ts_M3UA_DATA(rctx_sender, m3ua_data), 1); + f_M3UA_exp(idx_tx, tr_M3UA_DUNA({ts_M3UA_PC(oct2int(pc_receiver), 0)}, rctx_sender)); + + /* Test Q.704 timer T8: After we received the first DUNA, if we send another message we + * shouldn't receive another DUNA until T8 times out. Max for T8 is 1200, so we leave + * some more time. */ + f_M3UA_send(idx_tx, ts_M3UA_DATA(rctx_sender, m3ua_data), 1); + f_M3UA_exp_no(idx_tx, tr_M3UA_DUNA({ts_M3UA_PC(oct2int(pc_receiver), 0)}, rctx_sender), + timeout_val := c_t8_max_sec); + + /* After T8, we should receive again a DUNA: */ + f_M3UA_send(idx_tx, ts_M3UA_DATA(rctx_sender, m3ua_data), 1); + f_M3UA_exp(idx_tx, tr_M3UA_DUNA({ts_M3UA_PC(oct2int(pc_receiver), 0)}, rctx_sender)); + + /* Let T8 time out again: */ + f_M3UA_send(idx_tx, ts_M3UA_DATA(rctx_sender, m3ua_data), 1); + f_M3UA_exp_no(idx_tx, tr_M3UA_DUNA({ts_M3UA_PC(oct2int(pc_receiver), 0)}, rctx_sender), + timeout_val := c_t8_max_sec); + + + f_clear_m3ua(); +} + +/* test whether the STP sends back a M3UA DUNA when receiving a pkt towards an inaccessible SP (non existing/routable PC) */ +testcase TC_inaccessible_sp_duna() runs on RAW_M3UA_CT { + var Misc_Helpers.ro_charstring asps := { "asp-sender" }; + var M3uaConfigs m3ua_configs := m3ua_build_configs(asps); + var OCT4 rctx_sender := int2oct(m3ua_configs[0].routing_ctx, 4); + var OCT4 pc_sender := int2oct(m3ua_configs[0].point_code, 4); + var OCT4 rctx_receiver := int2oct(3, 4); + var OCT4 pc_receiver := int2oct(mp_inaccessible_pc, 4); + + f_init_m3ua(m3ua_configs := m3ua_configs); + + /* bring up the sender specifying a routing context */ + f_tc_inaccessible_sp_duna(0, pc_sender, rctx_sender, pc_receiver, rctx_receiver); +} + +/* test whether the STP sends back a M3UA DUNA when receiving a pkt towards an + * inaccessible SP (PC/AS known but no active ASPs towards it). */ +testcase TC_inaccessible_sp_duna2() runs on RAW_M3UA_CT { + var Misc_Helpers.ro_charstring asps := { "asp-sender", "asp-receiver0" }; + var M3uaConfigs m3ua_configs := m3ua_build_configs(asps); + var OCT4 rctx_sender := int2oct(m3ua_configs[0].routing_ctx, 4); + var OCT4 pc_sender := int2oct(m3ua_configs[0].point_code, 4); + var OCT4 rctx_receiver := int2oct(m3ua_configs[1].routing_ctx, 4); + var OCT4 pc_receiver := int2oct(m3ua_configs[1].point_code, 4); + + f_init_m3ua(m3ua_configs := m3ua_configs); + + /* bring up the sender specifying a routing context */ + f_tc_inaccessible_sp_duna(0, pc_sender, rctx_sender, pc_receiver, rctx_receiver); +} + control { /* M3UA Tests */ execute( TC_connect_asp_up() ); @@ -1782,6 +1879,8 @@ execute( TC_act_rctx_data_no_rctx() ); execute( TC_m3ua_sctp_srv_adm_shutdown() ); execute( TC_combinedlset_loadshare() ); + execute( TC_inaccessible_sp_duna() ); + execute( TC_inaccessible_sp_duna2() ); /* M3UA RKM tests */ execute( TC_rkm_reg_static_notpermitted() ); diff --git a/stp/expected-results.xml b/stp/expected-results.xml index e0170de..5834abb 100644 --- a/stp/expected-results.xml +++ b/stp/expected-results.xml @@ -15,6 +15,8 @@ <testcase classname='STP_Tests_M3UA' name='TC_act_rctx_data_no_rctx' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_m3ua_sctp_srv_adm_shutdown' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_combinedlset_loadshare' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_inaccessible_sp_duna' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_inaccessible_sp_duna2' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_rkm_reg_static_notpermitted' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_rkm_reg_static_permitted' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_rkm_reg_dynamic_permitted' time='MASKED'/> @@ -61,6 +63,7 @@ <testcase classname='STP_Tests_IPA' name='TC_unknown_client_dynamic_tmt_loadshare' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_combinedlset_loadshare' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_unknown_client_dynamic_combinedlset_loadshare' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_inaccessible_sp' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_beat' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_beat_timeout' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_clnt_beat_timeout' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d Gerrit-Change-Number: 41525 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Introduce tests to validate inaccessible SP scenario
by pespin 01 Dec '25

01 Dec '25

Attention is currently required from: daniel, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email ) Change subject: stp: Introduce tests to validate inaccessible SP scenario ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d Gerrit-Change-Number: 41525 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 15:02:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by daniel 01 Dec '25

01 Dec '25

Attention is currently required from: laforge, lynxis lazus, osmith, pespin. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 17: (1 comment) File tests/vty/Makefile.am: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/e54ef190_2b17b… : PS15, Line 35: ss7_asp_test.vty \ > this fixes it: […] amazing, thanks! I'll add it to VTY_TEST_ASP as well so it works consistently if we ever need to remove the glob there -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 17 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 01 Dec 2025 14:57:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by daniel 01 Dec '25

01 Dec '25

Attention is currently required from: laforge, lynxis lazus, osmith, pespin. daniel has uploaded a new patch set (#17) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add TCAP based loadsharing/routing ...................................................................... Add TCAP based loadsharing/routing TCAP based loadsharing will share the load based on the TCAP oTID and dTID. Because TCAP are session based, a TCAP session based tracking is implemented, to allow following traffic to forwarded to the same ASP. This TCAP session tracking is similar to IP connection tracking. ASPs within an AS can use the new IPA TCAP ROUTING protocol to register for specific TCAP ranges. TCAP sessions initiated by a peer (traffic towards such loadsharing AS/ASP), will use the oTID of the `TCAP Begin` to loadshare and select a ASP. Further if the TCAP session was initiated by a `loadshared` ASP, the oTID will be added to the session tracking. Co-authored-by: Harald Welte <laforge(a)osmocom.org> Co-authored-by: Alexander Couzens <lynxis(a)fe80.eu> Co-authored-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Related: SYS#5423 Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d --- M configure.ac M src/Makefile.am M src/ipa.c M src/ss7_as.c M src/ss7_as.h M src/ss7_as_vty.c M src/ss7_asp.h A src/tcap_as_loadshare.c A src/tcap_as_loadshare.h A src/tcap_trans_tracking.c A src/tcap_trans_tracking.h M src/xua_asp_fsm.c M tests/Makefile.am A tests/tcap/Makefile.am A tests/tcap/tcap_transaction_tracking_test.c A tests/tcap/tcap_transaction_tracking_test.ok M tests/testsuite.at M tests/vty/Makefile.am M tests/vty/osmo_stp_test.vty A tests/vty/osmo_stp_test_tcap.vty 20 files changed, 1,981 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/41309/17 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 17 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by osmith 01 Dec '25

01 Dec '25

Attention is currently required from: daniel, laforge, lynxis lazus, pespin. osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 16: (1 comment) File tests/vty/Makefile.am: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/4ff0cc59_8db59… : PS15, Line 35: ss7_asp_test.vty \ > This is still wrong, but I don't think it explains the build failures in the jenkins job. […] this fixes it: ```diff diff --git a/tests/vty/Makefile.am b/tests/vty/Makefile.am index 2d2ff87..ce96380 100644 --- a/tests/vty/Makefile.am +++ b/tests/vty/Makefile.am @@ -46,7 +46,7 @@ vty-transcript-test-stp: $(top_builddir)/stp/osmo-stp osmo_verify_transcript_vty.py -v \ -n OsmoSTP -p 4239 \ -r "$(top_builddir)/stp/osmo-stp -c $(top_srcdir)/doc/examples/osmo-stp-multihome.cfg" \ - $(U) $(srcdir)/$(VTY_TEST_STP) + $(U) $(patsubst %,$(srcdir)/%,$(VTY_TEST_STP)) # Run a specific test with: 'make vty-test VTY_TEST_ASP=ss7_asp_test.vty' VTY_TEST_ASP ?= ss7_asp_*.vty ``` -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 16 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 01 Dec 2025 14:33:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Introduce tests to validate inaccessible SP scenario
by osmith 01 Dec '25

01 Dec '25

Attention is currently required from: daniel, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email ) Change subject: stp: Introduce tests to validate inaccessible SP scenario ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d Gerrit-Change-Number: 41525 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 13:28:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0