Attention is currently required from: laforge, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email )
Change subject: mgcp_client: add support for VND.THEMWI.CCSD codec
......................................................................
Patch Set 2: Verified+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-mgw/+/41529/comment/8a083612_7d3e5646?usp… :
PS1, Line 22: Beyond the present client library addition, desired support for
> I included this explanation to make it clear that I plan to follow up with patches to actual Osmocom […]
I took the extra verbiage about future plans out of the commit message, moving it into the present comment:
Beyond the present client library addition, desired support for compressed CSD per TW-TS-007 in Osmocom components is as follows:
* Equip osmo-mgw rtpbridge with ability to convert between CCSD and CLEARMODE on the fly, using already merged libosmotrau functions for the actual conversion;
* Add CCSD support to tw-e1abis-mgw while regular osmo-mgw has no CSD support at all in E1 mode; possibly bring tw-e1abis-mgw into Osmocom at some point;
* Have OsmoBSC direct its MGW to emit CCSD when the CN requested it via TW-TS-003 BSSMAP extension;
* Possibly add compressed CSD support to OsmoMSC.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4
Gerrit-Change-Number: 41529
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Dec 2025 17:42:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Attention is currently required from: falconia, laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by pespin
Change subject: mgcp_client: add support for VND.THEMWI.CCSD codec
......................................................................
mgcp_client: add support for VND.THEMWI.CCSD codec
TW-TS-007 defines a compressed RTP payload format for GSM CSD,
reducing the payload size from 160 bytes of mostly constant filler
bits to 16, 32 or 37 bytes depending on specific CSD mode:
https://www.freecalypso.org/specs/tw-ts-007-v010001.txt
Clause 9 specifies payload type number 127 when this pseudo-codec
is used on AoIP interface, while Annex A gives it the name
VND.THEMWI.CCSD for SDP.
Add support for this codec to libosmo-mgcp-client, to make it
possible for OsmoBSC and OsmoMSC to request this codec from MGWs.
Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4
---
M include/osmocom/mgcp_client/mgcp_client.h
M src/libosmo-mgcp-client/mgcp_client.c
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/29/41529/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4
Gerrit-Change-Number: 41529
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, lynxis lazus, osmith, pespin.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )
Change subject: Add TCAP based loadsharing/routing
......................................................................
Patch Set 18:
(1 comment)
File tests/tcap/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/8acec11b_f8244… :
PS18, Line 5: AM_LDFLAGS = -static -no-install
> I used Makefile.am from tests/ss7/ as a template where -static was set. […]
I'll keep it like this and push a follow-up patch that removes static linking for all tests
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
Gerrit-Change-Number: 41309
Gerrit-PatchSet: 18
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 01 Dec 2025 17:14:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: laforge, neels, osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email )
Change subject: Validate session remote CP F-SEID and use it to transmit session requests
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/osmo-upf/up_endpoint.c:
https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/fc237059_526bb4b4?usp… :
PS1, Line 217: nack_response
> I think it's fine having it this, way it's only 3 lines of code ...
+2 for the `resp` and `cause` variables, +1 for the label name.
Not super critical, but a separate function would still be cleaner IMO.
File src/osmo-upf/up_session.c:
https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/c3b973b7_85b88960?usp… :
PS1, Line 115: return NULL;
> I also thought about it, and tbh I only added this return to avoid warnings on older compilers/stati […]
Fine with me.
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ifccd4d2b8d500c9928778400bb096baaa12c9a31
Gerrit-Change-Number: 41482
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Dec 2025 16:14:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: laforge, lynxis lazus, osmith, pespin.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )
Change subject: Add TCAP based loadsharing/routing
......................................................................
Patch Set 18:
(1 comment)
File tests/tcap/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/b213cf29_ccd70… :
PS18, Line 5: AM_LDFLAGS = -static -no-install
> weirdly enough we only seem to be adding the static flag for libosmo-sigtran, and not in other tests […]
I used Makefile.am from tests/ss7/ as a template where -static was set. But it probably was just adding $(LIBOSMONETIF_CFLAGS) that fixed it
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
Gerrit-Change-Number: 41309
Gerrit-PatchSet: 18
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 01 Dec 2025 15:47:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, laforge, lynxis lazus, osmith.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )
Change subject: Add TCAP based loadsharing/routing
......................................................................
Patch Set 18:
(1 comment)
File tests/tcap/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/22fd6852_a461a… :
PS18, Line 5: AM_LDFLAGS = -static -no-install
weirdly enough we only seem to be adding the static flag for libosmo-sigtran, and not in other tests for other projects, I wonder why. In general I'd expect this to work without having to link statically?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
Gerrit-Change-Number: 41309
Gerrit-PatchSet: 18
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 01 Dec 2025 15:44:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, laforge, lynxis lazus, osmith, pespin.
daniel has uploaded a new patch set (#18) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Verified-1 by Jenkins Builder
Change subject: Add TCAP based loadsharing/routing
......................................................................
Add TCAP based loadsharing/routing
TCAP based loadsharing will share the load based on the TCAP oTID and
dTID.
Because TCAP are session based, a TCAP session based tracking is implemented,
to allow following traffic to forwarded to the same ASP.
This TCAP session tracking is similar to IP connection tracking.
ASPs within an AS can use the new IPA TCAP ROUTING protocol to register
for specific TCAP ranges.
TCAP sessions initiated by a peer (traffic towards such loadsharing AS/ASP),
will use the oTID of the `TCAP Begin` to loadshare and select a ASP.
Further if the TCAP session was initiated by a `loadshared` ASP, the oTID
will be added to the session tracking.
Co-authored-by: Harald Welte <laforge(a)osmocom.org>
Co-authored-by: Alexander Couzens <lynxis(a)fe80.eu>
Co-authored-by: Pau Espin Pedrol <pespin(a)sysmocom.de>
Related: SYS#5423
Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
---
M configure.ac
M src/Makefile.am
M src/ipa.c
M src/ss7_as.c
M src/ss7_as.h
M src/ss7_as_vty.c
M src/ss7_asp.h
A src/tcap_as_loadshare.c
A src/tcap_as_loadshare.h
A src/tcap_trans_tracking.c
A src/tcap_trans_tracking.h
M src/xua_asp_fsm.c
M tests/Makefile.am
A tests/tcap/Makefile.am
A tests/tcap/tcap_transaction_tracking_test.c
A tests/tcap/tcap_transaction_tracking_test.ok
M tests/testsuite.at
M tests/vty/Makefile.am
M tests/vty/osmo_stp_test.vty
A tests/vty/osmo_stp_test_tcap.vty
20 files changed, 1,984 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/41309/18
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
Gerrit-Change-Number: 41309
Gerrit-PatchSet: 18
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: fixeria, jolly, laforge.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email )
Change subject: sctp_common: gen_sockopts/1: add heartbeat and RTO params
......................................................................
Patch Set 2:
(1 comment)
File config/sys.config:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531/comment/733d9bde_264b… :
PS2, Line 17: %% * rto_initial - RTO (retransmission time-out) initial, ms (default: 1000)
> do you mind sharing to which sysctls/sockopts those values relate?
Linux sysctl defaults on 6.17.8-arch1-1:
net.sctp.rto_initial = 3000
net.sctp.rto_max = 60000
net.sctp.rto_min = 1000
tbh, a rto_max of 1s for a satellite link looks a bit constrained to me.And iiuc by setting both rto_min and max to 1000 you are in practice establishing the RTO to 1000 in all cases, which may be suboptimal and problematic since you don't give the kernel space to accommodate to current connection status.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41531?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I081852d2df187ca7c3cb8969686530b8ac3644f3
Gerrit-Change-Number: 41531
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Dec 2025 15:38:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>