December 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: Add VTY command to list TCAP ranges for an AS
by daniel 02 Dec '25

02 Dec '25

Attention is currently required from: daniel, laforge, lynxis lazus, pespin. daniel has uploaded a new patch set (#19) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Add VTY command to list TCAP ranges for an AS ...................................................................... Add VTY command to list TCAP ranges for an AS Show the list of all tcap ranges and ASP for an AS: OsmoSTP# show cs7 instance 0 as name as-ipa-loadshare-0 tcap-ranges Tid Min Tid Max SSN PC ASP Name ------- ------- --- ------------- ------------ 300 599 0 (no PC) asp-ipa-loadshare-0-1 0 299 0 (no PC) asp-ipa-loadshare-0-0 Show the tcap range and ASP for specific TCAP Id: OsmoSTP# show cs7 instance 0 as name as-ipa-loadshare-0 tcap-ranges tid 15 Tid Min Tid Max SSN PC ASP Name ------- ------- --- ------------- ------------ 0 299 0 (no PC) asp-ipa-loadshare-0-0 Related: SYS#5423 Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf --- M src/Makefile.am M src/ss7_vty.c A src/tcap_as_loadshare_vty.c A src/tcap_as_loadshare_vty.h M tests/vty/osmo_stp_test.vty M tests/vty/osmo_stp_test_tcap.vty 6 files changed, 165 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/11/41311/19 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf Gerrit-Change-Number: 41311 Gerrit-PatchSet: 19 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by daniel 02 Dec '25

02 Dec '25

Attention is currently required from: daniel, laforge, lynxis lazus, osmith, pespin. daniel has uploaded a new patch set (#19) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Add TCAP based loadsharing/routing ...................................................................... Add TCAP based loadsharing/routing TCAP based loadsharing will share the load based on the TCAP oTID and dTID. Because TCAP are session based, a TCAP session based tracking is implemented, to allow following traffic to forwarded to the same ASP. This TCAP session tracking is similar to IP connection tracking. ASPs within an AS can use the new IPA TCAP ROUTING protocol to register for specific TCAP ranges. TCAP sessions initiated by a peer (traffic towards such loadsharing AS/ASP), will use the oTID of the `TCAP Begin` to loadshare and select a ASP. Further if the TCAP session was initiated by a `loadshared` ASP, the oTID will be added to the session tracking. Co-authored-by: Harald Welte <laforge(a)osmocom.org> Co-authored-by: Alexander Couzens <lynxis(a)fe80.eu> Co-authored-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Related: SYS#5423 Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d --- M configure.ac M src/Makefile.am M src/ipa.c M src/ss7_as.c M src/ss7_as.h M src/ss7_as_vty.c M src/ss7_asp.h A src/tcap_as_loadshare.c A src/tcap_as_loadshare.h A src/tcap_trans_tracking.c A src/tcap_trans_tracking.h M src/xua_asp_fsm.c M tests/Makefile.am A tests/tcap/Makefile.am A tests/tcap/tcap_transaction_tracking_test.c A tests/tcap/tcap_transaction_tracking_test.ok M tests/testsuite.at M tests/vty/Makefile.am M tests/vty/osmo_stp_test.vty A tests/vty/osmo_stp_test_tcap.vty 20 files changed, 1,985 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/41309/19 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 19 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-sigtran[master]: Use config.h with AC_CONFIG_HEADER for defines
by daniel 02 Dec '25

02 Dec '25

Attention is currently required from: daniel. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: Use config.h with AC_CONFIG_HEADER for defines ...................................................................... Use config.h with AC_CONFIG_HEADER for defines Change-Id: I15c25b04dc7ef62f46e2429042613ff8f7ca9ce9 --- M configure.ac M src/ipa.c M src/ss7_as.c M src/ss7_as.h M src/ss7_as_vty.c M src/ss7_asp.c M src/ss7_asp.h M src/ss7_asp_vty.c M src/ss7_vty.c M src/xua_asp_fsm.c M stp/stp_main.c M tests/ss7/ss7_test.c M tests/vty/ss7_asp_vty_test.c 13 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/22/41522/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I15c25b04dc7ef62f46e2429042613ff8f7ca9ce9 Gerrit-Change-Number: 41522 Gerrit-PatchSet: 7 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: Use DLTCAP for TCAP log messages
by daniel 02 Dec '25

02 Dec '25

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41523?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+2 by osmith, Code-Review-1 by pespin, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: Use DLTCAP for TCAP log messages ...................................................................... Use DLTCAP for TCAP log messages Depends: libosmocore.git Change-Id I004dddeeb7db3b47d373bb6281708f33d6e8148f Change-Id: Ic2fba30208a11d562fc67bb6f5c4586451a275df --- M TODO-RELEASE M src/tcap_as_loadshare.c M src/tcap_trans_tracking.c 3 files changed, 31 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/23/41523/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic2fba30208a11d562fc67bb6f5c4586451a275df Gerrit-Change-Number: 41523 Gerrit-PatchSet: 7 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: Use DLTCAP for TCAP log messages
by daniel 02 Dec '25

02 Dec '25

Attention is currently required from: fixeria, osmith, pespin. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41523?usp=email ) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: Use DLTCAP for TCAP log messages ...................................................................... Patch Set 7: (1 comment) Patchset: PS6: > Please @dwillmann@sysmocom.de add entry to TODO-RELEASE file: […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic2fba30208a11d562fc67bb6f5c4586451a275df Gerrit-Change-Number: 41523 Gerrit-PatchSet: 7 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Dec 2025 10:01:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-upf[master]: Split up_peer into pfcp_{node,entity}_peer
by laforge 02 Dec '25

02 Dec '25

Attention is currently required from: fixeria, neels, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/41470?usp=email ) Change subject: Split up_peer into pfcp_{node,entity}_peer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/41470?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ie64be4fd55157e9646e250f8cbe93ba3f3c19b17 Gerrit-Change-Number: 41470 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Dec 2025 09:33:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-mgw[master]: mgcp_client: add support for VND.THEMWI.CCSD codec
by laforge 02 Dec '25

02 Dec '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email ) Change subject: mgcp_client: add support for VND.THEMWI.CCSD codec ...................................................................... mgcp_client: add support for VND.THEMWI.CCSD codec TW-TS-007 defines a compressed RTP payload format for GSM CSD, reducing the payload size from 160 bytes of mostly constant filler bits to 16, 32 or 37 bytes depending on specific CSD mode: https://www.freecalypso.org/specs/tw-ts-007-v010001.txt Clause 9 specifies payload type number 127 when this pseudo-codec is used on AoIP interface, while Annex A gives it the name VND.THEMWI.CCSD for SDP. Add support for this codec to libosmo-mgcp-client, to make it possible for OsmoBSC and OsmoMSC to request this codec from MGWs. Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4 --- M include/osmocom/mgcp_client/mgcp_client.h M src/libosmo-mgcp-client/mgcp_client.c 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: falconia: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/mgcp_client/mgcp_client.h b/include/osmocom/mgcp_client/mgcp_client.h index 1d33690..d53f442 100644 --- a/include/osmocom/mgcp_client/mgcp_client.h +++ b/include/osmocom/mgcp_client/mgcp_client.h @@ -58,6 +58,7 @@ CODEC_AMRWB_16000_1 = 113, /* 3GPP TS 48.103 table 5.4.2.2.1 */ CODEC_IUFP = 96, CODEC_CLEARMODE = 120, /* 3GPP TS 48.103 table 5.4.2.2.1 */ + CODEC_COMPR_CSD = 127, /* compressed CSD per TW-TS-007 */ }; /* Note: when new codec types are added, the corresponding value strings * in mgcp_client.c (codec_table) must be updated as well. Enumerations diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 63d03f9..4924be4 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -61,6 +61,7 @@ { CODEC_AMRWB_16000_1, "AMR-WB/16000/1" }, { CODEC_IUFP, "VND.3GPP.IUFP/16000" }, { CODEC_CLEARMODE, "CLEARMODE/8000" }, + { CODEC_COMPR_CSD, "VND.THEMWI.CCSD/8000" }, { 0, NULL }, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4 Gerrit-Change-Number: 41529 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-mgw[master]: mgcp_client: add support for VND.THEMWI.CCSD codec
by laforge 02 Dec '25

02 Dec '25

Attention is currently required from: falconia, pespin. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email ) Change subject: mgcp_client: add support for VND.THEMWI.CCSD codec ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I added a V+1, on the basis that the actual build passes, and the linter is clearly in the wrong in […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4 Gerrit-Change-Number: 41529 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Dec 2025 09:32:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>

1 0

[XS] Change in osmo-mgw[master]: mgcp_client: add support for VND.THEMWI.CCSD codec
by laforge 02 Dec '25

02 Dec '25

Attention is currently required from: falconia, pespin. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email ) Change subject: mgcp_client: add support for VND.THEMWI.CCSD codec ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4 Gerrit-Change-Number: 41529 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Dec 2025 09:32:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: mtp3: Implement RTPC transfer prohibited to concerned SP or STP
by laforge 02 Dec '25

02 Dec '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41524?usp=email ) Change subject: mtp3: Implement RTPC transfer prohibited to concerned SP or STP ...................................................................... mtp3: Implement RTPC transfer prohibited to concerned SP or STP Send Transfer prohibited (DUNA in M3UA) to originator upon trying to route message to inaccessible DPC, as explained in Q.704 Figure 44 and section 13.2. Related: OS#6892 Change-Id: I7e89db3d82374ca03a2e71fb558c7cec9bd651c4 --- M src/Makefile.am M src/m3ua.c M src/mtp3_hmrt.c A src/mtp3_rtpc.c A src/mtp3_rtpc.h M src/xua_internal.h 6 files changed, 155 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve diff --git a/src/Makefile.am b/src/Makefile.am index 29cf10a..f51819e 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -6,6 +6,7 @@ mtp3_hmdc.h \ mtp3_hmdt.h \ mtp3_hmrt.h \ + mtp3_rtpc.h \ sccp_connection.h \ sccp_scoc_fsm.h \ sccp_instance.h \ @@ -53,6 +54,7 @@ mtp3_hmdc.c \ mtp3_hmdt.c \ mtp3_hmrt.c \ + mtp3_rtpc.c \ sccp2sua.c \ sccp_connection.c \ sccp_helpers.c \ diff --git a/src/m3ua.c b/src/m3ua.c index 36018e1..2b7c1e7 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -864,9 +864,9 @@ ***********************************************************************/ /* 3.4.1 Destination Unavailable (DUNA) */ -static struct xua_msg *m3ua_encode_duna(const uint32_t *rctx, unsigned int num_rctx, - const uint32_t *aff_pc, unsigned int num_aff_pc, - const char *info_string) +struct xua_msg *m3ua_encode_duna(const uint32_t *rctx, unsigned int num_rctx, + const uint32_t *aff_pc, unsigned int num_aff_pc, + const char *info_string) { struct xua_msg *xua = xua_msg_alloc(); diff --git a/src/mtp3_hmrt.c b/src/mtp3_hmrt.c index 9ab7e33..25b2bc4 100644 --- a/src/mtp3_hmrt.c +++ b/src/mtp3_hmrt.c @@ -36,6 +36,7 @@ #include <osmocom/sigtran/protocol/m3ua.h> #include "mtp3_hmdc.h" +#include "mtp3_rtpc.h" #include "xua_internal.h" #include "ss7_as.h" #include "ss7_asp.h" @@ -111,8 +112,9 @@ } else { LOGSS7(inst, LOGL_ERROR, "MTP-TRANSFER.req for dpc=%u=%s: no route!\n", dpc, osmo_ss7_pointcode_print(inst, dpc)); - /* DPC unknown HMRT -> MGMT */ - /* Message Received for inaccesible SP HMRT ->RTPC */ + /* "Message received for unknown SP HMRT -> MGMT"*/ + /* "Message received for inaccessible SP HMRT -> RTPC" */ + mtp3_rtpc_rx_msg_for_inaccessible_sp(inst, xua); /* Discard Message */ } xua_msg_free(xua); diff --git a/src/mtp3_rtpc.c b/src/mtp3_rtpc.c new file mode 100644 index 0000000..1ce5c25 --- /dev/null +++ b/src/mtp3_rtpc.c @@ -0,0 +1,131 @@ +/*********************************************************************** + * MTP Level 3 - Transfer prohibited control (RTPC), ITU Q.704 Figure 44 + ***********************************************************************/ + +/* (C) 2025 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +#include <stdint.h> + +#include <osmocom/sigtran/protocol/m3ua.h> +#include <osmocom/sigtran/osmo_ss7.h> + +#include "mtp3_hmdt.h" +#include "mtp3_rtpc.h" +#include "ss7_as.h" +#include "ss7_internal.h" +#include "ss7_route.h" +#include "ss7_route_table.h" +#include "xua_internal.h" +#include "xua_msg.h" + +/* Generate a DUNA message to be sent back to originator. */ +static struct xua_msg *gen_duna_ret_msg(struct osmo_ss7_instance *inst, const struct xua_msg *orig_xua) +{ + struct xua_msg *xua; + struct xua_msg_part *rctx_ie; + unsigned int num_rctx = 0; + uint32_t rctx = 0; + uint32_t aff_pc = htonl(orig_xua->mtp.dpc); + + if ((rctx_ie = xua_msg_find_tag(orig_xua, M3UA_IEI_ROUTE_CTX))) { + rctx = xua_msg_part_get_u32(rctx_ie); + num_rctx = 1; + } + xua = m3ua_encode_duna(&rctx, num_rctx, &aff_pc, 1, + "transfer prohibited (inaccessible SP)"); + OSMO_ASSERT(xua); + + xua->mtp = orig_xua->mtp; + xua->mtp.opc = orig_xua->mtp.dpc; + xua->mtp.dpc = orig_xua->mtp.opc; + return xua; +} + + /* Figure 44/Q.704 (sheet 1 of 3), "Message received for inaccessible SP HMRT -> RTPC" */ +int mtp3_rtpc_rx_msg_for_inaccessible_sp(struct osmo_ss7_instance *inst, const struct xua_msg *orig_xua) +{ + struct xua_msg *xua; + char buf_orig_opc[MAX_PC_STR_LEN]; + char buf_orig_dpc[MAX_PC_STR_LEN]; + struct osmo_ss7_route_label rtlabel; + struct osmo_ss7_route *rt; + + /* TODO: Start T8 */ + + /* "transfer prohibited RTPC -> HMRT", "To concerned SP or STP". + * See also Q.704 13.2 Transfer-prohibited. */ + + /* Note: There's no explicit mention of MTP3 TFP equivalent in RFC4666 (M3UA) specs, + * but section 1.4.3.2 explicitly mentions: "TFP ... MUST NOT be encapsulated as + * Data message Payload Data and sent either from SG to ASP or from ASP to + * SG. The SG MUST terminate these messages and generate M3UA messages, + * as appropriate." + * Best match for it is DUNA, so DUNA we send. + */ + + if (osmo_ss7_pc_is_local(inst, orig_xua->mtp.opc)) { + xua = gen_duna_ret_msg(inst, orig_xua); + return mtp3_hmdt_message_for_distribution(inst, xua); + } + + /* We should only be sending DUNA to M3UA peers, hence why we don't + * simply call mtp3_hmrt_message_for_routing() here. */ + rtlabel = (struct osmo_ss7_route_label){ + .opc = orig_xua->mtp.dpc, + .dpc = orig_xua->mtp.opc, + .sls = orig_xua->mtp.sls, + }; + rt = ss7_instance_lookup_route(inst, &rtlabel); + if (!rt) { + LOGSS7(inst, LOGL_NOTICE, "Tx TFP (DUNA) inaccessible SP %u=%s to concerned SP %u=%s: no route!\n", + orig_xua->mtp.dpc, osmo_ss7_pointcode_print_buf(buf_orig_dpc, sizeof(buf_orig_dpc), inst, orig_xua->mtp.dpc), + orig_xua->mtp.opc, osmo_ss7_pointcode_print_buf(buf_orig_opc, sizeof(buf_orig_opc), inst, orig_xua->mtp.opc)); + return 0; + } + if (!rt->dest.as) { + LOGSS7(inst, LOGL_ERROR, "Tx TFP (DUNA) inaccessible SP %u=%s to concerned SP %u=%s: unsupported for linkset!\n", + orig_xua->mtp.dpc, osmo_ss7_pointcode_print_buf(buf_orig_dpc, sizeof(buf_orig_dpc), inst, orig_xua->mtp.dpc), + orig_xua->mtp.opc, osmo_ss7_pointcode_print_buf(buf_orig_opc, sizeof(buf_orig_opc), inst, orig_xua->mtp.opc)); + return 0; + } + + switch (rt->dest.as->cfg.proto) { + case OSMO_SS7_ASP_PROT_M3UA: + LOGSS7(inst, LOGL_INFO, "Message received for inaccessible SP %u=%s. Tx TFP (DUNA) to concerned SP %u=%s\n", + orig_xua->mtp.dpc, osmo_ss7_pointcode_print_buf(buf_orig_dpc, sizeof(buf_orig_dpc), inst, orig_xua->mtp.dpc), + orig_xua->mtp.opc, osmo_ss7_pointcode_print_buf(buf_orig_opc, sizeof(buf_orig_opc), inst, orig_xua->mtp.opc)); + xua = gen_duna_ret_msg(inst, orig_xua); + return m3ua_tx_xua_as(rt->dest.as, xua); + case OSMO_SS7_ASP_PROT_IPA: + /* FIXME: No DUNA in IPA, maybe send SUA CLDR (SCCP UDTS) instead? */ + LOGSS7(inst, LOGL_INFO, "Message received for inaccessible SP %u=%s, " + "but concerned SP %u=%s is IPA-based and doesn't support TFP (DUNA)\n", + orig_xua->mtp.dpc, osmo_ss7_pointcode_print_buf(buf_orig_dpc, sizeof(buf_orig_dpc), inst, orig_xua->mtp.dpc), + orig_xua->mtp.opc, osmo_ss7_pointcode_print_buf(buf_orig_opc, sizeof(buf_orig_opc), inst, orig_xua->mtp.opc)); + return 0; + default: + LOGSS7(inst, LOGL_ERROR, "DUNA message for ASP of unknown protocol %u\n", + rt->dest.as->cfg.proto); + return 0; + } + + return 0; +} diff --git a/src/mtp3_rtpc.h b/src/mtp3_rtpc.h new file mode 100644 index 0000000..8a0569d --- /dev/null +++ b/src/mtp3_rtpc.h @@ -0,0 +1,11 @@ +#pragma once + +#include <stdint.h> +#include <unistd.h> + +#include <osmocom/sigtran/mtp_sap.h> + +#include "ss7_instance.h" +#include "xua_msg.h" + +int mtp3_rtpc_rx_msg_for_inaccessible_sp(struct osmo_ss7_instance *inst, const struct xua_msg *xua); diff --git a/src/xua_internal.h b/src/xua_internal.h index a1023c1..8674ef5 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -53,6 +53,10 @@ void m3ua_tx_dupu(struct osmo_ss7_asp *asp, const uint32_t *rctx, unsigned int num_rctx, uint32_t dpc, uint16_t user, uint16_t cause, const char *info_str); +struct xua_msg *m3ua_encode_duna(const uint32_t *rctx, unsigned int num_rctx, + const uint32_t *aff_pc, unsigned int num_aff_pc, + const char *info_string); + void xua_tx_snm_available(struct osmo_ss7_asp *asp, const uint32_t *rctx, unsigned int num_rctx, const uint32_t *aff_pc, unsigned int num_aff_pc, const char *info_str, bool available); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41524?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I7e89db3d82374ca03a2e71fb558c7cec9bd651c4 Gerrit-Change-Number: 41524 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0