Attention is currently required from: daniel, fixeria.
osmith has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41523?usp=email )
Change subject: Use DLTCAP for TCAP log messages
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41523?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic2fba30208a11d562fc67bb6f5c4586451a275df
Gerrit-Change-Number: 41523
Gerrit-PatchSet: 6
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Dec 2025 07:56:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel.
osmith has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522?usp=email )
Change subject: Use config.h with AC_CONFIG_HEADER for defines
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I15c25b04dc7ef62f46e2429042613ff8f7ca9ce9
Gerrit-Change-Number: 41522
Gerrit-PatchSet: 6
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Dec 2025 07:56:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email )
Change subject: mgcp_client: add support for VND.THEMWI.CCSD codec
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> The linter is being overly, unreasonably zealous here - the formatting changes it asks for would cle […]
I added a V+1, on the basis that the actual build passes, and the linter is clearly in the wrong in the present case. However, adding a human V+1 appears to be insufficient for overriding Jenkins Builder's V-1. Thus the question still stands: how do we override the linter?
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4
Gerrit-Change-Number: 41529
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Dec 2025 17:47:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Attention is currently required from: fixeria, laforge, pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41521?usp=email )
Change subject: Split ss7_hmrt.c into mtp3_hm{dc,dt,rt}.c
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
hmdc/hmdt are quite small, but if you're happy with it
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41521?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I1b94c1474722b49ce29796681cfbcfce65c95388
Gerrit-Change-Number: 41521
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Dec 2025 17:44:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email )
Change subject: mgcp_client: add support for VND.THEMWI.CCSD codec
......................................................................
Patch Set 2: Verified+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-mgw/+/41529/comment/8a083612_7d3e5646?usp… :
PS1, Line 22: Beyond the present client library addition, desired support for
> I included this explanation to make it clear that I plan to follow up with patches to actual Osmocom […]
I took the extra verbiage about future plans out of the commit message, moving it into the present comment:
Beyond the present client library addition, desired support for compressed CSD per TW-TS-007 in Osmocom components is as follows:
* Equip osmo-mgw rtpbridge with ability to convert between CCSD and CLEARMODE on the fly, using already merged libosmotrau functions for the actual conversion;
* Add CCSD support to tw-e1abis-mgw while regular osmo-mgw has no CSD support at all in E1 mode; possibly bring tw-e1abis-mgw into Osmocom at some point;
* Have OsmoBSC direct its MGW to emit CCSD when the CN requested it via TW-TS-003 BSSMAP extension;
* Possibly add compressed CSD support to OsmoMSC.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4
Gerrit-Change-Number: 41529
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Dec 2025 17:42:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Attention is currently required from: falconia, laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by pespin
Change subject: mgcp_client: add support for VND.THEMWI.CCSD codec
......................................................................
mgcp_client: add support for VND.THEMWI.CCSD codec
TW-TS-007 defines a compressed RTP payload format for GSM CSD,
reducing the payload size from 160 bytes of mostly constant filler
bits to 16, 32 or 37 bytes depending on specific CSD mode:
https://www.freecalypso.org/specs/tw-ts-007-v010001.txt
Clause 9 specifies payload type number 127 when this pseudo-codec
is used on AoIP interface, while Annex A gives it the name
VND.THEMWI.CCSD for SDP.
Add support for this codec to libosmo-mgcp-client, to make it
possible for OsmoBSC and OsmoMSC to request this codec from MGWs.
Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4
---
M include/osmocom/mgcp_client/mgcp_client.h
M src/libosmo-mgcp-client/mgcp_client.c
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/29/41529/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4
Gerrit-Change-Number: 41529
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, lynxis lazus, osmith, pespin.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )
Change subject: Add TCAP based loadsharing/routing
......................................................................
Patch Set 18:
(1 comment)
File tests/tcap/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/8acec11b_f8244… :
PS18, Line 5: AM_LDFLAGS = -static -no-install
> I used Makefile.am from tests/ss7/ as a template where -static was set. […]
I'll keep it like this and push a follow-up patch that removes static linking for all tests
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
Gerrit-Change-Number: 41309
Gerrit-PatchSet: 18
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 01 Dec 2025 17:14:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>