December 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-asn1-tcap[master]: .gitignore: Add missing tests/ entries
by pespin 03 Dec '25

03 Dec '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41538?usp=email ) Change subject: .gitignore: Add missing tests/ entries ...................................................................... .gitignore: Add missing tests/ entries Change-Id: I3156ca703034b85efdfbc30a09662d24ae4a68f8 --- M .gitignore 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/38/41538/1 diff --git a/.gitignore b/.gitignore index 50e7d67..5e624ab 100644 --- a/.gitignore +++ b/.gitignore @@ -25,3 +25,11 @@ .libs .version include/osmocom/tcap/version.h + +#tests +tests/*/*_test + +tests/atconfig +tests/package.m4 +tests/testsuite +tests/testsuite.log -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41538?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I3156ca703034b85efdfbc30a09662d24ae4a68f8 Gerrit-Change-Number: 41538 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-asn1-tcap[master]: tests/Makefile.am: Remove -static flag
by pespin 03 Dec '25

03 Dec '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41537?usp=email ) Change subject: tests/Makefile.am: Remove -static flag ...................................................................... tests/Makefile.am: Remove -static flag We are not using that flag anywhere else in osmocom, and we don't have any specific need for it here, so remove it. Change-Id: If77ed04a3b5e0d6057c1aefa37e45aff38bbeca5 --- M tests/parse/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/37/41537/1 diff --git a/tests/parse/Makefile.am b/tests/parse/Makefile.am index d464e2a..4a502b8 100644 --- a/tests/parse/Makefile.am +++ b/tests/parse/Makefile.am @@ -1,6 +1,6 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_srcdir)/src AM_CFLAGS = -Wall -AM_LDFLAGS = -static -no-install +AM_LDFLAGS = -no-install LDADD = $(top_builddir)/src/libosmo-asn1-tcap.la -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41537?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If77ed04a3b5e0d6057c1aefa37e45aff38bbeca5 Gerrit-Change-Number: 41537 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: Fix warning in tcap_transaction_tracking_test
by pespin 03 Dec '25

03 Dec '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41535?usp=email ) Change subject: Fix warning in tcap_transaction_tracking_test ...................................................................... Fix warning in tcap_transaction_tracking_test Change-Id: Ib3b361e2d16a9dab9b93ec9c211340f80f475b42 --- M tests/tcap/tcap_transaction_tracking_test.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/tests/tcap/tcap_transaction_tracking_test.c b/tests/tcap/tcap_transaction_tracking_test.c index 7ad52a9..ce3605b 100644 --- a/tests/tcap/tcap_transaction_tracking_test.c +++ b/tests/tcap/tcap_transaction_tracking_test.c @@ -228,7 +228,7 @@ uint32_t hlr_tids[] = { 24, 25, 26}; uint32_t vlr_tids[] = { 44, 45, 46}; - struct tcap_trans_track_entry *entry; + struct tcap_trans_track_entry *entry = NULL; printf("GC test\n"); @@ -239,6 +239,7 @@ &gvlr, &vlr_tids[i]); OSMO_ASSERT(entry); } + OSMO_ASSERT(entry); OSMO_ASSERT(count_unique_hash_entries(as) == 3); /* No entries should be GC'ed, because all entries should be within 10 secs */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41535?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib3b361e2d16a9dab9b93ec9c211340f80f475b42 Gerrit-Change-Number: 41535 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: Improve tests
by pespin 03 Dec '25

03 Dec '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534?usp=email ) Change subject: Improve tests ...................................................................... Improve tests Remove -static link flag and use built libs in $(top_builddir)/src/.libs to include internal functions where needed. Change-Id: I074f243b62a516534099c88f691a28065cd763dd --- M tests/ss7/Makefile.am M tests/tcap/Makefile.am M tests/vty/Makefile.am M tests/xua/Makefile.am 4 files changed, 17 insertions(+), 14 deletions(-) Approvals: lynxis lazus: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/tests/ss7/Makefile.am b/tests/ss7/Makefile.am index 236e846..bf2b9ed 100644 --- a/tests/ss7/Makefile.am +++ b/tests/ss7/Makefile.am @@ -1,9 +1,13 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall $(LIBOSMONETIF_CFLAGS) $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) -AM_LDFLAGS = -static -no-install -LDADD = $(top_builddir)/src/libosmo-sigtran.la \ - $(LIBOSMOCORE_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMONETIF_LIBS) $(LIBSCTP_LIBS) +AM_LDFLAGS = -no-install +LDADD = $(top_builddir)/src/.libs/libosmo-sigtran.a \ + $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMONETIF_LIBS) $(LIBSCTP_LIBS) + +if BUILD_WITH_TCAP_LOADSHARING +LDADD += $(LIBOSMOASN1TCAP_LIBS) +endif EXTRA_DIST = ss7_test.ok ss7_test.err diff --git a/tests/tcap/Makefile.am b/tests/tcap/Makefile.am index f53d74b..6aaf943 100644 --- a/tests/tcap/Makefile.am +++ b/tests/tcap/Makefile.am @@ -2,10 +2,10 @@ AM_CFLAGS = -Wall \ $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMONETIF_CFLAGS) $(LIBOSMOASN1TCAP_CFLAGS) $(LIBSCTP_CFLAGS) -AM_LDFLAGS = -static -no-install +AM_LDFLAGS = -no-install -LDADD = $(top_builddir)/src/libosmo-sigtran.la \ - $(LIBOSMOCORE_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMONETIF_LIBS) $(LIBOSMOASN1TCAP_LIBS) $(LIBSCTP_LIBS) +LDADD = $(top_builddir)/src/.libs/libosmo-sigtran.a \ + $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMONETIF_LIBS) $(LIBOSMOASN1TCAP_LIBS) $(LIBSCTP_LIBS) check_PROGRAMS = \ tcap_transaction_tracking_test \ @@ -19,7 +19,3 @@ tcap_transaction_tracking_test_SOURCES = \ tcap_transaction_tracking_test.c \ $(NULL) - -tcap_transaction_tracking_test_LDADD = \ - $(top_builddir)/src/tcap_trans_tracking.o \ - $(LDADD) diff --git a/tests/vty/Makefile.am b/tests/vty/Makefile.am index 707fbd4..79a56ec 100644 --- a/tests/vty/Makefile.am +++ b/tests/vty/Makefile.am @@ -1,7 +1,7 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) -AM_LDFLAGS = -static -no-install +AM_LDFLAGS = -no-install LDADD = $(top_builddir)/src/libosmo-sigtran.la \ $(LIBOSMOCORE_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMONETIF_LIBS) $(LIBSCTP_LIBS) diff --git a/tests/xua/Makefile.am b/tests/xua/Makefile.am index edff329..4af6446 100644 --- a/tests/xua/Makefile.am +++ b/tests/xua/Makefile.am @@ -1,9 +1,12 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall $(LIBOSMONETIF_CFLAGS) $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) -AM_LDFLAGS = -static -no-install -LDADD = $(top_builddir)/src/libosmo-sigtran.la \ - $(LIBOSMOCORE_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMONETIF_LIBS) $(LIBSCTP_LIBS) +AM_LDFLAGS = -no-install +LDADD = $(top_builddir)/src/.libs/libosmo-sigtran.a \ + $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMONETIF_LIBS) $(LIBSCTP_LIBS) +if BUILD_WITH_TCAP_LOADSHARING +LDADD += $(LIBOSMOASN1TCAP_LIBS) +endif EXTRA_DIST = xua_test.ok xua_test.err -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I074f243b62a516534099c88f691a28065cd763dd Gerrit-Change-Number: 41534 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: Improve tests
by pespin 03 Dec '25

03 Dec '25

Attention is currently required from: daniel, fixeria. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534?usp=email ) Change subject: Improve tests ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534/comment/1678024c_fab35… : PS1, Line 7: dynamically > linking it statically could also improve testin because the tests can use function which aren't expo […] Yes, linking against the .a does link those statically, while keeping other dependencies dynamically afaik. That's how we are doing it everywhere afaict. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I074f243b62a516534099c88f691a28065cd763dd Gerrit-Change-Number: 41534 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Dec 2025 13:04:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-sigtran[master]: Improve tests
by pespin 03 Dec '25

03 Dec '25

Attention is currently required from: daniel, fixeria. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534?usp=email ) Change subject: Improve tests ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534/comment/26d73693_878d0… : PS1, Line 9: Remove -static linker flag and use built libs > I see you're explaining what you're doing, but not why. […] Because we are not using this -static anywhere else in osmocom world. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I074f243b62a516534099c88f691a28065cd763dd Gerrit-Change-Number: 41534 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Dec 2025 13:03:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: Fix warning in tcap_transaction_tracking_test
by lynxis lazus 03 Dec '25

03 Dec '25

Attention is currently required from: daniel, fixeria. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41535?usp=email ) Change subject: Fix warning in tcap_transaction_tracking_test ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41535?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib3b361e2d16a9dab9b93ec9c211340f80f475b42 Gerrit-Change-Number: 41535 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Dec 2025 12:58:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: Improve tests
by lynxis lazus 03 Dec '25

03 Dec '25

Attention is currently required from: daniel, fixeria. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534?usp=email ) Change subject: Improve tests ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534/comment/f9650f70_eb67f… : PS1, Line 7: dynamically > BTW, tests are currently linked dynamically despite the `-static` (not sure if it does anything at a […] linking it statically could also improve testin because the tests can use function which aren't exported in the shared object, right? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I074f243b62a516534099c88f691a28065cd763dd Gerrit-Change-Number: 41534 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Dec 2025 12:58:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: stp: fix config for tcap routing tests
by daniel 03 Dec '25

03 Dec '25

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41513?usp=email ) Change subject: stp: fix config for tcap routing tests ...................................................................... stp: fix config for tcap routing tests Change-Id: I4b1172c60aa9bb9b3d298a35051c38d20127e004 --- M stp/osmo-stp-tcap.confmerge 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/stp/osmo-stp-tcap.confmerge b/stp/osmo-stp-tcap.confmerge index 3b417ac..4090099 100644 --- a/stp/osmo-stp-tcap.confmerge +++ b/stp/osmo-stp-tcap.confmerge @@ -77,6 +77,8 @@ role sg transport-role server as as-ipa-loadshare-0 ipa + traffic-mode loadshare + tcap-routing routing-key 0 5 point-code override dpc 23 asp asp-ipa-loadshare-0-0 @@ -96,6 +98,8 @@ role sg transport-role server as as-ipa-loadshare-1 ipa + traffic-mode loadshare + tcap-routing routing-key 0 6 point-code override dpc 7 asp asp-ipa-loadshare-1-0 @@ -115,6 +119,8 @@ role sg transport-role server as as-ipa-loadshare-2 ipa + traffic-mode loadshare + tcap-routing routing-key 0 7 point-code override dpc 6 asp asp-ipa-loadshare-2-0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41513?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4b1172c60aa9bb9b3d298a35051c38d20127e004 Gerrit-Change-Number: 41513 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: Improve tests
by osmith 03 Dec '25

03 Dec '25

Attention is currently required from: daniel, fixeria. osmith has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534?usp=email ) Change subject: Improve tests ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I074f243b62a516534099c88f691a28065cd763dd Gerrit-Change-Number: 41534 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Dec 2025 07:55:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0