Attention is currently required from: daniel, laforge, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )
Change subject: Add TCAP based loadsharing/routing
......................................................................
Patch Set 13:
(8 comments)
Patchset:
PS13:
Only small fixes needed, otherwise LGTM.
File src/ss7_as.h:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/c81f9839_7da5b… :
PS8, Line 6: #include <osmocom/core/hashtable.h>
> Here I would agree.
Done
File src/ss7_as_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/224513e7_82c53… :
PS13, Line 185:
unrelated, since you shouldn't be touching this function in this patch.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/6edaee27_c2341… :
PS13, Line 196: as->cfg.loadshare.opc_shift = atoi(argv[5]);
This change looks wrong, should be left untouched?
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/c0d49392_3f7bd… :
PS13, Line 214: #ifdef WITH_TCAP_LOADSHARING
This should probably be removed from here, imho tcap routing should be independent of resetting the mtp3 traffic-mode.
File src/ss7_asp.h:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d494bf02_aded2… :
PS8, Line 96: bool enabled;
> Does that make sense? why would somebody want to have TCAP routing enabled on some and not all of th […]
Done
File src/tcap_as_loadshare.h:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/0a83ddd8_2e15c… :
PS13, Line 28: struct tcap_range *tcap_range_alloc(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp,
Not blocking, but I think it's good practice to put the _alloc and _free function at the top of all the object functions.
File tests/vty/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/984e8fef_2c45f… :
PS13, Line 39: VTY_TEST_STP_DEFAULT += osmo_stp_test_tcap.vty
EXTRA_DIST += osmo_stp_test_tcap.vty
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
Gerrit-Change-Number: 41309
Gerrit-PatchSet: 13
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 27 Nov 2025 18:03:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: daniel, fixeria.
pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email )
Change subject: Add DLTCAP log category
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/core/logging.c:
https://gerrit.osmocom.org/c/libosmocore/+/41520/comment/aeafccf2_efd4a4f6?… :
PS2, Line 398: .description = "libosmo-sigtran TCAP",
I would maybe remove libosmo-sigtran from here, maybe we can use it in libosmo-asn1-tcap for instance.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I004dddeeb7db3b47d373bb6281708f33d6e8148f
Gerrit-Change-Number: 41520
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Nov 2025 17:51:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41252?usp=email )
Change subject: trau: add AMR TRAU frame interworking facility
......................................................................
Patch Set 18:
(1 comment)
Patchset:
PS18:
Given +1 votes from @laforge@osmocom.org and @pespin@sysmocom.de, this patch can be merged now - but since @vyanitskiy@sysmocom.de is also listed as a reviewer, I would like to get his opinion too. OTOH, Vadim often told me that E1 BTS and TRAU frames is an area of Osmocom in which he does not consider himself an expert. Therefore, I shall wait a few days, and if there is no objection from Vadim or others, then +2 to myself and merge.
In any case, this patch is needed in order to add support for AMR with E1 BTS by way of ThemWi E1 Abis MGW, which may or may not become part of mainline Osmocom in the future, depending on community interest. But even in the near term, while tw-e1abis-mgw is still maintained externally to Osmocom, having this patch in libosmotrau will be much easier than creating a separate ThemWi library just to hold this code addition.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41252?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I42706c2f68ed29aff1bf451b37e783983f8de3b0
Gerrit-Change-Number: 41252
Gerrit-PatchSet: 18
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Nov 2025 17:42:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add DLTCAP log category
......................................................................
Add DLTCAP log category
Change-Id: I004dddeeb7db3b47d373bb6281708f33d6e8148f
Related: SYS#5423
---
M include/osmocom/core/logging.h
M src/core/logging.c
M tests/logging/logging_vty_test.vty
3 files changed, 11 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/20/41520/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I004dddeeb7db3b47d373bb6281708f33d6e8148f
Gerrit-Change-Number: 41520
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: lynxis lazus, pespin.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email )
Change subject: Add VTY command to list TCAP ranges for an AS
......................................................................
Patch Set 13:
(1 comment)
File src/ss7_as_loadshare_tcap_vty.h:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/fa6bd706_a0327… :
PS8, Line 6: #ifdef WITH_TCAP_LOADSHARING
> No, I like to have static inlines instead if the feature isn't enabled.
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf
Gerrit-Change-Number: 41311
Gerrit-PatchSet: 13
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 27 Nov 2025 17:19:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: laforge, lynxis lazus, pespin.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )
Change subject: Add TCAP based loadsharing/routing
......................................................................
Patch Set 13:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/dba70098_65118… :
PS8, Line 13: This TCAP session tracking is similar to IP connection tracking.
> I guess you mean TCP connection here?
You can have connection tracking for other protocols as well. There was a file in proc called ip_conntrack with a list of the tracked connections, though I can only find /proc/net/nf_conntrack now.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
Gerrit-Change-Number: 41309
Gerrit-PatchSet: 13
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 27 Nov 2025 17:12:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, lynxis lazus, pespin.
daniel has uploaded a new patch set (#13) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add TCAP based loadsharing/routing
......................................................................
Add TCAP based loadsharing/routing
TCAP based loadsharing will share the load based on the TCAP oTID and
dTID.
Because TCAP are session based, a TCAP session based tracking is implemented,
to allow following traffic to forwarded to the same ASP.
This TCAP session tracking is similar to IP connection tracking.
ASPs within an AS can use the new IPA TCAP ROUTING protocol to register
for specific TCAP ranges.
TCAP sessions initiated by a peer (traffic towards such loadsharing AS/ASP),
will use the oTID of the `TCAP Begin` to loadshare and select a ASP.
Further if the TCAP session was initiated by a `loadshared` ASP, the oTID
will be added to the session tracking.
Co-authored-by: Harald Welte <laforge(a)osmocom.org>
Co-authored-by: Alexander Couzens <lynxis(a)fe80.eu>
Co-authored-by: Pau Espin Pedrol <pespin(a)sysmocom.de>
Related: SYS#5423
Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
---
M configure.ac
M src/Makefile.am
M src/ipa.c
M src/ss7_as.c
M src/ss7_as.h
M src/ss7_as_vty.c
M src/ss7_asp.h
A src/tcap_as_loadshare.c
A src/tcap_as_loadshare.h
A src/tcap_trans_tracking.c
A src/tcap_trans_tracking.h
M src/xua_asp_fsm.c
M tests/Makefile.am
A tests/tcap/Makefile.am
A tests/tcap/tcap_transaction_tracking_test.c
A tests/tcap/tcap_transaction_tracking_test.ok
M tests/testsuite.at
M tests/vty/Makefile.am
M tests/vty/osmo_stp_test.vty
A tests/vty/osmo_stp_test_tcap.vty
20 files changed, 2,143 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/41309/13
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d
Gerrit-Change-Number: 41309
Gerrit-PatchSet: 13
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>